You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan Ernst (JIRA)" <ji...@apache.org> on 2014/11/23 18:58:12 UTC
[jira] [Commented] (LUCENE-6068) Remove reader.fields() == null
checks everywhere
[ https://issues.apache.org/jira/browse/LUCENE-6068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222437#comment-14222437 ]
Ryan Ernst commented on LUCENE-6068:
------------------------------------
+1, It's nice to remove useless code!
> Remove reader.fields() == null checks everywhere
> ------------------------------------------------
>
> Key: LUCENE-6068
> URL: https://issues.apache.org/jira/browse/LUCENE-6068
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-6068.patch
>
>
> I don't know how this got this way, but it never returns null. SegmentReader even asserts this. But the api requires consumers to do a bunch of useless null checks. This is a bug.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org