[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #190: Decode Non-Exist field in Go

[GitBox <gi...@apache.org>]

wongoo commented on pull request #190:
URL: https://github.com/apache/dubbo-go-hessian2/pull/190#issuecomment-630693229


   there is no log in hessian now， it will return error if something goes wrong. should hessian support log? it may cause lower performance. If yes, I think it's should accept a logger , not calling the `log.Print`.
   
   ```go
   type loggerFunc func( format string, args... interface)
   func emptyLogger ( format string, args... interface) {}
   
   var logger = emptyLogger
   
   func EnableLogger(l loggerFunc){
         logger = l
   }
   func DisableLogger(){
         logger = emptyLogger
   }
   ```
   
   @AlexStocks @fangyincheng @hxmhlt 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org