Unapproved licenses

[Lukasz Lenart <lu...@googlemail.com>]

Hi,

I'm running a new release process and during launching mvn
release:perform rat plugin reported unapproved license in
app/jboss-blank/pom.xml - Apache License Header is missing. The
strange thing is that it was already included in the latest 2.2.1
release. I'm suspecting it's because of I'm using Maven 3 to do that
;-)

And to be more mysterious, also main struts2-parent pom.xml is missing
the header but rat plugin isn't complaining :P

How to obey that without rollbacking all the changes and adding
required headers?


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia 2010 http://javarsovia.pl

PS. Anyway it's a huge work for the future to adjust project to Maven 3 :D

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Unapproved licenses

[Lukasz Lenart <lu...@googlemail.com>]

2010/12/5 Martin Cooper <ma...@apache.org>:
>> "Licensed under the Apache License, Version 2.0 (the \"License\")"
>
> Comparing that with what's written here:
>
> http://www.apache.org/legal/src-headers.html#headers
>
> suggests that it's wrong, but it looks to me like that RAT code may be
> looking for something that *used* to be considered correct, and
> therefore probably exists in a lot of places.
>
> Note that the RAT source you're referring to is itself old, and has
> been replaced by what's in the Incubator. The project page for it
> clearly states "This project is being retained only for history
> purposes.". We need to be using what's in the Incubator, not what's
> known to be obsolete.

The latest Apache version is also looking for the same header but it
also looks for an url - either first or second must be correct.

And my problem was related to wrong url for scm tag in pom, I've
updated all of them and the release is almost ready to Vote. The last
problem are the missing asc files for OSGi bundles. I have them
locally, but they haven't been uploaded to the staging repository.
I've already asked guys from INFRA and waiting.... (d... :P)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia 2010 http://javarsovia.pl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Unapproved licenses

[Martin Cooper <ma...@apache.org>]

On Sun, Dec 5, 2010 at 3:50 AM, Lukasz Lenart
<lu...@googlemail.com> wrote:
> 2010/12/5 Martin Cooper <ma...@apache.org>:
>> I guess the real question is whether or not there is some other
>> license in there, and if so, how that's categorized at the ASF.
>
> Hmm... my thought is that it never worked :P, just Maven 3 showed it
> as a problem.
> I've reviewed the source code of RAT tool [1] and a file to match the
> ASF license must have such a header
>
> "Licensed under the Apache License, Version 2.0 (the \"License\")"

Comparing that with what's written here:

http://www.apache.org/legal/src-headers.html#headers

suggests that it's wrong, but it looks to me like that RAT code may be
looking for something that *used* to be considered correct, and
therefore probably exists in a lot of places.

Note that the RAT source you're referring to is itself old, and has
been replaced by what's in the Incubator. The project page for it
clearly states "This project is being retained only for history
purposes.". We need to be using what's in the Incubator, not what's
known to be obsolete.

--
Martin Cooper


> I don't know if it's a correct header, so then should we use rat plugin?
>
>> You might want to check with the RAT folks (via their own mailing
>> list) to see if there's actually a problem here or not.
>
> Thanks, I will try but since the project is in Incubator and Struts is
> using Codehause version it can be hard ;-)
>
> [1] http://code.google.com/p/arat/source/browse/trunk/rat/src/java/rat/analysis/license/ApacheSoftwareLicense20.java
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Kapituła Javarsovia 2010 http://javarsovia.pl
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Unapproved licenses

[Martin Cooper <ma...@apache.org>]

On Thu, Dec 2, 2010 at 12:26 AM, Lukasz Lenart
<lu...@googlemail.com> wrote:
> Hi,
>
> I'm running a new release process and during launching mvn
> release:perform rat plugin reported unapproved license in
> app/jboss-blank/pom.xml - Apache License Header is missing. The
> strange thing is that it was already included in the latest 2.2.1
> release. I'm suspecting it's because of I'm using Maven 3 to do that
> ;-)

I guess the real question is whether or not there is some other
license in there, and if so, how that's categorized at the ASF.

You might want to check with the RAT folks (via their own mailing
list) to see if there's actually a problem here or not.

--
Martin Cooper


> And to be more mysterious, also main struts2-parent pom.xml is missing
> the header but rat plugin isn't complaining :P
>
> How to obey that without rollbacking all the changes and adding
> required headers?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Kapituła Javarsovia 2010 http://javarsovia.pl
>
> PS. Anyway it's a huge work for the future to adjust project to Maven 3 :D
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org