You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/17 06:06:54 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29444: [MINOR] Fix couple typo in codebase

HyukjinKwon commented on a change in pull request #29444:
URL: https://github.com/apache/spark/pull/29444#discussion_r471249424



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
##########
@@ -187,7 +187,7 @@ class TextSocketStreamSuite extends StreamTest with SharedSparkSession {
 
   test("non-boolean includeTimestamp") {
     val provider = new TextSocketSourceProvider
-    val params = Map("host" -> "localhost", "port" -> "1234", "includeTimestamp" -> "fasle")
+    val params = Map("host" -> "localhost", "port" -> "1234", "includeTimestamp" -> "false")

Review comment:
       Seems like it was testing a negative case. `fasle` seems right value to test.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org