[GitHub] [lucene-solr] mikemccand commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #640: LUCENE-8671: Introduce Reader attributes
URL: https://github.com/apache/lucene-solr/pull/640#discussion_r274496177
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsReader.java
 ##########
 @@ -156,6 +190,8 @@ public BlockTreeTermsReader(PostingsReaderBase postingsReader, SegmentReadState
       seekDir(termsIn);
       seekDir(indexIn);
 
+      FSTLoadMode fstLoadMode = FSTLoadMode.valueOf(state.readerAttributes.getOrDefault(FST_MODE_KEY, FSTLoadMode.AUTO.toString()));
 
 Review comment:
   Do we get a nice exception if the string is invalid here?  Can we fix the exception to state which key we were looking up when we got the invalid `FSTLoadMode` enum?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org