You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by rawkintrevo <gi...@git.apache.org> on 2016/09/06 17:16:18 UTC

[GitHub] zeppelin pull request #1409: [ZEPPELIN-1461] Update Flink with latest versio...

GitHub user rawkintrevo opened a pull request:

    https://github.com/apache/zeppelin/pull/1409

    [ZEPPELIN-1461] Update Flink with latest version 1.1.2

    ### What is this PR for?
    Flink has had two releases since 1.0.3, we are now on 1.1.2
    
    This includes new functionality for streaming support in repl environment.
    
    ### What type of PR is it?
     Improvement 
    
    ### Todos
    * [x] - Update `pom.xml`
    * [x] - Update single (batch) environment to batch and streaming environments
    
    ### What is the Jira issue?
    [https://issues.apache.org/jira/browse/ZEPPELIN-1416?filter=-1](https://issues.apache.org/jira/browse/ZEPPELIN-1416?filter=-1)
    
    ### How should this be tested?
    Tests for previous versions are the same as new version.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    No
    * Is there breaking changes for older versions?
    Yes* older code written in the Flink interpreter will now have to use `benv` in place of `env`
    * Does this needs documentation?
    No 
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rawkintrevo/incubator-zeppelin zeppelin-1461

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1409
    
----
commit 9921a7ecfa4102461a2f79baac77d4c423238e37
Author: rawkintrevo <tr...@gmail.com>
Date:   2016-09-06T17:10:20Z

    [ZEPPELIN-1461] Update Flink with latest version 1.1.2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1409: [ZEPPELIN-1461] Update Flink with latest version 1.1.2

Posted by rawkintrevo <gi...@git.apache.org>.
Github user rawkintrevo commented on the issue:

    https://github.com/apache/zeppelin/pull/1409
  
    [Profile 2](https://travis-ci.org/apache/zeppelin/jobs/157948630) 
    [Profile 3](https://travis-ci.org/apache/zeppelin/jobs/157948631)
    [Profile 4](https://travis-ci.org/apache/zeppelin/jobs/157948632)
    All fail at `testWordCount`
    ```
    testWordCount(org.apache.zeppelin.flink.FlinkInterpreterTest)  Time elapsed: 0.204 sec  <<< FAILURE!
    java.lang.AssertionError: expected:<SUCCESS> but was:<ERROR>
    	at org.junit.Assert.fail(Assert.java:88)
    	at org.junit.Assert.failNotEquals(Assert.java:743)
    	at org.junit.Assert.assertEquals(Assert.java:118)
    	at org.junit.Assert.assertEquals(Assert.java:144)
    	at org.apache.zeppelin.flink.FlinkInterpreterTest.testWordCount(FlinkInterpreterTest.java:87)
    
    
    Results :
    
    Failed tests: 
      FlinkInterpreterTest.testWordCount:87 expected:<SUCCESS> but was:<ERROR>
    ```
    
    [Profile 6](https://travis-ci.org/apache/zeppelin/jobs/157948634) Stalled in pyspark interpreter.
    
    Very curious that some profiles fail this test, but others pass. Will explore tonight. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1409: [ZEPPELIN-1461] Update Flink with latest version 1.1.2

Posted by rawkintrevo <gi...@git.apache.org>.
Github user rawkintrevo commented on the issue:

    https://github.com/apache/zeppelin/pull/1409
  
    Flink Tests all passing now. 
    
    [Profile3](https://travis-ci.org/apache/zeppelin/jobs/158273244) Cassandra Test Timeout **Unrelated**
    
    [Profile8](https://travis-ci.org/apache/zeppelin/jobs/158273249)
    `- should provide onclick method *** FAILED ***`
    Display system 'onclick' method timeout. Known flaky test (I'll find it and link soon)
    
    LGTM?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1409: [ZEPPELIN-1461] Update Flink with latest versio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1409


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1409: [ZEPPELIN-1461] Update Flink with latest version 1.1.2

Posted by rawkintrevo <gi...@git.apache.org>.
Github user rawkintrevo commented on the issue:

    https://github.com/apache/zeppelin/pull/1409
  
    @Leemoonsoo all systems go on re-triggered build. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1409: [ZEPPELIN-1461] Update Flink with latest version 1.1.2

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/zeppelin/pull/1409
  
    Changes look good to me. +1 for merging after fixing the failing test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1409: [ZEPPELIN-1461] Update Flink with latest version 1.1.2

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1409
  
    Thanks @rawkintrevo, @tillrohrmann. It looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1409: [ZEPPELIN-1461] Update Flink with latest version 1.1.2

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1409
  
    Merge to master and branch-0.6, if there're no more dicussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---