[jira] Commented: (THRIFT-256) Generated code for child service is invalid if both child and parent are defined in the same Thrift file

["Esteve Fernandez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670401#action_12670401 ] 

Esteve Fernandez commented on THRIFT-256:
-----------------------------------------

I like it much more than mine, it's cleaner and easier to read. I don't know what I had in mind when I wrote that patch...

Do you think it should have an accompanying unit test?

> Generated code for child service is invalid if both child and parent are defined in the same Thrift file
> --------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-256
>                 URL: https://issues.apache.org/jira/browse/THRIFT-256
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Python)
>            Reporter: Esteve Fernandez
>         Attachments: 0001-THRIFT-256.-python-Fix-inheritance-of-services-in-t.patch, thrift-256.patch
>
>
> Given a Thrift file like this:
> simple.thrift:
> service Base {
> }
> service Child extends Parent {
> }
> the parent service is not qualified properly in the child service code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.