[jira] [Commented] (GEODE-3514) Clean up locator code related new protocol

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144559#comment-16144559 ] 

ASF GitHub Bot commented on GEODE-3514:
---------------------------------------

GitHub user pivotal-amurmann opened a pull request:

    https://github.com/apache/geode/pull/747

    GEODE-3514: Clean up locator and protobuf related code

    * Check for feature flag only once
    * Simplify TcpServerFactory
    * Indicate RoundTripLocatorConnection test properly as DUnit test
    * Move InvalidExecutionContextException to exception package.
    
    Signed-off-by: Alexander Murmann <am...@pivotal.io>
    Signed-off-by: Brian Rowe <br...@pivotal.io>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    It does not b/c develop is red. I will rebase again once that's fixed
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pivotal-amurmann/geode chore/GEODE-3514/locator_cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #747
    
----
commit 68bc6dd7853245e49bfee874af41a80eb68af159
Author: Brian Rowe <br...@pivotal.io>
Date:   2017-08-24T19:09:05Z

    GEODE-3514: Clean up locator and protobuf related code
    
    * Check for feature flag only once
    * Simplify TcpServerFactory
    * Indicate RoundTripLocatorConnection test properly as DUnit test
    * Move InvalidExecutionContextException to exception package.
    
    Signed-off-by: Alexander Murmann <am...@pivotal.io>
    Signed-off-by: Brian Rowe <br...@pivotal.io>

----


> Clean up locator code related new protocol
> ------------------------------------------
>
>                 Key: GEODE-3514
>                 URL: https://issues.apache.org/jira/browse/GEODE-3514
>             Project: Geode
>          Issue Type: Task
>          Components: client/server
>            Reporter: Alexander Murmann
>
> There were still outstanding issues on Geode PR 716 that we are addressing as part of this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)