You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2007/10/22 00:41:50 UTC

[jira] Created: (CXF-1125) java_first_jaxws example should use maven and JaxWs*FactoryBean

java_first_jaxws example should use maven and JaxWs*FactoryBean
---------------------------------------------------------------

                 Key: CXF-1125
                 URL: https://issues.apache.org/jira/browse/CXF-1125
             Project: CXF
          Issue Type: Improvement
          Components: Samples
            Reporter: Christian Schneider


When I tried to start with cxf I had the problem that I did not find a good java first example that was extensible.
I wanted to start with Java First , JAX-WS and JAXB and build the project with maven. I wanted an example that I could then
gradually extend to play with the features of cxf.

The current example has some shortcommings.

1) There is no support for maven. So people using maven will have difficulties setting all dependencies correctly

Can be easily fixed by adding a pom.xml

2) The way the server and client are set up gives you no clue how to extend the thing

I would propose using JaxWs*FactoryBean. The developer using the example will be more familiar with this style.

3) You don´t see the incoming and outgoing messages

I would add logging interceptors

4) The example lacks the @webparam annotation so it will not really produce a nice wsdl

Simple: add the annotation

I will work out a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-1125) java_first_jaxws example should use maven and JaxWs*FactoryBean

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536795 ] 

Daniel Kulp commented on CXF-1125:
----------------------------------

The fix for (1) probably cannot be "complete" until  a newer version of the maven assembly plugin is released.

The main reason is that (as release manager) I refuse to have hardcoded versions in the source.   The cxf.version needs to be filtered into the pom so it's not something that needs to be hand updated with each release.   Unfortunately, the filtering is broken in 2.2-beta-1.  It is fixed with the latest SNAPSHOT, but I'm not sure when that will be released.


Also, #2 is an "interesting" discussion.   If you are a pure JAX-WS person or a Spring person, using the JaxWs*FactoryBean is NOT the more familiar way of doing it.     The spring folks are definitely less likely to ever touch the JaxWs*FactoryBeans as they could just configure those in a spring config file instead of in code.  

> java_first_jaxws example should use maven and JaxWs*FactoryBean
> ---------------------------------------------------------------
>
>                 Key: CXF-1125
>                 URL: https://issues.apache.org/jira/browse/CXF-1125
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>            Reporter: Christian Schneider
>         Attachments: cxf_javafrst_path.txt
>
>
> When I tried to start with cxf I had the problem that I did not find a good java first example that was extensible.
> I wanted to start with Java First , JAX-WS and JAXB and build the project with maven. I wanted an example that I could then
> gradually extend to play with the features of cxf.
> The current example has some shortcommings.
> 1) There is no support for maven. So people using maven will have difficulties setting all dependencies correctly
> Can be easily fixed by adding a pom.xml
> 2) The way the server and client are set up gives you no clue how to extend the thing
> I would propose using JaxWs*FactoryBean. The developer using the example will be more familiar with this style.
> 3) You don´t see the incoming and outgoing messages
> I would add logging interceptors
> 4) The example lacks the @webparam annotation so it will not really produce a nice wsdl
> Simple: add the annotation
> I will work out a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CXF-1125) java_first_jaxws example should use maven and JaxWs*FactoryBean

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider updated CXF-1125:
-------------------------------------

    Attachment: cxf_javafrst_path.txt

Patch for all shortcommings mentioned in the issue. It would be great if this could be added to the example.

> java_first_jaxws example should use maven and JaxWs*FactoryBean
> ---------------------------------------------------------------
>
>                 Key: CXF-1125
>                 URL: https://issues.apache.org/jira/browse/CXF-1125
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>            Reporter: Christian Schneider
>         Attachments: cxf_javafrst_path.txt
>
>
> When I tried to start with cxf I had the problem that I did not find a good java first example that was extensible.
> I wanted to start with Java First , JAX-WS and JAXB and build the project with maven. I wanted an example that I could then
> gradually extend to play with the features of cxf.
> The current example has some shortcommings.
> 1) There is no support for maven. So people using maven will have difficulties setting all dependencies correctly
> Can be easily fixed by adding a pom.xml
> 2) The way the server and client are set up gives you no clue how to extend the thing
> I would propose using JaxWs*FactoryBean. The developer using the example will be more familiar with this style.
> 3) You don´t see the incoming and outgoing messages
> I would add logging interceptors
> 4) The example lacks the @webparam annotation so it will not really produce a nice wsdl
> Simple: add the annotation
> I will work out a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CXF-1125) java_first_jaxws example should use maven and JaxWs*FactoryBean

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536835 ] 

Christian Schneider commented on CXF-1125:
------------------------------------------

The patch can of course wait that long. I have added the pom to the wiki so people have a starting point for working with maven and cxf.

I already guessed that this is the way JAX WS is defined. But I think using the Service.* setup gives the novice user absolutely no clue how do to other xfire setups. And the notation looks very different from the Simple Frontend. But of course follwing the standard also is a good thing. Perhaps we could show both ways. 

If you tell me what you want changed I can build a new patch.

> java_first_jaxws example should use maven and JaxWs*FactoryBean
> ---------------------------------------------------------------
>
>                 Key: CXF-1125
>                 URL: https://issues.apache.org/jira/browse/CXF-1125
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>            Reporter: Christian Schneider
>         Attachments: cxf_javafrst_path.txt
>
>
> When I tried to start with cxf I had the problem that I did not find a good java first example that was extensible.
> I wanted to start with Java First , JAX-WS and JAXB and build the project with maven. I wanted an example that I could then
> gradually extend to play with the features of cxf.
> The current example has some shortcommings.
> 1) There is no support for maven. So people using maven will have difficulties setting all dependencies correctly
> Can be easily fixed by adding a pom.xml
> 2) The way the server and client are set up gives you no clue how to extend the thing
> I would propose using JaxWs*FactoryBean. The developer using the example will be more familiar with this style.
> 3) You don´t see the incoming and outgoing messages
> I would add logging interceptors
> 4) The example lacks the @webparam annotation so it will not really produce a nice wsdl
> Simple: add the annotation
> I will work out a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.