[jira] [Commented] (HIVE-21537) Scalar query rewrite could be improved to not generate an extra join if subquery is guaranteed to produce atmost one row

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806306#comment-16806306 ] 

Hive QA commented on HIVE-21537:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12964380/HIVE-21537.4.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15883 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16788/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16788/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16788/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12964380 - PreCommit-HIVE-Build

> Scalar query rewrite could be improved to not generate an extra join if subquery is guaranteed to produce atmost one row
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-21537
>                 URL: https://issues.apache.org/jira/browse/HIVE-21537
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Planning
>    Affects Versions: 4.0.0
>            Reporter: Vineet Garg
>            Assignee: Vineet Garg
>            Priority: Major
>              Labels: sub-query
>         Attachments: HIVE-21537.1.patch, HIVE-21537.2.patch, HIVE-21537.3.patch, HIVE-21537.4.patch
>
>
> Currently Hive planner introduces this branch and later executes a rule to remove this branch if it could. 
> Subquery remove rule itself could check if subquery will produce max one row (using relmetadat's getMaxRowCount) and avoid introducing this branch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)