You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/11/01 16:38:43 UTC

[GitHub] [commons-bcel] samabcde opened a new pull request, #162: improve test coverage to bcel/generic and UtilityTest

samabcde opened a new pull request, #162:
URL: https://github.com/apache/commons-bcel/pull/162

   For test class in `org.apache.bcel.generic`, basically just test the `accept` method as it is not covered for quite a lot of classes according to coverage report.  
   If this approach looks fine, I can help to add similar test for remaining class in `org.apache.bcel.generic`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory merged pull request #162: Improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #162:
URL: https://github.com/apache/commons-bcel/pull/162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1013953450


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,3118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import java.util.Objects;
+
+public class CountVisitor implements Visitor {
+    private int aaload;
+    private int aastore;
+    private int aconst_null;
+    private int allocationInstruction;
+    private int aload;
+    private int anewarray;
+    private int areturn;
+    private int arithmeticInstruction;
+    private int arrayInstruction;
+    private int arraylength;
+    private int astore;
+    private int athrow;
+    private int baload;
+    private int bastore;
+    private int bipush;
+    private int branchInstruction;
+    private int BREAKPOINT;
+    private int caload;
+    private int castore;
+    private int checkcast;
+    private int constantPushInstruction;
+    private int conversionInstruction;
+    private int cpInstruction;
+    private int d2F;
+    private int d2I;
+    private int d2L;
+    private int dadd;
+    private int daload;
+    private int dastore;
+    private int dcmpg;
+    private int dcmpl;
+    private int dconst;
+    private int ddiv;
+    private int dload;
+    private int dmul;
+    private int dneg;
+    private int drem;
+    private int dreturn;
+    private int dstore;
+    private int dsub;
+    private int dup;
+    private int dup_x1;
+    private int dup_x2;
+    private int dup2;
+    private int dup2_x1;
+    private int dup2_x2;
+    private int exceptionThrower;
+    private int f2D;
+    private int f2I;
+    private int f2L;
+    private int fadd;
+    private int faload;
+    private int fastore;
+    private int fcmpg;
+    private int fcmpl;
+    private int fconst;
+    private int fdiv;
+    private int fieldInstruction;
+    private int fieldOrMethod;
+    private int fload;
+    private int fmul;
+    private int fneg;
+    private int frem;
+    private int freturn;
+    private int fstore;
+    private int fsub;
+    private int getfield;
+    private int getstatic;
+    private int goTo;
+    private int goTo_w;
+    private int gotoInstruction;
+    private int i2B;
+    private int i2C;
+    private int i2D;
+    private int i2F;
+    private int i2L;
+    private int i2S;
+    private int iadd;
+    private int iaload;
+    private int iand;
+    private int iastore;
+    private int iconst;
+    private int idiv;
+    private int if_acmpeq;

Review Comment:
   Use camel case names.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011806687


##########
src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;

Review Comment:
   We do not use star imports. See the other tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011963343


##########
src/test/java/org/apache/bcel/generic/DMULTestCase.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class DMULTestCase {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();
+        DMUL dmul = new DMUL();
+        dmul.accept(countVisitor);
+        assertEquals(1, countVisitor.getVisitTypedInstructionCount());

Review Comment:
   Thx for pointing out. Updated to compare instance as suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011775699


##########
src/test/java/org/apache/bcel/generic/BREAKPOINTTest.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class BREAKPOINTTest {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();
+        BREAKPOINT breakpoint = new BREAKPOINT();
+        breakpoint.accept(countVisitor);
+        assertEquals(1, countVisitor.getVisitBREAKPOINTCount());
+    }
+}

Review Comment:
   >58 new files for 1% more code coverage  
   
   This is due to wrong file name, surefire only includes:
   ```
             <includes>
               <include>**/*TestCase.java</include>
               <include>**/PerformanceTest.java</include>
             </includes>
   ```
   And what I added only target for increasing coverage. `CountVisitor` works like a mock to verify corresponding `visitXXX` method are called in the `accept()` method.
   
   >Files should end in a new line. Check all new files.
   Updated and I can see the new line in IDE. But Github diff does not show the newline, let me know if my fix actually work.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1013019105


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,3118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import java.util.Objects;
+
+public class CountVisitor implements Visitor {
+
+    private int visitAALOADCount;
+    private int visitAASTORECount;
+    private int visitACONST_NULLCount;
+    private int visitAllocationInstructionCount;
+    private int visitALOADCount;
+    private int visitANEWARRAYCount;
+    private int visitARETURNCount;
+    private int visitArithmeticInstructionCount;
+    private int visitArrayInstructionCount;
+    private int visitARRAYLENGTHCount;
+    private int visitASTORECount;
+    private int visitATHROWCount;
+    private int visitBALOADCount;
+    private int visitBASTORECount;
+    private int visitBIPUSHCount;
+    private int visitBranchInstructionCount;
+    private int visitBREAKPOINTCount;
+    private int visitCALOADCount;
+    private int visitCASTORECount;
+    private int visitCHECKCASTCount;
+    private int visitConstantPushInstructionCount;
+    private int visitConversionInstructionCount;
+    private int visitCPInstructionCount;
+    private int visitD2FCount;
+    private int visitD2ICount;
+    private int visitD2LCount;
+    private int visitDADDCount;
+    private int visitDALOADCount;
+    private int visitDASTORECount;
+    private int visitDCMPGCount;
+    private int visitDCMPLCount;
+    private int visitDCONSTCount;
+    private int visitDDIVCount;
+    private int visitDLOADCount;
+    private int visitDMULCount;
+    private int visitDNEGCount;
+    private int visitDREMCount;
+    private int visitDRETURNCount;
+    private int visitDSTORECount;
+    private int visitDSUBCount;
+    private int visitDUPCount;
+    private int visitDUP_X1Count;
+    private int visitDUP_X2Count;
+    private int visitDUP2Count;
+    private int visitDUP2_X1Count;
+    private int visitDUP2_X2Count;
+    private int visitExceptionThrowerCount;
+    private int visitF2DCount;
+    private int visitF2ICount;
+    private int visitF2LCount;
+    private int visitFADDCount;
+    private int visitFALOADCount;
+    private int visitFASTORECount;
+    private int visitFCMPGCount;
+    private int visitFCMPLCount;
+    private int visitFCONSTCount;
+    private int visitFDIVCount;
+    private int visitFieldInstructionCount;
+    private int visitFieldOrMethodCount;
+    private int visitFLOADCount;
+    private int visitFMULCount;
+    private int visitFNEGCount;
+    private int visitFREMCount;
+    private int visitFRETURNCount;
+    private int visitFSTORECount;
+    private int visitFSUBCount;
+    private int visitGETFIELDCount;
+    private int visitGETSTATICCount;
+    private int visitGOTOCount;
+    private int visitGOTO_WCount;
+    private int visitGotoInstructionCount;
+    private int visitI2BCount;
+    private int visitI2CCount;
+    private int visitI2DCount;
+    private int visitI2FCount;
+    private int visitI2LCount;
+    private int visitI2SCount;
+    private int visitIADDCount;
+    private int visitIALOADCount;
+    private int visitIANDCount;
+    private int visitIASTORECount;
+    private int visitICONSTCount;
+    private int visitIDIVCount;
+    private int visitIF_ACMPEQCount;
+    private int visitIF_ACMPNECount;
+    private int visitIF_ICMPEQCount;
+    private int visitIF_ICMPGECount;
+    private int visitIF_ICMPGTCount;
+    private int visitIF_ICMPLECount;
+    private int visitIF_ICMPLTCount;
+    private int visitIF_ICMPNECount;
+    private int visitIFEQCount;
+    private int visitIFGECount;
+    private int visitIFGTCount;
+    private int visitIfInstructionCount;
+    private int visitIFLECount;
+    private int visitIFLTCount;
+    private int visitIFNECount;
+    private int visitIFNONNULLCount;
+    private int visitIFNULLCount;
+    private int visitIINCCount;
+    private int visitILOADCount;
+    private int visitIMPDEP1Count;
+    private int visitIMPDEP2Count;
+    private int visitIMULCount;
+    private int visitINEGCount;
+    private int visitINSTANCEOFCount;
+    private int visitINVOKEDYNAMICCount;
+    private int visitInvokeInstructionCount;
+    private int visitINVOKEINTERFACECount;
+    private int visitINVOKESPECIALCount;
+    private int visitINVOKESTATICCount;
+    private int visitINVOKEVIRTUALCount;
+    private int visitIORCount;
+    private int visitIREMCount;
+    private int visitIRETURNCount;
+    private int visitISHLCount;
+    private int visitISHRCount;
+    private int visitISTORECount;
+    private int visitISUBCount;
+    private int visitIUSHRCount;
+    private int visitIXORCount;
+    private int visitJSRCount;
+    private int visitJSR_WCount;
+    private int visitJsrInstructionCount;
+    private int visitL2DCount;
+    private int visitL2FCount;
+    private int visitL2ICount;
+    private int visitLADDCount;
+    private int visitLALOADCount;
+    private int visitLANDCount;
+    private int visitLASTORECount;
+    private int visitLCMPCount;
+    private int visitLCONSTCount;
+    private int visitLDCCount;
+    private int visitLDC2_WCount;
+    private int visitLDIVCount;
+    private int visitLLOADCount;
+    private int visitLMULCount;
+    private int visitLNEGCount;
+    private int visitLoadClassCount;
+    private int visitLoadInstructionCount;
+    private int visitLocalVariableInstructionCount;
+    private int visitLOOKUPSWITCHCount;
+    private int visitLORCount;
+    private int visitLREMCount;
+    private int visitLRETURNCount;
+    private int visitLSHLCount;
+    private int visitLSHRCount;
+    private int visitLSTORECount;
+    private int visitLSUBCount;
+    private int visitLUSHRCount;
+    private int visitLXORCount;
+    private int visitMONITORENTERCount;
+    private int visitMONITOREXITCount;
+    private int visitMULTIANEWARRAYCount;
+    private int visitNEWCount;
+    private int visitNEWARRAYCount;
+    private int visitNOPCount;
+    private int visitPOPCount;
+    private int visitPOP2Count;
+    private int visitPopInstructionCount;
+    private int visitPushInstructionCount;
+    private int visitPUTFIELDCount;
+    private int visitPUTSTATICCount;
+    private int visitRETCount;
+    private int visitRETURNCount;
+    private int visitReturnInstructionCount;
+    private int visitSALOADCount;
+    private int visitSASTORECount;
+    private int visitSelectCount;
+    private int visitSIPUSHCount;
+    private int visitStackConsumerCount;
+    private int visitStackInstructionCount;
+    private int visitStackProducerCount;
+    private int visitStoreInstructionCount;
+    private int visitSWAPCount;
+    private int visitTABLESWITCHCount;
+    private int visitTypedInstructionCount;
+    private int visitUnconditionalBranchCount;
+    private int visitVariableLengthInstructionCount;
+
+    public int getVisitAALOADCount() {
+        return visitAALOADCount;
+    }
+
+    public void setVisitAALOADCount(int visitAALOADCount) {
+        this.visitAALOADCount = visitAALOADCount;
+    }
+
+    public int getVisitAASTORECount() {
+        return visitAASTORECount;
+    }
+
+    public void setVisitAASTORECount(int visitAASTORECount) {
+        this.visitAASTORECount = visitAASTORECount;
+    }
+
+    public int getVisitACONST_NULLCount() {
+        return visitACONST_NULLCount;
+    }
+
+    public void setVisitACONST_NULLCount(int visitACONST_NULLCount) {
+        this.visitACONST_NULLCount = visitACONST_NULLCount;
+    }
+
+    public int getVisitAllocationInstructionCount() {
+        return visitAllocationInstructionCount;
+    }
+
+    public void setVisitAllocationInstructionCount(int visitAllocationInstructionCount) {
+        this.visitAllocationInstructionCount = visitAllocationInstructionCount;
+    }
+
+    public int getVisitALOADCount() {
+        return visitALOADCount;
+    }
+
+    public void setVisitALOADCount(int visitALOADCount) {
+        this.visitALOADCount = visitALOADCount;
+    }
+
+    public int getVisitANEWARRAYCount() {
+        return visitANEWARRAYCount;
+    }
+
+    public void setVisitANEWARRAYCount(int visitANEWARRAYCount) {
+        this.visitANEWARRAYCount = visitANEWARRAYCount;
+    }
+
+    public int getVisitARETURNCount() {
+        return visitARETURNCount;
+    }
+
+    public void setVisitARETURNCount(int visitARETURNCount) {
+        this.visitARETURNCount = visitARETURNCount;
+    }
+
+    public int getVisitArithmeticInstructionCount() {
+        return visitArithmeticInstructionCount;
+    }
+
+    public void setVisitArithmeticInstructionCount(int visitArithmeticInstructionCount) {
+        this.visitArithmeticInstructionCount = visitArithmeticInstructionCount;
+    }
+
+    public int getVisitArrayInstructionCount() {
+        return visitArrayInstructionCount;
+    }
+
+    public void setVisitArrayInstructionCount(int visitArrayInstructionCount) {
+        this.visitArrayInstructionCount = visitArrayInstructionCount;
+    }
+
+    public int getVisitARRAYLENGTHCount() {
+        return visitARRAYLENGTHCount;
+    }
+
+    public void setVisitARRAYLENGTHCount(int visitARRAYLENGTHCount) {
+        this.visitARRAYLENGTHCount = visitARRAYLENGTHCount;
+    }
+
+    public int getVisitASTORECount() {
+        return visitASTORECount;
+    }
+
+    public void setVisitASTORECount(int visitASTORECount) {
+        this.visitASTORECount = visitASTORECount;
+    }
+
+    public int getVisitATHROWCount() {
+        return visitATHROWCount;
+    }
+
+    public void setVisitATHROWCount(int visitATHROWCount) {
+        this.visitATHROWCount = visitATHROWCount;
+    }
+
+    public int getVisitBALOADCount() {
+        return visitBALOADCount;
+    }
+
+    public void setVisitBALOADCount(int visitBALOADCount) {
+        this.visitBALOADCount = visitBALOADCount;
+    }
+
+    public int getVisitBASTORECount() {
+        return visitBASTORECount;
+    }
+
+    public void setVisitBASTORECount(int visitBASTORECount) {
+        this.visitBASTORECount = visitBASTORECount;
+    }
+
+    public int getVisitBIPUSHCount() {
+        return visitBIPUSHCount;
+    }
+
+    public void setVisitBIPUSHCount(int visitBIPUSHCount) {
+        this.visitBIPUSHCount = visitBIPUSHCount;
+    }
+
+    public int getVisitBranchInstructionCount() {
+        return visitBranchInstructionCount;
+    }
+
+    public void setVisitBranchInstructionCount(int visitBranchInstructionCount) {
+        this.visitBranchInstructionCount = visitBranchInstructionCount;
+    }
+
+    public int getVisitBREAKPOINTCount() {
+        return visitBREAKPOINTCount;
+    }
+
+    public void setVisitBREAKPOINTCount(int visitBREAKPOINTCount) {
+        this.visitBREAKPOINTCount = visitBREAKPOINTCount;
+    }
+
+    public int getVisitCALOADCount() {
+        return visitCALOADCount;
+    }
+
+    public void setVisitCALOADCount(int visitCALOADCount) {
+        this.visitCALOADCount = visitCALOADCount;
+    }
+
+    public int getVisitCASTORECount() {
+        return visitCASTORECount;
+    }
+
+    public void setVisitCASTORECount(int visitCASTORECount) {
+        this.visitCASTORECount = visitCASTORECount;
+    }
+
+    public int getVisitCHECKCASTCount() {
+        return visitCHECKCASTCount;
+    }
+
+    public void setVisitCHECKCASTCount(int visitCHECKCASTCount) {
+        this.visitCHECKCASTCount = visitCHECKCASTCount;
+    }
+
+    public int getVisitConstantPushInstructionCount() {
+        return visitConstantPushInstructionCount;
+    }
+
+    public void setVisitConstantPushInstructionCount(int visitConstantPushInstructionCount) {
+        this.visitConstantPushInstructionCount = visitConstantPushInstructionCount;
+    }
+
+    public int getVisitConversionInstructionCount() {
+        return visitConversionInstructionCount;
+    }
+
+    public void setVisitConversionInstructionCount(int visitConversionInstructionCount) {
+        this.visitConversionInstructionCount = visitConversionInstructionCount;
+    }
+
+    public int getVisitCPInstructionCount() {
+        return visitCPInstructionCount;
+    }
+
+    public void setVisitCPInstructionCount(int visitCPInstructionCount) {
+        this.visitCPInstructionCount = visitCPInstructionCount;
+    }
+
+    public int getVisitD2FCount() {
+        return visitD2FCount;
+    }
+
+    public void setVisitD2FCount(int visitD2FCount) {
+        this.visitD2FCount = visitD2FCount;
+    }
+
+    public int getVisitD2ICount() {
+        return visitD2ICount;
+    }
+
+    public void setVisitD2ICount(int visitD2ICount) {
+        this.visitD2ICount = visitD2ICount;
+    }
+
+    public int getVisitD2LCount() {
+        return visitD2LCount;
+    }
+
+    public void setVisitD2LCount(int visitD2LCount) {
+        this.visitD2LCount = visitD2LCount;
+    }
+
+    public int getVisitDADDCount() {
+        return visitDADDCount;
+    }
+
+    public void setVisitDADDCount(int visitDADDCount) {
+        this.visitDADDCount = visitDADDCount;
+    }
+
+    public int getVisitDALOADCount() {
+        return visitDALOADCount;
+    }
+
+    public void setVisitDALOADCount(int visitDALOADCount) {
+        this.visitDALOADCount = visitDALOADCount;
+    }
+
+    public int getVisitDASTORECount() {
+        return visitDASTORECount;
+    }
+
+    public void setVisitDASTORECount(int visitDASTORECount) {
+        this.visitDASTORECount = visitDASTORECount;
+    }
+
+    public int getVisitDCMPGCount() {
+        return visitDCMPGCount;
+    }
+
+    public void setVisitDCMPGCount(int visitDCMPGCount) {
+        this.visitDCMPGCount = visitDCMPGCount;
+    }
+
+    public int getVisitDCMPLCount() {
+        return visitDCMPLCount;
+    }
+
+    public void setVisitDCMPLCount(int visitDCMPLCount) {
+        this.visitDCMPLCount = visitDCMPLCount;
+    }
+
+    public int getVisitDCONSTCount() {
+        return visitDCONSTCount;
+    }
+
+    public void setVisitDCONSTCount(int visitDCONSTCount) {
+        this.visitDCONSTCount = visitDCONSTCount;
+    }
+
+    public int getVisitDDIVCount() {
+        return visitDDIVCount;
+    }
+
+    public void setVisitDDIVCount(int visitDDIVCount) {
+        this.visitDDIVCount = visitDDIVCount;
+    }
+
+    public int getVisitDLOADCount() {
+        return visitDLOADCount;
+    }
+
+    public void setVisitDLOADCount(int visitDLOADCount) {
+        this.visitDLOADCount = visitDLOADCount;
+    }
+
+    public int getVisitDMULCount() {
+        return visitDMULCount;
+    }
+
+    public void setVisitDMULCount(int visitDMULCount) {
+        this.visitDMULCount = visitDMULCount;
+    }
+
+    public int getVisitDNEGCount() {
+        return visitDNEGCount;
+    }
+
+    public void setVisitDNEGCount(int visitDNEGCount) {
+        this.visitDNEGCount = visitDNEGCount;
+    }
+
+    public int getVisitDREMCount() {
+        return visitDREMCount;
+    }
+
+    public void setVisitDREMCount(int visitDREMCount) {
+        this.visitDREMCount = visitDREMCount;
+    }
+
+    public int getVisitDRETURNCount() {
+        return visitDRETURNCount;
+    }
+
+    public void setVisitDRETURNCount(int visitDRETURNCount) {
+        this.visitDRETURNCount = visitDRETURNCount;
+    }
+
+    public int getVisitDSTORECount() {
+        return visitDSTORECount;
+    }
+
+    public void setVisitDSTORECount(int visitDSTORECount) {
+        this.visitDSTORECount = visitDSTORECount;
+    }
+
+    public int getVisitDSUBCount() {
+        return visitDSUBCount;
+    }
+
+    public void setVisitDSUBCount(int visitDSUBCount) {
+        this.visitDSUBCount = visitDSUBCount;
+    }
+
+    public int getVisitDUPCount() {
+        return visitDUPCount;
+    }
+
+    public void setVisitDUPCount(int visitDUPCount) {
+        this.visitDUPCount = visitDUPCount;
+    }
+
+    public int getVisitDUP_X1Count() {
+        return visitDUP_X1Count;
+    }
+
+    public void setVisitDUP_X1Count(int visitDUP_X1Count) {
+        this.visitDUP_X1Count = visitDUP_X1Count;
+    }
+
+    public int getVisitDUP_X2Count() {
+        return visitDUP_X2Count;
+    }
+
+    public void setVisitDUP_X2Count(int visitDUP_X2Count) {
+        this.visitDUP_X2Count = visitDUP_X2Count;
+    }
+
+    public int getVisitDUP2Count() {
+        return visitDUP2Count;
+    }
+
+    public void setVisitDUP2Count(int visitDUP2Count) {
+        this.visitDUP2Count = visitDUP2Count;
+    }
+
+    public int getVisitDUP2_X1Count() {
+        return visitDUP2_X1Count;
+    }
+
+    public void setVisitDUP2_X1Count(int visitDUP2_X1Count) {
+        this.visitDUP2_X1Count = visitDUP2_X1Count;
+    }
+
+    public int getVisitDUP2_X2Count() {
+        return visitDUP2_X2Count;
+    }
+
+    public void setVisitDUP2_X2Count(int visitDUP2_X2Count) {
+        this.visitDUP2_X2Count = visitDUP2_X2Count;
+    }
+
+    public int getVisitExceptionThrowerCount() {
+        return visitExceptionThrowerCount;
+    }
+
+    public void setVisitExceptionThrowerCount(int visitExceptionThrowerCount) {
+        this.visitExceptionThrowerCount = visitExceptionThrowerCount;
+    }
+
+    public int getVisitF2DCount() {
+        return visitF2DCount;
+    }
+
+    public void setVisitF2DCount(int visitF2DCount) {
+        this.visitF2DCount = visitF2DCount;
+    }
+
+    public int getVisitF2ICount() {
+        return visitF2ICount;
+    }
+
+    public void setVisitF2ICount(int visitF2ICount) {
+        this.visitF2ICount = visitF2ICount;
+    }
+
+    public int getVisitF2LCount() {
+        return visitF2LCount;
+    }
+
+    public void setVisitF2LCount(int visitF2LCount) {
+        this.visitF2LCount = visitF2LCount;
+    }
+
+    public int getVisitFADDCount() {
+        return visitFADDCount;
+    }
+
+    public void setVisitFADDCount(int visitFADDCount) {
+        this.visitFADDCount = visitFADDCount;
+    }
+
+    public int getVisitFALOADCount() {
+        return visitFALOADCount;
+    }
+
+    public void setVisitFALOADCount(int visitFALOADCount) {
+        this.visitFALOADCount = visitFALOADCount;
+    }
+
+    public int getVisitFASTORECount() {
+        return visitFASTORECount;
+    }
+
+    public void setVisitFASTORECount(int visitFASTORECount) {
+        this.visitFASTORECount = visitFASTORECount;
+    }
+
+    public int getVisitFCMPGCount() {
+        return visitFCMPGCount;
+    }
+
+    public void setVisitFCMPGCount(int visitFCMPGCount) {
+        this.visitFCMPGCount = visitFCMPGCount;
+    }
+
+    public int getVisitFCMPLCount() {
+        return visitFCMPLCount;
+    }
+
+    public void setVisitFCMPLCount(int visitFCMPLCount) {
+        this.visitFCMPLCount = visitFCMPLCount;
+    }
+
+    public int getVisitFCONSTCount() {
+        return visitFCONSTCount;
+    }
+
+    public void setVisitFCONSTCount(int visitFCONSTCount) {
+        this.visitFCONSTCount = visitFCONSTCount;
+    }
+
+    public int getVisitFDIVCount() {
+        return visitFDIVCount;
+    }
+
+    public void setVisitFDIVCount(int visitFDIVCount) {
+        this.visitFDIVCount = visitFDIVCount;
+    }
+
+    public int getVisitFieldInstructionCount() {
+        return visitFieldInstructionCount;
+    }
+
+    public void setVisitFieldInstructionCount(int visitFieldInstructionCount) {
+        this.visitFieldInstructionCount = visitFieldInstructionCount;
+    }
+
+    public int getVisitFieldOrMethodCount() {
+        return visitFieldOrMethodCount;
+    }
+
+    public void setVisitFieldOrMethodCount(int visitFieldOrMethodCount) {
+        this.visitFieldOrMethodCount = visitFieldOrMethodCount;
+    }
+
+    public int getVisitFLOADCount() {
+        return visitFLOADCount;
+    }
+
+    public void setVisitFLOADCount(int visitFLOADCount) {
+        this.visitFLOADCount = visitFLOADCount;
+    }
+
+    public int getVisitFMULCount() {
+        return visitFMULCount;
+    }
+
+    public void setVisitFMULCount(int visitFMULCount) {
+        this.visitFMULCount = visitFMULCount;
+    }
+
+    public int getVisitFNEGCount() {
+        return visitFNEGCount;
+    }
+
+    public void setVisitFNEGCount(int visitFNEGCount) {
+        this.visitFNEGCount = visitFNEGCount;
+    }
+
+    public int getVisitFREMCount() {
+        return visitFREMCount;
+    }
+
+    public void setVisitFREMCount(int visitFREMCount) {
+        this.visitFREMCount = visitFREMCount;
+    }
+
+    public int getVisitFRETURNCount() {
+        return visitFRETURNCount;
+    }
+
+    public void setVisitFRETURNCount(int visitFRETURNCount) {
+        this.visitFRETURNCount = visitFRETURNCount;
+    }
+
+    public int getVisitFSTORECount() {
+        return visitFSTORECount;
+    }
+
+    public void setVisitFSTORECount(int visitFSTORECount) {
+        this.visitFSTORECount = visitFSTORECount;
+    }
+
+    public int getVisitFSUBCount() {
+        return visitFSUBCount;
+    }
+
+    public void setVisitFSUBCount(int visitFSUBCount) {
+        this.visitFSUBCount = visitFSUBCount;
+    }
+
+    public int getVisitGETFIELDCount() {
+        return visitGETFIELDCount;
+    }
+
+    public void setVisitGETFIELDCount(int visitGETFIELDCount) {
+        this.visitGETFIELDCount = visitGETFIELDCount;
+    }
+
+    public int getVisitGETSTATICCount() {
+        return visitGETSTATICCount;
+    }
+
+    public void setVisitGETSTATICCount(int visitGETSTATICCount) {
+        this.visitGETSTATICCount = visitGETSTATICCount;
+    }
+
+    public int getVisitGOTOCount() {
+        return visitGOTOCount;
+    }
+
+    public void setVisitGOTOCount(int visitGOTOCount) {
+        this.visitGOTOCount = visitGOTOCount;
+    }
+
+    public int getVisitGOTO_WCount() {
+        return visitGOTO_WCount;
+    }
+
+    public void setVisitGOTO_WCount(int visitGOTO_WCount) {
+        this.visitGOTO_WCount = visitGOTO_WCount;
+    }
+
+    public int getVisitGotoInstructionCount() {
+        return visitGotoInstructionCount;
+    }
+
+    public void setVisitGotoInstructionCount(int visitGotoInstructionCount) {
+        this.visitGotoInstructionCount = visitGotoInstructionCount;
+    }
+
+    public int getVisitI2BCount() {
+        return visitI2BCount;
+    }
+
+    public void setVisitI2BCount(int visitI2BCount) {
+        this.visitI2BCount = visitI2BCount;
+    }
+
+    public int getVisitI2CCount() {
+        return visitI2CCount;
+    }
+
+    public void setVisitI2CCount(int visitI2CCount) {
+        this.visitI2CCount = visitI2CCount;
+    }
+
+    public int getVisitI2DCount() {
+        return visitI2DCount;
+    }
+
+    public void setVisitI2DCount(int visitI2DCount) {
+        this.visitI2DCount = visitI2DCount;
+    }
+
+    public int getVisitI2FCount() {
+        return visitI2FCount;
+    }
+
+    public void setVisitI2FCount(int visitI2FCount) {
+        this.visitI2FCount = visitI2FCount;
+    }
+
+    public int getVisitI2LCount() {
+        return visitI2LCount;
+    }
+
+    public void setVisitI2LCount(int visitI2LCount) {
+        this.visitI2LCount = visitI2LCount;
+    }
+
+    public int getVisitI2SCount() {
+        return visitI2SCount;
+    }
+
+    public void setVisitI2SCount(int visitI2SCount) {
+        this.visitI2SCount = visitI2SCount;
+    }
+
+    public int getVisitIADDCount() {
+        return visitIADDCount;
+    }
+
+    public void setVisitIADDCount(int visitIADDCount) {
+        this.visitIADDCount = visitIADDCount;
+    }
+
+    public int getVisitIALOADCount() {
+        return visitIALOADCount;
+    }
+
+    public void setVisitIALOADCount(int visitIALOADCount) {
+        this.visitIALOADCount = visitIALOADCount;
+    }
+
+    public int getVisitIANDCount() {
+        return visitIANDCount;
+    }
+
+    public void setVisitIANDCount(int visitIANDCount) {
+        this.visitIANDCount = visitIANDCount;
+    }
+
+    public int getVisitIASTORECount() {
+        return visitIASTORECount;
+    }
+
+    public void setVisitIASTORECount(int visitIASTORECount) {
+        this.visitIASTORECount = visitIASTORECount;
+    }
+
+    public int getVisitICONSTCount() {
+        return visitICONSTCount;
+    }
+
+    public void setVisitICONSTCount(int visitICONSTCount) {
+        this.visitICONSTCount = visitICONSTCount;
+    }
+
+    public int getVisitIDIVCount() {
+        return visitIDIVCount;
+    }
+
+    public void setVisitIDIVCount(int visitIDIVCount) {
+        this.visitIDIVCount = visitIDIVCount;
+    }
+
+    public int getVisitIF_ACMPEQCount() {
+        return visitIF_ACMPEQCount;
+    }
+
+    public void setVisitIF_ACMPEQCount(int visitIF_ACMPEQCount) {
+        this.visitIF_ACMPEQCount = visitIF_ACMPEQCount;
+    }
+
+    public int getVisitIF_ACMPNECount() {
+        return visitIF_ACMPNECount;
+    }
+
+    public void setVisitIF_ACMPNECount(int visitIF_ACMPNECount) {
+        this.visitIF_ACMPNECount = visitIF_ACMPNECount;
+    }
+
+    public int getVisitIF_ICMPEQCount() {
+        return visitIF_ICMPEQCount;
+    }
+
+    public void setVisitIF_ICMPEQCount(int visitIF_ICMPEQCount) {
+        this.visitIF_ICMPEQCount = visitIF_ICMPEQCount;
+    }
+
+    public int getVisitIF_ICMPGECount() {
+        return visitIF_ICMPGECount;
+    }
+
+    public void setVisitIF_ICMPGECount(int visitIF_ICMPGECount) {
+        this.visitIF_ICMPGECount = visitIF_ICMPGECount;
+    }
+
+    public int getVisitIF_ICMPGTCount() {
+        return visitIF_ICMPGTCount;
+    }
+
+    public void setVisitIF_ICMPGTCount(int visitIF_ICMPGTCount) {
+        this.visitIF_ICMPGTCount = visitIF_ICMPGTCount;
+    }
+
+    public int getVisitIF_ICMPLECount() {
+        return visitIF_ICMPLECount;
+    }
+
+    public void setVisitIF_ICMPLECount(int visitIF_ICMPLECount) {
+        this.visitIF_ICMPLECount = visitIF_ICMPLECount;
+    }
+
+    public int getVisitIF_ICMPLTCount() {
+        return visitIF_ICMPLTCount;
+    }
+
+    public void setVisitIF_ICMPLTCount(int visitIF_ICMPLTCount) {
+        this.visitIF_ICMPLTCount = visitIF_ICMPLTCount;
+    }
+
+    public int getVisitIF_ICMPNECount() {
+        return visitIF_ICMPNECount;
+    }
+
+    public void setVisitIF_ICMPNECount(int visitIF_ICMPNECount) {
+        this.visitIF_ICMPNECount = visitIF_ICMPNECount;
+    }
+
+    public int getVisitIFEQCount() {
+        return visitIFEQCount;
+    }
+
+    public void setVisitIFEQCount(int visitIFEQCount) {
+        this.visitIFEQCount = visitIFEQCount;
+    }
+
+    public int getVisitIFGECount() {
+        return visitIFGECount;
+    }
+
+    public void setVisitIFGECount(int visitIFGECount) {
+        this.visitIFGECount = visitIFGECount;
+    }
+
+    public int getVisitIFGTCount() {
+        return visitIFGTCount;
+    }
+
+    public void setVisitIFGTCount(int visitIFGTCount) {
+        this.visitIFGTCount = visitIFGTCount;
+    }
+
+    public int getVisitIfInstructionCount() {
+        return visitIfInstructionCount;
+    }
+
+    public void setVisitIfInstructionCount(int visitIfInstructionCount) {
+        this.visitIfInstructionCount = visitIfInstructionCount;
+    }
+
+    public int getVisitIFLECount() {
+        return visitIFLECount;
+    }
+
+    public void setVisitIFLECount(int visitIFLECount) {
+        this.visitIFLECount = visitIFLECount;
+    }
+
+    public int getVisitIFLTCount() {
+        return visitIFLTCount;
+    }
+
+    public void setVisitIFLTCount(int visitIFLTCount) {
+        this.visitIFLTCount = visitIFLTCount;
+    }
+
+    public int getVisitIFNECount() {
+        return visitIFNECount;
+    }
+
+    public void setVisitIFNECount(int visitIFNECount) {
+        this.visitIFNECount = visitIFNECount;
+    }
+
+    public int getVisitIFNONNULLCount() {
+        return visitIFNONNULLCount;
+    }
+
+    public void setVisitIFNONNULLCount(int visitIFNONNULLCount) {
+        this.visitIFNONNULLCount = visitIFNONNULLCount;
+    }
+
+    public int getVisitIFNULLCount() {
+        return visitIFNULLCount;
+    }
+
+    public void setVisitIFNULLCount(int visitIFNULLCount) {
+        this.visitIFNULLCount = visitIFNULLCount;
+    }
+
+    public int getVisitIINCCount() {
+        return visitIINCCount;
+    }
+
+    public void setVisitIINCCount(int visitIINCCount) {
+        this.visitIINCCount = visitIINCCount;
+    }
+
+    public int getVisitILOADCount() {
+        return visitILOADCount;
+    }
+
+    public void setVisitILOADCount(int visitILOADCount) {
+        this.visitILOADCount = visitILOADCount;
+    }
+
+    public int getVisitIMPDEP1Count() {
+        return visitIMPDEP1Count;
+    }
+
+    public void setVisitIMPDEP1Count(int visitIMPDEP1Count) {
+        this.visitIMPDEP1Count = visitIMPDEP1Count;
+    }
+
+    public int getVisitIMPDEP2Count() {
+        return visitIMPDEP2Count;
+    }
+
+    public void setVisitIMPDEP2Count(int visitIMPDEP2Count) {
+        this.visitIMPDEP2Count = visitIMPDEP2Count;
+    }
+
+    public int getVisitIMULCount() {
+        return visitIMULCount;
+    }
+
+    public void setVisitIMULCount(int visitIMULCount) {
+        this.visitIMULCount = visitIMULCount;
+    }
+
+    public int getVisitINEGCount() {
+        return visitINEGCount;
+    }
+
+    public void setVisitINEGCount(int visitINEGCount) {
+        this.visitINEGCount = visitINEGCount;
+    }
+
+    public int getVisitINSTANCEOFCount() {
+        return visitINSTANCEOFCount;
+    }
+
+    public void setVisitINSTANCEOFCount(int visitINSTANCEOFCount) {
+        this.visitINSTANCEOFCount = visitINSTANCEOFCount;
+    }
+
+    public int getVisitINVOKEDYNAMICCount() {
+        return visitINVOKEDYNAMICCount;
+    }
+
+    public void setVisitINVOKEDYNAMICCount(int visitINVOKEDYNAMICCount) {
+        this.visitINVOKEDYNAMICCount = visitINVOKEDYNAMICCount;
+    }
+
+    public int getVisitInvokeInstructionCount() {
+        return visitInvokeInstructionCount;
+    }
+
+    public void setVisitInvokeInstructionCount(int visitInvokeInstructionCount) {
+        this.visitInvokeInstructionCount = visitInvokeInstructionCount;
+    }
+
+    public int getVisitINVOKEINTERFACECount() {
+        return visitINVOKEINTERFACECount;
+    }
+
+    public void setVisitINVOKEINTERFACECount(int visitINVOKEINTERFACECount) {
+        this.visitINVOKEINTERFACECount = visitINVOKEINTERFACECount;
+    }
+
+    public int getVisitINVOKESPECIALCount() {
+        return visitINVOKESPECIALCount;
+    }
+
+    public void setVisitINVOKESPECIALCount(int visitINVOKESPECIALCount) {
+        this.visitINVOKESPECIALCount = visitINVOKESPECIALCount;
+    }
+
+    public int getVisitINVOKESTATICCount() {
+        return visitINVOKESTATICCount;
+    }
+
+    public void setVisitINVOKESTATICCount(int visitINVOKESTATICCount) {
+        this.visitINVOKESTATICCount = visitINVOKESTATICCount;
+    }
+
+    public int getVisitINVOKEVIRTUALCount() {
+        return visitINVOKEVIRTUALCount;
+    }
+
+    public void setVisitINVOKEVIRTUALCount(int visitINVOKEVIRTUALCount) {
+        this.visitINVOKEVIRTUALCount = visitINVOKEVIRTUALCount;
+    }
+
+    public int getVisitIORCount() {
+        return visitIORCount;
+    }
+
+    public void setVisitIORCount(int visitIORCount) {
+        this.visitIORCount = visitIORCount;
+    }
+
+    public int getVisitIREMCount() {
+        return visitIREMCount;
+    }
+
+    public void setVisitIREMCount(int visitIREMCount) {
+        this.visitIREMCount = visitIREMCount;
+    }
+
+    public int getVisitIRETURNCount() {
+        return visitIRETURNCount;
+    }
+
+    public void setVisitIRETURNCount(int visitIRETURNCount) {
+        this.visitIRETURNCount = visitIRETURNCount;
+    }
+
+    public int getVisitISHLCount() {
+        return visitISHLCount;
+    }
+
+    public void setVisitISHLCount(int visitISHLCount) {
+        this.visitISHLCount = visitISHLCount;
+    }
+
+    public int getVisitISHRCount() {
+        return visitISHRCount;
+    }
+
+    public void setVisitISHRCount(int visitISHRCount) {
+        this.visitISHRCount = visitISHRCount;
+    }
+
+    public int getVisitISTORECount() {
+        return visitISTORECount;
+    }
+
+    public void setVisitISTORECount(int visitISTORECount) {
+        this.visitISTORECount = visitISTORECount;
+    }
+
+    public int getVisitISUBCount() {
+        return visitISUBCount;
+    }
+
+    public void setVisitISUBCount(int visitISUBCount) {
+        this.visitISUBCount = visitISUBCount;
+    }
+
+    public int getVisitIUSHRCount() {
+        return visitIUSHRCount;
+    }
+
+    public void setVisitIUSHRCount(int visitIUSHRCount) {
+        this.visitIUSHRCount = visitIUSHRCount;
+    }
+
+    public int getVisitIXORCount() {
+        return visitIXORCount;
+    }
+
+    public void setVisitIXORCount(int visitIXORCount) {
+        this.visitIXORCount = visitIXORCount;
+    }
+
+    public int getVisitJSRCount() {
+        return visitJSRCount;
+    }
+
+    public void setVisitJSRCount(int visitJSRCount) {
+        this.visitJSRCount = visitJSRCount;
+    }
+
+    public int getVisitJSR_WCount() {
+        return visitJSR_WCount;
+    }
+
+    public void setVisitJSR_WCount(int visitJSR_WCount) {
+        this.visitJSR_WCount = visitJSR_WCount;
+    }
+
+    public int getVisitJsrInstructionCount() {
+        return visitJsrInstructionCount;
+    }
+
+    public void setVisitJsrInstructionCount(int visitJsrInstructionCount) {
+        this.visitJsrInstructionCount = visitJsrInstructionCount;
+    }
+
+    public int getVisitL2DCount() {
+        return visitL2DCount;
+    }
+
+    public void setVisitL2DCount(int visitL2DCount) {
+        this.visitL2DCount = visitL2DCount;
+    }
+
+    public int getVisitL2FCount() {
+        return visitL2FCount;
+    }
+
+    public void setVisitL2FCount(int visitL2FCount) {
+        this.visitL2FCount = visitL2FCount;
+    }
+
+    public int getVisitL2ICount() {
+        return visitL2ICount;
+    }
+
+    public void setVisitL2ICount(int visitL2ICount) {
+        this.visitL2ICount = visitL2ICount;
+    }
+
+    public int getVisitLADDCount() {
+        return visitLADDCount;
+    }
+
+    public void setVisitLADDCount(int visitLADDCount) {
+        this.visitLADDCount = visitLADDCount;
+    }
+
+    public int getVisitLALOADCount() {
+        return visitLALOADCount;
+    }
+
+    public void setVisitLALOADCount(int visitLALOADCount) {
+        this.visitLALOADCount = visitLALOADCount;
+    }
+
+    public int getVisitLANDCount() {
+        return visitLANDCount;
+    }
+
+    public void setVisitLANDCount(int visitLANDCount) {
+        this.visitLANDCount = visitLANDCount;
+    }
+
+    public int getVisitLASTORECount() {
+        return visitLASTORECount;
+    }
+
+    public void setVisitLASTORECount(int visitLASTORECount) {
+        this.visitLASTORECount = visitLASTORECount;
+    }
+
+    public int getVisitLCMPCount() {
+        return visitLCMPCount;
+    }
+
+    public void setVisitLCMPCount(int visitLCMPCount) {
+        this.visitLCMPCount = visitLCMPCount;
+    }
+
+    public int getVisitLCONSTCount() {
+        return visitLCONSTCount;
+    }
+
+    public void setVisitLCONSTCount(int visitLCONSTCount) {
+        this.visitLCONSTCount = visitLCONSTCount;
+    }
+
+    public int getVisitLDCCount() {
+        return visitLDCCount;
+    }
+
+    public void setVisitLDCCount(int visitLDCCount) {
+        this.visitLDCCount = visitLDCCount;
+    }
+
+    public int getVisitLDC2_WCount() {
+        return visitLDC2_WCount;
+    }
+
+    public void setVisitLDC2_WCount(int visitLDC2_WCount) {
+        this.visitLDC2_WCount = visitLDC2_WCount;
+    }
+
+    public int getVisitLDIVCount() {
+        return visitLDIVCount;
+    }
+
+    public void setVisitLDIVCount(int visitLDIVCount) {
+        this.visitLDIVCount = visitLDIVCount;
+    }
+
+    public int getVisitLLOADCount() {
+        return visitLLOADCount;
+    }
+
+    public void setVisitLLOADCount(int visitLLOADCount) {
+        this.visitLLOADCount = visitLLOADCount;
+    }
+
+    public int getVisitLMULCount() {
+        return visitLMULCount;
+    }
+
+    public void setVisitLMULCount(int visitLMULCount) {
+        this.visitLMULCount = visitLMULCount;
+    }
+
+    public int getVisitLNEGCount() {
+        return visitLNEGCount;
+    }
+
+    public void setVisitLNEGCount(int visitLNEGCount) {
+        this.visitLNEGCount = visitLNEGCount;
+    }
+
+    public int getVisitLoadClassCount() {
+        return visitLoadClassCount;
+    }
+
+    public void setVisitLoadClassCount(int visitLoadClassCount) {
+        this.visitLoadClassCount = visitLoadClassCount;
+    }
+
+    public int getVisitLoadInstructionCount() {
+        return visitLoadInstructionCount;
+    }
+
+    public void setVisitLoadInstructionCount(int visitLoadInstructionCount) {
+        this.visitLoadInstructionCount = visitLoadInstructionCount;
+    }
+
+    public int getVisitLocalVariableInstructionCount() {
+        return visitLocalVariableInstructionCount;
+    }
+
+    public void setVisitLocalVariableInstructionCount(int visitLocalVariableInstructionCount) {
+        this.visitLocalVariableInstructionCount = visitLocalVariableInstructionCount;
+    }
+
+    public int getVisitLOOKUPSWITCHCount() {
+        return visitLOOKUPSWITCHCount;
+    }
+
+    public void setVisitLOOKUPSWITCHCount(int visitLOOKUPSWITCHCount) {
+        this.visitLOOKUPSWITCHCount = visitLOOKUPSWITCHCount;
+    }
+
+    public int getVisitLORCount() {
+        return visitLORCount;
+    }
+
+    public void setVisitLORCount(int visitLORCount) {
+        this.visitLORCount = visitLORCount;
+    }
+
+    public int getVisitLREMCount() {
+        return visitLREMCount;
+    }
+
+    public void setVisitLREMCount(int visitLREMCount) {
+        this.visitLREMCount = visitLREMCount;
+    }
+
+    public int getVisitLRETURNCount() {
+        return visitLRETURNCount;
+    }
+
+    public void setVisitLRETURNCount(int visitLRETURNCount) {
+        this.visitLRETURNCount = visitLRETURNCount;
+    }
+
+    public int getVisitLSHLCount() {
+        return visitLSHLCount;
+    }
+
+    public void setVisitLSHLCount(int visitLSHLCount) {
+        this.visitLSHLCount = visitLSHLCount;
+    }
+
+    public int getVisitLSHRCount() {
+        return visitLSHRCount;
+    }
+
+    public void setVisitLSHRCount(int visitLSHRCount) {
+        this.visitLSHRCount = visitLSHRCount;
+    }
+
+    public int getVisitLSTORECount() {
+        return visitLSTORECount;
+    }
+
+    public void setVisitLSTORECount(int visitLSTORECount) {
+        this.visitLSTORECount = visitLSTORECount;
+    }
+
+    public int getVisitLSUBCount() {
+        return visitLSUBCount;
+    }
+
+    public void setVisitLSUBCount(int visitLSUBCount) {
+        this.visitLSUBCount = visitLSUBCount;
+    }
+
+    public int getVisitLUSHRCount() {
+        return visitLUSHRCount;
+    }
+
+    public void setVisitLUSHRCount(int visitLUSHRCount) {
+        this.visitLUSHRCount = visitLUSHRCount;
+    }
+
+    public int getVisitLXORCount() {
+        return visitLXORCount;
+    }
+
+    public void setVisitLXORCount(int visitLXORCount) {
+        this.visitLXORCount = visitLXORCount;
+    }
+
+    public int getVisitMONITORENTERCount() {
+        return visitMONITORENTERCount;
+    }
+
+    public void setVisitMONITORENTERCount(int visitMONITORENTERCount) {
+        this.visitMONITORENTERCount = visitMONITORENTERCount;
+    }
+
+    public int getVisitMONITOREXITCount() {
+        return visitMONITOREXITCount;
+    }
+
+    public void setVisitMONITOREXITCount(int visitMONITOREXITCount) {
+        this.visitMONITOREXITCount = visitMONITOREXITCount;
+    }
+
+    public int getVisitMULTIANEWARRAYCount() {
+        return visitMULTIANEWARRAYCount;
+    }
+
+    public void setVisitMULTIANEWARRAYCount(int visitMULTIANEWARRAYCount) {
+        this.visitMULTIANEWARRAYCount = visitMULTIANEWARRAYCount;
+    }
+
+    public int getVisitNEWCount() {
+        return visitNEWCount;
+    }
+
+    public void setVisitNEWCount(int visitNEWCount) {
+        this.visitNEWCount = visitNEWCount;
+    }
+
+    public int getVisitNEWARRAYCount() {
+        return visitNEWARRAYCount;
+    }
+
+    public void setVisitNEWARRAYCount(int visitNEWARRAYCount) {
+        this.visitNEWARRAYCount = visitNEWARRAYCount;
+    }
+
+    public int getVisitNOPCount() {
+        return visitNOPCount;
+    }
+
+    public void setVisitNOPCount(int visitNOPCount) {
+        this.visitNOPCount = visitNOPCount;
+    }
+
+    public int getVisitPOPCount() {
+        return visitPOPCount;
+    }
+
+    public void setVisitPOPCount(int visitPOPCount) {
+        this.visitPOPCount = visitPOPCount;
+    }
+
+    public int getVisitPOP2Count() {
+        return visitPOP2Count;
+    }
+
+    public void setVisitPOP2Count(int visitPOP2Count) {
+        this.visitPOP2Count = visitPOP2Count;
+    }
+
+    public int getVisitPopInstructionCount() {
+        return visitPopInstructionCount;
+    }
+
+    public void setVisitPopInstructionCount(int visitPopInstructionCount) {
+        this.visitPopInstructionCount = visitPopInstructionCount;
+    }
+
+    public int getVisitPushInstructionCount() {
+        return visitPushInstructionCount;
+    }
+
+    public void setVisitPushInstructionCount(int visitPushInstructionCount) {
+        this.visitPushInstructionCount = visitPushInstructionCount;
+    }
+
+    public int getVisitPUTFIELDCount() {
+        return visitPUTFIELDCount;
+    }
+
+    public void setVisitPUTFIELDCount(int visitPUTFIELDCount) {
+        this.visitPUTFIELDCount = visitPUTFIELDCount;
+    }
+
+    public int getVisitPUTSTATICCount() {
+        return visitPUTSTATICCount;
+    }
+
+    public void setVisitPUTSTATICCount(int visitPUTSTATICCount) {
+        this.visitPUTSTATICCount = visitPUTSTATICCount;
+    }
+
+    public int getVisitRETCount() {
+        return visitRETCount;
+    }
+
+    public void setVisitRETCount(int visitRETCount) {
+        this.visitRETCount = visitRETCount;
+    }
+
+    public int getVisitRETURNCount() {
+        return visitRETURNCount;
+    }
+
+    public void setVisitRETURNCount(int visitRETURNCount) {
+        this.visitRETURNCount = visitRETURNCount;
+    }
+
+    public int getVisitReturnInstructionCount() {
+        return visitReturnInstructionCount;
+    }
+
+    public void setVisitReturnInstructionCount(int visitReturnInstructionCount) {
+        this.visitReturnInstructionCount = visitReturnInstructionCount;
+    }
+
+    public int getVisitSALOADCount() {
+        return visitSALOADCount;
+    }
+
+    public void setVisitSALOADCount(int visitSALOADCount) {
+        this.visitSALOADCount = visitSALOADCount;
+    }
+
+    public int getVisitSASTORECount() {
+        return visitSASTORECount;
+    }
+
+    public void setVisitSASTORECount(int visitSASTORECount) {
+        this.visitSASTORECount = visitSASTORECount;
+    }
+
+    public int getVisitSelectCount() {
+        return visitSelectCount;
+    }
+
+    public void setVisitSelectCount(int visitSelectCount) {
+        this.visitSelectCount = visitSelectCount;
+    }
+
+    public int getVisitSIPUSHCount() {
+        return visitSIPUSHCount;
+    }
+
+    public void setVisitSIPUSHCount(int visitSIPUSHCount) {
+        this.visitSIPUSHCount = visitSIPUSHCount;
+    }
+
+    public int getVisitStackConsumerCount() {
+        return visitStackConsumerCount;
+    }
+
+    public void setVisitStackConsumerCount(int visitStackConsumerCount) {
+        this.visitStackConsumerCount = visitStackConsumerCount;
+    }
+
+    public int getVisitStackInstructionCount() {
+        return visitStackInstructionCount;
+    }
+
+    public void setVisitStackInstructionCount(int visitStackInstructionCount) {
+        this.visitStackInstructionCount = visitStackInstructionCount;
+    }
+
+    public int getVisitStackProducerCount() {
+        return visitStackProducerCount;
+    }
+
+    public void setVisitStackProducerCount(int visitStackProducerCount) {
+        this.visitStackProducerCount = visitStackProducerCount;
+    }
+
+    public int getVisitStoreInstructionCount() {
+        return visitStoreInstructionCount;
+    }
+
+    public void setVisitStoreInstructionCount(int visitStoreInstructionCount) {
+        this.visitStoreInstructionCount = visitStoreInstructionCount;
+    }
+
+    public int getVisitSWAPCount() {
+        return visitSWAPCount;
+    }
+
+    public void setVisitSWAPCount(int visitSWAPCount) {
+        this.visitSWAPCount = visitSWAPCount;
+    }
+
+    public int getVisitTABLESWITCHCount() {
+        return visitTABLESWITCHCount;
+    }
+
+    public void setVisitTABLESWITCHCount(int visitTABLESWITCHCount) {
+        this.visitTABLESWITCHCount = visitTABLESWITCHCount;
+    }
+
+    public int getVisitTypedInstructionCount() {
+        return visitTypedInstructionCount;
+    }
+
+    public void setVisitTypedInstructionCount(int visitTypedInstructionCount) {
+        this.visitTypedInstructionCount = visitTypedInstructionCount;
+    }
+
+    public int getVisitUnconditionalBranchCount() {
+        return visitUnconditionalBranchCount;
+    }
+
+    public void setVisitUnconditionalBranchCount(int visitUnconditionalBranchCount) {
+        this.visitUnconditionalBranchCount = visitUnconditionalBranchCount;
+    }
+
+    public int getVisitVariableLengthInstructionCount() {
+        return visitVariableLengthInstructionCount;
+    }
+
+    public void setVisitVariableLengthInstructionCount(int visitVariableLengthInstructionCount) {
+        this.visitVariableLengthInstructionCount = visitVariableLengthInstructionCount;
+    }
+
+    @Override
+    public void visitAALOAD(AALOAD obj) {
+        visitAALOADCount++;
+    }
+
+    @Override
+    public void visitAASTORE(AASTORE obj) {
+        visitAASTORECount++;
+    }
+
+    @Override
+    public void visitACONST_NULL(ACONST_NULL obj) {
+        visitACONST_NULLCount++;
+    }
+
+    @Override
+    public void visitAllocationInstruction(AllocationInstruction obj) {
+        visitAllocationInstructionCount++;
+    }
+
+    @Override
+    public void visitALOAD(ALOAD obj) {
+        visitALOADCount++;
+    }
+
+    @Override
+    public void visitANEWARRAY(ANEWARRAY obj) {
+        visitANEWARRAYCount++;
+    }
+
+    @Override
+    public void visitARETURN(ARETURN obj) {
+        visitARETURNCount++;
+    }
+
+    @Override
+    public void visitArithmeticInstruction(ArithmeticInstruction obj) {
+        visitArithmeticInstructionCount++;
+    }
+
+    @Override
+    public void visitArrayInstruction(ArrayInstruction obj) {
+        visitArrayInstructionCount++;
+    }
+
+    @Override
+    public void visitARRAYLENGTH(ARRAYLENGTH obj) {
+        visitARRAYLENGTHCount++;
+    }
+
+    @Override
+    public void visitASTORE(ASTORE obj) {
+        visitASTORECount++;
+    }
+
+    @Override
+    public void visitATHROW(ATHROW obj) {
+        visitATHROWCount++;
+    }
+
+    @Override
+    public void visitBALOAD(BALOAD obj) {
+        visitBALOADCount++;
+    }
+
+    @Override
+    public void visitBASTORE(BASTORE obj) {
+        visitBASTORECount++;
+    }
+
+    @Override
+    public void visitBIPUSH(BIPUSH obj) {
+        visitBIPUSHCount++;
+    }
+
+    @Override
+    public void visitBranchInstruction(BranchInstruction obj) {
+        visitBranchInstructionCount++;
+    }
+
+    @Override
+    public void visitBREAKPOINT(BREAKPOINT obj) {
+        visitBREAKPOINTCount++;
+    }
+
+    @Override
+    public void visitCALOAD(CALOAD obj) {
+        visitCALOADCount++;
+    }
+
+    @Override
+    public void visitCASTORE(CASTORE obj) {
+        visitCASTORECount++;
+    }
+
+    @Override
+    public void visitCHECKCAST(CHECKCAST obj) {
+        visitCHECKCASTCount++;
+    }
+
+    @Override
+    public void visitConstantPushInstruction(ConstantPushInstruction obj) {
+        visitConstantPushInstructionCount++;
+    }
+
+    @Override
+    public void visitConversionInstruction(ConversionInstruction obj) {
+        visitConversionInstructionCount++;
+    }
+
+    @Override
+    public void visitCPInstruction(CPInstruction obj) {
+        visitCPInstructionCount++;
+    }
+
+    @Override
+    public void visitD2F(D2F obj) {
+        visitD2FCount++;
+    }
+
+    @Override
+    public void visitD2I(D2I obj) {
+        visitD2ICount++;
+    }
+
+    @Override
+    public void visitD2L(D2L obj) {
+        visitD2LCount++;
+    }
+
+    @Override
+    public void visitDADD(DADD obj) {
+        visitDADDCount++;
+    }
+
+    @Override
+    public void visitDALOAD(DALOAD obj) {
+        visitDALOADCount++;
+    }
+
+    @Override
+    public void visitDASTORE(DASTORE obj) {
+        visitDASTORECount++;
+    }
+
+    @Override
+    public void visitDCMPG(DCMPG obj) {
+        visitDCMPGCount++;
+    }
+
+    @Override
+    public void visitDCMPL(DCMPL obj) {
+        visitDCMPLCount++;
+    }
+
+    @Override
+    public void visitDCONST(DCONST obj) {
+        visitDCONSTCount++;
+    }
+
+    @Override
+    public void visitDDIV(DDIV obj) {
+        visitDDIVCount++;
+    }
+
+    @Override
+    public void visitDLOAD(DLOAD obj) {
+        visitDLOADCount++;
+    }
+
+    @Override
+    public void visitDMUL(DMUL obj) {
+        visitDMULCount++;
+    }
+
+    @Override
+    public void visitDNEG(DNEG obj) {
+        visitDNEGCount++;
+    }
+
+    @Override
+    public void visitDREM(DREM obj) {
+        visitDREMCount++;
+    }
+
+    @Override
+    public void visitDRETURN(DRETURN obj) {
+        visitDRETURNCount++;
+    }
+
+    @Override
+    public void visitDSTORE(DSTORE obj) {
+        visitDSTORECount++;
+    }
+
+    @Override
+    public void visitDSUB(DSUB obj) {
+        visitDSUBCount++;
+    }
+
+    @Override
+    public void visitDUP(DUP obj) {
+        visitDUPCount++;
+    }
+
+    @Override
+    public void visitDUP_X1(DUP_X1 obj) {
+        visitDUP_X1Count++;
+    }
+
+    @Override
+    public void visitDUP_X2(DUP_X2 obj) {
+        visitDUP_X2Count++;
+    }
+
+    @Override
+    public void visitDUP2(DUP2 obj) {
+        visitDUP2Count++;
+    }
+
+    @Override
+    public void visitDUP2_X1(DUP2_X1 obj) {
+        visitDUP2_X1Count++;
+    }
+
+    @Override
+    public void visitDUP2_X2(DUP2_X2 obj) {
+        visitDUP2_X2Count++;
+    }
+
+    @Override
+    public void visitExceptionThrower(ExceptionThrower obj) {
+        visitExceptionThrowerCount++;
+    }
+
+    @Override
+    public void visitF2D(F2D obj) {
+        visitF2DCount++;
+    }
+
+    @Override
+    public void visitF2I(F2I obj) {
+        visitF2ICount++;
+    }
+
+    @Override
+    public void visitF2L(F2L obj) {
+        visitF2LCount++;
+    }
+
+    @Override
+    public void visitFADD(FADD obj) {
+        visitFADDCount++;
+    }
+
+    @Override
+    public void visitFALOAD(FALOAD obj) {
+        visitFALOADCount++;
+    }
+
+    @Override
+    public void visitFASTORE(FASTORE obj) {
+        visitFASTORECount++;
+    }
+
+    @Override
+    public void visitFCMPG(FCMPG obj) {
+        visitFCMPGCount++;
+    }
+
+    @Override
+    public void visitFCMPL(FCMPL obj) {
+        visitFCMPLCount++;
+    }
+
+    @Override
+    public void visitFCONST(FCONST obj) {
+        visitFCONSTCount++;
+    }
+
+    @Override
+    public void visitFDIV(FDIV obj) {
+        visitFDIVCount++;
+    }
+
+    @Override
+    public void visitFieldInstruction(FieldInstruction obj) {
+        visitFieldInstructionCount++;
+    }
+
+    @Override
+    public void visitFieldOrMethod(FieldOrMethod obj) {
+        visitFieldOrMethodCount++;
+    }
+
+    @Override
+    public void visitFLOAD(FLOAD obj) {
+        visitFLOADCount++;
+    }
+
+    @Override
+    public void visitFMUL(FMUL obj) {
+        visitFMULCount++;
+    }
+
+    @Override
+    public void visitFNEG(FNEG obj) {
+        visitFNEGCount++;
+    }
+
+    @Override
+    public void visitFREM(FREM obj) {
+        visitFREMCount++;
+    }
+
+    @Override
+    public void visitFRETURN(FRETURN obj) {
+        visitFRETURNCount++;
+    }
+
+    @Override
+    public void visitFSTORE(FSTORE obj) {
+        visitFSTORECount++;
+    }
+
+    @Override
+    public void visitFSUB(FSUB obj) {
+        visitFSUBCount++;
+    }
+
+    @Override
+    public void visitGETFIELD(GETFIELD obj) {
+        visitGETFIELDCount++;
+    }
+
+    @Override
+    public void visitGETSTATIC(GETSTATIC obj) {
+        visitGETSTATICCount++;
+    }
+
+    @Override
+    public void visitGOTO(GOTO obj) {
+        visitGOTOCount++;
+    }
+
+    @Override
+    public void visitGOTO_W(GOTO_W obj) {
+        visitGOTO_WCount++;
+    }
+
+    @Override
+    public void visitGotoInstruction(GotoInstruction obj) {
+        visitGotoInstructionCount++;
+    }
+
+    @Override
+    public void visitI2B(I2B obj) {
+        visitI2BCount++;
+    }
+
+    @Override
+    public void visitI2C(I2C obj) {
+        visitI2CCount++;
+    }
+
+    @Override
+    public void visitI2D(I2D obj) {
+        visitI2DCount++;
+    }
+
+    @Override
+    public void visitI2F(I2F obj) {
+        visitI2FCount++;
+    }
+
+    @Override
+    public void visitI2L(I2L obj) {
+        visitI2LCount++;
+    }
+
+    @Override
+    public void visitI2S(I2S obj) {
+        visitI2SCount++;
+    }
+
+    @Override
+    public void visitIADD(IADD obj) {
+        visitIADDCount++;
+    }
+
+    @Override
+    public void visitIALOAD(IALOAD obj) {
+        visitIALOADCount++;
+    }
+
+    @Override
+    public void visitIAND(IAND obj) {
+        visitIANDCount++;
+    }
+
+    @Override
+    public void visitIASTORE(IASTORE obj) {
+        visitIASTORECount++;
+    }
+
+    @Override
+    public void visitICONST(ICONST obj) {
+        visitICONSTCount++;
+    }
+
+    @Override
+    public void visitIDIV(IDIV obj) {
+        visitIDIVCount++;
+    }
+
+    @Override
+    public void visitIF_ACMPEQ(IF_ACMPEQ obj) {
+        visitIF_ACMPEQCount++;
+    }
+
+    @Override
+    public void visitIF_ACMPNE(IF_ACMPNE obj) {
+        visitIF_ACMPNECount++;
+    }
+
+    @Override
+    public void visitIF_ICMPEQ(IF_ICMPEQ obj) {
+        visitIF_ICMPEQCount++;
+    }
+
+    @Override
+    public void visitIF_ICMPGE(IF_ICMPGE obj) {
+        visitIF_ICMPGECount++;
+    }
+
+    @Override
+    public void visitIF_ICMPGT(IF_ICMPGT obj) {
+        visitIF_ICMPGTCount++;
+    }
+
+    @Override
+    public void visitIF_ICMPLE(IF_ICMPLE obj) {
+        visitIF_ICMPLECount++;
+    }
+
+    @Override
+    public void visitIF_ICMPLT(IF_ICMPLT obj) {
+        visitIF_ICMPLTCount++;
+    }
+
+    @Override
+    public void visitIF_ICMPNE(IF_ICMPNE obj) {
+        visitIF_ICMPNECount++;
+    }
+
+    @Override
+    public void visitIFEQ(IFEQ obj) {
+        visitIFEQCount++;
+    }
+
+    @Override
+    public void visitIFGE(IFGE obj) {
+        visitIFGECount++;
+    }
+
+    @Override
+    public void visitIFGT(IFGT obj) {
+        visitIFGTCount++;
+    }
+
+    @Override
+    public void visitIfInstruction(IfInstruction obj) {
+        visitIfInstructionCount++;
+    }
+
+    @Override
+    public void visitIFLE(IFLE obj) {
+        visitIFLECount++;
+    }
+
+    @Override
+    public void visitIFLT(IFLT obj) {
+        visitIFLTCount++;
+    }
+
+    @Override
+    public void visitIFNE(IFNE obj) {
+        visitIFNECount++;
+    }
+
+    @Override
+    public void visitIFNONNULL(IFNONNULL obj) {
+        visitIFNONNULLCount++;
+    }
+
+    @Override
+    public void visitIFNULL(IFNULL obj) {
+        visitIFNULLCount++;
+    }
+
+    @Override
+    public void visitIINC(IINC obj) {
+        visitIINCCount++;
+    }
+
+    @Override
+    public void visitILOAD(ILOAD obj) {
+        visitILOADCount++;
+    }
+
+    @Override
+    public void visitIMPDEP1(IMPDEP1 obj) {
+        visitIMPDEP1Count++;
+    }
+
+    @Override
+    public void visitIMPDEP2(IMPDEP2 obj) {
+        visitIMPDEP2Count++;
+    }
+
+    @Override
+    public void visitIMUL(IMUL obj) {
+        visitIMULCount++;
+    }
+
+    @Override
+    public void visitINEG(INEG obj) {
+        visitINEGCount++;
+    }
+
+    @Override
+    public void visitINSTANCEOF(INSTANCEOF obj) {
+        visitINSTANCEOFCount++;
+    }
+
+    @Override
+    public void visitINVOKEDYNAMIC(INVOKEDYNAMIC obj) {
+        visitINVOKEDYNAMICCount++;
+    }
+
+    @Override
+    public void visitInvokeInstruction(InvokeInstruction obj) {
+        visitInvokeInstructionCount++;
+    }
+
+    @Override
+    public void visitINVOKEINTERFACE(INVOKEINTERFACE obj) {
+        visitINVOKEINTERFACECount++;
+    }
+
+    @Override
+    public void visitINVOKESPECIAL(INVOKESPECIAL obj) {
+        visitINVOKESPECIALCount++;
+    }
+
+    @Override
+    public void visitINVOKESTATIC(INVOKESTATIC obj) {
+        visitINVOKESTATICCount++;
+    }
+
+    @Override
+    public void visitINVOKEVIRTUAL(INVOKEVIRTUAL obj) {
+        visitINVOKEVIRTUALCount++;
+    }
+
+    @Override
+    public void visitIOR(IOR obj) {
+        visitIORCount++;
+    }
+
+    @Override
+    public void visitIREM(IREM obj) {
+        visitIREMCount++;
+    }
+
+    @Override
+    public void visitIRETURN(IRETURN obj) {
+        visitIRETURNCount++;
+    }
+
+    @Override
+    public void visitISHL(ISHL obj) {
+        visitISHLCount++;
+    }
+
+    @Override
+    public void visitISHR(ISHR obj) {
+        visitISHRCount++;
+    }
+
+    @Override
+    public void visitISTORE(ISTORE obj) {
+        visitISTORECount++;
+    }
+
+    @Override
+    public void visitISUB(ISUB obj) {
+        visitISUBCount++;
+    }
+
+    @Override
+    public void visitIUSHR(IUSHR obj) {
+        visitIUSHRCount++;
+    }
+
+    @Override
+    public void visitIXOR(IXOR obj) {
+        visitIXORCount++;
+    }
+
+    @Override
+    public void visitJSR(JSR obj) {
+        visitJSRCount++;
+    }
+
+    @Override
+    public void visitJSR_W(JSR_W obj) {
+        visitJSR_WCount++;
+    }
+
+    @Override
+    public void visitJsrInstruction(JsrInstruction obj) {
+        visitJsrInstructionCount++;
+    }
+
+    @Override
+    public void visitL2D(L2D obj) {
+        visitL2DCount++;
+    }
+
+    @Override
+    public void visitL2F(L2F obj) {
+        visitL2FCount++;
+    }
+
+    @Override
+    public void visitL2I(L2I obj) {
+        visitL2ICount++;
+    }
+
+    @Override
+    public void visitLADD(LADD obj) {
+        visitLADDCount++;
+    }
+
+    @Override
+    public void visitLALOAD(LALOAD obj) {
+        visitLALOADCount++;
+    }
+
+    @Override
+    public void visitLAND(LAND obj) {
+        visitLANDCount++;
+    }
+
+    @Override
+    public void visitLASTORE(LASTORE obj) {
+        visitLASTORECount++;
+    }
+
+    @Override
+    public void visitLCMP(LCMP obj) {
+        visitLCMPCount++;
+    }
+
+    @Override
+    public void visitLCONST(LCONST obj) {
+        visitLCONSTCount++;
+    }
+
+    @Override
+    public void visitLDC(LDC obj) {
+        visitLDCCount++;
+    }
+
+    @Override
+    public void visitLDC2_W(LDC2_W obj) {
+        visitLDC2_WCount++;
+    }
+
+    @Override
+    public void visitLDIV(LDIV obj) {
+        visitLDIVCount++;
+    }
+
+    @Override
+    public void visitLLOAD(LLOAD obj) {
+        visitLLOADCount++;
+    }
+
+    @Override
+    public void visitLMUL(LMUL obj) {
+        visitLMULCount++;
+    }
+
+    @Override
+    public void visitLNEG(LNEG obj) {
+        visitLNEGCount++;
+    }
+
+    @Override
+    public void visitLoadClass(LoadClass obj) {
+        visitLoadClassCount++;
+    }
+
+    @Override
+    public void visitLoadInstruction(LoadInstruction obj) {
+        visitLoadInstructionCount++;
+    }
+
+    @Override
+    public void visitLocalVariableInstruction(LocalVariableInstruction obj) {
+        visitLocalVariableInstructionCount++;
+    }
+
+    @Override
+    public void visitLOOKUPSWITCH(LOOKUPSWITCH obj) {
+        visitLOOKUPSWITCHCount++;
+    }
+
+    @Override
+    public void visitLOR(LOR obj) {
+        visitLORCount++;
+    }
+
+    @Override
+    public void visitLREM(LREM obj) {
+        visitLREMCount++;
+    }
+
+    @Override
+    public void visitLRETURN(LRETURN obj) {
+        visitLRETURNCount++;
+    }
+
+    @Override
+    public void visitLSHL(LSHL obj) {
+        visitLSHLCount++;
+    }
+
+    @Override
+    public void visitLSHR(LSHR obj) {
+        visitLSHRCount++;
+    }
+
+    @Override
+    public void visitLSTORE(LSTORE obj) {
+        visitLSTORECount++;
+    }
+
+    @Override
+    public void visitLSUB(LSUB obj) {
+        visitLSUBCount++;
+    }
+
+    @Override
+    public void visitLUSHR(LUSHR obj) {
+        visitLUSHRCount++;
+    }
+
+    @Override
+    public void visitLXOR(LXOR obj) {
+        visitLXORCount++;
+    }
+
+    @Override
+    public void visitMONITORENTER(MONITORENTER obj) {
+        visitMONITORENTERCount++;
+    }
+
+    @Override
+    public void visitMONITOREXIT(MONITOREXIT obj) {
+        visitMONITOREXITCount++;
+    }
+
+    @Override
+    public void visitMULTIANEWARRAY(MULTIANEWARRAY obj) {
+        visitMULTIANEWARRAYCount++;
+    }
+
+    @Override
+    public void visitNEW(NEW obj) {
+        visitNEWCount++;
+    }
+
+    @Override
+    public void visitNEWARRAY(NEWARRAY obj) {
+        visitNEWARRAYCount++;
+    }
+
+    @Override
+    public void visitNOP(NOP obj) {
+        visitNOPCount++;
+    }
+
+    @Override
+    public void visitPOP(POP obj) {
+        visitPOPCount++;
+    }
+
+    @Override
+    public void visitPOP2(POP2 obj) {
+        visitPOP2Count++;
+    }
+
+    @Override
+    public void visitPopInstruction(PopInstruction obj) {
+        visitPopInstructionCount++;
+    }
+
+    @Override
+    public void visitPushInstruction(PushInstruction obj) {
+        visitPushInstructionCount++;
+    }
+
+    @Override
+    public void visitPUTFIELD(PUTFIELD obj) {
+        visitPUTFIELDCount++;
+    }
+
+    @Override
+    public void visitPUTSTATIC(PUTSTATIC obj) {
+        visitPUTSTATICCount++;
+    }
+
+    @Override
+    public void visitRET(RET obj) {
+        visitRETCount++;
+    }
+
+    @Override
+    public void visitRETURN(RETURN obj) {
+        visitRETURNCount++;
+    }
+
+    @Override
+    public void visitReturnInstruction(ReturnInstruction obj) {
+        visitReturnInstructionCount++;
+    }
+
+    @Override
+    public void visitSALOAD(SALOAD obj) {
+        visitSALOADCount++;
+    }
+
+    @Override
+    public void visitSASTORE(SASTORE obj) {
+        visitSASTORECount++;
+    }
+
+    @Override
+    public void visitSelect(Select obj) {
+        visitSelectCount++;
+    }
+
+    @Override
+    public void visitSIPUSH(SIPUSH obj) {
+        visitSIPUSHCount++;
+    }
+
+    @Override
+    public void visitStackConsumer(StackConsumer obj) {
+        visitStackConsumerCount++;
+    }
+
+    @Override
+    public void visitStackInstruction(StackInstruction obj) {
+        visitStackInstructionCount++;
+    }
+
+    @Override
+    public void visitStackProducer(StackProducer obj) {
+        visitStackProducerCount++;
+    }
+
+    @Override
+    public void visitStoreInstruction(StoreInstruction obj) {
+        visitStoreInstructionCount++;
+    }
+
+    @Override
+    public void visitSWAP(SWAP obj) {
+        visitSWAPCount++;
+    }
+
+    @Override
+    public void visitTABLESWITCH(TABLESWITCH obj) {
+        visitTABLESWITCHCount++;
+    }
+
+    @Override
+    public void visitTypedInstruction(TypedInstruction obj) {
+        visitTypedInstructionCount++;
+    }
+
+    @Override
+    public void visitUnconditionalBranch(UnconditionalBranch obj) {
+        visitUnconditionalBranchCount++;
+    }
+
+    @Override
+    public void visitVariableLengthInstruction(VariableLengthInstruction obj) {
+        visitVariableLengthInstructionCount++;
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        CountVisitor that = (CountVisitor) o;
+        return visitAALOADCount == that.visitAALOADCount
+                && visitAASTORECount == that.visitAASTORECount
+                && visitACONST_NULLCount == that.visitACONST_NULLCount
+                && visitAllocationInstructionCount == that.visitAllocationInstructionCount
+                && visitALOADCount == that.visitALOADCount
+                && visitANEWARRAYCount == that.visitANEWARRAYCount
+                && visitARETURNCount == that.visitARETURNCount
+                && visitArithmeticInstructionCount == that.visitArithmeticInstructionCount
+                && visitArrayInstructionCount == that.visitArrayInstructionCount
+                && visitARRAYLENGTHCount == that.visitARRAYLENGTHCount
+                && visitASTORECount == that.visitASTORECount
+                && visitATHROWCount == that.visitATHROWCount
+                && visitBALOADCount == that.visitBALOADCount
+                && visitBASTORECount == that.visitBASTORECount
+                && visitBIPUSHCount == that.visitBIPUSHCount
+                && visitBranchInstructionCount == that.visitBranchInstructionCount
+                && visitBREAKPOINTCount == that.visitBREAKPOINTCount
+                && visitCALOADCount == that.visitCALOADCount
+                && visitCASTORECount == that.visitCASTORECount
+                && visitCHECKCASTCount == that.visitCHECKCASTCount
+                && visitConstantPushInstructionCount == that.visitConstantPushInstructionCount
+                && visitConversionInstructionCount == that.visitConversionInstructionCount
+                && visitCPInstructionCount == that.visitCPInstructionCount
+                && visitD2FCount == that.visitD2FCount
+                && visitD2ICount == that.visitD2ICount
+                && visitD2LCount == that.visitD2LCount
+                && visitDADDCount == that.visitDADDCount
+                && visitDALOADCount == that.visitDALOADCount
+                && visitDASTORECount == that.visitDASTORECount
+                && visitDCMPGCount == that.visitDCMPGCount
+                && visitDCMPLCount == that.visitDCMPLCount
+                && visitDCONSTCount == that.visitDCONSTCount
+                && visitDDIVCount == that.visitDDIVCount
+                && visitDLOADCount == that.visitDLOADCount
+                && visitDMULCount == that.visitDMULCount
+                && visitDNEGCount == that.visitDNEGCount
+                && visitDREMCount == that.visitDREMCount
+                && visitDRETURNCount == that.visitDRETURNCount
+                && visitDSTORECount == that.visitDSTORECount
+                && visitDSUBCount == that.visitDSUBCount
+                && visitDUPCount == that.visitDUPCount
+                && visitDUP_X1Count == that.visitDUP_X1Count
+                && visitDUP_X2Count == that.visitDUP_X2Count
+                && visitDUP2Count == that.visitDUP2Count
+                && visitDUP2_X1Count == that.visitDUP2_X1Count
+                && visitDUP2_X2Count == that.visitDUP2_X2Count
+                && visitExceptionThrowerCount == that.visitExceptionThrowerCount
+                && visitF2DCount == that.visitF2DCount
+                && visitF2ICount == that.visitF2ICount
+                && visitF2LCount == that.visitF2LCount
+                && visitFADDCount == that.visitFADDCount
+                && visitFALOADCount == that.visitFALOADCount
+                && visitFASTORECount == that.visitFASTORECount
+                && visitFCMPGCount == that.visitFCMPGCount
+                && visitFCMPLCount == that.visitFCMPLCount
+                && visitFCONSTCount == that.visitFCONSTCount
+                && visitFDIVCount == that.visitFDIVCount
+                && visitFieldInstructionCount == that.visitFieldInstructionCount
+                && visitFieldOrMethodCount == that.visitFieldOrMethodCount
+                && visitFLOADCount == that.visitFLOADCount
+                && visitFMULCount == that.visitFMULCount
+                && visitFNEGCount == that.visitFNEGCount
+                && visitFREMCount == that.visitFREMCount
+                && visitFRETURNCount == that.visitFRETURNCount
+                && visitFSTORECount == that.visitFSTORECount
+                && visitFSUBCount == that.visitFSUBCount
+                && visitGETFIELDCount == that.visitGETFIELDCount
+                && visitGETSTATICCount == that.visitGETSTATICCount
+                && visitGOTOCount == that.visitGOTOCount
+                && visitGOTO_WCount == that.visitGOTO_WCount
+                && visitGotoInstructionCount == that.visitGotoInstructionCount
+                && visitI2BCount == that.visitI2BCount
+                && visitI2CCount == that.visitI2CCount
+                && visitI2DCount == that.visitI2DCount
+                && visitI2FCount == that.visitI2FCount
+                && visitI2LCount == that.visitI2LCount
+                && visitI2SCount == that.visitI2SCount
+                && visitIADDCount == that.visitIADDCount
+                && visitIALOADCount == that.visitIALOADCount
+                && visitIANDCount == that.visitIANDCount
+                && visitIASTORECount == that.visitIASTORECount
+                && visitICONSTCount == that.visitICONSTCount
+                && visitIDIVCount == that.visitIDIVCount
+                && visitIF_ACMPEQCount == that.visitIF_ACMPEQCount
+                && visitIF_ACMPNECount == that.visitIF_ACMPNECount
+                && visitIF_ICMPEQCount == that.visitIF_ICMPEQCount
+                && visitIF_ICMPGECount == that.visitIF_ICMPGECount
+                && visitIF_ICMPGTCount == that.visitIF_ICMPGTCount
+                && visitIF_ICMPLECount == that.visitIF_ICMPLECount
+                && visitIF_ICMPLTCount == that.visitIF_ICMPLTCount
+                && visitIF_ICMPNECount == that.visitIF_ICMPNECount
+                && visitIFEQCount == that.visitIFEQCount
+                && visitIFGECount == that.visitIFGECount
+                && visitIFGTCount == that.visitIFGTCount
+                && visitIfInstructionCount == that.visitIfInstructionCount
+                && visitIFLECount == that.visitIFLECount
+                && visitIFLTCount == that.visitIFLTCount
+                && visitIFNECount == that.visitIFNECount
+                && visitIFNONNULLCount == that.visitIFNONNULLCount
+                && visitIFNULLCount == that.visitIFNULLCount
+                && visitIINCCount == that.visitIINCCount
+                && visitILOADCount == that.visitILOADCount
+                && visitIMPDEP1Count == that.visitIMPDEP1Count
+                && visitIMPDEP2Count == that.visitIMPDEP2Count
+                && visitIMULCount == that.visitIMULCount
+                && visitINEGCount == that.visitINEGCount
+                && visitINSTANCEOFCount == that.visitINSTANCEOFCount
+                && visitINVOKEDYNAMICCount == that.visitINVOKEDYNAMICCount
+                && visitInvokeInstructionCount == that.visitInvokeInstructionCount
+                && visitINVOKEINTERFACECount == that.visitINVOKEINTERFACECount
+                && visitINVOKESPECIALCount == that.visitINVOKESPECIALCount
+                && visitINVOKESTATICCount == that.visitINVOKESTATICCount
+                && visitINVOKEVIRTUALCount == that.visitINVOKEVIRTUALCount
+                && visitIORCount == that.visitIORCount
+                && visitIREMCount == that.visitIREMCount
+                && visitIRETURNCount == that.visitIRETURNCount
+                && visitISHLCount == that.visitISHLCount
+                && visitISHRCount == that.visitISHRCount
+                && visitISTORECount == that.visitISTORECount
+                && visitISUBCount == that.visitISUBCount
+                && visitIUSHRCount == that.visitIUSHRCount
+                && visitIXORCount == that.visitIXORCount
+                && visitJSRCount == that.visitJSRCount
+                && visitJSR_WCount == that.visitJSR_WCount
+                && visitJsrInstructionCount == that.visitJsrInstructionCount
+                && visitL2DCount == that.visitL2DCount
+                && visitL2FCount == that.visitL2FCount
+                && visitL2ICount == that.visitL2ICount
+                && visitLADDCount == that.visitLADDCount
+                && visitLALOADCount == that.visitLALOADCount
+                && visitLANDCount == that.visitLANDCount
+                && visitLASTORECount == that.visitLASTORECount
+                && visitLCMPCount == that.visitLCMPCount
+                && visitLCONSTCount == that.visitLCONSTCount
+                && visitLDCCount == that.visitLDCCount
+                && visitLDC2_WCount == that.visitLDC2_WCount
+                && visitLDIVCount == that.visitLDIVCount
+                && visitLLOADCount == that.visitLLOADCount
+                && visitLMULCount == that.visitLMULCount
+                && visitLNEGCount == that.visitLNEGCount
+                && visitLoadClassCount == that.visitLoadClassCount
+                && visitLoadInstructionCount == that.visitLoadInstructionCount
+                && visitLocalVariableInstructionCount == that.visitLocalVariableInstructionCount
+                && visitLOOKUPSWITCHCount == that.visitLOOKUPSWITCHCount
+                && visitLORCount == that.visitLORCount
+                && visitLREMCount == that.visitLREMCount
+                && visitLRETURNCount == that.visitLRETURNCount
+                && visitLSHLCount == that.visitLSHLCount
+                && visitLSHRCount == that.visitLSHRCount
+                && visitLSTORECount == that.visitLSTORECount
+                && visitLSUBCount == that.visitLSUBCount
+                && visitLUSHRCount == that.visitLUSHRCount
+                && visitLXORCount == that.visitLXORCount
+                && visitMONITORENTERCount == that.visitMONITORENTERCount
+                && visitMONITOREXITCount == that.visitMONITOREXITCount
+                && visitMULTIANEWARRAYCount == that.visitMULTIANEWARRAYCount
+                && visitNEWCount == that.visitNEWCount
+                && visitNEWARRAYCount == that.visitNEWARRAYCount
+                && visitNOPCount == that.visitNOPCount
+                && visitPOPCount == that.visitPOPCount
+                && visitPOP2Count == that.visitPOP2Count
+                && visitPopInstructionCount == that.visitPopInstructionCount
+                && visitPushInstructionCount == that.visitPushInstructionCount
+                && visitPUTFIELDCount == that.visitPUTFIELDCount
+                && visitPUTSTATICCount == that.visitPUTSTATICCount
+                && visitRETCount == that.visitRETCount
+                && visitRETURNCount == that.visitRETURNCount
+                && visitReturnInstructionCount == that.visitReturnInstructionCount
+                && visitSALOADCount == that.visitSALOADCount
+                && visitSASTORECount == that.visitSASTORECount
+                && visitSelectCount == that.visitSelectCount
+                && visitSIPUSHCount == that.visitSIPUSHCount
+                && visitStackConsumerCount == that.visitStackConsumerCount
+                && visitStackInstructionCount == that.visitStackInstructionCount
+                && visitStackProducerCount == that.visitStackProducerCount
+                && visitStoreInstructionCount == that.visitStoreInstructionCount
+                && visitSWAPCount == that.visitSWAPCount
+                && visitTABLESWITCHCount == that.visitTABLESWITCHCount
+                && visitTypedInstructionCount == that.visitTypedInstructionCount
+                && visitUnconditionalBranchCount == that.visitUnconditionalBranchCount
+                && visitVariableLengthInstructionCount == that.visitVariableLengthInstructionCount;
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(visitAALOADCount

Review Comment:
   I'm using IntelliJ to generate it. But it does not split line so I just split it.
   Updated to put comma in end of line, please check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011812884


##########
src/test/java/org/apache/bcel/generic/IREMTestCase.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class IREMTestCase {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();

Review Comment:
   It seems to me it might be simpler to compare CountVisitors instances, it would avoid all the getting of ivars.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1013099271


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -19,3100 +19,3100 @@
 import java.util.Objects;
 
 public class CountVisitor implements Visitor {
+    private int aaload;
+    private int aastore;
+    private int aconst_null;
+    private int allocationInstruction;
+    private int aload;
+    private int anewarray;
+    private int areturn;
+    private int arithmeticInstruction;
+    private int arrayInstruction;
+    private int arraylength;
+    private int astore;
+    private int athrow;
+    private int baload;
+    private int bastore;
+    private int bipush;
+    private int branchInstruction;
+    private int BREAKPOINT;

Review Comment:
   An instance variable name should NOT be all upper case.



##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -19,3100 +19,3100 @@
 import java.util.Objects;
 
 public class CountVisitor implements Visitor {
+    private int aaload;
+    private int aastore;
+    private int aconst_null;
+    private int allocationInstruction;
+    private int aload;
+    private int anewarray;
+    private int areturn;
+    private int arithmeticInstruction;
+    private int arrayInstruction;
+    private int arraylength;
+    private int astore;
+    private int athrow;
+    private int baload;
+    private int bastore;
+    private int bipush;
+    private int branchInstruction;
+    private int BREAKPOINT;
+    private int caload;
+    private int castore;
+    private int checkcast;
+    private int constantPushInstruction;
+    private int conversionInstruction;
+    private int cpInstruction;
+    private int d2F;
+    private int d2I;
+    private int d2L;
+    private int dadd;
+    private int daload;
+    private int dastore;
+    private int dcmpg;
+    private int dcmpl;
+    private int dconst;
+    private int ddiv;
+    private int dload;
+    private int dmul;
+    private int dneg;
+    private int drem;
+    private int dreturn;
+    private int dstore;
+    private int dsub;
+    private int dup;
+    private int dup_x1;
+    private int dup_x2;
+    private int dup2;
+    private int dup2_x1;
+    private int dup2_x2;
+    private int exceptionThrower;
+    private int f2D;
+    private int f2I;
+    private int f2L;
+    private int fadd;
+    private int faload;
+    private int fastore;
+    private int fcmpg;
+    private int fcmpl;
+    private int fconst;
+    private int fdiv;
+    private int fieldInstruction;
+    private int fieldOrMethod;
+    private int fload;
+    private int fmul;
+    private int fneg;
+    private int frem;
+    private int freturn;
+    private int fstore;
+    private int fsub;
+    private int getfield;
+    private int getstatic;
+    private int goTo;
+    private int goTo_w;

Review Comment:
   Again, no underscores in names; we use the camel case convention.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011962395


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,2012 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+public class CountVisitor implements Visitor {
+
+    public int getVisitAALOADCount() {
+        return visitAALOADCount;
+    }
+
+    public int getVisitAASTORECount() {
+        return visitAASTORECount;
+    }
+
+    public int getVisitACONST_NULLCount() {
+        return visitACONST_NULLCount;
+    }
+
+    public int getVisitAllocationInstructionCount() {
+        return visitAllocationInstructionCount;
+    }
+
+    public int getVisitALOADCount() {
+        return visitALOADCount;
+    }
+
+    public int getVisitANEWARRAYCount() {
+        return visitANEWARRAYCount;
+    }
+
+    public int getVisitARETURNCount() {
+        return visitARETURNCount;
+    }
+
+    public int getVisitArithmeticInstructionCount() {
+        return visitArithmeticInstructionCount;
+    }
+
+    public int getVisitArrayInstructionCount() {
+        return visitArrayInstructionCount;
+    }
+
+    public int getVisitARRAYLENGTHCount() {
+        return visitARRAYLENGTHCount;
+    }
+
+    public int getVisitASTORECount() {
+        return visitASTORECount;
+    }
+
+    public int getVisitATHROWCount() {
+        return visitATHROWCount;
+    }
+
+    public int getVisitBALOADCount() {
+        return visitBALOADCount;
+    }
+
+    public int getVisitBASTORECount() {
+        return visitBASTORECount;
+    }
+
+    public int getVisitBIPUSHCount() {
+        return visitBIPUSHCount;
+    }
+
+    public int getVisitBranchInstructionCount() {
+        return visitBranchInstructionCount;
+    }
+
+    public int getVisitBREAKPOINTCount() {
+        return visitBREAKPOINTCount;
+    }
+
+    public int getVisitCALOADCount() {
+        return visitCALOADCount;
+    }
+
+    public int getVisitCASTORECount() {
+        return visitCASTORECount;
+    }
+
+    public int getVisitCHECKCASTCount() {
+        return visitCHECKCASTCount;
+    }
+
+    public int getVisitConstantPushInstructionCount() {
+        return visitConstantPushInstructionCount;
+    }
+
+    public int getVisitConversionInstructionCount() {
+        return visitConversionInstructionCount;
+    }
+
+    public int getVisitCPInstructionCount() {
+        return visitCPInstructionCount;
+    }
+
+    public int getVisitD2FCount() {
+        return visitD2FCount;
+    }
+
+    public int getVisitD2ICount() {
+        return visitD2ICount;
+    }
+
+    public int getVisitD2LCount() {
+        return visitD2LCount;
+    }
+
+    public int getVisitDADDCount() {
+        return visitDADDCount;
+    }
+
+    public int getVisitDALOADCount() {
+        return visitDALOADCount;
+    }
+
+    public int getVisitDASTORECount() {
+        return visitDASTORECount;
+    }
+
+    public int getVisitDCMPGCount() {
+        return visitDCMPGCount;
+    }
+
+    public int getVisitDCMPLCount() {
+        return visitDCMPLCount;
+    }
+
+    public int getVisitDCONSTCount() {
+        return visitDCONSTCount;
+    }
+
+    public int getVisitDDIVCount() {
+        return visitDDIVCount;
+    }
+
+    public int getVisitDLOADCount() {
+        return visitDLOADCount;
+    }
+
+    public int getVisitDMULCount() {
+        return visitDMULCount;
+    }
+
+    public int getVisitDNEGCount() {
+        return visitDNEGCount;
+    }
+
+    public int getVisitDREMCount() {
+        return visitDREMCount;
+    }
+
+    public int getVisitDRETURNCount() {
+        return visitDRETURNCount;
+    }
+
+    public int getVisitDSTORECount() {
+        return visitDSTORECount;
+    }
+
+    public int getVisitDSUBCount() {
+        return visitDSUBCount;
+    }
+
+    public int getVisitDUPCount() {
+        return visitDUPCount;
+    }
+
+    public int getVisitDUP_X1Count() {
+        return visitDUP_X1Count;
+    }
+
+    public int getVisitDUP_X2Count() {
+        return visitDUP_X2Count;
+    }
+
+    public int getVisitDUP2Count() {
+        return visitDUP2Count;
+    }
+
+    public int getVisitDUP2_X1Count() {
+        return visitDUP2_X1Count;
+    }
+
+    public int getVisitDUP2_X2Count() {
+        return visitDUP2_X2Count;
+    }
+
+    public int getVisitExceptionThrowerCount() {
+        return visitExceptionThrowerCount;
+    }
+
+    public int getVisitF2DCount() {
+        return visitF2DCount;
+    }
+
+    public int getVisitF2ICount() {
+        return visitF2ICount;
+    }
+
+    public int getVisitF2LCount() {
+        return visitF2LCount;
+    }
+
+    public int getVisitFADDCount() {
+        return visitFADDCount;
+    }
+
+    public int getVisitFALOADCount() {
+        return visitFALOADCount;
+    }
+
+    public int getVisitFASTORECount() {
+        return visitFASTORECount;
+    }
+
+    public int getVisitFCMPGCount() {
+        return visitFCMPGCount;
+    }
+
+    public int getVisitFCMPLCount() {
+        return visitFCMPLCount;
+    }
+
+    public int getVisitFCONSTCount() {
+        return visitFCONSTCount;
+    }
+
+    public int getVisitFDIVCount() {
+        return visitFDIVCount;
+    }
+
+    public int getVisitFieldInstructionCount() {
+        return visitFieldInstructionCount;
+    }
+
+    public int getVisitFieldOrMethodCount() {
+        return visitFieldOrMethodCount;
+    }
+
+    public int getVisitFLOADCount() {
+        return visitFLOADCount;
+    }
+
+    public int getVisitFMULCount() {
+        return visitFMULCount;
+    }
+
+    public int getVisitFNEGCount() {
+        return visitFNEGCount;
+    }
+
+    public int getVisitFREMCount() {
+        return visitFREMCount;
+    }
+
+    public int getVisitFRETURNCount() {
+        return visitFRETURNCount;
+    }
+
+    public int getVisitFSTORECount() {
+        return visitFSTORECount;
+    }
+
+    public int getVisitFSUBCount() {
+        return visitFSUBCount;
+    }
+
+    public int getVisitGETFIELDCount() {
+        return visitGETFIELDCount;
+    }
+
+    public int getVisitGETSTATICCount() {
+        return visitGETSTATICCount;
+    }
+
+    public int getVisitGOTOCount() {
+        return visitGOTOCount;
+    }
+
+    public int getVisitGOTO_WCount() {
+        return visitGOTO_WCount;
+    }
+
+    public int getVisitGotoInstructionCount() {
+        return visitGotoInstructionCount;
+    }
+
+    public int getVisitI2BCount() {
+        return visitI2BCount;
+    }
+
+    public int getVisitI2CCount() {
+        return visitI2CCount;
+    }
+
+    public int getVisitI2DCount() {
+        return visitI2DCount;
+    }
+
+    public int getVisitI2FCount() {
+        return visitI2FCount;
+    }
+
+    public int getVisitI2LCount() {
+        return visitI2LCount;
+    }
+
+    public int getVisitI2SCount() {
+        return visitI2SCount;
+    }
+
+    public int getVisitIADDCount() {
+        return visitIADDCount;
+    }
+
+    public int getVisitIALOADCount() {
+        return visitIALOADCount;
+    }
+
+    public int getVisitIANDCount() {
+        return visitIANDCount;
+    }
+
+    public int getVisitIASTORECount() {
+        return visitIASTORECount;
+    }
+
+    public int getVisitICONSTCount() {
+        return visitICONSTCount;
+    }
+
+    public int getVisitIDIVCount() {
+        return visitIDIVCount;
+    }
+
+    public int getVisitIF_ACMPEQCount() {
+        return visitIF_ACMPEQCount;
+    }
+
+    public int getVisitIF_ACMPNECount() {
+        return visitIF_ACMPNECount;
+    }
+
+    public int getVisitIF_ICMPEQCount() {
+        return visitIF_ICMPEQCount;
+    }
+
+    public int getVisitIF_ICMPGECount() {
+        return visitIF_ICMPGECount;
+    }
+
+    public int getVisitIF_ICMPGTCount() {
+        return visitIF_ICMPGTCount;
+    }
+
+    public int getVisitIF_ICMPLECount() {
+        return visitIF_ICMPLECount;
+    }
+
+    public int getVisitIF_ICMPLTCount() {
+        return visitIF_ICMPLTCount;
+    }
+
+    public int getVisitIF_ICMPNECount() {
+        return visitIF_ICMPNECount;
+    }
+
+    public int getVisitIFEQCount() {
+        return visitIFEQCount;
+    }
+
+    public int getVisitIFGECount() {
+        return visitIFGECount;
+    }
+
+    public int getVisitIFGTCount() {
+        return visitIFGTCount;
+    }
+
+    public int getVisitIfInstructionCount() {
+        return visitIfInstructionCount;
+    }
+
+    public int getVisitIFLECount() {
+        return visitIFLECount;
+    }
+
+    public int getVisitIFLTCount() {
+        return visitIFLTCount;
+    }
+
+    public int getVisitIFNECount() {
+        return visitIFNECount;
+    }
+
+    public int getVisitIFNONNULLCount() {
+        return visitIFNONNULLCount;
+    }
+
+    public int getVisitIFNULLCount() {
+        return visitIFNULLCount;
+    }
+
+    public int getVisitIINCCount() {
+        return visitIINCCount;
+    }
+
+    public int getVisitILOADCount() {
+        return visitILOADCount;
+    }
+
+    public int getVisitIMPDEP1Count() {
+        return visitIMPDEP1Count;
+    }
+
+    public int getVisitIMPDEP2Count() {
+        return visitIMPDEP2Count;
+    }
+
+    public int getVisitIMULCount() {
+        return visitIMULCount;
+    }
+
+    public int getVisitINEGCount() {
+        return visitINEGCount;
+    }
+
+    public int getVisitINSTANCEOFCount() {
+        return visitINSTANCEOFCount;
+    }
+
+    public int getVisitINVOKEDYNAMICCount() {
+        return visitINVOKEDYNAMICCount;
+    }
+
+    public int getVisitInvokeInstructionCount() {
+        return visitInvokeInstructionCount;
+    }
+
+    public int getVisitINVOKEINTERFACECount() {
+        return visitINVOKEINTERFACECount;
+    }
+
+    public int getVisitINVOKESPECIALCount() {
+        return visitINVOKESPECIALCount;
+    }
+
+    public int getVisitINVOKESTATICCount() {
+        return visitINVOKESTATICCount;
+    }
+
+    public int getVisitINVOKEVIRTUALCount() {
+        return visitINVOKEVIRTUALCount;
+    }
+
+    public int getVisitIORCount() {
+        return visitIORCount;
+    }
+
+    public int getVisitIREMCount() {
+        return visitIREMCount;
+    }
+
+    public int getVisitIRETURNCount() {
+        return visitIRETURNCount;
+    }
+
+    public int getVisitISHLCount() {
+        return visitISHLCount;
+    }
+
+    public int getVisitISHRCount() {
+        return visitISHRCount;
+    }
+
+    public int getVisitISTORECount() {
+        return visitISTORECount;
+    }
+
+    public int getVisitISUBCount() {
+        return visitISUBCount;
+    }
+
+    public int getVisitIUSHRCount() {
+        return visitIUSHRCount;
+    }
+
+    public int getVisitIXORCount() {
+        return visitIXORCount;
+    }
+
+    public int getVisitJSRCount() {
+        return visitJSRCount;
+    }
+
+    public int getVisitJSR_WCount() {
+        return visitJSR_WCount;
+    }
+
+    public int getVisitJsrInstructionCount() {
+        return visitJsrInstructionCount;
+    }
+
+    public int getVisitL2DCount() {
+        return visitL2DCount;
+    }
+
+    public int getVisitL2FCount() {
+        return visitL2FCount;
+    }
+
+    public int getVisitL2ICount() {
+        return visitL2ICount;
+    }
+
+    public int getVisitLADDCount() {
+        return visitLADDCount;
+    }
+
+    public int getVisitLALOADCount() {
+        return visitLALOADCount;
+    }
+
+    public int getVisitLANDCount() {
+        return visitLANDCount;
+    }
+
+    public int getVisitLASTORECount() {
+        return visitLASTORECount;
+    }
+
+    public int getVisitLCMPCount() {
+        return visitLCMPCount;
+    }
+
+    public int getVisitLCONSTCount() {
+        return visitLCONSTCount;
+    }
+
+    public int getVisitLDCCount() {
+        return visitLDCCount;
+    }
+
+    public int getVisitLDC2_WCount() {
+        return visitLDC2_WCount;
+    }
+
+    public int getVisitLDIVCount() {
+        return visitLDIVCount;
+    }
+
+    public int getVisitLLOADCount() {
+        return visitLLOADCount;
+    }
+
+    public int getVisitLMULCount() {
+        return visitLMULCount;
+    }
+
+    public int getVisitLNEGCount() {
+        return visitLNEGCount;
+    }
+
+    public int getVisitLoadClassCount() {
+        return visitLoadClassCount;
+    }
+
+    public int getVisitLoadInstructionCount() {
+        return visitLoadInstructionCount;
+    }
+
+    public int getVisitLocalVariableInstructionCount() {
+        return visitLocalVariableInstructionCount;
+    }
+
+    public int getVisitLOOKUPSWITCHCount() {
+        return visitLOOKUPSWITCHCount;
+    }
+
+    public int getVisitLORCount() {
+        return visitLORCount;
+    }
+
+    public int getVisitLREMCount() {
+        return visitLREMCount;
+    }
+
+    public int getVisitLRETURNCount() {
+        return visitLRETURNCount;
+    }
+
+    public int getVisitLSHLCount() {
+        return visitLSHLCount;
+    }
+
+    public int getVisitLSHRCount() {
+        return visitLSHRCount;
+    }
+
+    public int getVisitLSTORECount() {
+        return visitLSTORECount;
+    }
+
+    public int getVisitLSUBCount() {
+        return visitLSUBCount;
+    }
+
+    public int getVisitLUSHRCount() {
+        return visitLUSHRCount;
+    }
+
+    public int getVisitLXORCount() {
+        return visitLXORCount;
+    }
+
+    public int getVisitMONITORENTERCount() {
+        return visitMONITORENTERCount;
+    }
+
+    public int getVisitMONITOREXITCount() {
+        return visitMONITOREXITCount;
+    }
+
+    public int getVisitMULTIANEWARRAYCount() {
+        return visitMULTIANEWARRAYCount;
+    }
+
+    public int getVisitNEWCount() {
+        return visitNEWCount;
+    }
+
+    public int getVisitNEWARRAYCount() {
+        return visitNEWARRAYCount;
+    }
+
+    public int getVisitNOPCount() {
+        return visitNOPCount;
+    }
+
+    public int getVisitPOPCount() {
+        return visitPOPCount;
+    }
+
+    public int getVisitPOP2Count() {
+        return visitPOP2Count;
+    }
+
+    public int getVisitPopInstructionCount() {
+        return visitPopInstructionCount;
+    }
+
+    public int getVisitPushInstructionCount() {
+        return visitPushInstructionCount;
+    }
+
+    public int getVisitPUTFIELDCount() {
+        return visitPUTFIELDCount;
+    }
+
+    public int getVisitPUTSTATICCount() {
+        return visitPUTSTATICCount;
+    }
+
+    public int getVisitRETCount() {
+        return visitRETCount;
+    }
+
+    public int getVisitRETURNCount() {
+        return visitRETURNCount;
+    }
+
+    public int getVisitReturnInstructionCount() {
+        return visitReturnInstructionCount;
+    }
+
+    public int getVisitSALOADCount() {
+        return visitSALOADCount;
+    }
+
+    public int getVisitSASTORECount() {
+        return visitSASTORECount;
+    }
+
+    public int getVisitSelectCount() {
+        return visitSelectCount;
+    }
+
+    public int getVisitSIPUSHCount() {
+        return visitSIPUSHCount;
+    }
+
+    public int getVisitStackConsumerCount() {
+        return visitStackConsumerCount;
+    }
+
+    public int getVisitStackInstructionCount() {
+        return visitStackInstructionCount;
+    }
+
+    public int getVisitStackProducerCount() {
+        return visitStackProducerCount;
+    }
+
+    public int getVisitStoreInstructionCount() {
+        return visitStoreInstructionCount;
+    }
+
+    public int getVisitSWAPCount() {
+        return visitSWAPCount;
+    }
+
+    public int getVisitTABLESWITCHCount() {
+        return visitTABLESWITCHCount;
+    }
+
+    public int getVisitTypedInstructionCount() {
+        return visitTypedInstructionCount;
+    }
+
+    public int getVisitUnconditionalBranchCount() {
+        return visitUnconditionalBranchCount;
+    }
+
+    public int getVisitVariableLengthInstructionCount() {
+        return visitVariableLengthInstructionCount;
+    }
+
+    private int visitAALOADCount = 0;

Review Comment:
   Updated, please check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1013976165


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,3118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import java.util.Objects;
+
+public class CountVisitor implements Visitor {
+    private int aaload;
+    private int aastore;
+    private int aconst_null;
+    private int allocationInstruction;
+    private int aload;
+    private int anewarray;
+    private int areturn;
+    private int arithmeticInstruction;
+    private int arrayInstruction;
+    private int arraylength;
+    private int astore;
+    private int athrow;
+    private int baload;
+    private int bastore;
+    private int bipush;
+    private int branchInstruction;
+    private int BREAKPOINT;
+    private int caload;
+    private int castore;
+    private int checkcast;
+    private int constantPushInstruction;
+    private int conversionInstruction;
+    private int cpInstruction;
+    private int d2F;
+    private int d2I;
+    private int d2L;
+    private int dadd;
+    private int daload;
+    private int dastore;
+    private int dcmpg;
+    private int dcmpl;
+    private int dconst;
+    private int ddiv;
+    private int dload;
+    private int dmul;
+    private int dneg;
+    private int drem;
+    private int dreturn;
+    private int dstore;
+    private int dsub;
+    private int dup;
+    private int dup_x1;
+    private int dup_x2;
+    private int dup2;
+    private int dup2_x1;
+    private int dup2_x2;
+    private int exceptionThrower;
+    private int f2D;
+    private int f2I;
+    private int f2L;
+    private int fadd;
+    private int faload;
+    private int fastore;
+    private int fcmpg;
+    private int fcmpl;
+    private int fconst;
+    private int fdiv;
+    private int fieldInstruction;
+    private int fieldOrMethod;
+    private int fload;
+    private int fmul;
+    private int fneg;
+    private int frem;
+    private int freturn;
+    private int fstore;
+    private int fsub;
+    private int getfield;
+    private int getstatic;
+    private int goTo;
+    private int goTo_w;
+    private int gotoInstruction;
+    private int i2B;
+    private int i2C;
+    private int i2D;
+    private int i2F;
+    private int i2L;
+    private int i2S;
+    private int iadd;
+    private int iaload;
+    private int iand;
+    private int iastore;
+    private int iconst;
+    private int idiv;
+    private int if_acmpeq;

Review Comment:
   Thx, how about variable for `NEW`, `RETURN` and `GOTO`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1010768596


##########
src/test/java/org/apache/bcel/generic/BREAKPOINTTest.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class BREAKPOINTTest {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();
+        BREAKPOINT breakpoint = new BREAKPOINT();
+        breakpoint.accept(countVisitor);
+        assertEquals(1, countVisitor.getVisitBREAKPOINTCount());
+    }
+}

Review Comment:
   Files should end in a new line. Check all new files. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011965812


##########
src/test/java/org/apache/bcel/generic/IREMTestCase.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class IREMTestCase {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();

Review Comment:
   Updated to create an `expected` instance for comparison.
   `equals`, `hashcode` and `toString` are generated using IDE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011800810


##########
src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class BREAKPOINTTestCase {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();

Review Comment:
   Hi @samabcde 
   If you look at the other tests, you'll see that we use `final` when possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011818719


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,2012 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+public class CountVisitor implements Visitor {
+
+    public int getVisitAALOADCount() {
+        return visitAALOADCount;
+    }
+
+    public int getVisitAASTORECount() {
+        return visitAASTORECount;
+    }
+
+    public int getVisitACONST_NULLCount() {
+        return visitACONST_NULLCount;
+    }
+
+    public int getVisitAllocationInstructionCount() {
+        return visitAllocationInstructionCount;
+    }
+
+    public int getVisitALOADCount() {
+        return visitALOADCount;
+    }
+
+    public int getVisitANEWARRAYCount() {
+        return visitANEWARRAYCount;
+    }
+
+    public int getVisitARETURNCount() {
+        return visitARETURNCount;
+    }
+
+    public int getVisitArithmeticInstructionCount() {
+        return visitArithmeticInstructionCount;
+    }
+
+    public int getVisitArrayInstructionCount() {
+        return visitArrayInstructionCount;
+    }
+
+    public int getVisitARRAYLENGTHCount() {
+        return visitARRAYLENGTHCount;
+    }
+
+    public int getVisitASTORECount() {
+        return visitASTORECount;
+    }
+
+    public int getVisitATHROWCount() {
+        return visitATHROWCount;
+    }
+
+    public int getVisitBALOADCount() {
+        return visitBALOADCount;
+    }
+
+    public int getVisitBASTORECount() {
+        return visitBASTORECount;
+    }
+
+    public int getVisitBIPUSHCount() {
+        return visitBIPUSHCount;
+    }
+
+    public int getVisitBranchInstructionCount() {
+        return visitBranchInstructionCount;
+    }
+
+    public int getVisitBREAKPOINTCount() {
+        return visitBREAKPOINTCount;
+    }
+
+    public int getVisitCALOADCount() {
+        return visitCALOADCount;
+    }
+
+    public int getVisitCASTORECount() {
+        return visitCASTORECount;
+    }
+
+    public int getVisitCHECKCASTCount() {
+        return visitCHECKCASTCount;
+    }
+
+    public int getVisitConstantPushInstructionCount() {
+        return visitConstantPushInstructionCount;
+    }
+
+    public int getVisitConversionInstructionCount() {
+        return visitConversionInstructionCount;
+    }
+
+    public int getVisitCPInstructionCount() {
+        return visitCPInstructionCount;
+    }
+
+    public int getVisitD2FCount() {
+        return visitD2FCount;
+    }
+
+    public int getVisitD2ICount() {
+        return visitD2ICount;
+    }
+
+    public int getVisitD2LCount() {
+        return visitD2LCount;
+    }
+
+    public int getVisitDADDCount() {
+        return visitDADDCount;
+    }
+
+    public int getVisitDALOADCount() {
+        return visitDALOADCount;
+    }
+
+    public int getVisitDASTORECount() {
+        return visitDASTORECount;
+    }
+
+    public int getVisitDCMPGCount() {
+        return visitDCMPGCount;
+    }
+
+    public int getVisitDCMPLCount() {
+        return visitDCMPLCount;
+    }
+
+    public int getVisitDCONSTCount() {
+        return visitDCONSTCount;
+    }
+
+    public int getVisitDDIVCount() {
+        return visitDDIVCount;
+    }
+
+    public int getVisitDLOADCount() {
+        return visitDLOADCount;
+    }
+
+    public int getVisitDMULCount() {
+        return visitDMULCount;
+    }
+
+    public int getVisitDNEGCount() {
+        return visitDNEGCount;
+    }
+
+    public int getVisitDREMCount() {
+        return visitDREMCount;
+    }
+
+    public int getVisitDRETURNCount() {
+        return visitDRETURNCount;
+    }
+
+    public int getVisitDSTORECount() {
+        return visitDSTORECount;
+    }
+
+    public int getVisitDSUBCount() {
+        return visitDSUBCount;
+    }
+
+    public int getVisitDUPCount() {
+        return visitDUPCount;
+    }
+
+    public int getVisitDUP_X1Count() {
+        return visitDUP_X1Count;
+    }
+
+    public int getVisitDUP_X2Count() {
+        return visitDUP_X2Count;
+    }
+
+    public int getVisitDUP2Count() {
+        return visitDUP2Count;
+    }
+
+    public int getVisitDUP2_X1Count() {
+        return visitDUP2_X1Count;
+    }
+
+    public int getVisitDUP2_X2Count() {
+        return visitDUP2_X2Count;
+    }
+
+    public int getVisitExceptionThrowerCount() {
+        return visitExceptionThrowerCount;
+    }
+
+    public int getVisitF2DCount() {
+        return visitF2DCount;
+    }
+
+    public int getVisitF2ICount() {
+        return visitF2ICount;
+    }
+
+    public int getVisitF2LCount() {
+        return visitF2LCount;
+    }
+
+    public int getVisitFADDCount() {
+        return visitFADDCount;
+    }
+
+    public int getVisitFALOADCount() {
+        return visitFALOADCount;
+    }
+
+    public int getVisitFASTORECount() {
+        return visitFASTORECount;
+    }
+
+    public int getVisitFCMPGCount() {
+        return visitFCMPGCount;
+    }
+
+    public int getVisitFCMPLCount() {
+        return visitFCMPLCount;
+    }
+
+    public int getVisitFCONSTCount() {
+        return visitFCONSTCount;
+    }
+
+    public int getVisitFDIVCount() {
+        return visitFDIVCount;
+    }
+
+    public int getVisitFieldInstructionCount() {
+        return visitFieldInstructionCount;
+    }
+
+    public int getVisitFieldOrMethodCount() {
+        return visitFieldOrMethodCount;
+    }
+
+    public int getVisitFLOADCount() {
+        return visitFLOADCount;
+    }
+
+    public int getVisitFMULCount() {
+        return visitFMULCount;
+    }
+
+    public int getVisitFNEGCount() {
+        return visitFNEGCount;
+    }
+
+    public int getVisitFREMCount() {
+        return visitFREMCount;
+    }
+
+    public int getVisitFRETURNCount() {
+        return visitFRETURNCount;
+    }
+
+    public int getVisitFSTORECount() {
+        return visitFSTORECount;
+    }
+
+    public int getVisitFSUBCount() {
+        return visitFSUBCount;
+    }
+
+    public int getVisitGETFIELDCount() {
+        return visitGETFIELDCount;
+    }
+
+    public int getVisitGETSTATICCount() {
+        return visitGETSTATICCount;
+    }
+
+    public int getVisitGOTOCount() {
+        return visitGOTOCount;
+    }
+
+    public int getVisitGOTO_WCount() {
+        return visitGOTO_WCount;
+    }
+
+    public int getVisitGotoInstructionCount() {
+        return visitGotoInstructionCount;
+    }
+
+    public int getVisitI2BCount() {
+        return visitI2BCount;
+    }
+
+    public int getVisitI2CCount() {
+        return visitI2CCount;
+    }
+
+    public int getVisitI2DCount() {
+        return visitI2DCount;
+    }
+
+    public int getVisitI2FCount() {
+        return visitI2FCount;
+    }
+
+    public int getVisitI2LCount() {
+        return visitI2LCount;
+    }
+
+    public int getVisitI2SCount() {
+        return visitI2SCount;
+    }
+
+    public int getVisitIADDCount() {
+        return visitIADDCount;
+    }
+
+    public int getVisitIALOADCount() {
+        return visitIALOADCount;
+    }
+
+    public int getVisitIANDCount() {
+        return visitIANDCount;
+    }
+
+    public int getVisitIASTORECount() {
+        return visitIASTORECount;
+    }
+
+    public int getVisitICONSTCount() {
+        return visitICONSTCount;
+    }
+
+    public int getVisitIDIVCount() {
+        return visitIDIVCount;
+    }
+
+    public int getVisitIF_ACMPEQCount() {
+        return visitIF_ACMPEQCount;
+    }
+
+    public int getVisitIF_ACMPNECount() {
+        return visitIF_ACMPNECount;
+    }
+
+    public int getVisitIF_ICMPEQCount() {
+        return visitIF_ICMPEQCount;
+    }
+
+    public int getVisitIF_ICMPGECount() {
+        return visitIF_ICMPGECount;
+    }
+
+    public int getVisitIF_ICMPGTCount() {
+        return visitIF_ICMPGTCount;
+    }
+
+    public int getVisitIF_ICMPLECount() {
+        return visitIF_ICMPLECount;
+    }
+
+    public int getVisitIF_ICMPLTCount() {
+        return visitIF_ICMPLTCount;
+    }
+
+    public int getVisitIF_ICMPNECount() {
+        return visitIF_ICMPNECount;
+    }
+
+    public int getVisitIFEQCount() {
+        return visitIFEQCount;
+    }
+
+    public int getVisitIFGECount() {
+        return visitIFGECount;
+    }
+
+    public int getVisitIFGTCount() {
+        return visitIFGTCount;
+    }
+
+    public int getVisitIfInstructionCount() {
+        return visitIfInstructionCount;
+    }
+
+    public int getVisitIFLECount() {
+        return visitIFLECount;
+    }
+
+    public int getVisitIFLTCount() {
+        return visitIFLTCount;
+    }
+
+    public int getVisitIFNECount() {
+        return visitIFNECount;
+    }
+
+    public int getVisitIFNONNULLCount() {
+        return visitIFNONNULLCount;
+    }
+
+    public int getVisitIFNULLCount() {
+        return visitIFNULLCount;
+    }
+
+    public int getVisitIINCCount() {
+        return visitIINCCount;
+    }
+
+    public int getVisitILOADCount() {
+        return visitILOADCount;
+    }
+
+    public int getVisitIMPDEP1Count() {
+        return visitIMPDEP1Count;
+    }
+
+    public int getVisitIMPDEP2Count() {
+        return visitIMPDEP2Count;
+    }
+
+    public int getVisitIMULCount() {
+        return visitIMULCount;
+    }
+
+    public int getVisitINEGCount() {
+        return visitINEGCount;
+    }
+
+    public int getVisitINSTANCEOFCount() {
+        return visitINSTANCEOFCount;
+    }
+
+    public int getVisitINVOKEDYNAMICCount() {
+        return visitINVOKEDYNAMICCount;
+    }
+
+    public int getVisitInvokeInstructionCount() {
+        return visitInvokeInstructionCount;
+    }
+
+    public int getVisitINVOKEINTERFACECount() {
+        return visitINVOKEINTERFACECount;
+    }
+
+    public int getVisitINVOKESPECIALCount() {
+        return visitINVOKESPECIALCount;
+    }
+
+    public int getVisitINVOKESTATICCount() {
+        return visitINVOKESTATICCount;
+    }
+
+    public int getVisitINVOKEVIRTUALCount() {
+        return visitINVOKEVIRTUALCount;
+    }
+
+    public int getVisitIORCount() {
+        return visitIORCount;
+    }
+
+    public int getVisitIREMCount() {
+        return visitIREMCount;
+    }
+
+    public int getVisitIRETURNCount() {
+        return visitIRETURNCount;
+    }
+
+    public int getVisitISHLCount() {
+        return visitISHLCount;
+    }
+
+    public int getVisitISHRCount() {
+        return visitISHRCount;
+    }
+
+    public int getVisitISTORECount() {
+        return visitISTORECount;
+    }
+
+    public int getVisitISUBCount() {
+        return visitISUBCount;
+    }
+
+    public int getVisitIUSHRCount() {
+        return visitIUSHRCount;
+    }
+
+    public int getVisitIXORCount() {
+        return visitIXORCount;
+    }
+
+    public int getVisitJSRCount() {
+        return visitJSRCount;
+    }
+
+    public int getVisitJSR_WCount() {
+        return visitJSR_WCount;
+    }
+
+    public int getVisitJsrInstructionCount() {
+        return visitJsrInstructionCount;
+    }
+
+    public int getVisitL2DCount() {
+        return visitL2DCount;
+    }
+
+    public int getVisitL2FCount() {
+        return visitL2FCount;
+    }
+
+    public int getVisitL2ICount() {
+        return visitL2ICount;
+    }
+
+    public int getVisitLADDCount() {
+        return visitLADDCount;
+    }
+
+    public int getVisitLALOADCount() {
+        return visitLALOADCount;
+    }
+
+    public int getVisitLANDCount() {
+        return visitLANDCount;
+    }
+
+    public int getVisitLASTORECount() {
+        return visitLASTORECount;
+    }
+
+    public int getVisitLCMPCount() {
+        return visitLCMPCount;
+    }
+
+    public int getVisitLCONSTCount() {
+        return visitLCONSTCount;
+    }
+
+    public int getVisitLDCCount() {
+        return visitLDCCount;
+    }
+
+    public int getVisitLDC2_WCount() {
+        return visitLDC2_WCount;
+    }
+
+    public int getVisitLDIVCount() {
+        return visitLDIVCount;
+    }
+
+    public int getVisitLLOADCount() {
+        return visitLLOADCount;
+    }
+
+    public int getVisitLMULCount() {
+        return visitLMULCount;
+    }
+
+    public int getVisitLNEGCount() {
+        return visitLNEGCount;
+    }
+
+    public int getVisitLoadClassCount() {
+        return visitLoadClassCount;
+    }
+
+    public int getVisitLoadInstructionCount() {
+        return visitLoadInstructionCount;
+    }
+
+    public int getVisitLocalVariableInstructionCount() {
+        return visitLocalVariableInstructionCount;
+    }
+
+    public int getVisitLOOKUPSWITCHCount() {
+        return visitLOOKUPSWITCHCount;
+    }
+
+    public int getVisitLORCount() {
+        return visitLORCount;
+    }
+
+    public int getVisitLREMCount() {
+        return visitLREMCount;
+    }
+
+    public int getVisitLRETURNCount() {
+        return visitLRETURNCount;
+    }
+
+    public int getVisitLSHLCount() {
+        return visitLSHLCount;
+    }
+
+    public int getVisitLSHRCount() {
+        return visitLSHRCount;
+    }
+
+    public int getVisitLSTORECount() {
+        return visitLSTORECount;
+    }
+
+    public int getVisitLSUBCount() {
+        return visitLSUBCount;
+    }
+
+    public int getVisitLUSHRCount() {
+        return visitLUSHRCount;
+    }
+
+    public int getVisitLXORCount() {
+        return visitLXORCount;
+    }
+
+    public int getVisitMONITORENTERCount() {
+        return visitMONITORENTERCount;
+    }
+
+    public int getVisitMONITOREXITCount() {
+        return visitMONITOREXITCount;
+    }
+
+    public int getVisitMULTIANEWARRAYCount() {
+        return visitMULTIANEWARRAYCount;
+    }
+
+    public int getVisitNEWCount() {
+        return visitNEWCount;
+    }
+
+    public int getVisitNEWARRAYCount() {
+        return visitNEWARRAYCount;
+    }
+
+    public int getVisitNOPCount() {
+        return visitNOPCount;
+    }
+
+    public int getVisitPOPCount() {
+        return visitPOPCount;
+    }
+
+    public int getVisitPOP2Count() {
+        return visitPOP2Count;
+    }
+
+    public int getVisitPopInstructionCount() {
+        return visitPopInstructionCount;
+    }
+
+    public int getVisitPushInstructionCount() {
+        return visitPushInstructionCount;
+    }
+
+    public int getVisitPUTFIELDCount() {
+        return visitPUTFIELDCount;
+    }
+
+    public int getVisitPUTSTATICCount() {
+        return visitPUTSTATICCount;
+    }
+
+    public int getVisitRETCount() {
+        return visitRETCount;
+    }
+
+    public int getVisitRETURNCount() {
+        return visitRETURNCount;
+    }
+
+    public int getVisitReturnInstructionCount() {
+        return visitReturnInstructionCount;
+    }
+
+    public int getVisitSALOADCount() {
+        return visitSALOADCount;
+    }
+
+    public int getVisitSASTORECount() {
+        return visitSASTORECount;
+    }
+
+    public int getVisitSelectCount() {
+        return visitSelectCount;
+    }
+
+    public int getVisitSIPUSHCount() {
+        return visitSIPUSHCount;
+    }
+
+    public int getVisitStackConsumerCount() {
+        return visitStackConsumerCount;
+    }
+
+    public int getVisitStackInstructionCount() {
+        return visitStackInstructionCount;
+    }
+
+    public int getVisitStackProducerCount() {
+        return visitStackProducerCount;
+    }
+
+    public int getVisitStoreInstructionCount() {
+        return visitStoreInstructionCount;
+    }
+
+    public int getVisitSWAPCount() {
+        return visitSWAPCount;
+    }
+
+    public int getVisitTABLESWITCHCount() {
+        return visitTABLESWITCHCount;
+    }
+
+    public int getVisitTypedInstructionCount() {
+        return visitTypedInstructionCount;
+    }
+
+    public int getVisitUnconditionalBranchCount() {
+        return visitUnconditionalBranchCount;
+    }
+
+    public int getVisitVariableLengthInstructionCount() {
+        return visitVariableLengthInstructionCount;
+    }
+
+    private int visitAALOADCount = 0;
+
+    @Override
+    public void visitAALOAD(AALOAD obj) {
+        visitAALOADCount++;
+    }
+
+    private int visitAASTORECount = 0;
+
+    @Override
+    public void visitAASTORE(AASTORE obj) {
+        visitAASTORECount++;
+    }
+
+    private int visitACONST_NULLCount = 0;
+
+    @Override
+    public void visitACONST_NULL(ACONST_NULL obj) {
+        visitACONST_NULLCount++;
+    }
+
+    private int visitAllocationInstructionCount = 0;
+
+    @Override
+    public void visitAllocationInstruction(AllocationInstruction obj) {
+        visitAllocationInstructionCount++;
+    }
+
+    private int visitALOADCount = 0;
+
+    @Override
+    public void visitALOAD(ALOAD obj) {
+        visitALOADCount++;
+    }
+
+    private int visitANEWARRAYCount = 0;
+
+    @Override
+    public void visitANEWARRAY(ANEWARRAY obj) {
+        visitANEWARRAYCount++;
+    }
+
+    private int visitARETURNCount = 0;
+
+    @Override
+    public void visitARETURN(ARETURN obj) {
+        visitARETURNCount++;
+    }
+
+    private int visitArithmeticInstructionCount = 0;
+
+    @Override
+    public void visitArithmeticInstruction(ArithmeticInstruction obj) {
+        visitArithmeticInstructionCount++;
+    }
+
+    private int visitArrayInstructionCount = 0;
+
+    @Override
+    public void visitArrayInstruction(ArrayInstruction obj) {
+        visitArrayInstructionCount++;
+    }
+
+    private int visitARRAYLENGTHCount = 0;
+
+    @Override
+    public void visitARRAYLENGTH(ARRAYLENGTH obj) {
+        visitARRAYLENGTHCount++;
+    }
+
+    private int visitASTORECount = 0;
+
+    @Override
+    public void visitASTORE(ASTORE obj) {
+        visitASTORECount++;
+    }
+
+    private int visitATHROWCount = 0;
+
+    @Override
+    public void visitATHROW(ATHROW obj) {
+        visitATHROWCount++;
+    }
+
+    private int visitBALOADCount = 0;
+
+    @Override
+    public void visitBALOAD(BALOAD obj) {
+        visitBALOADCount++;
+    }
+
+    private int visitBASTORECount = 0;
+
+    @Override
+    public void visitBASTORE(BASTORE obj) {
+        visitBASTORECount++;
+    }
+
+    private int visitBIPUSHCount = 0;
+
+    @Override
+    public void visitBIPUSH(BIPUSH obj) {
+        visitBIPUSHCount++;
+    }
+
+    private int visitBranchInstructionCount = 0;
+
+    @Override
+    public void visitBranchInstruction(BranchInstruction obj) {
+        visitBranchInstructionCount++;
+    }
+
+    private int visitBREAKPOINTCount = 0;
+
+    @Override
+    public void visitBREAKPOINT(BREAKPOINT obj) {
+        visitBREAKPOINTCount++;
+    }
+
+    private int visitCALOADCount = 0;
+
+    @Override
+    public void visitCALOAD(CALOAD obj) {
+        visitCALOADCount++;
+    }
+
+    private int visitCASTORECount = 0;
+
+    @Override
+    public void visitCASTORE(CASTORE obj) {
+        visitCASTORECount++;
+    }
+
+    private int visitCHECKCASTCount = 0;
+
+    @Override
+    public void visitCHECKCAST(CHECKCAST obj) {
+        visitCHECKCASTCount++;
+    }
+
+    private int visitConstantPushInstructionCount = 0;
+
+    @Override
+    public void visitConstantPushInstruction(ConstantPushInstruction obj) {
+        visitConstantPushInstructionCount++;
+    }
+
+    private int visitConversionInstructionCount = 0;
+
+    @Override
+    public void visitConversionInstruction(ConversionInstruction obj) {
+        visitConversionInstructionCount++;
+    }
+
+    private int visitCPInstructionCount = 0;
+
+    @Override
+    public void visitCPInstruction(CPInstruction obj) {
+        visitCPInstructionCount++;
+    }
+
+    private int visitD2FCount = 0;
+
+    @Override
+    public void visitD2F(D2F obj) {
+        visitD2FCount++;
+    }
+
+    private int visitD2ICount = 0;
+
+    @Override
+    public void visitD2I(D2I obj) {
+        visitD2ICount++;
+    }
+
+    private int visitD2LCount = 0;
+
+    @Override
+    public void visitD2L(D2L obj) {
+        visitD2LCount++;
+    }
+
+    private int visitDADDCount = 0;
+
+    @Override
+    public void visitDADD(DADD obj) {
+        visitDADDCount++;
+    }
+
+    private int visitDALOADCount = 0;
+
+    @Override
+    public void visitDALOAD(DALOAD obj) {
+        visitDALOADCount++;
+    }
+
+    private int visitDASTORECount = 0;
+
+    @Override
+    public void visitDASTORE(DASTORE obj) {
+        visitDASTORECount++;
+    }
+
+    private int visitDCMPGCount = 0;
+
+    @Override
+    public void visitDCMPG(DCMPG obj) {
+        visitDCMPGCount++;
+    }
+
+    private int visitDCMPLCount = 0;
+
+    @Override
+    public void visitDCMPL(DCMPL obj) {
+        visitDCMPLCount++;
+    }
+
+    private int visitDCONSTCount = 0;
+
+    @Override
+    public void visitDCONST(DCONST obj) {
+        visitDCONSTCount++;
+    }
+
+    private int visitDDIVCount = 0;
+
+    @Override
+    public void visitDDIV(DDIV obj) {
+        visitDDIVCount++;
+    }
+
+    private int visitDLOADCount = 0;
+
+    @Override
+    public void visitDLOAD(DLOAD obj) {
+        visitDLOADCount++;
+    }
+
+    private int visitDMULCount = 0;
+
+    @Override
+    public void visitDMUL(DMUL obj) {
+        visitDMULCount++;
+    }
+
+    private int visitDNEGCount = 0;
+
+    @Override
+    public void visitDNEG(DNEG obj) {
+        visitDNEGCount++;
+    }
+
+    private int visitDREMCount = 0;
+
+    @Override
+    public void visitDREM(DREM obj) {
+        visitDREMCount++;
+    }
+
+    private int visitDRETURNCount = 0;
+
+    @Override
+    public void visitDRETURN(DRETURN obj) {
+        visitDRETURNCount++;
+    }
+
+    private int visitDSTORECount = 0;
+
+    @Override
+    public void visitDSTORE(DSTORE obj) {
+        visitDSTORECount++;
+    }
+
+    private int visitDSUBCount = 0;
+
+    @Override
+    public void visitDSUB(DSUB obj) {
+        visitDSUBCount++;
+    }
+
+    private int visitDUPCount = 0;
+
+    @Override
+    public void visitDUP(DUP obj) {
+        visitDUPCount++;
+    }
+
+    private int visitDUP_X1Count = 0;
+
+    @Override
+    public void visitDUP_X1(DUP_X1 obj) {
+        visitDUP_X1Count++;
+    }
+
+    private int visitDUP_X2Count = 0;
+
+    @Override
+    public void visitDUP_X2(DUP_X2 obj) {
+        visitDUP_X2Count++;
+    }
+
+    private int visitDUP2Count = 0;
+
+    @Override
+    public void visitDUP2(DUP2 obj) {
+        visitDUP2Count++;
+    }
+
+    private int visitDUP2_X1Count = 0;
+
+    @Override
+    public void visitDUP2_X1(DUP2_X1 obj) {
+        visitDUP2_X1Count++;
+    }
+
+    private int visitDUP2_X2Count = 0;
+
+    @Override
+    public void visitDUP2_X2(DUP2_X2 obj) {
+        visitDUP2_X2Count++;
+    }
+
+    private int visitExceptionThrowerCount = 0;
+
+    @Override
+    public void visitExceptionThrower(ExceptionThrower obj) {
+        visitExceptionThrowerCount++;
+    }
+
+    private int visitF2DCount = 0;
+
+    @Override
+    public void visitF2D(F2D obj) {
+        visitF2DCount++;
+    }
+
+    private int visitF2ICount = 0;
+
+    @Override
+    public void visitF2I(F2I obj) {
+        visitF2ICount++;
+    }
+
+    private int visitF2LCount = 0;
+
+    @Override
+    public void visitF2L(F2L obj) {
+        visitF2LCount++;
+    }
+
+    private int visitFADDCount = 0;
+
+    @Override
+    public void visitFADD(FADD obj) {
+        visitFADDCount++;
+    }
+
+    private int visitFALOADCount = 0;
+
+    @Override
+    public void visitFALOAD(FALOAD obj) {
+        visitFALOADCount++;
+    }
+
+    private int visitFASTORECount = 0;
+
+    @Override
+    public void visitFASTORE(FASTORE obj) {
+        visitFASTORECount++;
+    }
+
+    private int visitFCMPGCount = 0;
+
+    @Override
+    public void visitFCMPG(FCMPG obj) {
+        visitFCMPGCount++;
+    }
+
+    private int visitFCMPLCount = 0;
+
+    @Override
+    public void visitFCMPL(FCMPL obj) {
+        visitFCMPLCount++;
+    }
+
+    private int visitFCONSTCount = 0;
+
+    @Override
+    public void visitFCONST(FCONST obj) {
+        visitFCONSTCount++;
+    }
+
+    private int visitFDIVCount = 0;
+
+    @Override
+    public void visitFDIV(FDIV obj) {
+        visitFDIVCount++;
+    }
+
+    private int visitFieldInstructionCount = 0;
+
+    @Override
+    public void visitFieldInstruction(FieldInstruction obj) {
+        visitFieldInstructionCount++;
+    }
+
+    private int visitFieldOrMethodCount = 0;
+
+    @Override
+    public void visitFieldOrMethod(FieldOrMethod obj) {
+        visitFieldOrMethodCount++;
+    }
+
+    private int visitFLOADCount = 0;
+
+    @Override
+    public void visitFLOAD(FLOAD obj) {
+        visitFLOADCount++;
+    }
+
+    private int visitFMULCount = 0;
+
+    @Override
+    public void visitFMUL(FMUL obj) {
+        visitFMULCount++;
+    }
+
+    private int visitFNEGCount = 0;
+
+    @Override
+    public void visitFNEG(FNEG obj) {
+        visitFNEGCount++;
+    }
+
+    private int visitFREMCount = 0;
+
+    @Override
+    public void visitFREM(FREM obj) {
+        visitFREMCount++;
+    }
+
+    private int visitFRETURNCount = 0;
+
+    @Override
+    public void visitFRETURN(FRETURN obj) {
+        visitFRETURNCount++;
+    }
+
+    private int visitFSTORECount = 0;
+
+    @Override
+    public void visitFSTORE(FSTORE obj) {
+        visitFSTORECount++;
+    }
+
+    private int visitFSUBCount = 0;
+
+    @Override
+    public void visitFSUB(FSUB obj) {
+        visitFSUBCount++;
+    }
+
+    private int visitGETFIELDCount = 0;
+
+    @Override
+    public void visitGETFIELD(GETFIELD obj) {
+        visitGETFIELDCount++;
+    }
+
+    private int visitGETSTATICCount = 0;
+
+    @Override
+    public void visitGETSTATIC(GETSTATIC obj) {
+        visitGETSTATICCount++;
+    }
+
+    private int visitGOTOCount = 0;
+
+    @Override
+    public void visitGOTO(GOTO obj) {
+        visitGOTOCount++;
+    }
+
+    private int visitGOTO_WCount = 0;
+
+    @Override
+    public void visitGOTO_W(GOTO_W obj) {
+        visitGOTO_WCount++;
+    }
+
+    private int visitGotoInstructionCount = 0;
+
+    @Override
+    public void visitGotoInstruction(GotoInstruction obj) {
+        visitGotoInstructionCount++;
+    }
+
+    private int visitI2BCount = 0;
+
+    @Override
+    public void visitI2B(I2B obj) {
+        visitI2BCount++;
+    }
+
+    private int visitI2CCount = 0;
+
+    @Override
+    public void visitI2C(I2C obj) {
+        visitI2CCount++;
+    }
+
+    private int visitI2DCount = 0;
+
+    @Override
+    public void visitI2D(I2D obj) {
+        visitI2DCount++;
+    }
+
+    private int visitI2FCount = 0;
+
+    @Override
+    public void visitI2F(I2F obj) {
+        visitI2FCount++;
+    }
+
+    private int visitI2LCount = 0;
+
+    @Override
+    public void visitI2L(I2L obj) {
+        visitI2LCount++;
+    }
+
+    private int visitI2SCount = 0;
+
+    @Override
+    public void visitI2S(I2S obj) {
+        visitI2SCount++;
+    }
+
+    private int visitIADDCount = 0;
+
+    @Override
+    public void visitIADD(IADD obj) {
+        visitIADDCount++;
+    }
+
+    private int visitIALOADCount = 0;
+
+    @Override
+    public void visitIALOAD(IALOAD obj) {
+        visitIALOADCount++;
+    }
+
+    private int visitIANDCount = 0;
+
+    @Override
+    public void visitIAND(IAND obj) {
+        visitIANDCount++;
+    }
+
+    private int visitIASTORECount = 0;
+
+    @Override
+    public void visitIASTORE(IASTORE obj) {
+        visitIASTORECount++;
+    }
+
+    private int visitICONSTCount = 0;
+
+    @Override
+    public void visitICONST(ICONST obj) {
+        visitICONSTCount++;
+    }
+
+    private int visitIDIVCount = 0;
+
+    @Override
+    public void visitIDIV(IDIV obj) {
+        visitIDIVCount++;
+    }
+
+    private int visitIF_ACMPEQCount = 0;
+
+    @Override
+    public void visitIF_ACMPEQ(IF_ACMPEQ obj) {
+        visitIF_ACMPEQCount++;
+    }
+
+    private int visitIF_ACMPNECount = 0;
+
+    @Override
+    public void visitIF_ACMPNE(IF_ACMPNE obj) {
+        visitIF_ACMPNECount++;
+    }
+
+    private int visitIF_ICMPEQCount = 0;
+
+    @Override
+    public void visitIF_ICMPEQ(IF_ICMPEQ obj) {
+        visitIF_ICMPEQCount++;
+    }
+
+    private int visitIF_ICMPGECount = 0;
+
+    @Override
+    public void visitIF_ICMPGE(IF_ICMPGE obj) {
+        visitIF_ICMPGECount++;
+    }
+
+    private int visitIF_ICMPGTCount = 0;
+
+    @Override
+    public void visitIF_ICMPGT(IF_ICMPGT obj) {
+        visitIF_ICMPGTCount++;

Review Comment:
   Any suggestion on how to name `visitIF_ICMPGTCount`?
   I just use the convention `visitXXXCount` for all count variables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1014024867


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -19,3100 +19,3100 @@
 import java.util.Objects;
 
 public class CountVisitor implements Visitor {
+    private int aaload;
+    private int aastore;
+    private int aconst_null;
+    private int allocationInstruction;
+    private int aload;
+    private int anewarray;
+    private int areturn;
+    private int arithmeticInstruction;
+    private int arrayInstruction;
+    private int arraylength;
+    private int astore;
+    private int athrow;
+    private int baload;
+    private int bastore;
+    private int bipush;
+    private int branchInstruction;
+    private int BREAKPOINT;
+    private int caload;
+    private int castore;
+    private int checkcast;
+    private int constantPushInstruction;
+    private int conversionInstruction;
+    private int cpInstruction;
+    private int d2F;
+    private int d2I;
+    private int d2L;
+    private int dadd;
+    private int daload;
+    private int dastore;
+    private int dcmpg;
+    private int dcmpl;
+    private int dconst;
+    private int ddiv;
+    private int dload;
+    private int dmul;
+    private int dneg;
+    private int drem;
+    private int dreturn;
+    private int dstore;
+    private int dsub;
+    private int dup;
+    private int dup_x1;
+    private int dup_x2;
+    private int dup2;
+    private int dup2_x1;
+    private int dup2_x2;
+    private int exceptionThrower;
+    private int f2D;
+    private int f2I;
+    private int f2L;
+    private int fadd;
+    private int faload;
+    private int fastore;
+    private int fcmpg;
+    private int fcmpl;
+    private int fconst;
+    private int fdiv;
+    private int fieldInstruction;
+    private int fieldOrMethod;
+    private int fload;
+    private int fmul;
+    private int fneg;
+    private int frem;
+    private int freturn;
+    private int fstore;
+    private int fsub;
+    private int getfield;
+    private int getstatic;
+    private int goTo;
+    private int goTo_w;

Review Comment:
   updated, except `NEW`, `RETURN`, `GOTO`, please check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011812884


##########
src/test/java/org/apache/bcel/generic/IREMTestCase.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class IREMTestCase {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();

Review Comment:
   It seems to me it might be simpler to compare CountVisitors instances



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1014023833


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -19,3100 +19,3100 @@
 import java.util.Objects;
 
 public class CountVisitor implements Visitor {
+    private int aaload;
+    private int aastore;
+    private int aconst_null;
+    private int allocationInstruction;
+    private int aload;
+    private int anewarray;
+    private int areturn;
+    private int arithmeticInstruction;
+    private int arrayInstruction;
+    private int arraylength;
+    private int astore;
+    private int athrow;
+    private int baload;
+    private int bastore;
+    private int bipush;
+    private int branchInstruction;
+    private int BREAKPOINT;

Review Comment:
   Updated, please check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] codecov-commenter commented on pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#issuecomment-1298848173

   # [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/162?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#162](https://codecov.io/gh/apache/commons-bcel/pull/162?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3655a8) into [master](https://codecov.io/gh/apache/commons-bcel/commit/587c9869e2dd9abc5dae70457c44f1ddabd0ef00?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (587c986) will **increase** coverage by `0.19%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #162      +/-   ##
   ============================================
   + Coverage     44.92%   45.12%   +0.19%     
   - Complexity     2516     2536      +20     
   ============================================
     Files           362      362              
     Lines         15567    15567              
     Branches       1920     1920              
   ============================================
   + Hits           6994     7025      +31     
   + Misses         7891     7867      -24     
   + Partials        682      675       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-bcel/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/bcel/classfile/Utility.java](https://codecov.io/gh/apache/commons-bcel/pull/162/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JjZWwvY2xhc3NmaWxlL1V0aWxpdHkuamF2YQ==) | `71.28% <0.00%> (+5.17%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] samabcde commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
samabcde commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011962014


##########
src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class BREAKPOINTTestCase {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();

Review Comment:
   Updated, please check.



##########
src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;

Review Comment:
   Updated, please check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011810774


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,2012 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+public class CountVisitor implements Visitor {
+
+    public int getVisitAALOADCount() {
+        return visitAALOADCount;
+    }
+
+    public int getVisitAASTORECount() {
+        return visitAASTORECount;
+    }
+
+    public int getVisitACONST_NULLCount() {
+        return visitACONST_NULLCount;
+    }
+
+    public int getVisitAllocationInstructionCount() {
+        return visitAllocationInstructionCount;
+    }
+
+    public int getVisitALOADCount() {
+        return visitALOADCount;
+    }
+
+    public int getVisitANEWARRAYCount() {
+        return visitANEWARRAYCount;
+    }
+
+    public int getVisitARETURNCount() {
+        return visitARETURNCount;
+    }
+
+    public int getVisitArithmeticInstructionCount() {
+        return visitArithmeticInstructionCount;
+    }
+
+    public int getVisitArrayInstructionCount() {
+        return visitArrayInstructionCount;
+    }
+
+    public int getVisitARRAYLENGTHCount() {
+        return visitARRAYLENGTHCount;
+    }
+
+    public int getVisitASTORECount() {
+        return visitASTORECount;
+    }
+
+    public int getVisitATHROWCount() {
+        return visitATHROWCount;
+    }
+
+    public int getVisitBALOADCount() {
+        return visitBALOADCount;
+    }
+
+    public int getVisitBASTORECount() {
+        return visitBASTORECount;
+    }
+
+    public int getVisitBIPUSHCount() {
+        return visitBIPUSHCount;
+    }
+
+    public int getVisitBranchInstructionCount() {
+        return visitBranchInstructionCount;
+    }
+
+    public int getVisitBREAKPOINTCount() {
+        return visitBREAKPOINTCount;
+    }
+
+    public int getVisitCALOADCount() {
+        return visitCALOADCount;
+    }
+
+    public int getVisitCASTORECount() {
+        return visitCASTORECount;
+    }
+
+    public int getVisitCHECKCASTCount() {
+        return visitCHECKCASTCount;
+    }
+
+    public int getVisitConstantPushInstructionCount() {
+        return visitConstantPushInstructionCount;
+    }
+
+    public int getVisitConversionInstructionCount() {
+        return visitConversionInstructionCount;
+    }
+
+    public int getVisitCPInstructionCount() {
+        return visitCPInstructionCount;
+    }
+
+    public int getVisitD2FCount() {
+        return visitD2FCount;
+    }
+
+    public int getVisitD2ICount() {
+        return visitD2ICount;
+    }
+
+    public int getVisitD2LCount() {
+        return visitD2LCount;
+    }
+
+    public int getVisitDADDCount() {
+        return visitDADDCount;
+    }
+
+    public int getVisitDALOADCount() {
+        return visitDALOADCount;
+    }
+
+    public int getVisitDASTORECount() {
+        return visitDASTORECount;
+    }
+
+    public int getVisitDCMPGCount() {
+        return visitDCMPGCount;
+    }
+
+    public int getVisitDCMPLCount() {
+        return visitDCMPLCount;
+    }
+
+    public int getVisitDCONSTCount() {
+        return visitDCONSTCount;
+    }
+
+    public int getVisitDDIVCount() {
+        return visitDDIVCount;
+    }
+
+    public int getVisitDLOADCount() {
+        return visitDLOADCount;
+    }
+
+    public int getVisitDMULCount() {
+        return visitDMULCount;
+    }
+
+    public int getVisitDNEGCount() {
+        return visitDNEGCount;
+    }
+
+    public int getVisitDREMCount() {
+        return visitDREMCount;
+    }
+
+    public int getVisitDRETURNCount() {
+        return visitDRETURNCount;
+    }
+
+    public int getVisitDSTORECount() {
+        return visitDSTORECount;
+    }
+
+    public int getVisitDSUBCount() {
+        return visitDSUBCount;
+    }
+
+    public int getVisitDUPCount() {
+        return visitDUPCount;
+    }
+
+    public int getVisitDUP_X1Count() {
+        return visitDUP_X1Count;
+    }
+
+    public int getVisitDUP_X2Count() {
+        return visitDUP_X2Count;
+    }
+
+    public int getVisitDUP2Count() {
+        return visitDUP2Count;
+    }
+
+    public int getVisitDUP2_X1Count() {
+        return visitDUP2_X1Count;
+    }
+
+    public int getVisitDUP2_X2Count() {
+        return visitDUP2_X2Count;
+    }
+
+    public int getVisitExceptionThrowerCount() {
+        return visitExceptionThrowerCount;
+    }
+
+    public int getVisitF2DCount() {
+        return visitF2DCount;
+    }
+
+    public int getVisitF2ICount() {
+        return visitF2ICount;
+    }
+
+    public int getVisitF2LCount() {
+        return visitF2LCount;
+    }
+
+    public int getVisitFADDCount() {
+        return visitFADDCount;
+    }
+
+    public int getVisitFALOADCount() {
+        return visitFALOADCount;
+    }
+
+    public int getVisitFASTORECount() {
+        return visitFASTORECount;
+    }
+
+    public int getVisitFCMPGCount() {
+        return visitFCMPGCount;
+    }
+
+    public int getVisitFCMPLCount() {
+        return visitFCMPLCount;
+    }
+
+    public int getVisitFCONSTCount() {
+        return visitFCONSTCount;
+    }
+
+    public int getVisitFDIVCount() {
+        return visitFDIVCount;
+    }
+
+    public int getVisitFieldInstructionCount() {
+        return visitFieldInstructionCount;
+    }
+
+    public int getVisitFieldOrMethodCount() {
+        return visitFieldOrMethodCount;
+    }
+
+    public int getVisitFLOADCount() {
+        return visitFLOADCount;
+    }
+
+    public int getVisitFMULCount() {
+        return visitFMULCount;
+    }
+
+    public int getVisitFNEGCount() {
+        return visitFNEGCount;
+    }
+
+    public int getVisitFREMCount() {
+        return visitFREMCount;
+    }
+
+    public int getVisitFRETURNCount() {
+        return visitFRETURNCount;
+    }
+
+    public int getVisitFSTORECount() {
+        return visitFSTORECount;
+    }
+
+    public int getVisitFSUBCount() {
+        return visitFSUBCount;
+    }
+
+    public int getVisitGETFIELDCount() {
+        return visitGETFIELDCount;
+    }
+
+    public int getVisitGETSTATICCount() {
+        return visitGETSTATICCount;
+    }
+
+    public int getVisitGOTOCount() {
+        return visitGOTOCount;
+    }
+
+    public int getVisitGOTO_WCount() {
+        return visitGOTO_WCount;
+    }
+
+    public int getVisitGotoInstructionCount() {
+        return visitGotoInstructionCount;
+    }
+
+    public int getVisitI2BCount() {
+        return visitI2BCount;
+    }
+
+    public int getVisitI2CCount() {
+        return visitI2CCount;
+    }
+
+    public int getVisitI2DCount() {
+        return visitI2DCount;
+    }
+
+    public int getVisitI2FCount() {
+        return visitI2FCount;
+    }
+
+    public int getVisitI2LCount() {
+        return visitI2LCount;
+    }
+
+    public int getVisitI2SCount() {
+        return visitI2SCount;
+    }
+
+    public int getVisitIADDCount() {
+        return visitIADDCount;
+    }
+
+    public int getVisitIALOADCount() {
+        return visitIALOADCount;
+    }
+
+    public int getVisitIANDCount() {
+        return visitIANDCount;
+    }
+
+    public int getVisitIASTORECount() {
+        return visitIASTORECount;
+    }
+
+    public int getVisitICONSTCount() {
+        return visitICONSTCount;
+    }
+
+    public int getVisitIDIVCount() {
+        return visitIDIVCount;
+    }
+
+    public int getVisitIF_ACMPEQCount() {
+        return visitIF_ACMPEQCount;
+    }
+
+    public int getVisitIF_ACMPNECount() {
+        return visitIF_ACMPNECount;
+    }
+
+    public int getVisitIF_ICMPEQCount() {
+        return visitIF_ICMPEQCount;
+    }
+
+    public int getVisitIF_ICMPGECount() {
+        return visitIF_ICMPGECount;
+    }
+
+    public int getVisitIF_ICMPGTCount() {
+        return visitIF_ICMPGTCount;
+    }
+
+    public int getVisitIF_ICMPLECount() {
+        return visitIF_ICMPLECount;
+    }
+
+    public int getVisitIF_ICMPLTCount() {
+        return visitIF_ICMPLTCount;
+    }
+
+    public int getVisitIF_ICMPNECount() {
+        return visitIF_ICMPNECount;
+    }
+
+    public int getVisitIFEQCount() {
+        return visitIFEQCount;
+    }
+
+    public int getVisitIFGECount() {
+        return visitIFGECount;
+    }
+
+    public int getVisitIFGTCount() {
+        return visitIFGTCount;
+    }
+
+    public int getVisitIfInstructionCount() {
+        return visitIfInstructionCount;
+    }
+
+    public int getVisitIFLECount() {
+        return visitIFLECount;
+    }
+
+    public int getVisitIFLTCount() {
+        return visitIFLTCount;
+    }
+
+    public int getVisitIFNECount() {
+        return visitIFNECount;
+    }
+
+    public int getVisitIFNONNULLCount() {
+        return visitIFNONNULLCount;
+    }
+
+    public int getVisitIFNULLCount() {
+        return visitIFNULLCount;
+    }
+
+    public int getVisitIINCCount() {
+        return visitIINCCount;
+    }
+
+    public int getVisitILOADCount() {
+        return visitILOADCount;
+    }
+
+    public int getVisitIMPDEP1Count() {
+        return visitIMPDEP1Count;
+    }
+
+    public int getVisitIMPDEP2Count() {
+        return visitIMPDEP2Count;
+    }
+
+    public int getVisitIMULCount() {
+        return visitIMULCount;
+    }
+
+    public int getVisitINEGCount() {
+        return visitINEGCount;
+    }
+
+    public int getVisitINSTANCEOFCount() {
+        return visitINSTANCEOFCount;
+    }
+
+    public int getVisitINVOKEDYNAMICCount() {
+        return visitINVOKEDYNAMICCount;
+    }
+
+    public int getVisitInvokeInstructionCount() {
+        return visitInvokeInstructionCount;
+    }
+
+    public int getVisitINVOKEINTERFACECount() {
+        return visitINVOKEINTERFACECount;
+    }
+
+    public int getVisitINVOKESPECIALCount() {
+        return visitINVOKESPECIALCount;
+    }
+
+    public int getVisitINVOKESTATICCount() {
+        return visitINVOKESTATICCount;
+    }
+
+    public int getVisitINVOKEVIRTUALCount() {
+        return visitINVOKEVIRTUALCount;
+    }
+
+    public int getVisitIORCount() {
+        return visitIORCount;
+    }
+
+    public int getVisitIREMCount() {
+        return visitIREMCount;
+    }
+
+    public int getVisitIRETURNCount() {
+        return visitIRETURNCount;
+    }
+
+    public int getVisitISHLCount() {
+        return visitISHLCount;
+    }
+
+    public int getVisitISHRCount() {
+        return visitISHRCount;
+    }
+
+    public int getVisitISTORECount() {
+        return visitISTORECount;
+    }
+
+    public int getVisitISUBCount() {
+        return visitISUBCount;
+    }
+
+    public int getVisitIUSHRCount() {
+        return visitIUSHRCount;
+    }
+
+    public int getVisitIXORCount() {
+        return visitIXORCount;
+    }
+
+    public int getVisitJSRCount() {
+        return visitJSRCount;
+    }
+
+    public int getVisitJSR_WCount() {
+        return visitJSR_WCount;
+    }
+
+    public int getVisitJsrInstructionCount() {
+        return visitJsrInstructionCount;
+    }
+
+    public int getVisitL2DCount() {
+        return visitL2DCount;
+    }
+
+    public int getVisitL2FCount() {
+        return visitL2FCount;
+    }
+
+    public int getVisitL2ICount() {
+        return visitL2ICount;
+    }
+
+    public int getVisitLADDCount() {
+        return visitLADDCount;
+    }
+
+    public int getVisitLALOADCount() {
+        return visitLALOADCount;
+    }
+
+    public int getVisitLANDCount() {
+        return visitLANDCount;
+    }
+
+    public int getVisitLASTORECount() {
+        return visitLASTORECount;
+    }
+
+    public int getVisitLCMPCount() {
+        return visitLCMPCount;
+    }
+
+    public int getVisitLCONSTCount() {
+        return visitLCONSTCount;
+    }
+
+    public int getVisitLDCCount() {
+        return visitLDCCount;
+    }
+
+    public int getVisitLDC2_WCount() {
+        return visitLDC2_WCount;
+    }
+
+    public int getVisitLDIVCount() {
+        return visitLDIVCount;
+    }
+
+    public int getVisitLLOADCount() {
+        return visitLLOADCount;
+    }
+
+    public int getVisitLMULCount() {
+        return visitLMULCount;
+    }
+
+    public int getVisitLNEGCount() {
+        return visitLNEGCount;
+    }
+
+    public int getVisitLoadClassCount() {
+        return visitLoadClassCount;
+    }
+
+    public int getVisitLoadInstructionCount() {
+        return visitLoadInstructionCount;
+    }
+
+    public int getVisitLocalVariableInstructionCount() {
+        return visitLocalVariableInstructionCount;
+    }
+
+    public int getVisitLOOKUPSWITCHCount() {
+        return visitLOOKUPSWITCHCount;
+    }
+
+    public int getVisitLORCount() {
+        return visitLORCount;
+    }
+
+    public int getVisitLREMCount() {
+        return visitLREMCount;
+    }
+
+    public int getVisitLRETURNCount() {
+        return visitLRETURNCount;
+    }
+
+    public int getVisitLSHLCount() {
+        return visitLSHLCount;
+    }
+
+    public int getVisitLSHRCount() {
+        return visitLSHRCount;
+    }
+
+    public int getVisitLSTORECount() {
+        return visitLSTORECount;
+    }
+
+    public int getVisitLSUBCount() {
+        return visitLSUBCount;
+    }
+
+    public int getVisitLUSHRCount() {
+        return visitLUSHRCount;
+    }
+
+    public int getVisitLXORCount() {
+        return visitLXORCount;
+    }
+
+    public int getVisitMONITORENTERCount() {
+        return visitMONITORENTERCount;
+    }
+
+    public int getVisitMONITOREXITCount() {
+        return visitMONITOREXITCount;
+    }
+
+    public int getVisitMULTIANEWARRAYCount() {
+        return visitMULTIANEWARRAYCount;
+    }
+
+    public int getVisitNEWCount() {
+        return visitNEWCount;
+    }
+
+    public int getVisitNEWARRAYCount() {
+        return visitNEWARRAYCount;
+    }
+
+    public int getVisitNOPCount() {
+        return visitNOPCount;
+    }
+
+    public int getVisitPOPCount() {
+        return visitPOPCount;
+    }
+
+    public int getVisitPOP2Count() {
+        return visitPOP2Count;
+    }
+
+    public int getVisitPopInstructionCount() {
+        return visitPopInstructionCount;
+    }
+
+    public int getVisitPushInstructionCount() {
+        return visitPushInstructionCount;
+    }
+
+    public int getVisitPUTFIELDCount() {
+        return visitPUTFIELDCount;
+    }
+
+    public int getVisitPUTSTATICCount() {
+        return visitPUTSTATICCount;
+    }
+
+    public int getVisitRETCount() {
+        return visitRETCount;
+    }
+
+    public int getVisitRETURNCount() {
+        return visitRETURNCount;
+    }
+
+    public int getVisitReturnInstructionCount() {
+        return visitReturnInstructionCount;
+    }
+
+    public int getVisitSALOADCount() {
+        return visitSALOADCount;
+    }
+
+    public int getVisitSASTORECount() {
+        return visitSASTORECount;
+    }
+
+    public int getVisitSelectCount() {
+        return visitSelectCount;
+    }
+
+    public int getVisitSIPUSHCount() {
+        return visitSIPUSHCount;
+    }
+
+    public int getVisitStackConsumerCount() {
+        return visitStackConsumerCount;
+    }
+
+    public int getVisitStackInstructionCount() {
+        return visitStackInstructionCount;
+    }
+
+    public int getVisitStackProducerCount() {
+        return visitStackProducerCount;
+    }
+
+    public int getVisitStoreInstructionCount() {
+        return visitStoreInstructionCount;
+    }
+
+    public int getVisitSWAPCount() {
+        return visitSWAPCount;
+    }
+
+    public int getVisitTABLESWITCHCount() {
+        return visitTABLESWITCHCount;
+    }
+
+    public int getVisitTypedInstructionCount() {
+        return visitTypedInstructionCount;
+    }
+
+    public int getVisitUnconditionalBranchCount() {
+        return visitUnconditionalBranchCount;
+    }
+
+    public int getVisitVariableLengthInstructionCount() {
+        return visitVariableLengthInstructionCount;
+    }
+
+    private int visitAALOADCount = 0;
+
+    @Override
+    public void visitAALOAD(AALOAD obj) {
+        visitAALOADCount++;
+    }
+
+    private int visitAASTORECount = 0;
+
+    @Override
+    public void visitAASTORE(AASTORE obj) {
+        visitAASTORECount++;
+    }
+
+    private int visitACONST_NULLCount = 0;
+
+    @Override
+    public void visitACONST_NULL(ACONST_NULL obj) {
+        visitACONST_NULLCount++;
+    }
+
+    private int visitAllocationInstructionCount = 0;
+
+    @Override
+    public void visitAllocationInstruction(AllocationInstruction obj) {
+        visitAllocationInstructionCount++;
+    }
+
+    private int visitALOADCount = 0;
+
+    @Override
+    public void visitALOAD(ALOAD obj) {
+        visitALOADCount++;
+    }
+
+    private int visitANEWARRAYCount = 0;
+
+    @Override
+    public void visitANEWARRAY(ANEWARRAY obj) {
+        visitANEWARRAYCount++;
+    }
+
+    private int visitARETURNCount = 0;
+
+    @Override
+    public void visitARETURN(ARETURN obj) {
+        visitARETURNCount++;
+    }
+
+    private int visitArithmeticInstructionCount = 0;
+
+    @Override
+    public void visitArithmeticInstruction(ArithmeticInstruction obj) {
+        visitArithmeticInstructionCount++;
+    }
+
+    private int visitArrayInstructionCount = 0;
+
+    @Override
+    public void visitArrayInstruction(ArrayInstruction obj) {
+        visitArrayInstructionCount++;
+    }
+
+    private int visitARRAYLENGTHCount = 0;
+
+    @Override
+    public void visitARRAYLENGTH(ARRAYLENGTH obj) {
+        visitARRAYLENGTHCount++;
+    }
+
+    private int visitASTORECount = 0;
+
+    @Override
+    public void visitASTORE(ASTORE obj) {
+        visitASTORECount++;
+    }
+
+    private int visitATHROWCount = 0;
+
+    @Override
+    public void visitATHROW(ATHROW obj) {
+        visitATHROWCount++;
+    }
+
+    private int visitBALOADCount = 0;
+
+    @Override
+    public void visitBALOAD(BALOAD obj) {
+        visitBALOADCount++;
+    }
+
+    private int visitBASTORECount = 0;
+
+    @Override
+    public void visitBASTORE(BASTORE obj) {
+        visitBASTORECount++;
+    }
+
+    private int visitBIPUSHCount = 0;
+
+    @Override
+    public void visitBIPUSH(BIPUSH obj) {
+        visitBIPUSHCount++;
+    }
+
+    private int visitBranchInstructionCount = 0;
+
+    @Override
+    public void visitBranchInstruction(BranchInstruction obj) {
+        visitBranchInstructionCount++;
+    }
+
+    private int visitBREAKPOINTCount = 0;
+
+    @Override
+    public void visitBREAKPOINT(BREAKPOINT obj) {
+        visitBREAKPOINTCount++;
+    }
+
+    private int visitCALOADCount = 0;
+
+    @Override
+    public void visitCALOAD(CALOAD obj) {
+        visitCALOADCount++;
+    }
+
+    private int visitCASTORECount = 0;
+
+    @Override
+    public void visitCASTORE(CASTORE obj) {
+        visitCASTORECount++;
+    }
+
+    private int visitCHECKCASTCount = 0;
+
+    @Override
+    public void visitCHECKCAST(CHECKCAST obj) {
+        visitCHECKCASTCount++;
+    }
+
+    private int visitConstantPushInstructionCount = 0;
+
+    @Override
+    public void visitConstantPushInstruction(ConstantPushInstruction obj) {
+        visitConstantPushInstructionCount++;
+    }
+
+    private int visitConversionInstructionCount = 0;
+
+    @Override
+    public void visitConversionInstruction(ConversionInstruction obj) {
+        visitConversionInstructionCount++;
+    }
+
+    private int visitCPInstructionCount = 0;
+
+    @Override
+    public void visitCPInstruction(CPInstruction obj) {
+        visitCPInstructionCount++;
+    }
+
+    private int visitD2FCount = 0;
+
+    @Override
+    public void visitD2F(D2F obj) {
+        visitD2FCount++;
+    }
+
+    private int visitD2ICount = 0;
+
+    @Override
+    public void visitD2I(D2I obj) {
+        visitD2ICount++;
+    }
+
+    private int visitD2LCount = 0;
+
+    @Override
+    public void visitD2L(D2L obj) {
+        visitD2LCount++;
+    }
+
+    private int visitDADDCount = 0;
+
+    @Override
+    public void visitDADD(DADD obj) {
+        visitDADDCount++;
+    }
+
+    private int visitDALOADCount = 0;
+
+    @Override
+    public void visitDALOAD(DALOAD obj) {
+        visitDALOADCount++;
+    }
+
+    private int visitDASTORECount = 0;
+
+    @Override
+    public void visitDASTORE(DASTORE obj) {
+        visitDASTORECount++;
+    }
+
+    private int visitDCMPGCount = 0;
+
+    @Override
+    public void visitDCMPG(DCMPG obj) {
+        visitDCMPGCount++;
+    }
+
+    private int visitDCMPLCount = 0;
+
+    @Override
+    public void visitDCMPL(DCMPL obj) {
+        visitDCMPLCount++;
+    }
+
+    private int visitDCONSTCount = 0;
+
+    @Override
+    public void visitDCONST(DCONST obj) {
+        visitDCONSTCount++;
+    }
+
+    private int visitDDIVCount = 0;
+
+    @Override
+    public void visitDDIV(DDIV obj) {
+        visitDDIVCount++;
+    }
+
+    private int visitDLOADCount = 0;
+
+    @Override
+    public void visitDLOAD(DLOAD obj) {
+        visitDLOADCount++;
+    }
+
+    private int visitDMULCount = 0;
+
+    @Override
+    public void visitDMUL(DMUL obj) {
+        visitDMULCount++;
+    }
+
+    private int visitDNEGCount = 0;
+
+    @Override
+    public void visitDNEG(DNEG obj) {
+        visitDNEGCount++;
+    }
+
+    private int visitDREMCount = 0;
+
+    @Override
+    public void visitDREM(DREM obj) {
+        visitDREMCount++;
+    }
+
+    private int visitDRETURNCount = 0;
+
+    @Override
+    public void visitDRETURN(DRETURN obj) {
+        visitDRETURNCount++;
+    }
+
+    private int visitDSTORECount = 0;
+
+    @Override
+    public void visitDSTORE(DSTORE obj) {
+        visitDSTORECount++;
+    }
+
+    private int visitDSUBCount = 0;
+
+    @Override
+    public void visitDSUB(DSUB obj) {
+        visitDSUBCount++;
+    }
+
+    private int visitDUPCount = 0;
+
+    @Override
+    public void visitDUP(DUP obj) {
+        visitDUPCount++;
+    }
+
+    private int visitDUP_X1Count = 0;
+
+    @Override
+    public void visitDUP_X1(DUP_X1 obj) {
+        visitDUP_X1Count++;
+    }
+
+    private int visitDUP_X2Count = 0;
+
+    @Override
+    public void visitDUP_X2(DUP_X2 obj) {
+        visitDUP_X2Count++;
+    }
+
+    private int visitDUP2Count = 0;
+
+    @Override
+    public void visitDUP2(DUP2 obj) {
+        visitDUP2Count++;
+    }
+
+    private int visitDUP2_X1Count = 0;
+
+    @Override
+    public void visitDUP2_X1(DUP2_X1 obj) {
+        visitDUP2_X1Count++;
+    }
+
+    private int visitDUP2_X2Count = 0;
+
+    @Override
+    public void visitDUP2_X2(DUP2_X2 obj) {
+        visitDUP2_X2Count++;
+    }
+
+    private int visitExceptionThrowerCount = 0;
+
+    @Override
+    public void visitExceptionThrower(ExceptionThrower obj) {
+        visitExceptionThrowerCount++;
+    }
+
+    private int visitF2DCount = 0;
+
+    @Override
+    public void visitF2D(F2D obj) {
+        visitF2DCount++;
+    }
+
+    private int visitF2ICount = 0;
+
+    @Override
+    public void visitF2I(F2I obj) {
+        visitF2ICount++;
+    }
+
+    private int visitF2LCount = 0;
+
+    @Override
+    public void visitF2L(F2L obj) {
+        visitF2LCount++;
+    }
+
+    private int visitFADDCount = 0;
+
+    @Override
+    public void visitFADD(FADD obj) {
+        visitFADDCount++;
+    }
+
+    private int visitFALOADCount = 0;
+
+    @Override
+    public void visitFALOAD(FALOAD obj) {
+        visitFALOADCount++;
+    }
+
+    private int visitFASTORECount = 0;
+
+    @Override
+    public void visitFASTORE(FASTORE obj) {
+        visitFASTORECount++;
+    }
+
+    private int visitFCMPGCount = 0;
+
+    @Override
+    public void visitFCMPG(FCMPG obj) {
+        visitFCMPGCount++;
+    }
+
+    private int visitFCMPLCount = 0;
+
+    @Override
+    public void visitFCMPL(FCMPL obj) {
+        visitFCMPLCount++;
+    }
+
+    private int visitFCONSTCount = 0;
+
+    @Override
+    public void visitFCONST(FCONST obj) {
+        visitFCONSTCount++;
+    }
+
+    private int visitFDIVCount = 0;
+
+    @Override
+    public void visitFDIV(FDIV obj) {
+        visitFDIVCount++;
+    }
+
+    private int visitFieldInstructionCount = 0;
+
+    @Override
+    public void visitFieldInstruction(FieldInstruction obj) {
+        visitFieldInstructionCount++;
+    }
+
+    private int visitFieldOrMethodCount = 0;
+
+    @Override
+    public void visitFieldOrMethod(FieldOrMethod obj) {
+        visitFieldOrMethodCount++;
+    }
+
+    private int visitFLOADCount = 0;
+
+    @Override
+    public void visitFLOAD(FLOAD obj) {
+        visitFLOADCount++;
+    }
+
+    private int visitFMULCount = 0;
+
+    @Override
+    public void visitFMUL(FMUL obj) {
+        visitFMULCount++;
+    }
+
+    private int visitFNEGCount = 0;
+
+    @Override
+    public void visitFNEG(FNEG obj) {
+        visitFNEGCount++;
+    }
+
+    private int visitFREMCount = 0;
+
+    @Override
+    public void visitFREM(FREM obj) {
+        visitFREMCount++;
+    }
+
+    private int visitFRETURNCount = 0;
+
+    @Override
+    public void visitFRETURN(FRETURN obj) {
+        visitFRETURNCount++;
+    }
+
+    private int visitFSTORECount = 0;
+
+    @Override
+    public void visitFSTORE(FSTORE obj) {
+        visitFSTORECount++;
+    }
+
+    private int visitFSUBCount = 0;
+
+    @Override
+    public void visitFSUB(FSUB obj) {
+        visitFSUBCount++;
+    }
+
+    private int visitGETFIELDCount = 0;
+
+    @Override
+    public void visitGETFIELD(GETFIELD obj) {
+        visitGETFIELDCount++;
+    }
+
+    private int visitGETSTATICCount = 0;
+
+    @Override
+    public void visitGETSTATIC(GETSTATIC obj) {
+        visitGETSTATICCount++;
+    }
+
+    private int visitGOTOCount = 0;
+
+    @Override
+    public void visitGOTO(GOTO obj) {
+        visitGOTOCount++;
+    }
+
+    private int visitGOTO_WCount = 0;
+
+    @Override
+    public void visitGOTO_W(GOTO_W obj) {
+        visitGOTO_WCount++;
+    }
+
+    private int visitGotoInstructionCount = 0;
+
+    @Override
+    public void visitGotoInstruction(GotoInstruction obj) {
+        visitGotoInstructionCount++;
+    }
+
+    private int visitI2BCount = 0;
+
+    @Override
+    public void visitI2B(I2B obj) {
+        visitI2BCount++;
+    }
+
+    private int visitI2CCount = 0;
+
+    @Override
+    public void visitI2C(I2C obj) {
+        visitI2CCount++;
+    }
+
+    private int visitI2DCount = 0;
+
+    @Override
+    public void visitI2D(I2D obj) {
+        visitI2DCount++;
+    }
+
+    private int visitI2FCount = 0;
+
+    @Override
+    public void visitI2F(I2F obj) {
+        visitI2FCount++;
+    }
+
+    private int visitI2LCount = 0;
+
+    @Override
+    public void visitI2L(I2L obj) {
+        visitI2LCount++;
+    }
+
+    private int visitI2SCount = 0;
+
+    @Override
+    public void visitI2S(I2S obj) {
+        visitI2SCount++;
+    }
+
+    private int visitIADDCount = 0;
+
+    @Override
+    public void visitIADD(IADD obj) {
+        visitIADDCount++;
+    }
+
+    private int visitIALOADCount = 0;
+
+    @Override
+    public void visitIALOAD(IALOAD obj) {
+        visitIALOADCount++;
+    }
+
+    private int visitIANDCount = 0;
+
+    @Override
+    public void visitIAND(IAND obj) {
+        visitIANDCount++;
+    }
+
+    private int visitIASTORECount = 0;
+
+    @Override
+    public void visitIASTORE(IASTORE obj) {
+        visitIASTORECount++;
+    }
+
+    private int visitICONSTCount = 0;
+
+    @Override
+    public void visitICONST(ICONST obj) {
+        visitICONSTCount++;
+    }
+
+    private int visitIDIVCount = 0;
+
+    @Override
+    public void visitIDIV(IDIV obj) {
+        visitIDIVCount++;
+    }
+
+    private int visitIF_ACMPEQCount = 0;
+
+    @Override
+    public void visitIF_ACMPEQ(IF_ACMPEQ obj) {
+        visitIF_ACMPEQCount++;
+    }
+
+    private int visitIF_ACMPNECount = 0;
+
+    @Override
+    public void visitIF_ACMPNE(IF_ACMPNE obj) {
+        visitIF_ACMPNECount++;
+    }
+
+    private int visitIF_ICMPEQCount = 0;
+
+    @Override
+    public void visitIF_ICMPEQ(IF_ICMPEQ obj) {
+        visitIF_ICMPEQCount++;
+    }
+
+    private int visitIF_ICMPGECount = 0;
+
+    @Override
+    public void visitIF_ICMPGE(IF_ICMPGE obj) {
+        visitIF_ICMPGECount++;
+    }
+
+    private int visitIF_ICMPGTCount = 0;
+
+    @Override
+    public void visitIF_ICMPGT(IF_ICMPGT obj) {
+        visitIF_ICMPGTCount++;

Review Comment:
   Don't use underscores.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011810182


##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,2012 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+public class CountVisitor implements Visitor {
+
+    public int getVisitAALOADCount() {
+        return visitAALOADCount;
+    }
+
+    public int getVisitAASTORECount() {
+        return visitAASTORECount;
+    }
+
+    public int getVisitACONST_NULLCount() {
+        return visitACONST_NULLCount;
+    }
+
+    public int getVisitAllocationInstructionCount() {
+        return visitAllocationInstructionCount;
+    }
+
+    public int getVisitALOADCount() {
+        return visitALOADCount;
+    }
+
+    public int getVisitANEWARRAYCount() {
+        return visitANEWARRAYCount;
+    }
+
+    public int getVisitARETURNCount() {
+        return visitARETURNCount;
+    }
+
+    public int getVisitArithmeticInstructionCount() {
+        return visitArithmeticInstructionCount;
+    }
+
+    public int getVisitArrayInstructionCount() {
+        return visitArrayInstructionCount;
+    }
+
+    public int getVisitARRAYLENGTHCount() {
+        return visitARRAYLENGTHCount;
+    }
+
+    public int getVisitASTORECount() {
+        return visitASTORECount;
+    }
+
+    public int getVisitATHROWCount() {
+        return visitATHROWCount;
+    }
+
+    public int getVisitBALOADCount() {
+        return visitBALOADCount;
+    }
+
+    public int getVisitBASTORECount() {
+        return visitBASTORECount;
+    }
+
+    public int getVisitBIPUSHCount() {
+        return visitBIPUSHCount;
+    }
+
+    public int getVisitBranchInstructionCount() {
+        return visitBranchInstructionCount;
+    }
+
+    public int getVisitBREAKPOINTCount() {
+        return visitBREAKPOINTCount;
+    }
+
+    public int getVisitCALOADCount() {
+        return visitCALOADCount;
+    }
+
+    public int getVisitCASTORECount() {
+        return visitCASTORECount;
+    }
+
+    public int getVisitCHECKCASTCount() {
+        return visitCHECKCASTCount;
+    }
+
+    public int getVisitConstantPushInstructionCount() {
+        return visitConstantPushInstructionCount;
+    }
+
+    public int getVisitConversionInstructionCount() {
+        return visitConversionInstructionCount;
+    }
+
+    public int getVisitCPInstructionCount() {
+        return visitCPInstructionCount;
+    }
+
+    public int getVisitD2FCount() {
+        return visitD2FCount;
+    }
+
+    public int getVisitD2ICount() {
+        return visitD2ICount;
+    }
+
+    public int getVisitD2LCount() {
+        return visitD2LCount;
+    }
+
+    public int getVisitDADDCount() {
+        return visitDADDCount;
+    }
+
+    public int getVisitDALOADCount() {
+        return visitDALOADCount;
+    }
+
+    public int getVisitDASTORECount() {
+        return visitDASTORECount;
+    }
+
+    public int getVisitDCMPGCount() {
+        return visitDCMPGCount;
+    }
+
+    public int getVisitDCMPLCount() {
+        return visitDCMPLCount;
+    }
+
+    public int getVisitDCONSTCount() {
+        return visitDCONSTCount;
+    }
+
+    public int getVisitDDIVCount() {
+        return visitDDIVCount;
+    }
+
+    public int getVisitDLOADCount() {
+        return visitDLOADCount;
+    }
+
+    public int getVisitDMULCount() {
+        return visitDMULCount;
+    }
+
+    public int getVisitDNEGCount() {
+        return visitDNEGCount;
+    }
+
+    public int getVisitDREMCount() {
+        return visitDREMCount;
+    }
+
+    public int getVisitDRETURNCount() {
+        return visitDRETURNCount;
+    }
+
+    public int getVisitDSTORECount() {
+        return visitDSTORECount;
+    }
+
+    public int getVisitDSUBCount() {
+        return visitDSUBCount;
+    }
+
+    public int getVisitDUPCount() {
+        return visitDUPCount;
+    }
+
+    public int getVisitDUP_X1Count() {
+        return visitDUP_X1Count;
+    }
+
+    public int getVisitDUP_X2Count() {
+        return visitDUP_X2Count;
+    }
+
+    public int getVisitDUP2Count() {
+        return visitDUP2Count;
+    }
+
+    public int getVisitDUP2_X1Count() {
+        return visitDUP2_X1Count;
+    }
+
+    public int getVisitDUP2_X2Count() {
+        return visitDUP2_X2Count;
+    }
+
+    public int getVisitExceptionThrowerCount() {
+        return visitExceptionThrowerCount;
+    }
+
+    public int getVisitF2DCount() {
+        return visitF2DCount;
+    }
+
+    public int getVisitF2ICount() {
+        return visitF2ICount;
+    }
+
+    public int getVisitF2LCount() {
+        return visitF2LCount;
+    }
+
+    public int getVisitFADDCount() {
+        return visitFADDCount;
+    }
+
+    public int getVisitFALOADCount() {
+        return visitFALOADCount;
+    }
+
+    public int getVisitFASTORECount() {
+        return visitFASTORECount;
+    }
+
+    public int getVisitFCMPGCount() {
+        return visitFCMPGCount;
+    }
+
+    public int getVisitFCMPLCount() {
+        return visitFCMPLCount;
+    }
+
+    public int getVisitFCONSTCount() {
+        return visitFCONSTCount;
+    }
+
+    public int getVisitFDIVCount() {
+        return visitFDIVCount;
+    }
+
+    public int getVisitFieldInstructionCount() {
+        return visitFieldInstructionCount;
+    }
+
+    public int getVisitFieldOrMethodCount() {
+        return visitFieldOrMethodCount;
+    }
+
+    public int getVisitFLOADCount() {
+        return visitFLOADCount;
+    }
+
+    public int getVisitFMULCount() {
+        return visitFMULCount;
+    }
+
+    public int getVisitFNEGCount() {
+        return visitFNEGCount;
+    }
+
+    public int getVisitFREMCount() {
+        return visitFREMCount;
+    }
+
+    public int getVisitFRETURNCount() {
+        return visitFRETURNCount;
+    }
+
+    public int getVisitFSTORECount() {
+        return visitFSTORECount;
+    }
+
+    public int getVisitFSUBCount() {
+        return visitFSUBCount;
+    }
+
+    public int getVisitGETFIELDCount() {
+        return visitGETFIELDCount;
+    }
+
+    public int getVisitGETSTATICCount() {
+        return visitGETSTATICCount;
+    }
+
+    public int getVisitGOTOCount() {
+        return visitGOTOCount;
+    }
+
+    public int getVisitGOTO_WCount() {
+        return visitGOTO_WCount;
+    }
+
+    public int getVisitGotoInstructionCount() {
+        return visitGotoInstructionCount;
+    }
+
+    public int getVisitI2BCount() {
+        return visitI2BCount;
+    }
+
+    public int getVisitI2CCount() {
+        return visitI2CCount;
+    }
+
+    public int getVisitI2DCount() {
+        return visitI2DCount;
+    }
+
+    public int getVisitI2FCount() {
+        return visitI2FCount;
+    }
+
+    public int getVisitI2LCount() {
+        return visitI2LCount;
+    }
+
+    public int getVisitI2SCount() {
+        return visitI2SCount;
+    }
+
+    public int getVisitIADDCount() {
+        return visitIADDCount;
+    }
+
+    public int getVisitIALOADCount() {
+        return visitIALOADCount;
+    }
+
+    public int getVisitIANDCount() {
+        return visitIANDCount;
+    }
+
+    public int getVisitIASTORECount() {
+        return visitIASTORECount;
+    }
+
+    public int getVisitICONSTCount() {
+        return visitICONSTCount;
+    }
+
+    public int getVisitIDIVCount() {
+        return visitIDIVCount;
+    }
+
+    public int getVisitIF_ACMPEQCount() {
+        return visitIF_ACMPEQCount;
+    }
+
+    public int getVisitIF_ACMPNECount() {
+        return visitIF_ACMPNECount;
+    }
+
+    public int getVisitIF_ICMPEQCount() {
+        return visitIF_ICMPEQCount;
+    }
+
+    public int getVisitIF_ICMPGECount() {
+        return visitIF_ICMPGECount;
+    }
+
+    public int getVisitIF_ICMPGTCount() {
+        return visitIF_ICMPGTCount;
+    }
+
+    public int getVisitIF_ICMPLECount() {
+        return visitIF_ICMPLECount;
+    }
+
+    public int getVisitIF_ICMPLTCount() {
+        return visitIF_ICMPLTCount;
+    }
+
+    public int getVisitIF_ICMPNECount() {
+        return visitIF_ICMPNECount;
+    }
+
+    public int getVisitIFEQCount() {
+        return visitIFEQCount;
+    }
+
+    public int getVisitIFGECount() {
+        return visitIFGECount;
+    }
+
+    public int getVisitIFGTCount() {
+        return visitIFGTCount;
+    }
+
+    public int getVisitIfInstructionCount() {
+        return visitIfInstructionCount;
+    }
+
+    public int getVisitIFLECount() {
+        return visitIFLECount;
+    }
+
+    public int getVisitIFLTCount() {
+        return visitIFLTCount;
+    }
+
+    public int getVisitIFNECount() {
+        return visitIFNECount;
+    }
+
+    public int getVisitIFNONNULLCount() {
+        return visitIFNONNULLCount;
+    }
+
+    public int getVisitIFNULLCount() {
+        return visitIFNULLCount;
+    }
+
+    public int getVisitIINCCount() {
+        return visitIINCCount;
+    }
+
+    public int getVisitILOADCount() {
+        return visitILOADCount;
+    }
+
+    public int getVisitIMPDEP1Count() {
+        return visitIMPDEP1Count;
+    }
+
+    public int getVisitIMPDEP2Count() {
+        return visitIMPDEP2Count;
+    }
+
+    public int getVisitIMULCount() {
+        return visitIMULCount;
+    }
+
+    public int getVisitINEGCount() {
+        return visitINEGCount;
+    }
+
+    public int getVisitINSTANCEOFCount() {
+        return visitINSTANCEOFCount;
+    }
+
+    public int getVisitINVOKEDYNAMICCount() {
+        return visitINVOKEDYNAMICCount;
+    }
+
+    public int getVisitInvokeInstructionCount() {
+        return visitInvokeInstructionCount;
+    }
+
+    public int getVisitINVOKEINTERFACECount() {
+        return visitINVOKEINTERFACECount;
+    }
+
+    public int getVisitINVOKESPECIALCount() {
+        return visitINVOKESPECIALCount;
+    }
+
+    public int getVisitINVOKESTATICCount() {
+        return visitINVOKESTATICCount;
+    }
+
+    public int getVisitINVOKEVIRTUALCount() {
+        return visitINVOKEVIRTUALCount;
+    }
+
+    public int getVisitIORCount() {
+        return visitIORCount;
+    }
+
+    public int getVisitIREMCount() {
+        return visitIREMCount;
+    }
+
+    public int getVisitIRETURNCount() {
+        return visitIRETURNCount;
+    }
+
+    public int getVisitISHLCount() {
+        return visitISHLCount;
+    }
+
+    public int getVisitISHRCount() {
+        return visitISHRCount;
+    }
+
+    public int getVisitISTORECount() {
+        return visitISTORECount;
+    }
+
+    public int getVisitISUBCount() {
+        return visitISUBCount;
+    }
+
+    public int getVisitIUSHRCount() {
+        return visitIUSHRCount;
+    }
+
+    public int getVisitIXORCount() {
+        return visitIXORCount;
+    }
+
+    public int getVisitJSRCount() {
+        return visitJSRCount;
+    }
+
+    public int getVisitJSR_WCount() {
+        return visitJSR_WCount;
+    }
+
+    public int getVisitJsrInstructionCount() {
+        return visitJsrInstructionCount;
+    }
+
+    public int getVisitL2DCount() {
+        return visitL2DCount;
+    }
+
+    public int getVisitL2FCount() {
+        return visitL2FCount;
+    }
+
+    public int getVisitL2ICount() {
+        return visitL2ICount;
+    }
+
+    public int getVisitLADDCount() {
+        return visitLADDCount;
+    }
+
+    public int getVisitLALOADCount() {
+        return visitLALOADCount;
+    }
+
+    public int getVisitLANDCount() {
+        return visitLANDCount;
+    }
+
+    public int getVisitLASTORECount() {
+        return visitLASTORECount;
+    }
+
+    public int getVisitLCMPCount() {
+        return visitLCMPCount;
+    }
+
+    public int getVisitLCONSTCount() {
+        return visitLCONSTCount;
+    }
+
+    public int getVisitLDCCount() {
+        return visitLDCCount;
+    }
+
+    public int getVisitLDC2_WCount() {
+        return visitLDC2_WCount;
+    }
+
+    public int getVisitLDIVCount() {
+        return visitLDIVCount;
+    }
+
+    public int getVisitLLOADCount() {
+        return visitLLOADCount;
+    }
+
+    public int getVisitLMULCount() {
+        return visitLMULCount;
+    }
+
+    public int getVisitLNEGCount() {
+        return visitLNEGCount;
+    }
+
+    public int getVisitLoadClassCount() {
+        return visitLoadClassCount;
+    }
+
+    public int getVisitLoadInstructionCount() {
+        return visitLoadInstructionCount;
+    }
+
+    public int getVisitLocalVariableInstructionCount() {
+        return visitLocalVariableInstructionCount;
+    }
+
+    public int getVisitLOOKUPSWITCHCount() {
+        return visitLOOKUPSWITCHCount;
+    }
+
+    public int getVisitLORCount() {
+        return visitLORCount;
+    }
+
+    public int getVisitLREMCount() {
+        return visitLREMCount;
+    }
+
+    public int getVisitLRETURNCount() {
+        return visitLRETURNCount;
+    }
+
+    public int getVisitLSHLCount() {
+        return visitLSHLCount;
+    }
+
+    public int getVisitLSHRCount() {
+        return visitLSHRCount;
+    }
+
+    public int getVisitLSTORECount() {
+        return visitLSTORECount;
+    }
+
+    public int getVisitLSUBCount() {
+        return visitLSUBCount;
+    }
+
+    public int getVisitLUSHRCount() {
+        return visitLUSHRCount;
+    }
+
+    public int getVisitLXORCount() {
+        return visitLXORCount;
+    }
+
+    public int getVisitMONITORENTERCount() {
+        return visitMONITORENTERCount;
+    }
+
+    public int getVisitMONITOREXITCount() {
+        return visitMONITOREXITCount;
+    }
+
+    public int getVisitMULTIANEWARRAYCount() {
+        return visitMULTIANEWARRAYCount;
+    }
+
+    public int getVisitNEWCount() {
+        return visitNEWCount;
+    }
+
+    public int getVisitNEWARRAYCount() {
+        return visitNEWARRAYCount;
+    }
+
+    public int getVisitNOPCount() {
+        return visitNOPCount;
+    }
+
+    public int getVisitPOPCount() {
+        return visitPOPCount;
+    }
+
+    public int getVisitPOP2Count() {
+        return visitPOP2Count;
+    }
+
+    public int getVisitPopInstructionCount() {
+        return visitPopInstructionCount;
+    }
+
+    public int getVisitPushInstructionCount() {
+        return visitPushInstructionCount;
+    }
+
+    public int getVisitPUTFIELDCount() {
+        return visitPUTFIELDCount;
+    }
+
+    public int getVisitPUTSTATICCount() {
+        return visitPUTSTATICCount;
+    }
+
+    public int getVisitRETCount() {
+        return visitRETCount;
+    }
+
+    public int getVisitRETURNCount() {
+        return visitRETURNCount;
+    }
+
+    public int getVisitReturnInstructionCount() {
+        return visitReturnInstructionCount;
+    }
+
+    public int getVisitSALOADCount() {
+        return visitSALOADCount;
+    }
+
+    public int getVisitSASTORECount() {
+        return visitSASTORECount;
+    }
+
+    public int getVisitSelectCount() {
+        return visitSelectCount;
+    }
+
+    public int getVisitSIPUSHCount() {
+        return visitSIPUSHCount;
+    }
+
+    public int getVisitStackConsumerCount() {
+        return visitStackConsumerCount;
+    }
+
+    public int getVisitStackInstructionCount() {
+        return visitStackInstructionCount;
+    }
+
+    public int getVisitStackProducerCount() {
+        return visitStackProducerCount;
+    }
+
+    public int getVisitStoreInstructionCount() {
+        return visitStoreInstructionCount;
+    }
+
+    public int getVisitSWAPCount() {
+        return visitSWAPCount;
+    }
+
+    public int getVisitTABLESWITCHCount() {
+        return visitTABLESWITCHCount;
+    }
+
+    public int getVisitTypedInstructionCount() {
+        return visitTypedInstructionCount;
+    }
+
+    public int getVisitUnconditionalBranchCount() {
+        return visitUnconditionalBranchCount;
+    }
+
+    public int getVisitVariableLengthInstructionCount() {
+        return visitVariableLengthInstructionCount;
+    }
+
+    private int visitAALOADCount = 0;

Review Comment:
   Don't initialize values to their default values.
   Group all instance variable declarations at the top of the file, see the rest of the code base.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1012389784


##########
src/test/java/org/apache/bcel/classfile/UtilityTestCase.java:
##########
@@ -59,4 +63,70 @@ public void testSignatureToStringWithGenerics() throws Exception {
         assertEquals("<K extends Object, V extends Object> extends Object",
             Utility.signatureToString("<K:Ljava/lang/Object;V:Ljava/lang/Object;>Ljava/lang/Object;"), "class signature");
     }
+
+    @Test
+    public void testClearBit() {
+        assertEquals(0, Utility.clearBit(0, 0));
+        assertEquals(0, Utility.clearBit(1, 0), "1 bit 0 set to 0 -> 0");
+        assertEquals(1, Utility.clearBit(1, 1), "1 bit 1 is 0 hence no change");
+        assertEquals(8, Utility.clearBit(8, 4), "1000 only has 4 bit hence no change");
+        assertEquals(1, Utility.clearBit(9, 3), "1001 bit 3 set to 0 -> 0001");
+        assertEquals(-2, Utility.clearBit(-1, 0), "111...11 set bit 0 to 0 -> 111..10");
+        assertEquals(0, Utility.clearBit(Integer.MIN_VALUE, 31), "100...00 set bit 31 to 0 -> 000..00");
+    }
+
+    @Test
+    public void testSetBit() {
+        assertEquals(1, Utility.setBit(0, 0), "0 bit 0 set to 1 -> 1");
+        assertEquals(1, Utility.setBit(1, 0), "1 bit 0 is 1 hence no change");
+        assertEquals(3, Utility.setBit(1, 1), "1 bit 1 set to 1 -> 3");
+        assertEquals(8, Utility.setBit(8, 3), "1000 bit 3 is 1 hence no change");
+        assertEquals(9, Utility.setBit(1, 3), "0001 bit 3 set to 1 -> 1001");
+        assertEquals(-1, Utility.setBit(-2, 0), "111...10 set bit 0 to 1 -> 111..11");
+        assertEquals(Integer.MIN_VALUE, Utility.setBit(0, 31), "000...00 set bit 31 to 0 -> 100..00");
+    }
+
+    @Test
+    public void testIsSet() {
+        assertTrue(Utility.isSet(1, 0));
+        assertTrue(Utility.isSet(7, 1));
+        assertTrue(Utility.isSet(8, 3));
+        assertTrue(Utility.isSet(9, 0));
+        assertTrue(Utility.isSet(Integer.MIN_VALUE, 31));
+        assertFalse(Utility.isSet(0, 0));
+        assertFalse(Utility.isSet(8, 4));
+        assertFalse(Utility.isSet(9, 1));
+    }
+
+    @Test
+    public void testConvertString() {
+        assertEquals("\\n", Utility.convertString("\n"));
+        assertEquals("\\r", Utility.convertString("\r"));
+        assertEquals("\\\"", Utility.convertString("\""));
+        assertEquals("\\\'", Utility.convertString("\'"));
+        assertEquals("\\\\", Utility.convertString("\\"));
+        assertEquals("abc", Utility.convertString("abc"));
+    }
+
+    @Test
+    public void testPrintArray() {
+        assertEquals(null, Utility.printArray(null, false, false));
+        assertEquals("", Utility.printArray(new Object[0], false, false));
+        assertEquals("{}", Utility.printArray(new Object[0], true, false));
+        assertEquals("null", Utility.printArray(new Object[]{null}, false, false));
+        assertEquals("a, b", Utility.printArray(new String[]{"a", "b"}, false, false));
+        assertEquals("{a, b}", Utility.printArray(new String[]{"a", "b"}, true, false));
+        assertEquals("\"a\", \"b\"", Utility.printArray(new String[]{"a", "b"}, false, true));
+        assertEquals("{\"a\", \"b\"}", Utility.printArray(new String[]{"a", "b"}, true, true));
+    }
+
+    @Test
+    public void testSearchOpcode() {
+        assertEquals(Const.ALOAD,Utility.searchOpcode("aload"));

Review Comment:
   Fix formatting, space missing after commas.



##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,3118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import java.util.Objects;
+
+public class CountVisitor implements Visitor {
+
+    private int visitAALOADCount;
+    private int visitAASTORECount;
+    private int visitACONST_NULLCount;
+    private int visitAllocationInstructionCount;
+    private int visitALOADCount;
+    private int visitANEWARRAYCount;
+    private int visitARETURNCount;
+    private int visitArithmeticInstructionCount;
+    private int visitArrayInstructionCount;
+    private int visitARRAYLENGTHCount;
+    private int visitASTORECount;
+    private int visitATHROWCount;
+    private int visitBALOADCount;
+    private int visitBASTORECount;
+    private int visitBIPUSHCount;
+    private int visitBranchInstructionCount;
+    private int visitBREAKPOINTCount;
+    private int visitCALOADCount;
+    private int visitCASTORECount;
+    private int visitCHECKCASTCount;
+    private int visitConstantPushInstructionCount;
+    private int visitConversionInstructionCount;
+    private int visitCPInstructionCount;
+    private int visitD2FCount;
+    private int visitD2ICount;
+    private int visitD2LCount;
+    private int visitDADDCount;
+    private int visitDALOADCount;
+    private int visitDASTORECount;
+    private int visitDCMPGCount;
+    private int visitDCMPLCount;
+    private int visitDCONSTCount;
+    private int visitDDIVCount;
+    private int visitDLOADCount;
+    private int visitDMULCount;
+    private int visitDNEGCount;
+    private int visitDREMCount;
+    private int visitDRETURNCount;
+    private int visitDSTORECount;
+    private int visitDSUBCount;
+    private int visitDUPCount;
+    private int visitDUP_X1Count;
+    private int visitDUP_X2Count;
+    private int visitDUP2Count;
+    private int visitDUP2_X1Count;
+    private int visitDUP2_X2Count;
+    private int visitExceptionThrowerCount;
+    private int visitF2DCount;
+    private int visitF2ICount;
+    private int visitF2LCount;
+    private int visitFADDCount;
+    private int visitFALOADCount;
+    private int visitFASTORECount;
+    private int visitFCMPGCount;
+    private int visitFCMPLCount;
+    private int visitFCONSTCount;
+    private int visitFDIVCount;
+    private int visitFieldInstructionCount;
+    private int visitFieldOrMethodCount;
+    private int visitFLOADCount;
+    private int visitFMULCount;
+    private int visitFNEGCount;
+    private int visitFREMCount;
+    private int visitFRETURNCount;
+    private int visitFSTORECount;
+    private int visitFSUBCount;
+    private int visitGETFIELDCount;
+    private int visitGETSTATICCount;
+    private int visitGOTOCount;
+    private int visitGOTO_WCount;
+    private int visitGotoInstructionCount;
+    private int visitI2BCount;
+    private int visitI2CCount;
+    private int visitI2DCount;
+    private int visitI2FCount;
+    private int visitI2LCount;
+    private int visitI2SCount;
+    private int visitIADDCount;
+    private int visitIALOADCount;
+    private int visitIANDCount;
+    private int visitIASTORECount;
+    private int visitICONSTCount;
+    private int visitIDIVCount;
+    private int visitIF_ACMPEQCount;
+    private int visitIF_ACMPNECount;
+    private int visitIF_ICMPEQCount;
+    private int visitIF_ICMPGECount;
+    private int visitIF_ICMPGTCount;
+    private int visitIF_ICMPLECount;
+    private int visitIF_ICMPLTCount;
+    private int visitIF_ICMPNECount;
+    private int visitIFEQCount;
+    private int visitIFGECount;
+    private int visitIFGTCount;
+    private int visitIfInstructionCount;
+    private int visitIFLECount;
+    private int visitIFLTCount;
+    private int visitIFNECount;
+    private int visitIFNONNULLCount;
+    private int visitIFNULLCount;
+    private int visitIINCCount;
+    private int visitILOADCount;
+    private int visitIMPDEP1Count;
+    private int visitIMPDEP2Count;
+    private int visitIMULCount;
+    private int visitINEGCount;
+    private int visitINSTANCEOFCount;
+    private int visitINVOKEDYNAMICCount;
+    private int visitInvokeInstructionCount;
+    private int visitINVOKEINTERFACECount;
+    private int visitINVOKESPECIALCount;
+    private int visitINVOKESTATICCount;
+    private int visitINVOKEVIRTUALCount;
+    private int visitIORCount;
+    private int visitIREMCount;
+    private int visitIRETURNCount;
+    private int visitISHLCount;
+    private int visitISHRCount;
+    private int visitISTORECount;
+    private int visitISUBCount;
+    private int visitIUSHRCount;
+    private int visitIXORCount;
+    private int visitJSRCount;
+    private int visitJSR_WCount;
+    private int visitJsrInstructionCount;
+    private int visitL2DCount;
+    private int visitL2FCount;
+    private int visitL2ICount;
+    private int visitLADDCount;
+    private int visitLALOADCount;
+    private int visitLANDCount;
+    private int visitLASTORECount;
+    private int visitLCMPCount;
+    private int visitLCONSTCount;
+    private int visitLDCCount;
+    private int visitLDC2_WCount;
+    private int visitLDIVCount;
+    private int visitLLOADCount;
+    private int visitLMULCount;
+    private int visitLNEGCount;
+    private int visitLoadClassCount;
+    private int visitLoadInstructionCount;
+    private int visitLocalVariableInstructionCount;
+    private int visitLOOKUPSWITCHCount;
+    private int visitLORCount;
+    private int visitLREMCount;
+    private int visitLRETURNCount;
+    private int visitLSHLCount;
+    private int visitLSHRCount;
+    private int visitLSTORECount;
+    private int visitLSUBCount;
+    private int visitLUSHRCount;
+    private int visitLXORCount;
+    private int visitMONITORENTERCount;
+    private int visitMONITOREXITCount;
+    private int visitMULTIANEWARRAYCount;
+    private int visitNEWCount;
+    private int visitNEWARRAYCount;
+    private int visitNOPCount;
+    private int visitPOPCount;
+    private int visitPOP2Count;
+    private int visitPopInstructionCount;
+    private int visitPushInstructionCount;
+    private int visitPUTFIELDCount;
+    private int visitPUTSTATICCount;
+    private int visitRETCount;
+    private int visitRETURNCount;
+    private int visitReturnInstructionCount;
+    private int visitSALOADCount;
+    private int visitSASTORECount;
+    private int visitSelectCount;
+    private int visitSIPUSHCount;
+    private int visitStackConsumerCount;
+    private int visitStackInstructionCount;
+    private int visitStackProducerCount;
+    private int visitStoreInstructionCount;
+    private int visitSWAPCount;
+    private int visitTABLESWITCHCount;
+    private int visitTypedInstructionCount;
+    private int visitUnconditionalBranchCount;
+    private int visitVariableLengthInstructionCount;
+
+    public int getVisitAALOADCount() {
+        return visitAALOADCount;
+    }
+
+    public void setVisitAALOADCount(int visitAALOADCount) {
+        this.visitAALOADCount = visitAALOADCount;
+    }
+
+    public int getVisitAASTORECount() {
+        return visitAASTORECount;
+    }
+
+    public void setVisitAASTORECount(int visitAASTORECount) {
+        this.visitAASTORECount = visitAASTORECount;
+    }
+
+    public int getVisitACONST_NULLCount() {
+        return visitACONST_NULLCount;
+    }
+
+    public void setVisitACONST_NULLCount(int visitACONST_NULLCount) {
+        this.visitACONST_NULLCount = visitACONST_NULLCount;
+    }
+
+    public int getVisitAllocationInstructionCount() {
+        return visitAllocationInstructionCount;
+    }
+
+    public void setVisitAllocationInstructionCount(int visitAllocationInstructionCount) {
+        this.visitAllocationInstructionCount = visitAllocationInstructionCount;
+    }
+
+    public int getVisitALOADCount() {
+        return visitALOADCount;
+    }
+
+    public void setVisitALOADCount(int visitALOADCount) {
+        this.visitALOADCount = visitALOADCount;
+    }
+
+    public int getVisitANEWARRAYCount() {
+        return visitANEWARRAYCount;
+    }
+
+    public void setVisitANEWARRAYCount(int visitANEWARRAYCount) {
+        this.visitANEWARRAYCount = visitANEWARRAYCount;
+    }
+
+    public int getVisitARETURNCount() {
+        return visitARETURNCount;
+    }
+
+    public void setVisitARETURNCount(int visitARETURNCount) {
+        this.visitARETURNCount = visitARETURNCount;
+    }
+
+    public int getVisitArithmeticInstructionCount() {
+        return visitArithmeticInstructionCount;
+    }
+
+    public void setVisitArithmeticInstructionCount(int visitArithmeticInstructionCount) {
+        this.visitArithmeticInstructionCount = visitArithmeticInstructionCount;
+    }
+
+    public int getVisitArrayInstructionCount() {
+        return visitArrayInstructionCount;
+    }
+
+    public void setVisitArrayInstructionCount(int visitArrayInstructionCount) {
+        this.visitArrayInstructionCount = visitArrayInstructionCount;
+    }
+
+    public int getVisitARRAYLENGTHCount() {
+        return visitARRAYLENGTHCount;
+    }
+
+    public void setVisitARRAYLENGTHCount(int visitARRAYLENGTHCount) {
+        this.visitARRAYLENGTHCount = visitARRAYLENGTHCount;
+    }
+
+    public int getVisitASTORECount() {
+        return visitASTORECount;
+    }
+
+    public void setVisitASTORECount(int visitASTORECount) {
+        this.visitASTORECount = visitASTORECount;
+    }
+
+    public int getVisitATHROWCount() {
+        return visitATHROWCount;
+    }
+
+    public void setVisitATHROWCount(int visitATHROWCount) {
+        this.visitATHROWCount = visitATHROWCount;
+    }
+
+    public int getVisitBALOADCount() {
+        return visitBALOADCount;
+    }
+
+    public void setVisitBALOADCount(int visitBALOADCount) {
+        this.visitBALOADCount = visitBALOADCount;
+    }
+
+    public int getVisitBASTORECount() {
+        return visitBASTORECount;
+    }
+
+    public void setVisitBASTORECount(int visitBASTORECount) {
+        this.visitBASTORECount = visitBASTORECount;
+    }
+
+    public int getVisitBIPUSHCount() {
+        return visitBIPUSHCount;
+    }
+
+    public void setVisitBIPUSHCount(int visitBIPUSHCount) {
+        this.visitBIPUSHCount = visitBIPUSHCount;
+    }
+
+    public int getVisitBranchInstructionCount() {
+        return visitBranchInstructionCount;
+    }
+
+    public void setVisitBranchInstructionCount(int visitBranchInstructionCount) {
+        this.visitBranchInstructionCount = visitBranchInstructionCount;
+    }
+
+    public int getVisitBREAKPOINTCount() {
+        return visitBREAKPOINTCount;
+    }
+
+    public void setVisitBREAKPOINTCount(int visitBREAKPOINTCount) {
+        this.visitBREAKPOINTCount = visitBREAKPOINTCount;
+    }
+
+    public int getVisitCALOADCount() {
+        return visitCALOADCount;
+    }
+
+    public void setVisitCALOADCount(int visitCALOADCount) {
+        this.visitCALOADCount = visitCALOADCount;
+    }
+
+    public int getVisitCASTORECount() {
+        return visitCASTORECount;
+    }
+
+    public void setVisitCASTORECount(int visitCASTORECount) {
+        this.visitCASTORECount = visitCASTORECount;
+    }
+
+    public int getVisitCHECKCASTCount() {
+        return visitCHECKCASTCount;
+    }
+
+    public void setVisitCHECKCASTCount(int visitCHECKCASTCount) {
+        this.visitCHECKCASTCount = visitCHECKCASTCount;
+    }
+
+    public int getVisitConstantPushInstructionCount() {
+        return visitConstantPushInstructionCount;
+    }
+
+    public void setVisitConstantPushInstructionCount(int visitConstantPushInstructionCount) {
+        this.visitConstantPushInstructionCount = visitConstantPushInstructionCount;
+    }
+
+    public int getVisitConversionInstructionCount() {
+        return visitConversionInstructionCount;
+    }
+
+    public void setVisitConversionInstructionCount(int visitConversionInstructionCount) {
+        this.visitConversionInstructionCount = visitConversionInstructionCount;
+    }
+
+    public int getVisitCPInstructionCount() {
+        return visitCPInstructionCount;
+    }
+
+    public void setVisitCPInstructionCount(int visitCPInstructionCount) {
+        this.visitCPInstructionCount = visitCPInstructionCount;
+    }
+
+    public int getVisitD2FCount() {
+        return visitD2FCount;
+    }
+
+    public void setVisitD2FCount(int visitD2FCount) {
+        this.visitD2FCount = visitD2FCount;
+    }
+
+    public int getVisitD2ICount() {
+        return visitD2ICount;
+    }
+
+    public void setVisitD2ICount(int visitD2ICount) {
+        this.visitD2ICount = visitD2ICount;
+    }
+
+    public int getVisitD2LCount() {
+        return visitD2LCount;
+    }
+
+    public void setVisitD2LCount(int visitD2LCount) {
+        this.visitD2LCount = visitD2LCount;
+    }
+
+    public int getVisitDADDCount() {
+        return visitDADDCount;
+    }
+
+    public void setVisitDADDCount(int visitDADDCount) {
+        this.visitDADDCount = visitDADDCount;
+    }
+
+    public int getVisitDALOADCount() {
+        return visitDALOADCount;
+    }
+
+    public void setVisitDALOADCount(int visitDALOADCount) {
+        this.visitDALOADCount = visitDALOADCount;
+    }
+
+    public int getVisitDASTORECount() {
+        return visitDASTORECount;
+    }
+
+    public void setVisitDASTORECount(int visitDASTORECount) {
+        this.visitDASTORECount = visitDASTORECount;
+    }
+
+    public int getVisitDCMPGCount() {
+        return visitDCMPGCount;
+    }
+
+    public void setVisitDCMPGCount(int visitDCMPGCount) {
+        this.visitDCMPGCount = visitDCMPGCount;
+    }
+
+    public int getVisitDCMPLCount() {
+        return visitDCMPLCount;
+    }
+
+    public void setVisitDCMPLCount(int visitDCMPLCount) {
+        this.visitDCMPLCount = visitDCMPLCount;
+    }
+
+    public int getVisitDCONSTCount() {
+        return visitDCONSTCount;
+    }
+
+    public void setVisitDCONSTCount(int visitDCONSTCount) {
+        this.visitDCONSTCount = visitDCONSTCount;
+    }
+
+    public int getVisitDDIVCount() {
+        return visitDDIVCount;
+    }
+
+    public void setVisitDDIVCount(int visitDDIVCount) {
+        this.visitDDIVCount = visitDDIVCount;
+    }
+
+    public int getVisitDLOADCount() {
+        return visitDLOADCount;
+    }
+
+    public void setVisitDLOADCount(int visitDLOADCount) {
+        this.visitDLOADCount = visitDLOADCount;
+    }
+
+    public int getVisitDMULCount() {
+        return visitDMULCount;
+    }
+
+    public void setVisitDMULCount(int visitDMULCount) {
+        this.visitDMULCount = visitDMULCount;
+    }
+
+    public int getVisitDNEGCount() {
+        return visitDNEGCount;
+    }
+
+    public void setVisitDNEGCount(int visitDNEGCount) {
+        this.visitDNEGCount = visitDNEGCount;
+    }
+
+    public int getVisitDREMCount() {
+        return visitDREMCount;
+    }
+
+    public void setVisitDREMCount(int visitDREMCount) {
+        this.visitDREMCount = visitDREMCount;
+    }
+
+    public int getVisitDRETURNCount() {
+        return visitDRETURNCount;
+    }
+
+    public void setVisitDRETURNCount(int visitDRETURNCount) {
+        this.visitDRETURNCount = visitDRETURNCount;
+    }
+
+    public int getVisitDSTORECount() {
+        return visitDSTORECount;
+    }
+
+    public void setVisitDSTORECount(int visitDSTORECount) {
+        this.visitDSTORECount = visitDSTORECount;
+    }
+
+    public int getVisitDSUBCount() {
+        return visitDSUBCount;
+    }
+
+    public void setVisitDSUBCount(int visitDSUBCount) {
+        this.visitDSUBCount = visitDSUBCount;
+    }
+
+    public int getVisitDUPCount() {
+        return visitDUPCount;
+    }
+
+    public void setVisitDUPCount(int visitDUPCount) {
+        this.visitDUPCount = visitDUPCount;
+    }
+
+    public int getVisitDUP_X1Count() {
+        return visitDUP_X1Count;
+    }
+
+    public void setVisitDUP_X1Count(int visitDUP_X1Count) {
+        this.visitDUP_X1Count = visitDUP_X1Count;
+    }
+
+    public int getVisitDUP_X2Count() {
+        return visitDUP_X2Count;
+    }
+
+    public void setVisitDUP_X2Count(int visitDUP_X2Count) {
+        this.visitDUP_X2Count = visitDUP_X2Count;
+    }
+
+    public int getVisitDUP2Count() {
+        return visitDUP2Count;
+    }
+
+    public void setVisitDUP2Count(int visitDUP2Count) {
+        this.visitDUP2Count = visitDUP2Count;
+    }
+
+    public int getVisitDUP2_X1Count() {
+        return visitDUP2_X1Count;
+    }
+
+    public void setVisitDUP2_X1Count(int visitDUP2_X1Count) {
+        this.visitDUP2_X1Count = visitDUP2_X1Count;
+    }
+
+    public int getVisitDUP2_X2Count() {
+        return visitDUP2_X2Count;
+    }
+
+    public void setVisitDUP2_X2Count(int visitDUP2_X2Count) {
+        this.visitDUP2_X2Count = visitDUP2_X2Count;
+    }
+
+    public int getVisitExceptionThrowerCount() {
+        return visitExceptionThrowerCount;
+    }
+
+    public void setVisitExceptionThrowerCount(int visitExceptionThrowerCount) {
+        this.visitExceptionThrowerCount = visitExceptionThrowerCount;
+    }
+
+    public int getVisitF2DCount() {
+        return visitF2DCount;
+    }
+
+    public void setVisitF2DCount(int visitF2DCount) {
+        this.visitF2DCount = visitF2DCount;
+    }
+
+    public int getVisitF2ICount() {
+        return visitF2ICount;
+    }
+
+    public void setVisitF2ICount(int visitF2ICount) {
+        this.visitF2ICount = visitF2ICount;
+    }
+
+    public int getVisitF2LCount() {
+        return visitF2LCount;
+    }
+
+    public void setVisitF2LCount(int visitF2LCount) {
+        this.visitF2LCount = visitF2LCount;
+    }
+
+    public int getVisitFADDCount() {
+        return visitFADDCount;
+    }
+
+    public void setVisitFADDCount(int visitFADDCount) {
+        this.visitFADDCount = visitFADDCount;
+    }
+
+    public int getVisitFALOADCount() {
+        return visitFALOADCount;
+    }
+
+    public void setVisitFALOADCount(int visitFALOADCount) {
+        this.visitFALOADCount = visitFALOADCount;
+    }
+
+    public int getVisitFASTORECount() {
+        return visitFASTORECount;
+    }
+
+    public void setVisitFASTORECount(int visitFASTORECount) {
+        this.visitFASTORECount = visitFASTORECount;
+    }
+
+    public int getVisitFCMPGCount() {
+        return visitFCMPGCount;
+    }
+
+    public void setVisitFCMPGCount(int visitFCMPGCount) {
+        this.visitFCMPGCount = visitFCMPGCount;
+    }
+
+    public int getVisitFCMPLCount() {
+        return visitFCMPLCount;
+    }
+
+    public void setVisitFCMPLCount(int visitFCMPLCount) {
+        this.visitFCMPLCount = visitFCMPLCount;
+    }
+
+    public int getVisitFCONSTCount() {
+        return visitFCONSTCount;
+    }
+
+    public void setVisitFCONSTCount(int visitFCONSTCount) {
+        this.visitFCONSTCount = visitFCONSTCount;
+    }
+
+    public int getVisitFDIVCount() {
+        return visitFDIVCount;
+    }
+
+    public void setVisitFDIVCount(int visitFDIVCount) {
+        this.visitFDIVCount = visitFDIVCount;
+    }
+
+    public int getVisitFieldInstructionCount() {
+        return visitFieldInstructionCount;
+    }
+
+    public void setVisitFieldInstructionCount(int visitFieldInstructionCount) {
+        this.visitFieldInstructionCount = visitFieldInstructionCount;
+    }
+
+    public int getVisitFieldOrMethodCount() {
+        return visitFieldOrMethodCount;
+    }
+
+    public void setVisitFieldOrMethodCount(int visitFieldOrMethodCount) {
+        this.visitFieldOrMethodCount = visitFieldOrMethodCount;
+    }
+
+    public int getVisitFLOADCount() {
+        return visitFLOADCount;
+    }
+
+    public void setVisitFLOADCount(int visitFLOADCount) {
+        this.visitFLOADCount = visitFLOADCount;
+    }
+
+    public int getVisitFMULCount() {
+        return visitFMULCount;
+    }
+
+    public void setVisitFMULCount(int visitFMULCount) {
+        this.visitFMULCount = visitFMULCount;
+    }
+
+    public int getVisitFNEGCount() {
+        return visitFNEGCount;
+    }
+
+    public void setVisitFNEGCount(int visitFNEGCount) {
+        this.visitFNEGCount = visitFNEGCount;
+    }
+
+    public int getVisitFREMCount() {
+        return visitFREMCount;
+    }
+
+    public void setVisitFREMCount(int visitFREMCount) {
+        this.visitFREMCount = visitFREMCount;
+    }
+
+    public int getVisitFRETURNCount() {
+        return visitFRETURNCount;
+    }
+
+    public void setVisitFRETURNCount(int visitFRETURNCount) {
+        this.visitFRETURNCount = visitFRETURNCount;
+    }
+
+    public int getVisitFSTORECount() {
+        return visitFSTORECount;
+    }
+
+    public void setVisitFSTORECount(int visitFSTORECount) {
+        this.visitFSTORECount = visitFSTORECount;
+    }
+
+    public int getVisitFSUBCount() {
+        return visitFSUBCount;
+    }
+
+    public void setVisitFSUBCount(int visitFSUBCount) {
+        this.visitFSUBCount = visitFSUBCount;
+    }
+
+    public int getVisitGETFIELDCount() {
+        return visitGETFIELDCount;
+    }
+
+    public void setVisitGETFIELDCount(int visitGETFIELDCount) {
+        this.visitGETFIELDCount = visitGETFIELDCount;
+    }
+
+    public int getVisitGETSTATICCount() {
+        return visitGETSTATICCount;
+    }
+
+    public void setVisitGETSTATICCount(int visitGETSTATICCount) {
+        this.visitGETSTATICCount = visitGETSTATICCount;
+    }
+
+    public int getVisitGOTOCount() {
+        return visitGOTOCount;
+    }
+
+    public void setVisitGOTOCount(int visitGOTOCount) {
+        this.visitGOTOCount = visitGOTOCount;
+    }
+
+    public int getVisitGOTO_WCount() {
+        return visitGOTO_WCount;
+    }
+
+    public void setVisitGOTO_WCount(int visitGOTO_WCount) {
+        this.visitGOTO_WCount = visitGOTO_WCount;
+    }
+
+    public int getVisitGotoInstructionCount() {
+        return visitGotoInstructionCount;
+    }
+
+    public void setVisitGotoInstructionCount(int visitGotoInstructionCount) {
+        this.visitGotoInstructionCount = visitGotoInstructionCount;
+    }
+
+    public int getVisitI2BCount() {
+        return visitI2BCount;
+    }
+
+    public void setVisitI2BCount(int visitI2BCount) {
+        this.visitI2BCount = visitI2BCount;
+    }
+
+    public int getVisitI2CCount() {
+        return visitI2CCount;
+    }
+
+    public void setVisitI2CCount(int visitI2CCount) {
+        this.visitI2CCount = visitI2CCount;
+    }
+
+    public int getVisitI2DCount() {
+        return visitI2DCount;
+    }
+
+    public void setVisitI2DCount(int visitI2DCount) {
+        this.visitI2DCount = visitI2DCount;
+    }
+
+    public int getVisitI2FCount() {
+        return visitI2FCount;
+    }
+
+    public void setVisitI2FCount(int visitI2FCount) {
+        this.visitI2FCount = visitI2FCount;
+    }
+
+    public int getVisitI2LCount() {
+        return visitI2LCount;
+    }
+
+    public void setVisitI2LCount(int visitI2LCount) {
+        this.visitI2LCount = visitI2LCount;
+    }
+
+    public int getVisitI2SCount() {
+        return visitI2SCount;
+    }
+
+    public void setVisitI2SCount(int visitI2SCount) {
+        this.visitI2SCount = visitI2SCount;
+    }
+
+    public int getVisitIADDCount() {
+        return visitIADDCount;
+    }
+
+    public void setVisitIADDCount(int visitIADDCount) {
+        this.visitIADDCount = visitIADDCount;
+    }
+
+    public int getVisitIALOADCount() {
+        return visitIALOADCount;
+    }
+
+    public void setVisitIALOADCount(int visitIALOADCount) {
+        this.visitIALOADCount = visitIALOADCount;
+    }
+
+    public int getVisitIANDCount() {
+        return visitIANDCount;
+    }
+
+    public void setVisitIANDCount(int visitIANDCount) {
+        this.visitIANDCount = visitIANDCount;
+    }
+
+    public int getVisitIASTORECount() {
+        return visitIASTORECount;
+    }
+
+    public void setVisitIASTORECount(int visitIASTORECount) {
+        this.visitIASTORECount = visitIASTORECount;
+    }
+
+    public int getVisitICONSTCount() {
+        return visitICONSTCount;
+    }
+
+    public void setVisitICONSTCount(int visitICONSTCount) {
+        this.visitICONSTCount = visitICONSTCount;
+    }
+
+    public int getVisitIDIVCount() {
+        return visitIDIVCount;
+    }
+
+    public void setVisitIDIVCount(int visitIDIVCount) {
+        this.visitIDIVCount = visitIDIVCount;
+    }
+
+    public int getVisitIF_ACMPEQCount() {
+        return visitIF_ACMPEQCount;
+    }
+
+    public void setVisitIF_ACMPEQCount(int visitIF_ACMPEQCount) {
+        this.visitIF_ACMPEQCount = visitIF_ACMPEQCount;
+    }
+
+    public int getVisitIF_ACMPNECount() {
+        return visitIF_ACMPNECount;
+    }
+
+    public void setVisitIF_ACMPNECount(int visitIF_ACMPNECount) {
+        this.visitIF_ACMPNECount = visitIF_ACMPNECount;
+    }
+
+    public int getVisitIF_ICMPEQCount() {
+        return visitIF_ICMPEQCount;
+    }
+
+    public void setVisitIF_ICMPEQCount(int visitIF_ICMPEQCount) {
+        this.visitIF_ICMPEQCount = visitIF_ICMPEQCount;
+    }
+
+    public int getVisitIF_ICMPGECount() {
+        return visitIF_ICMPGECount;
+    }
+
+    public void setVisitIF_ICMPGECount(int visitIF_ICMPGECount) {
+        this.visitIF_ICMPGECount = visitIF_ICMPGECount;
+    }
+
+    public int getVisitIF_ICMPGTCount() {
+        return visitIF_ICMPGTCount;
+    }
+
+    public void setVisitIF_ICMPGTCount(int visitIF_ICMPGTCount) {
+        this.visitIF_ICMPGTCount = visitIF_ICMPGTCount;
+    }
+
+    public int getVisitIF_ICMPLECount() {
+        return visitIF_ICMPLECount;
+    }
+
+    public void setVisitIF_ICMPLECount(int visitIF_ICMPLECount) {
+        this.visitIF_ICMPLECount = visitIF_ICMPLECount;
+    }
+
+    public int getVisitIF_ICMPLTCount() {
+        return visitIF_ICMPLTCount;
+    }
+
+    public void setVisitIF_ICMPLTCount(int visitIF_ICMPLTCount) {
+        this.visitIF_ICMPLTCount = visitIF_ICMPLTCount;
+    }
+
+    public int getVisitIF_ICMPNECount() {
+        return visitIF_ICMPNECount;
+    }
+
+    public void setVisitIF_ICMPNECount(int visitIF_ICMPNECount) {
+        this.visitIF_ICMPNECount = visitIF_ICMPNECount;
+    }
+
+    public int getVisitIFEQCount() {
+        return visitIFEQCount;
+    }
+
+    public void setVisitIFEQCount(int visitIFEQCount) {
+        this.visitIFEQCount = visitIFEQCount;
+    }
+
+    public int getVisitIFGECount() {
+        return visitIFGECount;
+    }
+
+    public void setVisitIFGECount(int visitIFGECount) {
+        this.visitIFGECount = visitIFGECount;
+    }
+
+    public int getVisitIFGTCount() {
+        return visitIFGTCount;
+    }
+
+    public void setVisitIFGTCount(int visitIFGTCount) {
+        this.visitIFGTCount = visitIFGTCount;
+    }
+
+    public int getVisitIfInstructionCount() {
+        return visitIfInstructionCount;
+    }
+
+    public void setVisitIfInstructionCount(int visitIfInstructionCount) {
+        this.visitIfInstructionCount = visitIfInstructionCount;
+    }
+
+    public int getVisitIFLECount() {
+        return visitIFLECount;
+    }
+
+    public void setVisitIFLECount(int visitIFLECount) {
+        this.visitIFLECount = visitIFLECount;
+    }
+
+    public int getVisitIFLTCount() {
+        return visitIFLTCount;
+    }
+
+    public void setVisitIFLTCount(int visitIFLTCount) {
+        this.visitIFLTCount = visitIFLTCount;
+    }
+
+    public int getVisitIFNECount() {
+        return visitIFNECount;
+    }
+
+    public void setVisitIFNECount(int visitIFNECount) {
+        this.visitIFNECount = visitIFNECount;
+    }
+
+    public int getVisitIFNONNULLCount() {
+        return visitIFNONNULLCount;
+    }
+
+    public void setVisitIFNONNULLCount(int visitIFNONNULLCount) {
+        this.visitIFNONNULLCount = visitIFNONNULLCount;
+    }
+
+    public int getVisitIFNULLCount() {
+        return visitIFNULLCount;
+    }
+
+    public void setVisitIFNULLCount(int visitIFNULLCount) {
+        this.visitIFNULLCount = visitIFNULLCount;
+    }
+
+    public int getVisitIINCCount() {
+        return visitIINCCount;
+    }
+
+    public void setVisitIINCCount(int visitIINCCount) {
+        this.visitIINCCount = visitIINCCount;
+    }
+
+    public int getVisitILOADCount() {
+        return visitILOADCount;
+    }
+
+    public void setVisitILOADCount(int visitILOADCount) {
+        this.visitILOADCount = visitILOADCount;
+    }
+
+    public int getVisitIMPDEP1Count() {
+        return visitIMPDEP1Count;
+    }
+
+    public void setVisitIMPDEP1Count(int visitIMPDEP1Count) {
+        this.visitIMPDEP1Count = visitIMPDEP1Count;
+    }
+
+    public int getVisitIMPDEP2Count() {
+        return visitIMPDEP2Count;
+    }
+
+    public void setVisitIMPDEP2Count(int visitIMPDEP2Count) {
+        this.visitIMPDEP2Count = visitIMPDEP2Count;
+    }
+
+    public int getVisitIMULCount() {
+        return visitIMULCount;
+    }
+
+    public void setVisitIMULCount(int visitIMULCount) {
+        this.visitIMULCount = visitIMULCount;
+    }
+
+    public int getVisitINEGCount() {
+        return visitINEGCount;
+    }
+
+    public void setVisitINEGCount(int visitINEGCount) {
+        this.visitINEGCount = visitINEGCount;
+    }
+
+    public int getVisitINSTANCEOFCount() {
+        return visitINSTANCEOFCount;
+    }
+
+    public void setVisitINSTANCEOFCount(int visitINSTANCEOFCount) {
+        this.visitINSTANCEOFCount = visitINSTANCEOFCount;
+    }
+
+    public int getVisitINVOKEDYNAMICCount() {
+        return visitINVOKEDYNAMICCount;
+    }
+
+    public void setVisitINVOKEDYNAMICCount(int visitINVOKEDYNAMICCount) {
+        this.visitINVOKEDYNAMICCount = visitINVOKEDYNAMICCount;
+    }
+
+    public int getVisitInvokeInstructionCount() {
+        return visitInvokeInstructionCount;
+    }
+
+    public void setVisitInvokeInstructionCount(int visitInvokeInstructionCount) {
+        this.visitInvokeInstructionCount = visitInvokeInstructionCount;
+    }
+
+    public int getVisitINVOKEINTERFACECount() {
+        return visitINVOKEINTERFACECount;
+    }
+
+    public void setVisitINVOKEINTERFACECount(int visitINVOKEINTERFACECount) {
+        this.visitINVOKEINTERFACECount = visitINVOKEINTERFACECount;
+    }
+
+    public int getVisitINVOKESPECIALCount() {
+        return visitINVOKESPECIALCount;
+    }
+
+    public void setVisitINVOKESPECIALCount(int visitINVOKESPECIALCount) {
+        this.visitINVOKESPECIALCount = visitINVOKESPECIALCount;
+    }
+
+    public int getVisitINVOKESTATICCount() {
+        return visitINVOKESTATICCount;
+    }
+
+    public void setVisitINVOKESTATICCount(int visitINVOKESTATICCount) {
+        this.visitINVOKESTATICCount = visitINVOKESTATICCount;
+    }
+
+    public int getVisitINVOKEVIRTUALCount() {
+        return visitINVOKEVIRTUALCount;
+    }
+
+    public void setVisitINVOKEVIRTUALCount(int visitINVOKEVIRTUALCount) {
+        this.visitINVOKEVIRTUALCount = visitINVOKEVIRTUALCount;
+    }
+
+    public int getVisitIORCount() {
+        return visitIORCount;
+    }
+
+    public void setVisitIORCount(int visitIORCount) {
+        this.visitIORCount = visitIORCount;
+    }
+
+    public int getVisitIREMCount() {
+        return visitIREMCount;
+    }
+
+    public void setVisitIREMCount(int visitIREMCount) {
+        this.visitIREMCount = visitIREMCount;
+    }
+
+    public int getVisitIRETURNCount() {
+        return visitIRETURNCount;
+    }
+
+    public void setVisitIRETURNCount(int visitIRETURNCount) {
+        this.visitIRETURNCount = visitIRETURNCount;
+    }
+
+    public int getVisitISHLCount() {
+        return visitISHLCount;
+    }
+
+    public void setVisitISHLCount(int visitISHLCount) {
+        this.visitISHLCount = visitISHLCount;
+    }
+
+    public int getVisitISHRCount() {
+        return visitISHRCount;
+    }
+
+    public void setVisitISHRCount(int visitISHRCount) {
+        this.visitISHRCount = visitISHRCount;
+    }
+
+    public int getVisitISTORECount() {
+        return visitISTORECount;
+    }
+
+    public void setVisitISTORECount(int visitISTORECount) {
+        this.visitISTORECount = visitISTORECount;
+    }
+
+    public int getVisitISUBCount() {
+        return visitISUBCount;
+    }
+
+    public void setVisitISUBCount(int visitISUBCount) {
+        this.visitISUBCount = visitISUBCount;
+    }
+
+    public int getVisitIUSHRCount() {
+        return visitIUSHRCount;
+    }
+
+    public void setVisitIUSHRCount(int visitIUSHRCount) {
+        this.visitIUSHRCount = visitIUSHRCount;
+    }
+
+    public int getVisitIXORCount() {
+        return visitIXORCount;
+    }
+
+    public void setVisitIXORCount(int visitIXORCount) {
+        this.visitIXORCount = visitIXORCount;
+    }
+
+    public int getVisitJSRCount() {
+        return visitJSRCount;
+    }
+
+    public void setVisitJSRCount(int visitJSRCount) {
+        this.visitJSRCount = visitJSRCount;
+    }
+
+    public int getVisitJSR_WCount() {
+        return visitJSR_WCount;
+    }
+
+    public void setVisitJSR_WCount(int visitJSR_WCount) {
+        this.visitJSR_WCount = visitJSR_WCount;
+    }
+
+    public int getVisitJsrInstructionCount() {
+        return visitJsrInstructionCount;
+    }
+
+    public void setVisitJsrInstructionCount(int visitJsrInstructionCount) {
+        this.visitJsrInstructionCount = visitJsrInstructionCount;
+    }
+
+    public int getVisitL2DCount() {
+        return visitL2DCount;
+    }
+
+    public void setVisitL2DCount(int visitL2DCount) {
+        this.visitL2DCount = visitL2DCount;
+    }
+
+    public int getVisitL2FCount() {
+        return visitL2FCount;
+    }
+
+    public void setVisitL2FCount(int visitL2FCount) {
+        this.visitL2FCount = visitL2FCount;
+    }
+
+    public int getVisitL2ICount() {
+        return visitL2ICount;
+    }
+
+    public void setVisitL2ICount(int visitL2ICount) {
+        this.visitL2ICount = visitL2ICount;
+    }
+
+    public int getVisitLADDCount() {
+        return visitLADDCount;
+    }
+
+    public void setVisitLADDCount(int visitLADDCount) {
+        this.visitLADDCount = visitLADDCount;
+    }
+
+    public int getVisitLALOADCount() {
+        return visitLALOADCount;
+    }
+
+    public void setVisitLALOADCount(int visitLALOADCount) {
+        this.visitLALOADCount = visitLALOADCount;
+    }
+
+    public int getVisitLANDCount() {
+        return visitLANDCount;
+    }
+
+    public void setVisitLANDCount(int visitLANDCount) {
+        this.visitLANDCount = visitLANDCount;
+    }
+
+    public int getVisitLASTORECount() {
+        return visitLASTORECount;
+    }
+
+    public void setVisitLASTORECount(int visitLASTORECount) {
+        this.visitLASTORECount = visitLASTORECount;
+    }
+
+    public int getVisitLCMPCount() {
+        return visitLCMPCount;
+    }
+
+    public void setVisitLCMPCount(int visitLCMPCount) {
+        this.visitLCMPCount = visitLCMPCount;
+    }
+
+    public int getVisitLCONSTCount() {
+        return visitLCONSTCount;
+    }
+
+    public void setVisitLCONSTCount(int visitLCONSTCount) {
+        this.visitLCONSTCount = visitLCONSTCount;
+    }
+
+    public int getVisitLDCCount() {
+        return visitLDCCount;
+    }
+
+    public void setVisitLDCCount(int visitLDCCount) {
+        this.visitLDCCount = visitLDCCount;
+    }
+
+    public int getVisitLDC2_WCount() {
+        return visitLDC2_WCount;
+    }
+
+    public void setVisitLDC2_WCount(int visitLDC2_WCount) {
+        this.visitLDC2_WCount = visitLDC2_WCount;
+    }
+
+    public int getVisitLDIVCount() {
+        return visitLDIVCount;
+    }
+
+    public void setVisitLDIVCount(int visitLDIVCount) {
+        this.visitLDIVCount = visitLDIVCount;
+    }
+
+    public int getVisitLLOADCount() {
+        return visitLLOADCount;
+    }
+
+    public void setVisitLLOADCount(int visitLLOADCount) {
+        this.visitLLOADCount = visitLLOADCount;
+    }
+
+    public int getVisitLMULCount() {
+        return visitLMULCount;
+    }
+
+    public void setVisitLMULCount(int visitLMULCount) {
+        this.visitLMULCount = visitLMULCount;
+    }
+
+    public int getVisitLNEGCount() {
+        return visitLNEGCount;
+    }
+
+    public void setVisitLNEGCount(int visitLNEGCount) {
+        this.visitLNEGCount = visitLNEGCount;
+    }
+
+    public int getVisitLoadClassCount() {
+        return visitLoadClassCount;
+    }
+
+    public void setVisitLoadClassCount(int visitLoadClassCount) {
+        this.visitLoadClassCount = visitLoadClassCount;
+    }
+
+    public int getVisitLoadInstructionCount() {
+        return visitLoadInstructionCount;
+    }
+
+    public void setVisitLoadInstructionCount(int visitLoadInstructionCount) {
+        this.visitLoadInstructionCount = visitLoadInstructionCount;
+    }
+
+    public int getVisitLocalVariableInstructionCount() {
+        return visitLocalVariableInstructionCount;
+    }
+
+    public void setVisitLocalVariableInstructionCount(int visitLocalVariableInstructionCount) {
+        this.visitLocalVariableInstructionCount = visitLocalVariableInstructionCount;
+    }
+
+    public int getVisitLOOKUPSWITCHCount() {
+        return visitLOOKUPSWITCHCount;
+    }
+
+    public void setVisitLOOKUPSWITCHCount(int visitLOOKUPSWITCHCount) {
+        this.visitLOOKUPSWITCHCount = visitLOOKUPSWITCHCount;
+    }
+
+    public int getVisitLORCount() {
+        return visitLORCount;
+    }
+
+    public void setVisitLORCount(int visitLORCount) {
+        this.visitLORCount = visitLORCount;
+    }
+
+    public int getVisitLREMCount() {
+        return visitLREMCount;
+    }
+
+    public void setVisitLREMCount(int visitLREMCount) {
+        this.visitLREMCount = visitLREMCount;
+    }
+
+    public int getVisitLRETURNCount() {
+        return visitLRETURNCount;
+    }
+
+    public void setVisitLRETURNCount(int visitLRETURNCount) {
+        this.visitLRETURNCount = visitLRETURNCount;
+    }
+
+    public int getVisitLSHLCount() {
+        return visitLSHLCount;
+    }
+
+    public void setVisitLSHLCount(int visitLSHLCount) {
+        this.visitLSHLCount = visitLSHLCount;
+    }
+
+    public int getVisitLSHRCount() {
+        return visitLSHRCount;
+    }
+
+    public void setVisitLSHRCount(int visitLSHRCount) {
+        this.visitLSHRCount = visitLSHRCount;
+    }
+
+    public int getVisitLSTORECount() {
+        return visitLSTORECount;
+    }
+
+    public void setVisitLSTORECount(int visitLSTORECount) {
+        this.visitLSTORECount = visitLSTORECount;
+    }
+
+    public int getVisitLSUBCount() {
+        return visitLSUBCount;
+    }
+
+    public void setVisitLSUBCount(int visitLSUBCount) {
+        this.visitLSUBCount = visitLSUBCount;
+    }
+
+    public int getVisitLUSHRCount() {
+        return visitLUSHRCount;
+    }
+
+    public void setVisitLUSHRCount(int visitLUSHRCount) {
+        this.visitLUSHRCount = visitLUSHRCount;
+    }
+
+    public int getVisitLXORCount() {
+        return visitLXORCount;
+    }
+
+    public void setVisitLXORCount(int visitLXORCount) {
+        this.visitLXORCount = visitLXORCount;
+    }
+
+    public int getVisitMONITORENTERCount() {
+        return visitMONITORENTERCount;
+    }
+
+    public void setVisitMONITORENTERCount(int visitMONITORENTERCount) {
+        this.visitMONITORENTERCount = visitMONITORENTERCount;
+    }
+
+    public int getVisitMONITOREXITCount() {
+        return visitMONITOREXITCount;
+    }
+
+    public void setVisitMONITOREXITCount(int visitMONITOREXITCount) {
+        this.visitMONITOREXITCount = visitMONITOREXITCount;
+    }
+
+    public int getVisitMULTIANEWARRAYCount() {
+        return visitMULTIANEWARRAYCount;
+    }
+
+    public void setVisitMULTIANEWARRAYCount(int visitMULTIANEWARRAYCount) {
+        this.visitMULTIANEWARRAYCount = visitMULTIANEWARRAYCount;
+    }
+
+    public int getVisitNEWCount() {
+        return visitNEWCount;
+    }
+
+    public void setVisitNEWCount(int visitNEWCount) {
+        this.visitNEWCount = visitNEWCount;
+    }
+
+    public int getVisitNEWARRAYCount() {
+        return visitNEWARRAYCount;
+    }
+
+    public void setVisitNEWARRAYCount(int visitNEWARRAYCount) {
+        this.visitNEWARRAYCount = visitNEWARRAYCount;
+    }
+
+    public int getVisitNOPCount() {
+        return visitNOPCount;
+    }
+
+    public void setVisitNOPCount(int visitNOPCount) {
+        this.visitNOPCount = visitNOPCount;
+    }
+
+    public int getVisitPOPCount() {
+        return visitPOPCount;
+    }
+
+    public void setVisitPOPCount(int visitPOPCount) {
+        this.visitPOPCount = visitPOPCount;
+    }
+
+    public int getVisitPOP2Count() {
+        return visitPOP2Count;
+    }
+
+    public void setVisitPOP2Count(int visitPOP2Count) {
+        this.visitPOP2Count = visitPOP2Count;
+    }
+
+    public int getVisitPopInstructionCount() {
+        return visitPopInstructionCount;
+    }
+
+    public void setVisitPopInstructionCount(int visitPopInstructionCount) {
+        this.visitPopInstructionCount = visitPopInstructionCount;
+    }
+
+    public int getVisitPushInstructionCount() {
+        return visitPushInstructionCount;
+    }
+
+    public void setVisitPushInstructionCount(int visitPushInstructionCount) {
+        this.visitPushInstructionCount = visitPushInstructionCount;
+    }
+
+    public int getVisitPUTFIELDCount() {
+        return visitPUTFIELDCount;
+    }
+
+    public void setVisitPUTFIELDCount(int visitPUTFIELDCount) {
+        this.visitPUTFIELDCount = visitPUTFIELDCount;
+    }
+
+    public int getVisitPUTSTATICCount() {
+        return visitPUTSTATICCount;
+    }
+
+    public void setVisitPUTSTATICCount(int visitPUTSTATICCount) {
+        this.visitPUTSTATICCount = visitPUTSTATICCount;
+    }
+
+    public int getVisitRETCount() {
+        return visitRETCount;
+    }
+
+    public void setVisitRETCount(int visitRETCount) {
+        this.visitRETCount = visitRETCount;
+    }
+
+    public int getVisitRETURNCount() {
+        return visitRETURNCount;
+    }
+
+    public void setVisitRETURNCount(int visitRETURNCount) {
+        this.visitRETURNCount = visitRETURNCount;
+    }
+
+    public int getVisitReturnInstructionCount() {
+        return visitReturnInstructionCount;
+    }
+
+    public void setVisitReturnInstructionCount(int visitReturnInstructionCount) {
+        this.visitReturnInstructionCount = visitReturnInstructionCount;
+    }
+
+    public int getVisitSALOADCount() {
+        return visitSALOADCount;
+    }
+
+    public void setVisitSALOADCount(int visitSALOADCount) {
+        this.visitSALOADCount = visitSALOADCount;
+    }
+
+    public int getVisitSASTORECount() {
+        return visitSASTORECount;
+    }
+
+    public void setVisitSASTORECount(int visitSASTORECount) {
+        this.visitSASTORECount = visitSASTORECount;
+    }
+
+    public int getVisitSelectCount() {
+        return visitSelectCount;
+    }
+
+    public void setVisitSelectCount(int visitSelectCount) {
+        this.visitSelectCount = visitSelectCount;
+    }
+
+    public int getVisitSIPUSHCount() {
+        return visitSIPUSHCount;
+    }
+
+    public void setVisitSIPUSHCount(int visitSIPUSHCount) {
+        this.visitSIPUSHCount = visitSIPUSHCount;
+    }
+
+    public int getVisitStackConsumerCount() {
+        return visitStackConsumerCount;
+    }
+
+    public void setVisitStackConsumerCount(int visitStackConsumerCount) {
+        this.visitStackConsumerCount = visitStackConsumerCount;
+    }
+
+    public int getVisitStackInstructionCount() {
+        return visitStackInstructionCount;
+    }
+
+    public void setVisitStackInstructionCount(int visitStackInstructionCount) {
+        this.visitStackInstructionCount = visitStackInstructionCount;
+    }
+
+    public int getVisitStackProducerCount() {
+        return visitStackProducerCount;
+    }
+
+    public void setVisitStackProducerCount(int visitStackProducerCount) {
+        this.visitStackProducerCount = visitStackProducerCount;
+    }
+
+    public int getVisitStoreInstructionCount() {
+        return visitStoreInstructionCount;
+    }
+
+    public void setVisitStoreInstructionCount(int visitStoreInstructionCount) {
+        this.visitStoreInstructionCount = visitStoreInstructionCount;
+    }
+
+    public int getVisitSWAPCount() {
+        return visitSWAPCount;
+    }
+
+    public void setVisitSWAPCount(int visitSWAPCount) {
+        this.visitSWAPCount = visitSWAPCount;
+    }
+
+    public int getVisitTABLESWITCHCount() {
+        return visitTABLESWITCHCount;
+    }
+
+    public void setVisitTABLESWITCHCount(int visitTABLESWITCHCount) {
+        this.visitTABLESWITCHCount = visitTABLESWITCHCount;
+    }
+
+    public int getVisitTypedInstructionCount() {
+        return visitTypedInstructionCount;
+    }
+
+    public void setVisitTypedInstructionCount(int visitTypedInstructionCount) {
+        this.visitTypedInstructionCount = visitTypedInstructionCount;
+    }
+
+    public int getVisitUnconditionalBranchCount() {
+        return visitUnconditionalBranchCount;
+    }
+
+    public void setVisitUnconditionalBranchCount(int visitUnconditionalBranchCount) {
+        this.visitUnconditionalBranchCount = visitUnconditionalBranchCount;
+    }
+
+    public int getVisitVariableLengthInstructionCount() {
+        return visitVariableLengthInstructionCount;
+    }
+
+    public void setVisitVariableLengthInstructionCount(int visitVariableLengthInstructionCount) {
+        this.visitVariableLengthInstructionCount = visitVariableLengthInstructionCount;
+    }
+
+    @Override
+    public void visitAALOAD(AALOAD obj) {
+        visitAALOADCount++;
+    }
+
+    @Override
+    public void visitAASTORE(AASTORE obj) {
+        visitAASTORECount++;
+    }
+
+    @Override
+    public void visitACONST_NULL(ACONST_NULL obj) {
+        visitACONST_NULLCount++;
+    }
+
+    @Override
+    public void visitAllocationInstruction(AllocationInstruction obj) {
+        visitAllocationInstructionCount++;
+    }
+
+    @Override
+    public void visitALOAD(ALOAD obj) {
+        visitALOADCount++;
+    }
+
+    @Override
+    public void visitANEWARRAY(ANEWARRAY obj) {
+        visitANEWARRAYCount++;
+    }
+
+    @Override
+    public void visitARETURN(ARETURN obj) {
+        visitARETURNCount++;
+    }
+
+    @Override
+    public void visitArithmeticInstruction(ArithmeticInstruction obj) {
+        visitArithmeticInstructionCount++;
+    }
+
+    @Override
+    public void visitArrayInstruction(ArrayInstruction obj) {
+        visitArrayInstructionCount++;
+    }
+
+    @Override
+    public void visitARRAYLENGTH(ARRAYLENGTH obj) {
+        visitARRAYLENGTHCount++;
+    }
+
+    @Override
+    public void visitASTORE(ASTORE obj) {
+        visitASTORECount++;
+    }
+
+    @Override
+    public void visitATHROW(ATHROW obj) {
+        visitATHROWCount++;
+    }
+
+    @Override
+    public void visitBALOAD(BALOAD obj) {
+        visitBALOADCount++;
+    }
+
+    @Override
+    public void visitBASTORE(BASTORE obj) {
+        visitBASTORECount++;
+    }
+
+    @Override
+    public void visitBIPUSH(BIPUSH obj) {
+        visitBIPUSHCount++;
+    }
+
+    @Override
+    public void visitBranchInstruction(BranchInstruction obj) {
+        visitBranchInstructionCount++;
+    }
+
+    @Override
+    public void visitBREAKPOINT(BREAKPOINT obj) {
+        visitBREAKPOINTCount++;
+    }
+
+    @Override
+    public void visitCALOAD(CALOAD obj) {
+        visitCALOADCount++;
+    }
+
+    @Override
+    public void visitCASTORE(CASTORE obj) {
+        visitCASTORECount++;
+    }
+
+    @Override
+    public void visitCHECKCAST(CHECKCAST obj) {
+        visitCHECKCASTCount++;
+    }
+
+    @Override
+    public void visitConstantPushInstruction(ConstantPushInstruction obj) {
+        visitConstantPushInstructionCount++;
+    }
+
+    @Override
+    public void visitConversionInstruction(ConversionInstruction obj) {
+        visitConversionInstructionCount++;
+    }
+
+    @Override
+    public void visitCPInstruction(CPInstruction obj) {
+        visitCPInstructionCount++;
+    }
+
+    @Override
+    public void visitD2F(D2F obj) {
+        visitD2FCount++;
+    }
+
+    @Override
+    public void visitD2I(D2I obj) {
+        visitD2ICount++;
+    }
+
+    @Override
+    public void visitD2L(D2L obj) {
+        visitD2LCount++;
+    }
+
+    @Override
+    public void visitDADD(DADD obj) {
+        visitDADDCount++;
+    }
+
+    @Override
+    public void visitDALOAD(DALOAD obj) {
+        visitDALOADCount++;
+    }
+
+    @Override
+    public void visitDASTORE(DASTORE obj) {
+        visitDASTORECount++;
+    }
+
+    @Override
+    public void visitDCMPG(DCMPG obj) {
+        visitDCMPGCount++;
+    }
+
+    @Override
+    public void visitDCMPL(DCMPL obj) {
+        visitDCMPLCount++;
+    }
+
+    @Override
+    public void visitDCONST(DCONST obj) {
+        visitDCONSTCount++;
+    }
+
+    @Override
+    public void visitDDIV(DDIV obj) {
+        visitDDIVCount++;
+    }
+
+    @Override
+    public void visitDLOAD(DLOAD obj) {
+        visitDLOADCount++;
+    }
+
+    @Override
+    public void visitDMUL(DMUL obj) {
+        visitDMULCount++;
+    }
+
+    @Override
+    public void visitDNEG(DNEG obj) {
+        visitDNEGCount++;
+    }
+
+    @Override
+    public void visitDREM(DREM obj) {
+        visitDREMCount++;
+    }
+
+    @Override
+    public void visitDRETURN(DRETURN obj) {
+        visitDRETURNCount++;
+    }
+
+    @Override
+    public void visitDSTORE(DSTORE obj) {
+        visitDSTORECount++;
+    }
+
+    @Override
+    public void visitDSUB(DSUB obj) {
+        visitDSUBCount++;
+    }
+
+    @Override
+    public void visitDUP(DUP obj) {
+        visitDUPCount++;
+    }
+
+    @Override
+    public void visitDUP_X1(DUP_X1 obj) {
+        visitDUP_X1Count++;
+    }
+
+    @Override
+    public void visitDUP_X2(DUP_X2 obj) {
+        visitDUP_X2Count++;
+    }
+
+    @Override
+    public void visitDUP2(DUP2 obj) {
+        visitDUP2Count++;
+    }
+
+    @Override
+    public void visitDUP2_X1(DUP2_X1 obj) {
+        visitDUP2_X1Count++;
+    }
+
+    @Override
+    public void visitDUP2_X2(DUP2_X2 obj) {
+        visitDUP2_X2Count++;
+    }
+
+    @Override
+    public void visitExceptionThrower(ExceptionThrower obj) {
+        visitExceptionThrowerCount++;
+    }
+
+    @Override
+    public void visitF2D(F2D obj) {
+        visitF2DCount++;
+    }
+
+    @Override
+    public void visitF2I(F2I obj) {
+        visitF2ICount++;
+    }
+
+    @Override
+    public void visitF2L(F2L obj) {
+        visitF2LCount++;
+    }
+
+    @Override
+    public void visitFADD(FADD obj) {
+        visitFADDCount++;
+    }
+
+    @Override
+    public void visitFALOAD(FALOAD obj) {
+        visitFALOADCount++;
+    }
+
+    @Override
+    public void visitFASTORE(FASTORE obj) {
+        visitFASTORECount++;
+    }
+
+    @Override
+    public void visitFCMPG(FCMPG obj) {
+        visitFCMPGCount++;
+    }
+
+    @Override
+    public void visitFCMPL(FCMPL obj) {
+        visitFCMPLCount++;
+    }
+
+    @Override
+    public void visitFCONST(FCONST obj) {
+        visitFCONSTCount++;
+    }
+
+    @Override
+    public void visitFDIV(FDIV obj) {
+        visitFDIVCount++;
+    }
+
+    @Override
+    public void visitFieldInstruction(FieldInstruction obj) {
+        visitFieldInstructionCount++;
+    }
+
+    @Override
+    public void visitFieldOrMethod(FieldOrMethod obj) {
+        visitFieldOrMethodCount++;
+    }
+
+    @Override
+    public void visitFLOAD(FLOAD obj) {
+        visitFLOADCount++;
+    }
+
+    @Override
+    public void visitFMUL(FMUL obj) {
+        visitFMULCount++;
+    }
+
+    @Override
+    public void visitFNEG(FNEG obj) {
+        visitFNEGCount++;
+    }
+
+    @Override
+    public void visitFREM(FREM obj) {
+        visitFREMCount++;
+    }
+
+    @Override
+    public void visitFRETURN(FRETURN obj) {
+        visitFRETURNCount++;
+    }
+
+    @Override
+    public void visitFSTORE(FSTORE obj) {
+        visitFSTORECount++;
+    }
+
+    @Override
+    public void visitFSUB(FSUB obj) {
+        visitFSUBCount++;
+    }
+
+    @Override
+    public void visitGETFIELD(GETFIELD obj) {
+        visitGETFIELDCount++;
+    }
+
+    @Override
+    public void visitGETSTATIC(GETSTATIC obj) {
+        visitGETSTATICCount++;
+    }
+
+    @Override
+    public void visitGOTO(GOTO obj) {
+        visitGOTOCount++;
+    }
+
+    @Override
+    public void visitGOTO_W(GOTO_W obj) {
+        visitGOTO_WCount++;
+    }
+
+    @Override
+    public void visitGotoInstruction(GotoInstruction obj) {
+        visitGotoInstructionCount++;
+    }
+
+    @Override
+    public void visitI2B(I2B obj) {
+        visitI2BCount++;
+    }
+
+    @Override
+    public void visitI2C(I2C obj) {
+        visitI2CCount++;
+    }
+
+    @Override
+    public void visitI2D(I2D obj) {
+        visitI2DCount++;
+    }
+
+    @Override
+    public void visitI2F(I2F obj) {
+        visitI2FCount++;
+    }
+
+    @Override
+    public void visitI2L(I2L obj) {
+        visitI2LCount++;
+    }
+
+    @Override
+    public void visitI2S(I2S obj) {
+        visitI2SCount++;
+    }
+
+    @Override
+    public void visitIADD(IADD obj) {
+        visitIADDCount++;
+    }
+
+    @Override
+    public void visitIALOAD(IALOAD obj) {
+        visitIALOADCount++;
+    }
+
+    @Override
+    public void visitIAND(IAND obj) {
+        visitIANDCount++;
+    }
+
+    @Override
+    public void visitIASTORE(IASTORE obj) {
+        visitIASTORECount++;
+    }
+
+    @Override
+    public void visitICONST(ICONST obj) {
+        visitICONSTCount++;
+    }
+
+    @Override
+    public void visitIDIV(IDIV obj) {
+        visitIDIVCount++;
+    }
+
+    @Override
+    public void visitIF_ACMPEQ(IF_ACMPEQ obj) {
+        visitIF_ACMPEQCount++;
+    }
+
+    @Override
+    public void visitIF_ACMPNE(IF_ACMPNE obj) {
+        visitIF_ACMPNECount++;
+    }
+
+    @Override
+    public void visitIF_ICMPEQ(IF_ICMPEQ obj) {
+        visitIF_ICMPEQCount++;
+    }
+
+    @Override
+    public void visitIF_ICMPGE(IF_ICMPGE obj) {
+        visitIF_ICMPGECount++;
+    }
+
+    @Override
+    public void visitIF_ICMPGT(IF_ICMPGT obj) {
+        visitIF_ICMPGTCount++;
+    }
+
+    @Override
+    public void visitIF_ICMPLE(IF_ICMPLE obj) {
+        visitIF_ICMPLECount++;
+    }
+
+    @Override
+    public void visitIF_ICMPLT(IF_ICMPLT obj) {
+        visitIF_ICMPLTCount++;
+    }
+
+    @Override
+    public void visitIF_ICMPNE(IF_ICMPNE obj) {
+        visitIF_ICMPNECount++;
+    }
+
+    @Override
+    public void visitIFEQ(IFEQ obj) {
+        visitIFEQCount++;
+    }
+
+    @Override
+    public void visitIFGE(IFGE obj) {
+        visitIFGECount++;
+    }
+
+    @Override
+    public void visitIFGT(IFGT obj) {
+        visitIFGTCount++;
+    }
+
+    @Override
+    public void visitIfInstruction(IfInstruction obj) {
+        visitIfInstructionCount++;
+    }
+
+    @Override
+    public void visitIFLE(IFLE obj) {
+        visitIFLECount++;
+    }
+
+    @Override
+    public void visitIFLT(IFLT obj) {
+        visitIFLTCount++;
+    }
+
+    @Override
+    public void visitIFNE(IFNE obj) {
+        visitIFNECount++;
+    }
+
+    @Override
+    public void visitIFNONNULL(IFNONNULL obj) {
+        visitIFNONNULLCount++;
+    }
+
+    @Override
+    public void visitIFNULL(IFNULL obj) {
+        visitIFNULLCount++;
+    }
+
+    @Override
+    public void visitIINC(IINC obj) {
+        visitIINCCount++;
+    }
+
+    @Override
+    public void visitILOAD(ILOAD obj) {
+        visitILOADCount++;
+    }
+
+    @Override
+    public void visitIMPDEP1(IMPDEP1 obj) {
+        visitIMPDEP1Count++;
+    }
+
+    @Override
+    public void visitIMPDEP2(IMPDEP2 obj) {
+        visitIMPDEP2Count++;
+    }
+
+    @Override
+    public void visitIMUL(IMUL obj) {
+        visitIMULCount++;
+    }
+
+    @Override
+    public void visitINEG(INEG obj) {
+        visitINEGCount++;
+    }
+
+    @Override
+    public void visitINSTANCEOF(INSTANCEOF obj) {
+        visitINSTANCEOFCount++;
+    }
+
+    @Override
+    public void visitINVOKEDYNAMIC(INVOKEDYNAMIC obj) {
+        visitINVOKEDYNAMICCount++;
+    }
+
+    @Override
+    public void visitInvokeInstruction(InvokeInstruction obj) {
+        visitInvokeInstructionCount++;
+    }
+
+    @Override
+    public void visitINVOKEINTERFACE(INVOKEINTERFACE obj) {
+        visitINVOKEINTERFACECount++;
+    }
+
+    @Override
+    public void visitINVOKESPECIAL(INVOKESPECIAL obj) {
+        visitINVOKESPECIALCount++;
+    }
+
+    @Override
+    public void visitINVOKESTATIC(INVOKESTATIC obj) {
+        visitINVOKESTATICCount++;
+    }
+
+    @Override
+    public void visitINVOKEVIRTUAL(INVOKEVIRTUAL obj) {
+        visitINVOKEVIRTUALCount++;
+    }
+
+    @Override
+    public void visitIOR(IOR obj) {
+        visitIORCount++;
+    }
+
+    @Override
+    public void visitIREM(IREM obj) {
+        visitIREMCount++;
+    }
+
+    @Override
+    public void visitIRETURN(IRETURN obj) {
+        visitIRETURNCount++;
+    }
+
+    @Override
+    public void visitISHL(ISHL obj) {
+        visitISHLCount++;
+    }
+
+    @Override
+    public void visitISHR(ISHR obj) {
+        visitISHRCount++;
+    }
+
+    @Override
+    public void visitISTORE(ISTORE obj) {
+        visitISTORECount++;
+    }
+
+    @Override
+    public void visitISUB(ISUB obj) {
+        visitISUBCount++;
+    }
+
+    @Override
+    public void visitIUSHR(IUSHR obj) {
+        visitIUSHRCount++;
+    }
+
+    @Override
+    public void visitIXOR(IXOR obj) {
+        visitIXORCount++;
+    }
+
+    @Override
+    public void visitJSR(JSR obj) {
+        visitJSRCount++;
+    }
+
+    @Override
+    public void visitJSR_W(JSR_W obj) {
+        visitJSR_WCount++;
+    }
+
+    @Override
+    public void visitJsrInstruction(JsrInstruction obj) {
+        visitJsrInstructionCount++;
+    }
+
+    @Override
+    public void visitL2D(L2D obj) {
+        visitL2DCount++;
+    }
+
+    @Override
+    public void visitL2F(L2F obj) {
+        visitL2FCount++;
+    }
+
+    @Override
+    public void visitL2I(L2I obj) {
+        visitL2ICount++;
+    }
+
+    @Override
+    public void visitLADD(LADD obj) {
+        visitLADDCount++;
+    }
+
+    @Override
+    public void visitLALOAD(LALOAD obj) {
+        visitLALOADCount++;
+    }
+
+    @Override
+    public void visitLAND(LAND obj) {
+        visitLANDCount++;
+    }
+
+    @Override
+    public void visitLASTORE(LASTORE obj) {
+        visitLASTORECount++;
+    }
+
+    @Override
+    public void visitLCMP(LCMP obj) {
+        visitLCMPCount++;
+    }
+
+    @Override
+    public void visitLCONST(LCONST obj) {
+        visitLCONSTCount++;
+    }
+
+    @Override
+    public void visitLDC(LDC obj) {
+        visitLDCCount++;
+    }
+
+    @Override
+    public void visitLDC2_W(LDC2_W obj) {
+        visitLDC2_WCount++;
+    }
+
+    @Override
+    public void visitLDIV(LDIV obj) {
+        visitLDIVCount++;
+    }
+
+    @Override
+    public void visitLLOAD(LLOAD obj) {
+        visitLLOADCount++;
+    }
+
+    @Override
+    public void visitLMUL(LMUL obj) {
+        visitLMULCount++;
+    }
+
+    @Override
+    public void visitLNEG(LNEG obj) {
+        visitLNEGCount++;
+    }
+
+    @Override
+    public void visitLoadClass(LoadClass obj) {
+        visitLoadClassCount++;
+    }
+
+    @Override
+    public void visitLoadInstruction(LoadInstruction obj) {
+        visitLoadInstructionCount++;
+    }
+
+    @Override
+    public void visitLocalVariableInstruction(LocalVariableInstruction obj) {
+        visitLocalVariableInstructionCount++;
+    }
+
+    @Override
+    public void visitLOOKUPSWITCH(LOOKUPSWITCH obj) {
+        visitLOOKUPSWITCHCount++;
+    }
+
+    @Override
+    public void visitLOR(LOR obj) {
+        visitLORCount++;
+    }
+
+    @Override
+    public void visitLREM(LREM obj) {
+        visitLREMCount++;
+    }
+
+    @Override
+    public void visitLRETURN(LRETURN obj) {
+        visitLRETURNCount++;
+    }
+
+    @Override
+    public void visitLSHL(LSHL obj) {
+        visitLSHLCount++;
+    }
+
+    @Override
+    public void visitLSHR(LSHR obj) {
+        visitLSHRCount++;
+    }
+
+    @Override
+    public void visitLSTORE(LSTORE obj) {
+        visitLSTORECount++;
+    }
+
+    @Override
+    public void visitLSUB(LSUB obj) {
+        visitLSUBCount++;
+    }
+
+    @Override
+    public void visitLUSHR(LUSHR obj) {
+        visitLUSHRCount++;
+    }
+
+    @Override
+    public void visitLXOR(LXOR obj) {
+        visitLXORCount++;
+    }
+
+    @Override
+    public void visitMONITORENTER(MONITORENTER obj) {
+        visitMONITORENTERCount++;
+    }
+
+    @Override
+    public void visitMONITOREXIT(MONITOREXIT obj) {
+        visitMONITOREXITCount++;
+    }
+
+    @Override
+    public void visitMULTIANEWARRAY(MULTIANEWARRAY obj) {
+        visitMULTIANEWARRAYCount++;
+    }
+
+    @Override
+    public void visitNEW(NEW obj) {
+        visitNEWCount++;
+    }
+
+    @Override
+    public void visitNEWARRAY(NEWARRAY obj) {
+        visitNEWARRAYCount++;
+    }
+
+    @Override
+    public void visitNOP(NOP obj) {
+        visitNOPCount++;
+    }
+
+    @Override
+    public void visitPOP(POP obj) {
+        visitPOPCount++;
+    }
+
+    @Override
+    public void visitPOP2(POP2 obj) {
+        visitPOP2Count++;
+    }
+
+    @Override
+    public void visitPopInstruction(PopInstruction obj) {
+        visitPopInstructionCount++;
+    }
+
+    @Override
+    public void visitPushInstruction(PushInstruction obj) {
+        visitPushInstructionCount++;
+    }
+
+    @Override
+    public void visitPUTFIELD(PUTFIELD obj) {
+        visitPUTFIELDCount++;
+    }
+
+    @Override
+    public void visitPUTSTATIC(PUTSTATIC obj) {
+        visitPUTSTATICCount++;
+    }
+
+    @Override
+    public void visitRET(RET obj) {
+        visitRETCount++;
+    }
+
+    @Override
+    public void visitRETURN(RETURN obj) {
+        visitRETURNCount++;
+    }
+
+    @Override
+    public void visitReturnInstruction(ReturnInstruction obj) {
+        visitReturnInstructionCount++;
+    }
+
+    @Override
+    public void visitSALOAD(SALOAD obj) {
+        visitSALOADCount++;
+    }
+
+    @Override
+    public void visitSASTORE(SASTORE obj) {
+        visitSASTORECount++;
+    }
+
+    @Override
+    public void visitSelect(Select obj) {
+        visitSelectCount++;
+    }
+
+    @Override
+    public void visitSIPUSH(SIPUSH obj) {
+        visitSIPUSHCount++;
+    }
+
+    @Override
+    public void visitStackConsumer(StackConsumer obj) {
+        visitStackConsumerCount++;
+    }
+
+    @Override
+    public void visitStackInstruction(StackInstruction obj) {
+        visitStackInstructionCount++;
+    }
+
+    @Override
+    public void visitStackProducer(StackProducer obj) {
+        visitStackProducerCount++;
+    }
+
+    @Override
+    public void visitStoreInstruction(StoreInstruction obj) {
+        visitStoreInstructionCount++;
+    }
+
+    @Override
+    public void visitSWAP(SWAP obj) {
+        visitSWAPCount++;
+    }
+
+    @Override
+    public void visitTABLESWITCH(TABLESWITCH obj) {
+        visitTABLESWITCHCount++;
+    }
+
+    @Override
+    public void visitTypedInstruction(TypedInstruction obj) {
+        visitTypedInstructionCount++;
+    }
+
+    @Override
+    public void visitUnconditionalBranch(UnconditionalBranch obj) {
+        visitUnconditionalBranchCount++;
+    }
+
+    @Override
+    public void visitVariableLengthInstruction(VariableLengthInstruction obj) {
+        visitVariableLengthInstructionCount++;
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        CountVisitor that = (CountVisitor) o;
+        return visitAALOADCount == that.visitAALOADCount
+                && visitAASTORECount == that.visitAASTORECount
+                && visitACONST_NULLCount == that.visitACONST_NULLCount
+                && visitAllocationInstructionCount == that.visitAllocationInstructionCount
+                && visitALOADCount == that.visitALOADCount
+                && visitANEWARRAYCount == that.visitANEWARRAYCount
+                && visitARETURNCount == that.visitARETURNCount
+                && visitArithmeticInstructionCount == that.visitArithmeticInstructionCount
+                && visitArrayInstructionCount == that.visitArrayInstructionCount
+                && visitARRAYLENGTHCount == that.visitARRAYLENGTHCount
+                && visitASTORECount == that.visitASTORECount
+                && visitATHROWCount == that.visitATHROWCount
+                && visitBALOADCount == that.visitBALOADCount
+                && visitBASTORECount == that.visitBASTORECount
+                && visitBIPUSHCount == that.visitBIPUSHCount
+                && visitBranchInstructionCount == that.visitBranchInstructionCount
+                && visitBREAKPOINTCount == that.visitBREAKPOINTCount
+                && visitCALOADCount == that.visitCALOADCount
+                && visitCASTORECount == that.visitCASTORECount
+                && visitCHECKCASTCount == that.visitCHECKCASTCount
+                && visitConstantPushInstructionCount == that.visitConstantPushInstructionCount
+                && visitConversionInstructionCount == that.visitConversionInstructionCount
+                && visitCPInstructionCount == that.visitCPInstructionCount
+                && visitD2FCount == that.visitD2FCount
+                && visitD2ICount == that.visitD2ICount
+                && visitD2LCount == that.visitD2LCount
+                && visitDADDCount == that.visitDADDCount
+                && visitDALOADCount == that.visitDALOADCount
+                && visitDASTORECount == that.visitDASTORECount
+                && visitDCMPGCount == that.visitDCMPGCount
+                && visitDCMPLCount == that.visitDCMPLCount
+                && visitDCONSTCount == that.visitDCONSTCount
+                && visitDDIVCount == that.visitDDIVCount
+                && visitDLOADCount == that.visitDLOADCount
+                && visitDMULCount == that.visitDMULCount
+                && visitDNEGCount == that.visitDNEGCount
+                && visitDREMCount == that.visitDREMCount
+                && visitDRETURNCount == that.visitDRETURNCount
+                && visitDSTORECount == that.visitDSTORECount
+                && visitDSUBCount == that.visitDSUBCount
+                && visitDUPCount == that.visitDUPCount
+                && visitDUP_X1Count == that.visitDUP_X1Count
+                && visitDUP_X2Count == that.visitDUP_X2Count
+                && visitDUP2Count == that.visitDUP2Count
+                && visitDUP2_X1Count == that.visitDUP2_X1Count
+                && visitDUP2_X2Count == that.visitDUP2_X2Count
+                && visitExceptionThrowerCount == that.visitExceptionThrowerCount
+                && visitF2DCount == that.visitF2DCount
+                && visitF2ICount == that.visitF2ICount
+                && visitF2LCount == that.visitF2LCount
+                && visitFADDCount == that.visitFADDCount
+                && visitFALOADCount == that.visitFALOADCount
+                && visitFASTORECount == that.visitFASTORECount
+                && visitFCMPGCount == that.visitFCMPGCount
+                && visitFCMPLCount == that.visitFCMPLCount
+                && visitFCONSTCount == that.visitFCONSTCount
+                && visitFDIVCount == that.visitFDIVCount
+                && visitFieldInstructionCount == that.visitFieldInstructionCount
+                && visitFieldOrMethodCount == that.visitFieldOrMethodCount
+                && visitFLOADCount == that.visitFLOADCount
+                && visitFMULCount == that.visitFMULCount
+                && visitFNEGCount == that.visitFNEGCount
+                && visitFREMCount == that.visitFREMCount
+                && visitFRETURNCount == that.visitFRETURNCount
+                && visitFSTORECount == that.visitFSTORECount
+                && visitFSUBCount == that.visitFSUBCount
+                && visitGETFIELDCount == that.visitGETFIELDCount
+                && visitGETSTATICCount == that.visitGETSTATICCount
+                && visitGOTOCount == that.visitGOTOCount
+                && visitGOTO_WCount == that.visitGOTO_WCount
+                && visitGotoInstructionCount == that.visitGotoInstructionCount
+                && visitI2BCount == that.visitI2BCount
+                && visitI2CCount == that.visitI2CCount
+                && visitI2DCount == that.visitI2DCount
+                && visitI2FCount == that.visitI2FCount
+                && visitI2LCount == that.visitI2LCount
+                && visitI2SCount == that.visitI2SCount
+                && visitIADDCount == that.visitIADDCount
+                && visitIALOADCount == that.visitIALOADCount
+                && visitIANDCount == that.visitIANDCount
+                && visitIASTORECount == that.visitIASTORECount
+                && visitICONSTCount == that.visitICONSTCount
+                && visitIDIVCount == that.visitIDIVCount
+                && visitIF_ACMPEQCount == that.visitIF_ACMPEQCount
+                && visitIF_ACMPNECount == that.visitIF_ACMPNECount
+                && visitIF_ICMPEQCount == that.visitIF_ICMPEQCount
+                && visitIF_ICMPGECount == that.visitIF_ICMPGECount
+                && visitIF_ICMPGTCount == that.visitIF_ICMPGTCount
+                && visitIF_ICMPLECount == that.visitIF_ICMPLECount
+                && visitIF_ICMPLTCount == that.visitIF_ICMPLTCount
+                && visitIF_ICMPNECount == that.visitIF_ICMPNECount
+                && visitIFEQCount == that.visitIFEQCount
+                && visitIFGECount == that.visitIFGECount
+                && visitIFGTCount == that.visitIFGTCount
+                && visitIfInstructionCount == that.visitIfInstructionCount
+                && visitIFLECount == that.visitIFLECount
+                && visitIFLTCount == that.visitIFLTCount
+                && visitIFNECount == that.visitIFNECount
+                && visitIFNONNULLCount == that.visitIFNONNULLCount
+                && visitIFNULLCount == that.visitIFNULLCount
+                && visitIINCCount == that.visitIINCCount
+                && visitILOADCount == that.visitILOADCount
+                && visitIMPDEP1Count == that.visitIMPDEP1Count
+                && visitIMPDEP2Count == that.visitIMPDEP2Count
+                && visitIMULCount == that.visitIMULCount
+                && visitINEGCount == that.visitINEGCount
+                && visitINSTANCEOFCount == that.visitINSTANCEOFCount
+                && visitINVOKEDYNAMICCount == that.visitINVOKEDYNAMICCount
+                && visitInvokeInstructionCount == that.visitInvokeInstructionCount
+                && visitINVOKEINTERFACECount == that.visitINVOKEINTERFACECount
+                && visitINVOKESPECIALCount == that.visitINVOKESPECIALCount
+                && visitINVOKESTATICCount == that.visitINVOKESTATICCount
+                && visitINVOKEVIRTUALCount == that.visitINVOKEVIRTUALCount
+                && visitIORCount == that.visitIORCount
+                && visitIREMCount == that.visitIREMCount
+                && visitIRETURNCount == that.visitIRETURNCount
+                && visitISHLCount == that.visitISHLCount
+                && visitISHRCount == that.visitISHRCount
+                && visitISTORECount == that.visitISTORECount
+                && visitISUBCount == that.visitISUBCount
+                && visitIUSHRCount == that.visitIUSHRCount
+                && visitIXORCount == that.visitIXORCount
+                && visitJSRCount == that.visitJSRCount
+                && visitJSR_WCount == that.visitJSR_WCount
+                && visitJsrInstructionCount == that.visitJsrInstructionCount
+                && visitL2DCount == that.visitL2DCount
+                && visitL2FCount == that.visitL2FCount
+                && visitL2ICount == that.visitL2ICount
+                && visitLADDCount == that.visitLADDCount
+                && visitLALOADCount == that.visitLALOADCount
+                && visitLANDCount == that.visitLANDCount
+                && visitLASTORECount == that.visitLASTORECount
+                && visitLCMPCount == that.visitLCMPCount
+                && visitLCONSTCount == that.visitLCONSTCount
+                && visitLDCCount == that.visitLDCCount
+                && visitLDC2_WCount == that.visitLDC2_WCount
+                && visitLDIVCount == that.visitLDIVCount
+                && visitLLOADCount == that.visitLLOADCount
+                && visitLMULCount == that.visitLMULCount
+                && visitLNEGCount == that.visitLNEGCount
+                && visitLoadClassCount == that.visitLoadClassCount
+                && visitLoadInstructionCount == that.visitLoadInstructionCount
+                && visitLocalVariableInstructionCount == that.visitLocalVariableInstructionCount
+                && visitLOOKUPSWITCHCount == that.visitLOOKUPSWITCHCount
+                && visitLORCount == that.visitLORCount
+                && visitLREMCount == that.visitLREMCount
+                && visitLRETURNCount == that.visitLRETURNCount
+                && visitLSHLCount == that.visitLSHLCount
+                && visitLSHRCount == that.visitLSHRCount
+                && visitLSTORECount == that.visitLSTORECount
+                && visitLSUBCount == that.visitLSUBCount
+                && visitLUSHRCount == that.visitLUSHRCount
+                && visitLXORCount == that.visitLXORCount
+                && visitMONITORENTERCount == that.visitMONITORENTERCount
+                && visitMONITOREXITCount == that.visitMONITOREXITCount
+                && visitMULTIANEWARRAYCount == that.visitMULTIANEWARRAYCount
+                && visitNEWCount == that.visitNEWCount
+                && visitNEWARRAYCount == that.visitNEWARRAYCount
+                && visitNOPCount == that.visitNOPCount
+                && visitPOPCount == that.visitPOPCount
+                && visitPOP2Count == that.visitPOP2Count
+                && visitPopInstructionCount == that.visitPopInstructionCount
+                && visitPushInstructionCount == that.visitPushInstructionCount
+                && visitPUTFIELDCount == that.visitPUTFIELDCount
+                && visitPUTSTATICCount == that.visitPUTSTATICCount
+                && visitRETCount == that.visitRETCount
+                && visitRETURNCount == that.visitRETURNCount
+                && visitReturnInstructionCount == that.visitReturnInstructionCount
+                && visitSALOADCount == that.visitSALOADCount
+                && visitSASTORECount == that.visitSASTORECount
+                && visitSelectCount == that.visitSelectCount
+                && visitSIPUSHCount == that.visitSIPUSHCount
+                && visitStackConsumerCount == that.visitStackConsumerCount
+                && visitStackInstructionCount == that.visitStackInstructionCount
+                && visitStackProducerCount == that.visitStackProducerCount
+                && visitStoreInstructionCount == that.visitStoreInstructionCount
+                && visitSWAPCount == that.visitSWAPCount
+                && visitTABLESWITCHCount == that.visitTABLESWITCHCount
+                && visitTypedInstructionCount == that.visitTypedInstructionCount
+                && visitUnconditionalBranchCount == that.visitUnconditionalBranchCount
+                && visitVariableLengthInstructionCount == that.visitVariableLengthInstructionCount;
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(visitAALOADCount

Review Comment:
   The comma should be at the end of each line, not the start. Note that you can use Eclipse to generate `hashCode()` and `equals()` methods for you which will guarantee that nothing is missing and that the formatting is not weird.



##########
src/test/java/org/apache/bcel/generic/CountVisitor.java:
##########
@@ -0,0 +1,2012 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+public class CountVisitor implements Visitor {
+
+    public int getVisitAALOADCount() {
+        return visitAALOADCount;
+    }
+
+    public int getVisitAASTORECount() {
+        return visitAASTORECount;
+    }
+
+    public int getVisitACONST_NULLCount() {
+        return visitACONST_NULLCount;
+    }
+
+    public int getVisitAllocationInstructionCount() {
+        return visitAllocationInstructionCount;
+    }
+
+    public int getVisitALOADCount() {
+        return visitALOADCount;
+    }
+
+    public int getVisitANEWARRAYCount() {
+        return visitANEWARRAYCount;
+    }
+
+    public int getVisitARETURNCount() {
+        return visitARETURNCount;
+    }
+
+    public int getVisitArithmeticInstructionCount() {
+        return visitArithmeticInstructionCount;
+    }
+
+    public int getVisitArrayInstructionCount() {
+        return visitArrayInstructionCount;
+    }
+
+    public int getVisitARRAYLENGTHCount() {
+        return visitARRAYLENGTHCount;
+    }
+
+    public int getVisitASTORECount() {
+        return visitASTORECount;
+    }
+
+    public int getVisitATHROWCount() {
+        return visitATHROWCount;
+    }
+
+    public int getVisitBALOADCount() {
+        return visitBALOADCount;
+    }
+
+    public int getVisitBASTORECount() {
+        return visitBASTORECount;
+    }
+
+    public int getVisitBIPUSHCount() {
+        return visitBIPUSHCount;
+    }
+
+    public int getVisitBranchInstructionCount() {
+        return visitBranchInstructionCount;
+    }
+
+    public int getVisitBREAKPOINTCount() {
+        return visitBREAKPOINTCount;
+    }
+
+    public int getVisitCALOADCount() {
+        return visitCALOADCount;
+    }
+
+    public int getVisitCASTORECount() {
+        return visitCASTORECount;
+    }
+
+    public int getVisitCHECKCASTCount() {
+        return visitCHECKCASTCount;
+    }
+
+    public int getVisitConstantPushInstructionCount() {
+        return visitConstantPushInstructionCount;
+    }
+
+    public int getVisitConversionInstructionCount() {
+        return visitConversionInstructionCount;
+    }
+
+    public int getVisitCPInstructionCount() {
+        return visitCPInstructionCount;
+    }
+
+    public int getVisitD2FCount() {
+        return visitD2FCount;
+    }
+
+    public int getVisitD2ICount() {
+        return visitD2ICount;
+    }
+
+    public int getVisitD2LCount() {
+        return visitD2LCount;
+    }
+
+    public int getVisitDADDCount() {
+        return visitDADDCount;
+    }
+
+    public int getVisitDALOADCount() {
+        return visitDALOADCount;
+    }
+
+    public int getVisitDASTORECount() {
+        return visitDASTORECount;
+    }
+
+    public int getVisitDCMPGCount() {
+        return visitDCMPGCount;
+    }
+
+    public int getVisitDCMPLCount() {
+        return visitDCMPLCount;
+    }
+
+    public int getVisitDCONSTCount() {
+        return visitDCONSTCount;
+    }
+
+    public int getVisitDDIVCount() {
+        return visitDDIVCount;
+    }
+
+    public int getVisitDLOADCount() {
+        return visitDLOADCount;
+    }
+
+    public int getVisitDMULCount() {
+        return visitDMULCount;
+    }
+
+    public int getVisitDNEGCount() {
+        return visitDNEGCount;
+    }
+
+    public int getVisitDREMCount() {
+        return visitDREMCount;
+    }
+
+    public int getVisitDRETURNCount() {
+        return visitDRETURNCount;
+    }
+
+    public int getVisitDSTORECount() {
+        return visitDSTORECount;
+    }
+
+    public int getVisitDSUBCount() {
+        return visitDSUBCount;
+    }
+
+    public int getVisitDUPCount() {
+        return visitDUPCount;
+    }
+
+    public int getVisitDUP_X1Count() {
+        return visitDUP_X1Count;
+    }
+
+    public int getVisitDUP_X2Count() {
+        return visitDUP_X2Count;
+    }
+
+    public int getVisitDUP2Count() {
+        return visitDUP2Count;
+    }
+
+    public int getVisitDUP2_X1Count() {
+        return visitDUP2_X1Count;
+    }
+
+    public int getVisitDUP2_X2Count() {
+        return visitDUP2_X2Count;
+    }
+
+    public int getVisitExceptionThrowerCount() {
+        return visitExceptionThrowerCount;
+    }
+
+    public int getVisitF2DCount() {
+        return visitF2DCount;
+    }
+
+    public int getVisitF2ICount() {
+        return visitF2ICount;
+    }
+
+    public int getVisitF2LCount() {
+        return visitF2LCount;
+    }
+
+    public int getVisitFADDCount() {
+        return visitFADDCount;
+    }
+
+    public int getVisitFALOADCount() {
+        return visitFALOADCount;
+    }
+
+    public int getVisitFASTORECount() {
+        return visitFASTORECount;
+    }
+
+    public int getVisitFCMPGCount() {
+        return visitFCMPGCount;
+    }
+
+    public int getVisitFCMPLCount() {
+        return visitFCMPLCount;
+    }
+
+    public int getVisitFCONSTCount() {
+        return visitFCONSTCount;
+    }
+
+    public int getVisitFDIVCount() {
+        return visitFDIVCount;
+    }
+
+    public int getVisitFieldInstructionCount() {
+        return visitFieldInstructionCount;
+    }
+
+    public int getVisitFieldOrMethodCount() {
+        return visitFieldOrMethodCount;
+    }
+
+    public int getVisitFLOADCount() {
+        return visitFLOADCount;
+    }
+
+    public int getVisitFMULCount() {
+        return visitFMULCount;
+    }
+
+    public int getVisitFNEGCount() {
+        return visitFNEGCount;
+    }
+
+    public int getVisitFREMCount() {
+        return visitFREMCount;
+    }
+
+    public int getVisitFRETURNCount() {
+        return visitFRETURNCount;
+    }
+
+    public int getVisitFSTORECount() {
+        return visitFSTORECount;
+    }
+
+    public int getVisitFSUBCount() {
+        return visitFSUBCount;
+    }
+
+    public int getVisitGETFIELDCount() {
+        return visitGETFIELDCount;
+    }
+
+    public int getVisitGETSTATICCount() {
+        return visitGETSTATICCount;
+    }
+
+    public int getVisitGOTOCount() {
+        return visitGOTOCount;
+    }
+
+    public int getVisitGOTO_WCount() {
+        return visitGOTO_WCount;
+    }
+
+    public int getVisitGotoInstructionCount() {
+        return visitGotoInstructionCount;
+    }
+
+    public int getVisitI2BCount() {
+        return visitI2BCount;
+    }
+
+    public int getVisitI2CCount() {
+        return visitI2CCount;
+    }
+
+    public int getVisitI2DCount() {
+        return visitI2DCount;
+    }
+
+    public int getVisitI2FCount() {
+        return visitI2FCount;
+    }
+
+    public int getVisitI2LCount() {
+        return visitI2LCount;
+    }
+
+    public int getVisitI2SCount() {
+        return visitI2SCount;
+    }
+
+    public int getVisitIADDCount() {
+        return visitIADDCount;
+    }
+
+    public int getVisitIALOADCount() {
+        return visitIALOADCount;
+    }
+
+    public int getVisitIANDCount() {
+        return visitIANDCount;
+    }
+
+    public int getVisitIASTORECount() {
+        return visitIASTORECount;
+    }
+
+    public int getVisitICONSTCount() {
+        return visitICONSTCount;
+    }
+
+    public int getVisitIDIVCount() {
+        return visitIDIVCount;
+    }
+
+    public int getVisitIF_ACMPEQCount() {
+        return visitIF_ACMPEQCount;
+    }
+
+    public int getVisitIF_ACMPNECount() {
+        return visitIF_ACMPNECount;
+    }
+
+    public int getVisitIF_ICMPEQCount() {
+        return visitIF_ICMPEQCount;
+    }
+
+    public int getVisitIF_ICMPGECount() {
+        return visitIF_ICMPGECount;
+    }
+
+    public int getVisitIF_ICMPGTCount() {
+        return visitIF_ICMPGTCount;
+    }
+
+    public int getVisitIF_ICMPLECount() {
+        return visitIF_ICMPLECount;
+    }
+
+    public int getVisitIF_ICMPLTCount() {
+        return visitIF_ICMPLTCount;
+    }
+
+    public int getVisitIF_ICMPNECount() {
+        return visitIF_ICMPNECount;
+    }
+
+    public int getVisitIFEQCount() {
+        return visitIFEQCount;
+    }
+
+    public int getVisitIFGECount() {
+        return visitIFGECount;
+    }
+
+    public int getVisitIFGTCount() {
+        return visitIFGTCount;
+    }
+
+    public int getVisitIfInstructionCount() {
+        return visitIfInstructionCount;
+    }
+
+    public int getVisitIFLECount() {
+        return visitIFLECount;
+    }
+
+    public int getVisitIFLTCount() {
+        return visitIFLTCount;
+    }
+
+    public int getVisitIFNECount() {
+        return visitIFNECount;
+    }
+
+    public int getVisitIFNONNULLCount() {
+        return visitIFNONNULLCount;
+    }
+
+    public int getVisitIFNULLCount() {
+        return visitIFNULLCount;
+    }
+
+    public int getVisitIINCCount() {
+        return visitIINCCount;
+    }
+
+    public int getVisitILOADCount() {
+        return visitILOADCount;
+    }
+
+    public int getVisitIMPDEP1Count() {
+        return visitIMPDEP1Count;
+    }
+
+    public int getVisitIMPDEP2Count() {
+        return visitIMPDEP2Count;
+    }
+
+    public int getVisitIMULCount() {
+        return visitIMULCount;
+    }
+
+    public int getVisitINEGCount() {
+        return visitINEGCount;
+    }
+
+    public int getVisitINSTANCEOFCount() {
+        return visitINSTANCEOFCount;
+    }
+
+    public int getVisitINVOKEDYNAMICCount() {
+        return visitINVOKEDYNAMICCount;
+    }
+
+    public int getVisitInvokeInstructionCount() {
+        return visitInvokeInstructionCount;
+    }
+
+    public int getVisitINVOKEINTERFACECount() {
+        return visitINVOKEINTERFACECount;
+    }
+
+    public int getVisitINVOKESPECIALCount() {
+        return visitINVOKESPECIALCount;
+    }
+
+    public int getVisitINVOKESTATICCount() {
+        return visitINVOKESTATICCount;
+    }
+
+    public int getVisitINVOKEVIRTUALCount() {
+        return visitINVOKEVIRTUALCount;
+    }
+
+    public int getVisitIORCount() {
+        return visitIORCount;
+    }
+
+    public int getVisitIREMCount() {
+        return visitIREMCount;
+    }
+
+    public int getVisitIRETURNCount() {
+        return visitIRETURNCount;
+    }
+
+    public int getVisitISHLCount() {
+        return visitISHLCount;
+    }
+
+    public int getVisitISHRCount() {
+        return visitISHRCount;
+    }
+
+    public int getVisitISTORECount() {
+        return visitISTORECount;
+    }
+
+    public int getVisitISUBCount() {
+        return visitISUBCount;
+    }
+
+    public int getVisitIUSHRCount() {
+        return visitIUSHRCount;
+    }
+
+    public int getVisitIXORCount() {
+        return visitIXORCount;
+    }
+
+    public int getVisitJSRCount() {
+        return visitJSRCount;
+    }
+
+    public int getVisitJSR_WCount() {
+        return visitJSR_WCount;
+    }
+
+    public int getVisitJsrInstructionCount() {
+        return visitJsrInstructionCount;
+    }
+
+    public int getVisitL2DCount() {
+        return visitL2DCount;
+    }
+
+    public int getVisitL2FCount() {
+        return visitL2FCount;
+    }
+
+    public int getVisitL2ICount() {
+        return visitL2ICount;
+    }
+
+    public int getVisitLADDCount() {
+        return visitLADDCount;
+    }
+
+    public int getVisitLALOADCount() {
+        return visitLALOADCount;
+    }
+
+    public int getVisitLANDCount() {
+        return visitLANDCount;
+    }
+
+    public int getVisitLASTORECount() {
+        return visitLASTORECount;
+    }
+
+    public int getVisitLCMPCount() {
+        return visitLCMPCount;
+    }
+
+    public int getVisitLCONSTCount() {
+        return visitLCONSTCount;
+    }
+
+    public int getVisitLDCCount() {
+        return visitLDCCount;
+    }
+
+    public int getVisitLDC2_WCount() {
+        return visitLDC2_WCount;
+    }
+
+    public int getVisitLDIVCount() {
+        return visitLDIVCount;
+    }
+
+    public int getVisitLLOADCount() {
+        return visitLLOADCount;
+    }
+
+    public int getVisitLMULCount() {
+        return visitLMULCount;
+    }
+
+    public int getVisitLNEGCount() {
+        return visitLNEGCount;
+    }
+
+    public int getVisitLoadClassCount() {
+        return visitLoadClassCount;
+    }
+
+    public int getVisitLoadInstructionCount() {
+        return visitLoadInstructionCount;
+    }
+
+    public int getVisitLocalVariableInstructionCount() {
+        return visitLocalVariableInstructionCount;
+    }
+
+    public int getVisitLOOKUPSWITCHCount() {
+        return visitLOOKUPSWITCHCount;
+    }
+
+    public int getVisitLORCount() {
+        return visitLORCount;
+    }
+
+    public int getVisitLREMCount() {
+        return visitLREMCount;
+    }
+
+    public int getVisitLRETURNCount() {
+        return visitLRETURNCount;
+    }
+
+    public int getVisitLSHLCount() {
+        return visitLSHLCount;
+    }
+
+    public int getVisitLSHRCount() {
+        return visitLSHRCount;
+    }
+
+    public int getVisitLSTORECount() {
+        return visitLSTORECount;
+    }
+
+    public int getVisitLSUBCount() {
+        return visitLSUBCount;
+    }
+
+    public int getVisitLUSHRCount() {
+        return visitLUSHRCount;
+    }
+
+    public int getVisitLXORCount() {
+        return visitLXORCount;
+    }
+
+    public int getVisitMONITORENTERCount() {
+        return visitMONITORENTERCount;
+    }
+
+    public int getVisitMONITOREXITCount() {
+        return visitMONITOREXITCount;
+    }
+
+    public int getVisitMULTIANEWARRAYCount() {
+        return visitMULTIANEWARRAYCount;
+    }
+
+    public int getVisitNEWCount() {
+        return visitNEWCount;
+    }
+
+    public int getVisitNEWARRAYCount() {
+        return visitNEWARRAYCount;
+    }
+
+    public int getVisitNOPCount() {
+        return visitNOPCount;
+    }
+
+    public int getVisitPOPCount() {
+        return visitPOPCount;
+    }
+
+    public int getVisitPOP2Count() {
+        return visitPOP2Count;
+    }
+
+    public int getVisitPopInstructionCount() {
+        return visitPopInstructionCount;
+    }
+
+    public int getVisitPushInstructionCount() {
+        return visitPushInstructionCount;
+    }
+
+    public int getVisitPUTFIELDCount() {
+        return visitPUTFIELDCount;
+    }
+
+    public int getVisitPUTSTATICCount() {
+        return visitPUTSTATICCount;
+    }
+
+    public int getVisitRETCount() {
+        return visitRETCount;
+    }
+
+    public int getVisitRETURNCount() {
+        return visitRETURNCount;
+    }
+
+    public int getVisitReturnInstructionCount() {
+        return visitReturnInstructionCount;
+    }
+
+    public int getVisitSALOADCount() {
+        return visitSALOADCount;
+    }
+
+    public int getVisitSASTORECount() {
+        return visitSASTORECount;
+    }
+
+    public int getVisitSelectCount() {
+        return visitSelectCount;
+    }
+
+    public int getVisitSIPUSHCount() {
+        return visitSIPUSHCount;
+    }
+
+    public int getVisitStackConsumerCount() {
+        return visitStackConsumerCount;
+    }
+
+    public int getVisitStackInstructionCount() {
+        return visitStackInstructionCount;
+    }
+
+    public int getVisitStackProducerCount() {
+        return visitStackProducerCount;
+    }
+
+    public int getVisitStoreInstructionCount() {
+        return visitStoreInstructionCount;
+    }
+
+    public int getVisitSWAPCount() {
+        return visitSWAPCount;
+    }
+
+    public int getVisitTABLESWITCHCount() {
+        return visitTABLESWITCHCount;
+    }
+
+    public int getVisitTypedInstructionCount() {
+        return visitTypedInstructionCount;
+    }
+
+    public int getVisitUnconditionalBranchCount() {
+        return visitUnconditionalBranchCount;
+    }
+
+    public int getVisitVariableLengthInstructionCount() {
+        return visitVariableLengthInstructionCount;
+    }
+
+    private int visitAALOADCount = 0;
+
+    @Override
+    public void visitAALOAD(AALOAD obj) {
+        visitAALOADCount++;
+    }
+
+    private int visitAASTORECount = 0;
+
+    @Override
+    public void visitAASTORE(AASTORE obj) {
+        visitAASTORECount++;
+    }
+
+    private int visitACONST_NULLCount = 0;
+
+    @Override
+    public void visitACONST_NULL(ACONST_NULL obj) {
+        visitACONST_NULLCount++;
+    }
+
+    private int visitAllocationInstructionCount = 0;
+
+    @Override
+    public void visitAllocationInstruction(AllocationInstruction obj) {
+        visitAllocationInstructionCount++;
+    }
+
+    private int visitALOADCount = 0;
+
+    @Override
+    public void visitALOAD(ALOAD obj) {
+        visitALOADCount++;
+    }
+
+    private int visitANEWARRAYCount = 0;
+
+    @Override
+    public void visitANEWARRAY(ANEWARRAY obj) {
+        visitANEWARRAYCount++;
+    }
+
+    private int visitARETURNCount = 0;
+
+    @Override
+    public void visitARETURN(ARETURN obj) {
+        visitARETURNCount++;
+    }
+
+    private int visitArithmeticInstructionCount = 0;
+
+    @Override
+    public void visitArithmeticInstruction(ArithmeticInstruction obj) {
+        visitArithmeticInstructionCount++;
+    }
+
+    private int visitArrayInstructionCount = 0;
+
+    @Override
+    public void visitArrayInstruction(ArrayInstruction obj) {
+        visitArrayInstructionCount++;
+    }
+
+    private int visitARRAYLENGTHCount = 0;
+
+    @Override
+    public void visitARRAYLENGTH(ARRAYLENGTH obj) {
+        visitARRAYLENGTHCount++;
+    }
+
+    private int visitASTORECount = 0;
+
+    @Override
+    public void visitASTORE(ASTORE obj) {
+        visitASTORECount++;
+    }
+
+    private int visitATHROWCount = 0;
+
+    @Override
+    public void visitATHROW(ATHROW obj) {
+        visitATHROWCount++;
+    }
+
+    private int visitBALOADCount = 0;
+
+    @Override
+    public void visitBALOAD(BALOAD obj) {
+        visitBALOADCount++;
+    }
+
+    private int visitBASTORECount = 0;
+
+    @Override
+    public void visitBASTORE(BASTORE obj) {
+        visitBASTORECount++;
+    }
+
+    private int visitBIPUSHCount = 0;
+
+    @Override
+    public void visitBIPUSH(BIPUSH obj) {
+        visitBIPUSHCount++;
+    }
+
+    private int visitBranchInstructionCount = 0;
+
+    @Override
+    public void visitBranchInstruction(BranchInstruction obj) {
+        visitBranchInstructionCount++;
+    }
+
+    private int visitBREAKPOINTCount = 0;
+
+    @Override
+    public void visitBREAKPOINT(BREAKPOINT obj) {
+        visitBREAKPOINTCount++;
+    }
+
+    private int visitCALOADCount = 0;
+
+    @Override
+    public void visitCALOAD(CALOAD obj) {
+        visitCALOADCount++;
+    }
+
+    private int visitCASTORECount = 0;
+
+    @Override
+    public void visitCASTORE(CASTORE obj) {
+        visitCASTORECount++;
+    }
+
+    private int visitCHECKCASTCount = 0;
+
+    @Override
+    public void visitCHECKCAST(CHECKCAST obj) {
+        visitCHECKCASTCount++;
+    }
+
+    private int visitConstantPushInstructionCount = 0;
+
+    @Override
+    public void visitConstantPushInstruction(ConstantPushInstruction obj) {
+        visitConstantPushInstructionCount++;
+    }
+
+    private int visitConversionInstructionCount = 0;
+
+    @Override
+    public void visitConversionInstruction(ConversionInstruction obj) {
+        visitConversionInstructionCount++;
+    }
+
+    private int visitCPInstructionCount = 0;
+
+    @Override
+    public void visitCPInstruction(CPInstruction obj) {
+        visitCPInstructionCount++;
+    }
+
+    private int visitD2FCount = 0;
+
+    @Override
+    public void visitD2F(D2F obj) {
+        visitD2FCount++;
+    }
+
+    private int visitD2ICount = 0;
+
+    @Override
+    public void visitD2I(D2I obj) {
+        visitD2ICount++;
+    }
+
+    private int visitD2LCount = 0;
+
+    @Override
+    public void visitD2L(D2L obj) {
+        visitD2LCount++;
+    }
+
+    private int visitDADDCount = 0;
+
+    @Override
+    public void visitDADD(DADD obj) {
+        visitDADDCount++;
+    }
+
+    private int visitDALOADCount = 0;
+
+    @Override
+    public void visitDALOAD(DALOAD obj) {
+        visitDALOADCount++;
+    }
+
+    private int visitDASTORECount = 0;
+
+    @Override
+    public void visitDASTORE(DASTORE obj) {
+        visitDASTORECount++;
+    }
+
+    private int visitDCMPGCount = 0;
+
+    @Override
+    public void visitDCMPG(DCMPG obj) {
+        visitDCMPGCount++;
+    }
+
+    private int visitDCMPLCount = 0;
+
+    @Override
+    public void visitDCMPL(DCMPL obj) {
+        visitDCMPLCount++;
+    }
+
+    private int visitDCONSTCount = 0;
+
+    @Override
+    public void visitDCONST(DCONST obj) {
+        visitDCONSTCount++;
+    }
+
+    private int visitDDIVCount = 0;
+
+    @Override
+    public void visitDDIV(DDIV obj) {
+        visitDDIVCount++;
+    }
+
+    private int visitDLOADCount = 0;
+
+    @Override
+    public void visitDLOAD(DLOAD obj) {
+        visitDLOADCount++;
+    }
+
+    private int visitDMULCount = 0;
+
+    @Override
+    public void visitDMUL(DMUL obj) {
+        visitDMULCount++;
+    }
+
+    private int visitDNEGCount = 0;
+
+    @Override
+    public void visitDNEG(DNEG obj) {
+        visitDNEGCount++;
+    }
+
+    private int visitDREMCount = 0;
+
+    @Override
+    public void visitDREM(DREM obj) {
+        visitDREMCount++;
+    }
+
+    private int visitDRETURNCount = 0;
+
+    @Override
+    public void visitDRETURN(DRETURN obj) {
+        visitDRETURNCount++;
+    }
+
+    private int visitDSTORECount = 0;
+
+    @Override
+    public void visitDSTORE(DSTORE obj) {
+        visitDSTORECount++;
+    }
+
+    private int visitDSUBCount = 0;
+
+    @Override
+    public void visitDSUB(DSUB obj) {
+        visitDSUBCount++;
+    }
+
+    private int visitDUPCount = 0;
+
+    @Override
+    public void visitDUP(DUP obj) {
+        visitDUPCount++;
+    }
+
+    private int visitDUP_X1Count = 0;
+
+    @Override
+    public void visitDUP_X1(DUP_X1 obj) {
+        visitDUP_X1Count++;
+    }
+
+    private int visitDUP_X2Count = 0;
+
+    @Override
+    public void visitDUP_X2(DUP_X2 obj) {
+        visitDUP_X2Count++;
+    }
+
+    private int visitDUP2Count = 0;
+
+    @Override
+    public void visitDUP2(DUP2 obj) {
+        visitDUP2Count++;
+    }
+
+    private int visitDUP2_X1Count = 0;
+
+    @Override
+    public void visitDUP2_X1(DUP2_X1 obj) {
+        visitDUP2_X1Count++;
+    }
+
+    private int visitDUP2_X2Count = 0;
+
+    @Override
+    public void visitDUP2_X2(DUP2_X2 obj) {
+        visitDUP2_X2Count++;
+    }
+
+    private int visitExceptionThrowerCount = 0;
+
+    @Override
+    public void visitExceptionThrower(ExceptionThrower obj) {
+        visitExceptionThrowerCount++;
+    }
+
+    private int visitF2DCount = 0;
+
+    @Override
+    public void visitF2D(F2D obj) {
+        visitF2DCount++;
+    }
+
+    private int visitF2ICount = 0;
+
+    @Override
+    public void visitF2I(F2I obj) {
+        visitF2ICount++;
+    }
+
+    private int visitF2LCount = 0;
+
+    @Override
+    public void visitF2L(F2L obj) {
+        visitF2LCount++;
+    }
+
+    private int visitFADDCount = 0;
+
+    @Override
+    public void visitFADD(FADD obj) {
+        visitFADDCount++;
+    }
+
+    private int visitFALOADCount = 0;
+
+    @Override
+    public void visitFALOAD(FALOAD obj) {
+        visitFALOADCount++;
+    }
+
+    private int visitFASTORECount = 0;
+
+    @Override
+    public void visitFASTORE(FASTORE obj) {
+        visitFASTORECount++;
+    }
+
+    private int visitFCMPGCount = 0;
+
+    @Override
+    public void visitFCMPG(FCMPG obj) {
+        visitFCMPGCount++;
+    }
+
+    private int visitFCMPLCount = 0;
+
+    @Override
+    public void visitFCMPL(FCMPL obj) {
+        visitFCMPLCount++;
+    }
+
+    private int visitFCONSTCount = 0;
+
+    @Override
+    public void visitFCONST(FCONST obj) {
+        visitFCONSTCount++;
+    }
+
+    private int visitFDIVCount = 0;
+
+    @Override
+    public void visitFDIV(FDIV obj) {
+        visitFDIVCount++;
+    }
+
+    private int visitFieldInstructionCount = 0;
+
+    @Override
+    public void visitFieldInstruction(FieldInstruction obj) {
+        visitFieldInstructionCount++;
+    }
+
+    private int visitFieldOrMethodCount = 0;
+
+    @Override
+    public void visitFieldOrMethod(FieldOrMethod obj) {
+        visitFieldOrMethodCount++;
+    }
+
+    private int visitFLOADCount = 0;
+
+    @Override
+    public void visitFLOAD(FLOAD obj) {
+        visitFLOADCount++;
+    }
+
+    private int visitFMULCount = 0;
+
+    @Override
+    public void visitFMUL(FMUL obj) {
+        visitFMULCount++;
+    }
+
+    private int visitFNEGCount = 0;
+
+    @Override
+    public void visitFNEG(FNEG obj) {
+        visitFNEGCount++;
+    }
+
+    private int visitFREMCount = 0;
+
+    @Override
+    public void visitFREM(FREM obj) {
+        visitFREMCount++;
+    }
+
+    private int visitFRETURNCount = 0;
+
+    @Override
+    public void visitFRETURN(FRETURN obj) {
+        visitFRETURNCount++;
+    }
+
+    private int visitFSTORECount = 0;
+
+    @Override
+    public void visitFSTORE(FSTORE obj) {
+        visitFSTORECount++;
+    }
+
+    private int visitFSUBCount = 0;
+
+    @Override
+    public void visitFSUB(FSUB obj) {
+        visitFSUBCount++;
+    }
+
+    private int visitGETFIELDCount = 0;
+
+    @Override
+    public void visitGETFIELD(GETFIELD obj) {
+        visitGETFIELDCount++;
+    }
+
+    private int visitGETSTATICCount = 0;
+
+    @Override
+    public void visitGETSTATIC(GETSTATIC obj) {
+        visitGETSTATICCount++;
+    }
+
+    private int visitGOTOCount = 0;
+
+    @Override
+    public void visitGOTO(GOTO obj) {
+        visitGOTOCount++;
+    }
+
+    private int visitGOTO_WCount = 0;
+
+    @Override
+    public void visitGOTO_W(GOTO_W obj) {
+        visitGOTO_WCount++;
+    }
+
+    private int visitGotoInstructionCount = 0;
+
+    @Override
+    public void visitGotoInstruction(GotoInstruction obj) {
+        visitGotoInstructionCount++;
+    }
+
+    private int visitI2BCount = 0;
+
+    @Override
+    public void visitI2B(I2B obj) {
+        visitI2BCount++;
+    }
+
+    private int visitI2CCount = 0;
+
+    @Override
+    public void visitI2C(I2C obj) {
+        visitI2CCount++;
+    }
+
+    private int visitI2DCount = 0;
+
+    @Override
+    public void visitI2D(I2D obj) {
+        visitI2DCount++;
+    }
+
+    private int visitI2FCount = 0;
+
+    @Override
+    public void visitI2F(I2F obj) {
+        visitI2FCount++;
+    }
+
+    private int visitI2LCount = 0;
+
+    @Override
+    public void visitI2L(I2L obj) {
+        visitI2LCount++;
+    }
+
+    private int visitI2SCount = 0;
+
+    @Override
+    public void visitI2S(I2S obj) {
+        visitI2SCount++;
+    }
+
+    private int visitIADDCount = 0;
+
+    @Override
+    public void visitIADD(IADD obj) {
+        visitIADDCount++;
+    }
+
+    private int visitIALOADCount = 0;
+
+    @Override
+    public void visitIALOAD(IALOAD obj) {
+        visitIALOADCount++;
+    }
+
+    private int visitIANDCount = 0;
+
+    @Override
+    public void visitIAND(IAND obj) {
+        visitIANDCount++;
+    }
+
+    private int visitIASTORECount = 0;
+
+    @Override
+    public void visitIASTORE(IASTORE obj) {
+        visitIASTORECount++;
+    }
+
+    private int visitICONSTCount = 0;
+
+    @Override
+    public void visitICONST(ICONST obj) {
+        visitICONSTCount++;
+    }
+
+    private int visitIDIVCount = 0;
+
+    @Override
+    public void visitIDIV(IDIV obj) {
+        visitIDIVCount++;
+    }
+
+    private int visitIF_ACMPEQCount = 0;
+
+    @Override
+    public void visitIF_ACMPEQ(IF_ACMPEQ obj) {
+        visitIF_ACMPEQCount++;
+    }
+
+    private int visitIF_ACMPNECount = 0;
+
+    @Override
+    public void visitIF_ACMPNE(IF_ACMPNE obj) {
+        visitIF_ACMPNECount++;
+    }
+
+    private int visitIF_ICMPEQCount = 0;
+
+    @Override
+    public void visitIF_ICMPEQ(IF_ICMPEQ obj) {
+        visitIF_ICMPEQCount++;
+    }
+
+    private int visitIF_ICMPGECount = 0;
+
+    @Override
+    public void visitIF_ICMPGE(IF_ICMPGE obj) {
+        visitIF_ICMPGECount++;
+    }
+
+    private int visitIF_ICMPGTCount = 0;
+
+    @Override
+    public void visitIF_ICMPGT(IF_ICMPGT obj) {
+        visitIF_ICMPGTCount++;

Review Comment:
   This a _visitor_ that _only_ counts, so naming every ivars `visitSomethingCount` feels redundant to me, I would keep the names as simple as possible like `something`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #162: improve test coverage to bcel/generic and UtilityTest

Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #162:
URL: https://github.com/apache/commons-bcel/pull/162#discussion_r1011811645


##########
src/test/java/org/apache/bcel/generic/DMULTestCase.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bcel.generic;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class DMULTestCase {
+    @Test
+    public void accept() {
+        CountVisitor countVisitor = new CountVisitor();
+        DMUL dmul = new DMUL();
+        dmul.accept(countVisitor);
+        assertEquals(1, countVisitor.getVisitTypedInstructionCount());

Review Comment:
   What about all the other values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org