You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/01/01 12:14:33 UTC

[GitHub] zeppelin pull request #1829: [DOCS] Remove outdated 'Security Setup' section...

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1829

    [DOCS] Remove outdated 'Security Setup' section in SECURITY-README

    ### What is this PR for?
    [SECURITY-README.md](https://github.com/apache/zeppelin/blob/master/SECURITY-README.md) was added by #53 when Shiro auth was implemented for the first time. But I think we need to keep "Security Setup" information in one source; [Official docs website](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#security-setup) and guide ppl to see this official docs page so that `SECURITY-README.md` can only contain dev related contents (not step by step setup guide).
    
    ### What type of PR is it?
    Documentation
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    Just clicking "View" would be enough I guess :)
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin remove/duplicatedSection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1829
    
----
commit d908da95a63b7bcf4ff7861afc883552649df7e2
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2017-01-01T07:50:58Z

    Remove outdated 'Security Setup' section in SECURITY-README

commit 3e867acb1d5f18ce6f9a67e35a32933694d2e479
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2017-01-01T07:51:16Z

    Fix wired numbering

commit 8ce33bef3ef5a46e45851769123504421082f57a
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2017-01-01T08:01:23Z

    Remove note sentence

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1829: [DOCS] Remove outdated 'Security Setup' section in SEC...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/1829
  
    Hmm, true, it's possible that way.
    I just thought its better to point to the latest release, but I can see your point here.
    
    I don't feel strongly either case, so LGTM.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1829: [DOCS] Remove outdated 'Security Setup' section...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1829


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1829: [DOCS] Remove outdated 'Security Setup' section in SEC...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1829
  
    @felixcheung Yeah I know what you mean. Thanks for your suggestion and review anyway! 
    Then will merge this into master if there are no more comments :) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1829: [DOCS] Remove outdated 'Security Setup' section in SEC...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1829
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---