You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Marcin (JIRA)" <ji...@apache.org> on 2010/02/01 12:11:50 UTC
[jira] Created: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
error reporting is rendering "404 missing core name in path" for all type of errors
-----------------------------------------------------------------------------------
Key: SOLR-1743
URL: https://issues.apache.org/jira/browse/SOLR-1743
Project: Solr
Issue Type: Bug
Components: Build
Environment: all
Reporter: Marcin
Fix For: 1.5
despite the error in schema syntax or any other type of error you will always get:
"404 missing core name in path" communicate.
cheers,
/Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840045#action_12840045 ]
Hoss Man commented on SOLR-1743:
--------------------------------
Okay now i'm just going to rant...
abortOnConfigurationError feels like it's just devolved into nonsense at this point .. the orriginal purpose was to let people configure wether they wanted to solr to try to keep running even if something like a request handler couldn't be loaded -- set it to true and solr wouldn't start up and the admin screen would tell you why, set it to false and solr would work, but requests for that request handler would fail
once we added multicore support, the usage of abortOnConfigurationError just stoped making sense ... if your solr.xml refers to just core1, and core1's solrconfig.xml sets it to "false" and has a request handler that can't be llooaded things keep working -- but if you also have a core2 whose solrconfig.xml sets it to "true" then the whole server won't start up ... that's just silly.
Maybe it's just time to rethink the whole damn thing...
* deprecate the SolrConfig.SEVERE_ERRORS singleton - make SolrCore start keeping a personal list of exceptions it was able to get past (ie: a plugin it couldn't load)
* Eliminate Initializer.isAbortOnConfigurationError - instead make each SolreCore keep track of that itself
* if initializing a core throws an exception (either from parsing the config, or from instantiating the SolrCore or IndexSchema) CoreContainer should keep track of that exception as being specific to that core name (Map<String,Exception>)
** removing a core, or recreating a core with the same name should clear any corresponding entry from this map
* when SolrDispatchFilter processes a path, it should generate a useful error message in either case:
** CoreContainer says it has an init exception for the core name that corresponds to that path
** the SolrCore exists; has sAbortOnConfigurationError()=true; and has a non-empty list of exceptions
...thoughts?
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-1743:
---------------------------
Attachment: SOLR-1743.restore14behavior.patch
Ok, I've been doing some more testing...
First off: a lot of my early comments on this issue were inaccurate -- in some cases I was trying to test the behavior of trunk using a "single core" example with some errors in the solrconfig.xml, but i was using the "example/solr" dir on the trunk, and i completly forgot that it has a solr.xml file in it now.
>From what i can tell, the only real difference between the behavior of trunk, and the behavior of Solr 1.4 is that: in 1.4 when using legacy single core mode (ie: no solr.xml) you would get good error messages if an low level error happened that completely prevented the core from loading (ie: schema init problem, or xml parsing problem with solrconfig.xml) This is because the default behavior of abortOnConfigurationError was "true" for legacy single core mode, and that boolean drives SolrDispatchFilter's decision about what type of error message to display.
The latest attached patch (SOLR-1743.restore14behavior.patch) should get us back to the error reporting behavior of Solr 1.4 -- i think we should go ahead and commit this to the trunk as a temporary fix for the current bug, while we flesh out improvements to the entire concept of abortOnConfigurationError in another issue.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.restore14behavior.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-1743:
------------------------------
Attachment: SOLR-1743.patch
Well its no surprise that I'm confusing...
But I swear I tested that stupid patch - and yet .. I must not have ...
Here is a patch updated to trunk and with the correct fix.
Was still looking at the abortOnConfig setting in the wrong place - if the schema couldn't load, an exception *still* caused the setting check to be skipped -
so setting check has to go in the createCore call, right after the config object is created.
Swear I'm looking at the darn exception at http://localhost:8983/solr/admin/ right now.
Like I said, this is not a full fix to the issue, but it least puts us back where we were with single core, and solves half the multi core problem.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843373#action_12843373 ]
Hoss Man commented on SOLR-1743:
--------------------------------
bq. Okay, I sat down and thought about what we should do before really reading through your suggestion - and I came up with practically the exact same thing - so I think this is what we should attempt.
I know i brought it up here in the issue comments, but I think we should probably track this type of change in a separate issue as an "Improvement"
for the scope of this issue, let's start by getting a simpler patch commited that at least restores the behavior from 1.4 -- w/solr.xml you always get "missing core name" on config error, w/o solr.xml you get good error messages even if solrconfig.xml can't be parsed. It won't help new users in who start with the current example from the trunk (since it has a solr.xml) but it will get things back to where they were for existing users who try upgrading.
As i recall one of the patches already posted does this just fine (i just can't remember which one) so that part should be fairly straight forward.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844227#action_12844227 ]
Mark Miller commented on SOLR-1743:
-----------------------------------
This looks good to me as a first step - tested with both config and schema errors.
Would be nice if single core with the solr.xml also worked, but no biggie - we can fix with the rest of multi-core.
bq. Note for no good reason what so ever,
Well, I think it was supposed to work (even though the whole idea is kind of broken anway), cause it attempted to, so reason is prob a bug ...
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.restore14behavior.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830271#action_12830271 ]
Mark Miller commented on SOLR-1743:
-----------------------------------
Not quite as bad as I thought - I guess this is setup to work right with multicore. Wasn't seeing the full picture.
The reason we don't see the error is because the core doesn't load, and abortOnConfigurationError never gets set to true. We don't handle that setting correctly with MultiCore - we check it by iterating through all of the cores that loaded - but a core with a config erorr wouldn't have loaded ... so abortOnConfigError gets read as false when it should be true.
So we can fix that, but if you *don't* want to abortOnConfiguration error, your still going to see this confusing message, so we should prob improve on that as well.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839948#action_12839948 ]
Hoss Man commented on SOLR-1743:
--------------------------------
Mark: i'm confused by your comments/patch
I applied your patch allong with the schema.xml "typo" patch i posted above to Solr trunk (r917814) and still got "missing core name in path" when hitting http://localhost:8983/solr/admin/
I thought that since example/solr/conf/solrconfig.xml uses {{<abortOnConfigurationError>${solr.abortOnConfigurationError:true}</abortOnConfigurationError>}} it would fall into the situation you described as being fixed?
(Did you maybe attach a different version of the patch then you ment to?)
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840021#action_12840021 ]
Hoss Man commented on SOLR-1743:
--------------------------------
Grrrr... ignore that last patch, it changes the default behavior to be like abortOnConfigurationError=true for multicores even if no core ever asked for it ... which would be bad (in 1.4 those cores will all still load, but with this patch they won't)
Still thinking about it....
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843227#action_12843227 ]
Mark Miller commented on SOLR-1743:
-----------------------------------
Okay, I sat down and thought about what we should do before really reading through your suggestion - and I came up with practically the exact same thing - so I think this is what we should attempt.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843355#action_12843355 ]
Mark Miller commented on SOLR-1743:
-----------------------------------
So from what I can see - the immediate problem here is that places that would like to register an error do not have access to the core name - eg schema, solrconfig
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840177#action_12840177 ]
Mark Miller commented on SOLR-1743:
-----------------------------------
Hoss - I've got to digest and respond to this more fully later, but:
Yes, I def agree the best solution is something entirely different. I agree that the current, historical based stuff is just not right for multicore. What I've tried to do is just hack things back closer to what they were, but a real solution would be to start from scratch and handle things better -
Sounds like you have an idea for that, and I'll dig into your explanation when I get a chance and perhaps off some feedback.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-1743:
---------------------------
Attachment: SOLR-1743.patch
I think i give up.
First off: sorry mark, this comment was way off base...
bq. I'm also wondering if your patch breaks the purpose of CoreContainer.Initializer.setAbortOnConfigurationError
...digging through the history i realized that this is how Initializer has always worked: you can set the default behavior for "legacy" single core mode, but whenever it sees a solr.xml file it overwrites that default value with "false"
This is fundamentally what's bitch slapping me at the moment ... the attached patch tries to mimic the historical behavior, and i think i saw it work (but i'm kinda cross-eeyed right now so i can honestly say you shouldn't take my word for it -- i wouldn't) but it doesn't really address the fact that since the example now contains a solr.xml, anybody who starts with the Solr 1.5 example and makes a typo in their solrconfig.xml so that it's not well formed won't get a useful error message in the browser like they would in Solr 1.4
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840014#action_12840014 ]
Hoss Man commented on SOLR-1743:
--------------------------------
No worries dude .. i don't really even understand how it worked before, let alone with your patch.
Your latest version deals with my typo in schema.xml example, but when testing out some other use cases it looks like the default assumption was that abortOnConfigurationError=true unless the solrconfig.xml can be parsed cleanly and sets it to false ... which means that in 1.4 a single core malformed solrconfig.xml (ie: garbage in the prolog) would generate a good error message -- and with your latest patch it still generates the "missind core name" error.
It seems like in order to preserve we need to use tertiary state for the CoreContainer.abortOnConfigurationError ... null assumes true until at least one solrocnfig.xml is parsed cleanly, then false unless at least one config sets it to true.
I'm also wondering if your patch breaks the purpose of CoreContainer.Initializer.setAbortOnConfigurationError ... i think the idea there was that prior to initializing the CoreContainer, Embedded Solr users could call that method to force abortOnConfigurationError even if it wasn't set in any of hte solrconfig.xml files.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-1743:
------------------------------
Attachment: SOLR-1743.patch
Fixes the "at least one core has abortOnConfigError = true" case.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller reassigned SOLR-1743:
---------------------------------
Assignee: Mark Miller
I think this was always a bug with MultiCore and single core worked. Now that we always run in "multicore mode", its just more prominent. I think. Anyway, I see whats going wrong and I'll take a whack at a fix.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man resolved SOLR-1743.
----------------------------
Resolution: Fixed
Committed revision 923909.
NOTE: since this bug was introduced after 1.4, and since i expect it to get superceeded by SOLR-1817 prior to the next release, I didn't bother with a CHANGES.txt entry
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.restore14behavior.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829828#action_12829828 ]
Mark Miller commented on SOLR-1743:
-----------------------------------
bq. ... I'll take a whack at a fix.
Heh - perhaps I will. Annoyingly, its going to take some thought. The old machinery counts on an exception while building the core bubbling up to the dispatchfilter init method - but the corecontainer swallows such exceptions, as we try and run other cores even if one is whacked. Anyway, this error reporting will have to be done in a completely different way to properly work with multicore.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-1743:
---------------------------
Attachment: SOLR-1743.patch
Ok, here's my attempt at making sense of this.
As far as i can tell this restores all of the useful behavior that SOlr 1.4 had with abortOnConfirurationError in single core mode ... some quick multicore testing makes me think it's improved the error reporting in some situations there as well, but i'm sure i haven't tried all of the edge cases -- it may have broken something.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller updated SOLR-1743:
------------------------------
Attachment: SOLR-1743.patch
Here is a quick attempt at solving most of the rest of this.
The idea is:
reporting that the mutlicore core name is missing on the http://localhost:8983/solr/admin/ page is now not always correct when SolrCore is not put into the request.
Sometimes this means an error in one of the cores - though with the previous part of this patch you only run into this issue when abortOnConfigError is false.
But anyway, what this does is: if there is no default core specified, the old error is shown - you are missing the corename.
If there is a default core specified (and there is by default these days - collection1), and that core couldn't load, all of the errors found while loading cores are printed to the page:
HTTP ERROR: 404
Severe errors in solr configuration.
Check your log files for more detailed information on what may be wrong.
The following are the errors registered by the cores you tried to load:
Could prob be a better message even.
Still, if you try and go to the full url of a core that couldn't load, you will get page not found - because the core will have never loaded. Would be nice to see the error there too, but this is as far as I go at the moment.
This patch also removes a System.out in the last patch and fixes a bug in reading the defaultCoreName from solr.xml - it was looking for it at /solr when it should have been looking at /solr/cores.
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Assignee: Mark Miller
> Fix For: 1.5
>
> Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1743) error reporting is rendering "404
missing core name in path" for all type of errors
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829747#action_12829747 ]
Hoss Man commented on SOLR-1743:
--------------------------------
We definitely shouldn't be generating a "missing core name in path" for situations like missconfiguration in a single core setup.
In the trunk, things like attempting to load a RequestHandler class that can't be found correctly result in a "Severe errors in solr configuration." type message in the browser, which then shows the stack trace of the problem.
However: something as simple as a typoe like this...
{code}
Index: example/solr/conf/schema.xml
===================================================================
--- example/solr/conf/schema.xml (revision 906596)
+++ example/solr/conf/schema.xml (working copy)
@@ -456,7 +456,7 @@
when adding a document.
-->
- <field name="id" type="string" indexed="true" stored="true" required="true" />
+ <field name="id" type="asdfasdf" indexed="true" stored="true" required="true" />
<field name="sku" type="textTight" indexed="true" stored="true" omitNorms="true"/>
<field name="name" type="textgen" indexed="true" stored="true"/>
<field name="alphaNameSort" type="alphaOnlySort" indexed="true" stored="false"/>
{code}
...results in http://localhost:8983/solr/admin/ generating the "missing core name in path" error described, with no other context.
In Solr 1.4, this same type of error would have generated a "Severe errors in solr configuration." type message (w/ stack trace) so this definitely seems like a new bug in IndexSchema config error handling introduced in the trunk since Solr 1.4
> error reporting is rendering "404 missing core name in path" for all type of errors
> -----------------------------------------------------------------------------------
>
> Key: SOLR-1743
> URL: https://issues.apache.org/jira/browse/SOLR-1743
> Project: Solr
> Issue Type: Bug
> Components: Build
> Environment: all
> Reporter: Marcin
> Fix For: 1.5
>
>
> despite the error in schema syntax or any other type of error you will always get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.