You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by brandtg <gi...@git.apache.org> on 2014/09/16 02:29:36 UTC

[GitHub] helix pull request: Back-pressure handler in NettyHelixIPCService

GitHub user brandtg opened a pull request:

    https://github.com/apache/helix/pull/4

    Back-pressure handler in NettyHelixIPCService

    Removes hack in which Netty Channel was periodically closed to allow Netty objects to be GC'ed in favor of properly using channel writability changed events.
    
    Before calling `Channel#writeAndFlush`, we call `BackPressureHandler#waitUntilWritable`, which will block if the channel is not writable until `#channelWritabilityChanged` is called.
    
    Ran `BenchmarkDriver` locally to verify that heap usage stays relatively low and constant when NIC saturated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brandtg/helix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit 6c0f13bb703f6949177775da84cfc15f11f84179
Author: Greg Brandt <br...@gmail.com>
Date:   2014-09-15T22:56:07Z

    Back-pressure handler in NettyHelixIPCService

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: Back-pressure handler in NettyHelixIPCService

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: Back-pressure handler in NettyHelixIPCService

Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on the pull request:

    https://github.com/apache/helix/pull/4#issuecomment-55691652
  
    Verified build and mvn test. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---