You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/02/28 15:34:54 UTC

[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #130: fix: Fix cmake build + test and verification script on Windows

paleolimbot opened a new pull request, #130:
URL: https://github.com/apache/arrow-nanoarrow/pull/130

   Before this PR, any invocation of cmake build + test and/or running the verification script fails on Windows because (1) the most common R executable path has a space (`C:/Program Files/R/...`) and because dynamically linking Arrow is hard.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot commented on pull request #130: fix: Fix cmake build + test and verification script on Windows

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #130:
URL: https://github.com/apache/arrow-nanoarrow/pull/130#issuecomment-1448429302

   Verified that this works out-of-the-box when you open this repo in VSCode on Windows (with a normal CMake install).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #130: fix: Fix cmake build + test and verification script on Windows

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #130:
URL: https://github.com/apache/arrow-nanoarrow/pull/130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #130: fix: Fix cmake build + test and verification script on Windows

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #130:
URL: https://github.com/apache/arrow-nanoarrow/pull/130#issuecomment-1448408736

   # [Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#130](https://codecov.io/gh/apache/arrow-nanoarrow/pull/130?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb9f092) into [main](https://codecov.io/gh/apache/arrow-nanoarrow/commit/a843dd4a2addf644689471e914b0433a343db8d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a843dd4) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##             main     #130   +/-   ##
   =======================================
     Coverage   92.91%   92.91%           
   =======================================
     Files           7        7           
     Lines        1652     1652           
     Branches       52       52           
   =======================================
     Hits         1535     1535           
     Misses         84       84           
     Partials       33       33           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org