You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 07:40:29 UTC
[GitHub] [flink] zhijiangW opened a new pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
zhijiangW opened a new pull request #12163:
URL: https://github.com/apache/flink/pull/12163
## What is the purpose of the change
Currently we rely on whether unaligned checkpoint is enabled to determine whether to read recovered states during task startup, then it will block the requirements of recovery from previous unaligned states even though the current mode is aligned.
We can make `ChannelStateReader` provide the hint whether there are any channel states to be read during startup, then we will never lose any chances to recover from them.
## Brief change log
- Provide `ChannelStateReader#hasStates` interface methods and implements it in related instances.
- Adjust the condition in `StreamTask#beforeInvoke` to reuse the new hint.
## Verifying this change
new unit test in `StreamTaskTest#testBeforeInvokeWithoutChannelStates`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #12163:
URL: https://github.com/apache/flink/pull/12163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629611014
Private azure build succeeded https://dev.azure.com/pnowojski/Flink/_build/results?buildId=35&view=results % unrelated known issue https://issues.apache.org/jira/browse/FLINK-17724
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629094177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cf3fa632f8433d21c8e4718bf5a644d33405e580",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1396",
"triggerID" : "cf3fa632f8433d21c8e4718bf5a644d33405e580",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf3fa632f8433d21c8e4718bf5a644d33405e580 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1396)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629084464
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cf3fa632f8433d21c8e4718bf5a644d33405e580 (Fri May 15 07:42:41 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629094177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cf3fa632f8433d21c8e4718bf5a644d33405e580",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cf3fa632f8433d21c8e4718bf5a644d33405e580",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf3fa632f8433d21c8e4718bf5a644d33405e580 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629183364
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629642188
Thanks for review and merging @pnowojski
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629279669
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629400209
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW removed a comment on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
zhijiangW removed a comment on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629183364
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629094177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cf3fa632f8433d21c8e4718bf5a644d33405e580",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1396",
"triggerID" : "cf3fa632f8433d21c8e4718bf5a644d33405e580",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf3fa632f8433d21c8e4718bf5a644d33405e580 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1396)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12163: [FLINK-17719][task][checkpointing] Provide ChannelStateReader#hasStates for hints of reading channel states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12163:
URL: https://github.com/apache/flink/pull/12163#issuecomment-629084464
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cf3fa632f8433d21c8e4718bf5a644d33405e580 (Fri Oct 16 10:32:51 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org