You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Joel Bernstein (Jira)" <ji...@apache.org> on 2019/12/10 19:55:00 UTC
[jira] [Updated] (SOLR-14045) Test and review all PostFilters with
grouping
[ https://issues.apache.org/jira/browse/SOLR-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Bernstein updated SOLR-14045:
----------------------------------
Description:
SOLR-13970 throws an exception if collapsing and grouping are combined. The issue here is that the CollapsingQParserPlugin is a postfilter that uses DocValues during the collect. Grouping calls postfilters twice during its two part grouping logic. When DocValues moved to the iterator API it was no longer valid to call the same postfilter twice without resetting the internal state of the DocValues caches. So, collapsing and grouping stopped working. For the time being throwing an exception ensures that people don't uses these features together, because unfortunately sometimes they work and sometimes they break depending on the situation. So it's possible to get fooled into thinking collapse and grouping work together.
We need to check the other postfilters to see if they have the same problem and either fix them so they can be can be called repeatedly or throw exceptions when used with grouping.
was:
SOLR-13970 throws an exception if collapsing and grouping are combined. The issue here is that the CollapsingQParserPlugin is a postfilter that uses DocValues during the collect. Grouping calls the postfilter twice during it's two part grouping logic. When DocValues moved to the iterator API it was no longer valid to call the same postfilter twice without resetting the internal state of the DocValues caches. So, collapsing and grouping stopped working. For the time being throwing an exception ensures that people don't uses these features together, because unfortunately sometimes they work and sometimes they break depending on the situation. So it's possible to get fooled into thinking collapse and grouping work together.
We need to check the other postfilters to see if they have the same problem and either fix them so they can be can be called repeatedly or throw exceptions when used with grouping.
> Test and review all PostFilters with grouping
> ---------------------------------------------
>
> Key: SOLR-14045
> URL: https://issues.apache.org/jira/browse/SOLR-14045
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Joel Bernstein
> Priority: Major
>
> SOLR-13970 throws an exception if collapsing and grouping are combined. The issue here is that the CollapsingQParserPlugin is a postfilter that uses DocValues during the collect. Grouping calls postfilters twice during its two part grouping logic. When DocValues moved to the iterator API it was no longer valid to call the same postfilter twice without resetting the internal state of the DocValues caches. So, collapsing and grouping stopped working. For the time being throwing an exception ensures that people don't uses these features together, because unfortunately sometimes they work and sometimes they break depending on the situation. So it's possible to get fooled into thinking collapse and grouping work together.
> We need to check the other postfilters to see if they have the same problem and either fix them so they can be can be called repeatedly or throw exceptions when used with grouping.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org