[GitHub] [calcite] tanclary commented on a diff in pull request #3434: [CALCITE-6013] Unnecessary measures added as projects during rel cons…

["tanclary (via GitHub)" <gi...@apache.org>]

tanclary commented on code in PR #3434:
URL: https://github.com/apache/calcite/pull/3434#discussion_r1329312890


##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -4689,6 +4689,23 @@ void checkUserDefinedOrderByOver(NullCollation nullCollation) {
         .withSql(sql)
         .ok();
   }
+  
+  /** Test case for:
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-6013">[CALCITE-6013]
+   * Unnecessary measures added as projects during rel construction</a>.
+   */  
+    @Test void testAvoidUnnecessaryMeasureProject() {
+    final String sql = "select deptno\n"
+        + "from empm\n"
+        + "group by deptno";
+    fixture()

Review Comment:
   for context I added this so the mock table w/ measure columns gets used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org