[GitHub] clintropolis commented on a change in pull request #6158: Make time-related variables more readable

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #6158: Make time-related variables more readable
URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r209741804
 
 

 ##########
 File path: common/src/main/java/io/druid/common/config/Log4jShutdown.java
 ##########
 @@ -28,11 +28,12 @@
 import javax.annotation.concurrent.GuardedBy;
 import java.util.Queue;
 import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
 
 public class Log4jShutdown implements ShutdownCallbackRegistry, LifeCycle
 {
-  private static final long SHUTDOWN_WAIT_TIMEOUT = 60000;
+  private static final long SHUTDOWN_WAIT_TIMEOUT = TimeUnit.MINUTES.toMillis(1);
 
 Review comment:
   This is nice, but any chance you could be convinced to also rename these variables to include the unit of time they represent? e.g. `SHUTDOWN_WAIT_TIMEOUT_MILLIS` instead fo `SHUTDOWN_WAIT_TIMEOUT`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org