You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/23 15:25:44 UTC
[GitHub] [kafka] julian9499 opened a new pull request #10382: KAFKA 12420 - Kafka network Selector class has many constructors; use a Builder pattern instead
julian9499 opened a new pull request #10382:
URL: https://github.com/apache/kafka/pull/10382
Replace the 6 network selector constructors with a builder that can be used to specify the needed parameters instead of using one of the 6 defined constructors.
This pull requests updates all usages of the network selector and does not add any tests. Existing tests already tests the correctness of the network selector and our solution only changes the instance creation of the selector. All tests ran correctly..
### Committer Checklist (excluded from commit message)
- [ x] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ x] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] julian9499 removed a comment on pull request #10382: KAFKA-12420: Kafka network Selector class has many constructors; use a Builder pattern instead
Posted by GitBox <gi...@apache.org>.
julian9499 removed a comment on pull request #10382:
URL: https://github.com/apache/kafka/pull/10382#issuecomment-805007894
@vvcephei could you rerun the ci? If I should not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] julian9499 closed pull request #10382: KAFKA-12420: Kafka network Selector class has many constructors; use a Builder pattern instead
Posted by GitBox <gi...@apache.org>.
julian9499 closed pull request #10382:
URL: https://github.com/apache/kafka/pull/10382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] julian9499 commented on pull request #10382: KAFKA-12420: Kafka network Selector class has many constructors; use a Builder pattern instead
Posted by GitBox <gi...@apache.org>.
julian9499 commented on pull request #10382:
URL: https://github.com/apache/kafka/pull/10382#issuecomment-805007894
@vvcephei could you rerun the ci? If I should not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org