You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/09 01:45:09 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #10068: [FLINK-13702][FLINK-13740] Fixed issues with generic types and materialization of lazy binary formats in blink planner
JingsongLi commented on a change in pull request #10068:
URL: https://github.com/apache/flink/pull/10068#discussion_r422439119
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/BinaryGenericSerializer.java
##########
@@ -127,63 +133,41 @@ public int hashCode() {
@Override
public TypeSerializerSnapshot<BinaryGeneric<T>> snapshotConfiguration() {
- return new BinaryGenericSerializerSnapshot<>(serializer);
+ return new BinaryGenericSerializerSnapshot<>(this);
+ }
+
+ public TypeSerializer<T> getInnerSerializer() {
+ return serializer;
}
/**
* {@link TypeSerializerSnapshot} for {@link BinaryGenericSerializer}.
*/
- public static final class BinaryGenericSerializerSnapshot<T> implements TypeSerializerSnapshot<BinaryGeneric<T>> {
- private static final int CURRENT_VERSION = 3;
-
- private TypeSerializer<T> previousSerializer;
+ public static final class BinaryGenericSerializerSnapshot<T> extends CompositeTypeSerializerSnapshot<BinaryGeneric<T>, BinaryGenericSerializer<T>> {
Review comment:
Yes...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org