You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/01/17 16:59:27 UTC

Re: Review Request 53850: Implemented fetching Docker images that have V2 schema 2 manifests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53850/
-----------------------------------------------------------

(Updated Jan. 17, 2017, 4:59 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6934
    https://issues.apache.org/jira/browse/MESOS-6934


Repository: mesos


Description
-------

Implemented fetching Docker images that have V2 schema 2 manifests.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp b06ddff68a8d2df13abb838b03a8e73d4e273c31 
  src/tests/containerizer/provisioner_docker_tests.cpp 96821692a8b2080a25997afa66a0b5e6699c95c4 
  src/tests/uri_fetcher_tests.cpp 3c1bd33137612de90d65b7af288bb81ac9876c8b 
  src/uri/fetchers/docker.cpp 3f38dddfb4c089322fe4e13b1ef2070b4835885c 

Diff: https://reviews.apache.org/r/53850/diff/


Testing
-------

Added test to verify that V2 schema 2 image manifest can be pulled with all image blobs. Modified previously added "pull image by digest" test to pull an image that has schema 2 manifest. Ran `make check`.


Thanks,

Ilya Pronin