You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/05/27 12:33:16 UTC

[PR] Remove unknown active transport [shardingsphere]

terrymanu opened a new pull request, #38732:
URL: https://github.com/apache/shardingsphere/pull/38732

   Fixes #35294.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove unknown active transport [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #38732:
URL: https://github.com/apache/shardingsphere/pull/38732#issuecomment-4554945776

   ### Decision
   
   - **Merge Verdict: Mergeable**
   - **Reviewed Scope:** Latest head `54ab48310ad`; reviewed the PR changes under `mcp/bootstrap`, `mcp/core`, and `mcp/support`, especially the active transport flow from YAML configuration to `MCPRuntimeLauncher`, `MCPRuntimeContext`, `MCPRequestScope`, and `RuntimeStatusHandler`.
   - **Not Reviewed Scope:** No separate manual end-to-end run was performed by this reviewer; relied on GitHub Actions for MCP E2E coverage.
   - **Need Expert Review:** No.
   
   ### Basis
   
   - The root-cause direction is correct: the runtime no longer exposes the placeholder `unknown` transport. `MCPRuntimeLauncher` now derives the active transport from the validated `MCPTransportType` and passes the concrete value into `MCPRuntimeContext`.
   - The production entry path is covered by YAML configuration validation and enum-based transport typing, so adding duplicate validation in `MCPRuntimeContext` is not necessary for this change.
   - The removed fallback contract is covered by tests: `MCPRuntimeLauncherTest` verifies both HTTP and STDIO propagation, and `RuntimeStatusHandlerTest` verifies the STDIO runtime status output.
   - The change is scoped to MCP runtime transport metadata and related tests. I did not find unrelated behavior changes, shared SQL execution-path risks, dependency changes, parser changes, or performance-sensitive path changes.
   - The formatter/style gates are satisfied according to the project gates: GitHub `Check - Spotless` and `Check - CheckStyle` passed.
   
   ### Pre-Merge Checks
   
   - GitHub reports the PR as mergeable with `mergeable_state: clean`.
   - GitHub check-runs for latest head have no pending checks and no failed checks.
   - Local scoped verification passed: `./mvnw -pl :shardingsphere-mcp-bootstrap -am -DskipITs -Dspotless.skip=true -Dtest=RuntimeStatusHandlerTest,MCPRuntimeLauncherTest -Dsurefire.failIfNoSpecifiedTests=false test`.
   - PR body uses `For #35294.`, so it does not auto-close the discussion issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove unknown active transport [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38732:
URL: https://github.com/apache/shardingsphere/pull/38732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org