You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/07 18:05:50 UTC

[GitHub] kristw commented on a change in pull request #6829: Fix line chart overflowing the right side

kristw commented on a change in pull request #6829: Fix line chart overflowing the right side
URL: https://github.com/apache/incubator-superset/pull/6829#discussion_r254803455
 
 

 ##########
 File path: superset/assets/src/visualizations/nvd3/NVD3Vis.js
 ##########
 @@ -641,15 +641,15 @@ function nvd3Vis(element, props) {
         // If x bounds are shown, we need a right margin
         margins.right = Math.max(20, maxXAxisLabelHeight / 2) + marginPad;
       }
-      if (staggerLabels) {
-        margins.bottom = 40;
-      } else {
+      if (xLabelRotation === 45) {
 
 Review comment:
   Short ans: I changed and it fixes the issue with line chart. 
   Longer ans: There are other code that modify `margins.right` above, which will be overridden by your `else` clause.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org