[GitHub] [hudi] guanziyue commented on a diff in pull request #9523: [DO NOT MEGRE] HUDI-1517 Adding support for Per log file marker to track all log files added by a commit and to assist with rollbacks

["guanziyue (via GitHub)" <gi...@apache.org>]

guanziyue commented on code in PR #9523:
URL: https://github.com/apache/hudi/pull/9523#discussion_r1305094068


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -130,6 +132,53 @@ public Set<String> createdAndMergedDataPaths(HoodieEngineContext context, int pa
     return dataFiles;
   }
 
+  public Set<String> appendedLogPaths(HoodieEngineContext context, int parallelism) throws IOException {

Review Comment:
   Currently createdAndMergedDataPaths not return any log file markers because the change to generate 'create' type marker for log file has been reverted. I notice you also comment the code about this change. Let me explain it there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org