You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/14 19:59:01 UTC
[kudu-CR](branch-1.10.x) [mini-cluster] fix on building mini-cluster JAR
Hello Kudu Jenkins, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14709
to review the following change.
Change subject: [mini-cluster] fix on building mini-cluster JAR
......................................................................
[mini-cluster] fix on building mini-cluster JAR
Prior to this patch, build_mini_cluster_binaries.sh script didn't
properly handle the case of running in the same workspace that
was used to build the mini-cluster JAR for prior releases. That
might result in not building the required JAR, so no binary
content would be uploaded by running publish_mini_cluster_binaries.sh
script later on.
This patch fixes the issue: by default, the build directory
is re-created upon every run of the build_mini_cluster_binaries.sh
script unless MINI_CLUSTER_NO_FRESH_BUILD environment variable is set.
Also, even if MINI_CLUSTER_NO_FRESH_BUILD is set and the build directory
is not re-created, the script now warns on ambiguity when multiple
artifact directories are present.
Change-Id: Ic2d5c2a83e2a0ab959e2eb7898d47ab736cd1e1f
Reviewed-on: http://gerrit.cloudera.org:8080/14702
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 6406123924c3900e8edd65eebbb3d93963fd2a7b)
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/14709/1
--
To view, visit http://gerrit.cloudera.org:8080/14709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2d5c2a83e2a0ab959e2eb7898d47ab736cd1e1f
Gerrit-Change-Number: 14709
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.10.x) [mini-cluster] fix on building mini-cluster JAR
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14709 )
Change subject: [mini-cluster] fix on building mini-cluster JAR
......................................................................
Patch Set 1: Verified+1 Code-Review+2
This is a useful patch to avoid manual directory cleanup.
--
To view, visit http://gerrit.cloudera.org:8080/14709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2d5c2a83e2a0ab959e2eb7898d47ab736cd1e1f
Gerrit-Change-Number: 14709
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Nov 2019 20:00:26 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) [mini-cluster] fix on building mini-cluster JAR
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14709 )
Change subject: [mini-cluster] fix on building mini-cluster JAR
......................................................................
[mini-cluster] fix on building mini-cluster JAR
Prior to this patch, build_mini_cluster_binaries.sh script didn't
properly handle the case of running in the same workspace that
was used to build the mini-cluster JAR for prior releases. That
might result in not building the required JAR, so no binary
content would be uploaded by running publish_mini_cluster_binaries.sh
script later on.
This patch fixes the issue: by default, the build directory
is re-created upon every run of the build_mini_cluster_binaries.sh
script unless MINI_CLUSTER_NO_FRESH_BUILD environment variable is set.
Also, even if MINI_CLUSTER_NO_FRESH_BUILD is set and the build directory
is not re-created, the script now warns on ambiguity when multiple
artifact directories are present.
Change-Id: Ic2d5c2a83e2a0ab959e2eb7898d47ab736cd1e1f
Reviewed-on: http://gerrit.cloudera.org:8080/14702
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 6406123924c3900e8edd65eebbb3d93963fd2a7b)
Reviewed-on: http://gerrit.cloudera.org:8080/14709
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/mini-cluster/build_mini_cluster_binaries.sh
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2d5c2a83e2a0ab959e2eb7898d47ab736cd1e1f
Gerrit-Change-Number: 14709
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)