You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "eldenmoon (via GitHub)" <gi...@apache.org> on 2024/09/03 04:01:59 UTC
[PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
eldenmoon opened a new pull request, #40300:
URL: https://github.com/apache/doris/pull/40300
If partial update with delete clause, the new rowset delete sign should be considered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2325562274
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2325568736
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2325563203
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2325603790
<details>
<summary>ClickBench: <b>Total hot run time: 32.66 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit df1890b27cebfe67d5b9260c960dc67b28b3ddd6, data reload: false
query1 0.04 0.04 0.04
query2 0.08 0.04 0.04
query3 0.23 0.06 0.06
query4 1.66 0.10 0.10
query5 0.51 0.52 0.49
query6 1.14 0.74 0.74
query7 0.01 0.01 0.02
query8 0.05 0.05 0.05
query9 0.54 0.48 0.48
query10 0.55 0.55 0.54
query11 0.16 0.11 0.12
query12 0.15 0.12 0.12
query13 0.62 0.58 0.59
query14 2.07 2.06 2.03
query15 0.89 0.82 0.81
query16 0.38 0.38 0.38
query17 1.08 1.08 1.06
query18 0.20 0.20 0.20
query19 1.83 1.84 1.86
query20 0.01 0.02 0.01
query21 15.41 0.68 0.67
query22 4.87 5.73 2.37
query23 18.27 1.30 1.30
query24 2.06 0.24 0.21
query25 0.15 0.08 0.08
query26 0.26 0.18 0.20
query27 0.08 0.08 0.07
query28 13.32 1.02 1.02
query29 12.61 3.37 3.35
query30 0.23 0.06 0.06
query31 2.87 0.40 0.40
query32 3.27 0.50 0.49
query33 2.94 2.98 3.05
query34 17.13 4.36 4.39
query35 4.47 4.45 4.37
query36 0.68 0.48 0.50
query37 0.19 0.15 0.16
query38 0.15 0.14 0.15
query39 0.05 0.04 0.04
query40 0.15 0.13 0.13
query41 0.10 0.04 0.05
query42 0.06 0.04 0.05
query43 0.04 0.04 0.04
Total cold run time: 111.56 s
Total hot run time: 32.66 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #40300:
URL: https://github.com/apache/doris/pull/40300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2325562243
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2325599120
<details>
<summary>TPC-DS: <b>Total hot run time: 192697 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit df1890b27cebfe67d5b9260c960dc67b28b3ddd6, data reload: false
query1 1246 862 883 862
query2 6452 1941 1907 1907
query3 10625 4055 3821 3821
query4 59206 26805 23219 23219
query5 5475 493 488 488
query6 404 161 163 161
query7 5777 302 286 286
query8 293 205 195 195
query9 8995 2464 2429 2429
query10 487 264 259 259
query11 17967 15038 15347 15038
query12 161 103 99 99
query13 1557 395 397 395
query14 11066 7500 7241 7241
query15 240 185 186 185
query16 7562 485 489 485
query17 1121 567 564 564
query18 1934 309 303 303
query19 290 150 143 143
query20 124 112 114 112
query21 204 104 105 104
query22 4705 4475 4793 4475
query23 34213 33258 33326 33258
query24 5941 2982 2791 2791
query25 519 378 379 378
query26 689 171 150 150
query27 1785 272 266 266
query28 3672 2005 1988 1988
query29 671 403 396 396
query30 242 155 156 155
query31 907 758 781 758
query32 81 50 55 50
query33 463 286 281 281
query34 847 471 480 471
query35 837 712 710 710
query36 1070 897 923 897
query37 138 88 89 88
query38 4036 3888 3962 3888
query39 1525 1395 1399 1395
query40 200 114 115 114
query41 48 47 45 45
query42 123 95 94 94
query43 509 454 480 454
query44 1066 726 732 726
query45 202 173 167 167
query46 1097 740 740 740
query47 1934 1799 1809 1799
query48 383 293 301 293
query49 773 433 446 433
query50 835 425 404 404
query51 7032 6900 6943 6900
query52 100 86 90 86
query53 249 180 182 180
query54 573 474 458 458
query55 80 75 79 75
query56 291 272 269 269
query57 1209 1094 1077 1077
query58 253 277 258 258
query59 3006 2965 2720 2720
query60 318 283 285 283
query61 125 122 119 119
query62 768 669 665 665
query63 213 187 178 178
query64 2878 754 732 732
query65 3190 3131 3152 3131
query66 694 352 345 345
query67 15550 15369 15200 15200
query68 3212 584 570 570
query69 419 291 295 291
query70 1199 1148 1139 1139
query71 334 290 284 284
query72 6466 4197 4181 4181
query73 744 328 330 328
query74 9121 8859 8865 8859
query75 3365 2706 2698 2698
query76 1489 992 995 992
query77 526 314 320 314
query78 11235 9540 9140 9140
query79 1074 517 514 514
query80 889 509 496 496
query81 577 237 235 235
query82 259 144 140 140
query83 194 148 147 147
query84 262 79 75 75
query85 701 316 279 279
query86 384 299 308 299
query87 4360 4252 4332 4252
query88 3236 2323 2330 2323
query89 365 286 282 282
query90 1890 192 184 184
query91 121 103 103 103
query92 60 52 49 49
query93 1057 521 523 521
query94 815 305 294 294
query95 344 247 250 247
query96 595 261 263 261
query97 3207 3094 3118 3094
query98 225 201 195 195
query99 1793 1275 1283 1275
Total cold run time: 307744 ms
Total hot run time: 192697 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2325590200
<details>
<summary>TPC-H: <b>Total hot run time: 38031 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit df1890b27cebfe67d5b9260c960dc67b28b3ddd6, data reload: false
------ Round 1 ----------------------------------
q1 17706 4401 4331 4331
q2 2019 183 196 183
q3 11756 936 1086 936
q4 10511 694 790 694
q5 7760 2821 2840 2821
q6 229 140 139 139
q7 966 607 596 596
q8 9337 2096 2067 2067
q9 7117 6533 6535 6533
q10 6992 2218 2177 2177
q11 484 257 249 249
q12 397 220 223 220
q13 18910 3059 3117 3059
q14 278 231 246 231
q15 527 490 492 490
q16 589 495 512 495
q17 979 707 696 696
q18 7351 6841 6764 6764
q19 1401 1093 1063 1063
q20 680 341 336 336
q21 4224 2944 3002 2944
q22 1134 1029 1007 1007
Total cold run time: 111347 ms
Total hot run time: 38031 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4418 4355 4322 4322
q2 370 274 272 272
q3 2913 2702 2711 2702
q4 1923 1657 1667 1657
q5 5683 5665 5804 5665
q6 239 141 132 132
q7 2222 1828 1810 1810
q8 3295 3459 3533 3459
q9 8785 8835 8742 8742
q10 3648 3408 3345 3345
q11 607 518 506 506
q12 847 673 665 665
q13 16172 3189 3324 3189
q14 334 308 296 296
q15 522 490 492 490
q16 651 576 590 576
q17 1849 1528 1533 1528
q18 8084 7919 8001 7919
q19 1736 1675 1478 1478
q20 2163 1884 1960 1884
q21 5727 5521 5416 5416
q22 1118 1049 1055 1049
Total cold run time: 73306 ms
Total hot run time: 57102 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2325567270
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2327768535
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](ShortCircuit) consider delete sign flag when hits row [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40300:
URL: https://github.com/apache/doris/pull/40300#issuecomment-2327768558
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org