You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "freemandealer (via GitHub)" <gi...@apache.org> on 2023/06/08 03:44:17 UTC

[GitHub] [doris] freemandealer opened a new issue, #20578: [Enhancement] let regression case fail fast when job is cancelled

freemandealer opened a new issue, #20578:
URL: https://github.com/apache/doris/issues/20578

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Description
   
   Your can always see such code in doris regression-test/suites:
   
   ```    
   while (max_try_secs--) {
           String res = getJobState(tbName1)
           if (res == "FINISHED") {
               sleep(3000)
               break
           } else {
               Thread.sleep(1000)
               if (max_try_secs < 1) {
                   println "test timeout," + "state:" + res
                   assertEquals("FINISHED", res)
               }
           }
      }
   ```
   
   That is: we quit ONLY if  'FINISHED', otherwise we wait until timeout.
   It slows down the regression test because job status could also be other certain and unchanging status such as 'CANCELLED' which is meaningless to wait for.
   
   So we need to wait only for those changing status.
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] ArmandoZ commented on issue #20578: [Enhancement] let regression case fail fast when job is cancelled

Posted by "ArmandoZ (via GitHub)" <gi...@apache.org>.
ArmandoZ commented on issue #20578:
URL: https://github.com/apache/doris/issues/20578#issuecomment-1593855080

   I‘d like to work on this. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei closed issue #20578: [Enhancement] let regression case fail fast when job is cancelled

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei closed issue #20578: [Enhancement] let regression case fail fast when job is cancelled
URL: https://github.com/apache/doris/issues/20578


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org