[GitHub] [arrow] jorisvandenbossche commented on pull request #10495: ARROW-12994: [R] stringr tests fails on non-UTC machines due to strptime defaulting to local timezone and Arrow defaulting to UTC

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on pull request #10495:
URL: https://github.com/apache/arrow/pull/10495#issuecomment-874715686


   > [@nealrichardson] I'm wary of hardcoding UTC in our tests because it opens up all kinds of ways where we might do the wrong thing if you're not on UTC. 
   
   Isn't the issue here that R's `strptime` assumes your local machine timezone, while Arrow's version doesn't do this. So some way or another, the test will need to take into account this difference in behaviour (unless we want to adapt the R bindings for `strptime` to use the machine timezone?). 
   
   > Here are some tests I added at that time to test all of the combinations
   
   That are general tests about timezone handling (eg when roundtripping between R <-> Arrow), I think? While here it is a specific test about the behaviour of the `strptime` kernel.
   
   > This ticket has been opened about the C++ function: https://issues.apache.org/jira/browse/ARROW-12820
   
   That ticket is about not ignoring the timezone if it is present in the string. The current test you are modifying here doesn't have that, so I think this is unrelated to ARROW-12820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org