You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Anna Szonyi <sz...@cloudera.com> on 2016/12/14 14:00:52 UTC
Review Request 54745: SQOOP-3084 bug fix in aop.xml,
org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be
changed after SQOOP-3051
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54745/
-----------------------------------------------------------
Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
Bugs: SQOOP-3084
https://issues.apache.org/jira/browse/SQOOP-3084
Repository: sqoop-trunk
Description
-------
SQOOP-3084 Due to ivy changes in 3051 the path of org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed, as there is no longer a hadoop${hadoopversion}test, just test
There is another jira to fix the issue with the fault injection targets no longer working after SQOOP-2983
Diffs
-----
src/test/aop/build/aop.xml 77320aa
Diff: https://reviews.apache.org/r/54745/diff/
Testing
-------
ant compile, ant test, ant jar-fault-inject
Thanks,
Anna Szonyi
Re: Review Request 54745: SQOOP-3084 bug fix in aop.xml,
org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be
changed after SQOOP-3051
Posted by Attila Szabo <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54745/#review159430
-----------------------------------------------------------
Ship it!
Hi Anna,
Thanks for cleaning this up too!
Attila
- Attila Szabo
On Dec. 14, 2016, 2 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54745/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 2 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
>
>
> Bugs: SQOOP-3084
> https://issues.apache.org/jira/browse/SQOOP-3084
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3084 Due to ivy changes in 3051 the path of org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed, as there is no longer a hadoop${hadoopversion}test, just test
> There is another jira to fix the issue with the fault injection targets no longer working after SQOOP-2983
>
>
> Diffs
> -----
>
> src/test/aop/build/aop.xml 77320aa
>
> Diff: https://reviews.apache.org/r/54745/diff/
>
>
> Testing
> -------
>
> ant compile, ant test, ant jar-fault-inject
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 54745: SQOOP-3084 bug fix in aop.xml,
org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be
changed after SQOOP-3051
Posted by Erzsebet Szilagyi <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54745/#review159150
-----------------------------------------------------------
Ship it!
Thank you for catching this error and providing a fix so quickly!
- Erzsebet Szilagyi
On Dec. 14, 2016, 3 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54745/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 3 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
>
>
> Bugs: SQOOP-3084
> https://issues.apache.org/jira/browse/SQOOP-3084
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3084 Due to ivy changes in 3051 the path of org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed, as there is no longer a hadoop${hadoopversion}test, just test
> There is another jira to fix the issue with the fault injection targets no longer working after SQOOP-2983
>
>
> Diffs
> -----
>
> src/test/aop/build/aop.xml 77320aa
>
> Diff: https://reviews.apache.org/r/54745/diff/
>
>
> Testing
> -------
>
> ant compile, ant test, ant jar-fault-inject
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 54745: SQOOP-3084 bug fix in aop.xml,
org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be
changed after SQOOP-3051
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54745/#review159309
-----------------------------------------------------------
Ship it!
Ship It!
- Szabolcs Vasas
On Dec. 14, 2016, 2 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54745/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 2 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
>
>
> Bugs: SQOOP-3084
> https://issues.apache.org/jira/browse/SQOOP-3084
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3084 Due to ivy changes in 3051 the path of org/aspectj/tools/ant/taskdefs/aspectjTaskdefs.properties path needs to be changed, as there is no longer a hadoop${hadoopversion}test, just test
> There is another jira to fix the issue with the fault injection targets no longer working after SQOOP-2983
>
>
> Diffs
> -----
>
> src/test/aop/build/aop.xml 77320aa
>
> Diff: https://reviews.apache.org/r/54745/diff/
>
>
> Testing
> -------
>
> ant compile, ant test, ant jar-fault-inject
>
>
> Thanks,
>
> Anna Szonyi
>
>