You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/07/31 16:54:30 UTC

[GitHub] brodybits opened a new pull request #384: spec cover apple version functions (covers GH-376 update)

brodybits opened a new pull request #384: spec cover apple version functions (covers GH-376 update)
URL: https://github.com/apache/cordova-ios/pull/384
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   iOS
   
   ### What does this PR do?
   
   - cover apple version functions in spec, as needed to cover the GH-376 update that I already merged into `master`
   
   (was part of GH-377 by @erisu)
   
   ### What testing has been done on this change?
   
   - [x] `npm run unit-tests` passes on local machine (also on deprecated Node.js 4 version)
   - [ ] `npm test` items pass on Travis CI
   - [ ] `npm run unit-tests` passes on AppVeyor CI
   
   ### Checklist
   
   - ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~
   - ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.~~
   - [x] Added automated test coverage as appropriate for this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org