[jira] [Commented] (UIMA-5372) SM failed to unregister a service but allowed another to start

["Burn Lewis (JIRA)" <de...@uima.apache.org>]

    [ https://issues.apache.org/jira/browse/UIMA-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967980#comment-15967980 ] 

Burn Lewis commented on UIMA-5372:
----------------------------------

After review, changed getServicesForApito check the url for null instead of the id for -1 (these are the "undefined" values) as was originally done.
In handleModifiedServices (which handles SM-detected changes in the OR's publication of service instances) if the instance is no longer in the instanceid->service map the service id is used to try to locate the service (previously its url was looked up in the unregistered map.). This may be an overly cautious check as all of a service's instanceids are removed from that map when all instances have been shutdown and the unregistration completed.

> SM failed to unregister a service but allowed another to start
> --------------------------------------------------------------
>
>                 Key: UIMA-5372
>                 URL: https://issues.apache.org/jira/browse/UIMA-5372
>             Project: UIMA
>          Issue Type: Bug
>          Components: DUCC
>            Reporter: Burn Lewis
>            Assignee: Burn Lewis
>             Fix For: future-DUCC
>
>
> Vito unregistered 8799 but the SM threw an NPE and didn't shut it down, while claiming that it is unregistered.  sm log in /users/burn/for/SM
> 16 Mar 2017 10:07:27,725  INFO SM.ServiceHandler - 8799 authorized  unregister request from Vito.Colano allowed.
> 16 Mar 2017 10:07:27,725  INFO SM.ServiceHandler - 8799 ServiceStateHandler.unregister  Removing UIMA-AS:dsqa-async-service-Vito.Colano-2017-08:tcp://broker1:61616 8799
> processIncoming  ===== Orchestrator State Arrives =====
> 16 Mar 2017 10:07:34,184  INFO SM.ServiceHandler - N/A    runCommands  Running 2 API Tasks.
> 16 Mar 2017 10:07:34,185 ERROR SM.ServiceHandler - N/A    run 
> java.lang.NullPointerException
> 	at org.apache.uima.ducc.sm.ServiceHandler.doStop(ServiceHandler.java:884)
> 	at org.apache.uima.ducc.sm.ApiHandler.run(ApiHandler.java:89)
> 	at org.apache.uima.ducc.sm.ServiceHandler.runCommands(ServiceHandler.java:243)
> 	at org.apache.uima.ducc.sm.ServiceHandler.run(ServiceHandler.java:117)
> 	at java.lang.Thread.run(Thread.java:780)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)