[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9098: SQL Database: provide `@SQLDatabase.AdditionalEntity` to support create additional tables from a model.

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #9098:
URL: https://github.com/apache/skywalking/pull/9098#discussion_r876736214


##########
docs/en/FAQ/v9-version-upgrade.md:
##########
@@ -20,4 +20,5 @@ Notice **Incompatibility (1)**, the UI template configuration protocol is incomp
    These data would be incompatible with previous versions.
    Make sure to remove the older `ServiceTraffic` table before OAP(v9) starts. 
    OAP would generate the new table in the start procedure, and recreate all existing services when traffic comes.
+   Since V9.1, SQL Database: move `Tags list` from `Segment`,`Logs`,`Alarms` to their additional table, remove them before OAP starts.

Review Comment:
   ```suggestion
      Since V9.1, SQL Database: move `Tags list` from `Segment`, `Logs`, `Alarms` to their additional tables, remove them before OAP starts.
   ```
   
   I think we don't have to remove these old tables? As you are adding a new table not change one(abandon some columns should be safe?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org