You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/14 15:08:00 UTC
[jira] [Commented] (KAFKA-9425) InFlightRequests Class Uses
Thread-Safe Counter Non-Thread-Safe Collection
[ https://issues.apache.org/jira/browse/KAFKA-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015148#comment-17015148 ]
ASF GitHub Bot commented on KAFKA-9425:
---------------------------------------
belugabehr commented on pull request #7958: KAFKA-9425: InFlightRequests Class Uses Thread-Safe Counter Non-Threa…
URL: https://github.com/apache/kafka/pull/7958
…d-Safe Collection
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> InFlightRequests Class Uses Thread-Safe Counter Non-Thread-Safe Collection
> --------------------------------------------------------------------------
>
> Key: KAFKA-9425
> URL: https://issues.apache.org/jira/browse/KAFKA-9425
> Project: Kafka
> Issue Type: Improvement
> Reporter: David Mollitor
> Priority: Minor
>
> [https://github.com/apache/kafka/blob/d6ace7b2d7c4ad721dd8247fb2b3eff9f67fbfee/clients/src/main/java/org/apache/kafka/clients/InFlightRequests.java#L34-L36]
>
> Not sure why this needs the overheard of {{AtomicInteger}} when the collection being modified isn't itself thread-safe. The comment of the counter says that it may lag as things currently stand.
>
> Also, add a few more niceties since I'm opening it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)