You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2019/10/01 09:04:22 UTC

[GitHub] [incubator-nemo] wonook commented on a change in pull request #232: [NEMO-411] Bug in ScheduleGroupPass, OutputTag, DuplicateEdgeGroup

wonook commented on a change in pull request #232: [NEMO-411] Bug in ScheduleGroupPass, OutputTag, DuplicateEdgeGroup
URL: https://github.com/apache/incubator-nemo/pull/232#discussion_r329946316
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
 ##########
 @@ -471,9 +472,11 @@ private boolean isConnectedToStreamVertex(final IREdge irEdge) {
     return irEdge.getDst() instanceof RelayVertex || irEdge.getSrc() instanceof RelayVertex;
   }
 
-  private Map<Optional<String>, List<IREdge>> groupOutEdgesByAdditionalOutputTag(final List<IREdge> outEdges) {
+  private final AtomicInteger distinctIntegerForEmptyOutputTag = new AtomicInteger(0);
 
 Review comment:
   As it's used in a stream, I think it would make sense to use an AtomicInteger, as it could perform get & increment simultaneously, while mutable int can't. I think a primary reason for using Java streams is since they could be run in parallel.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services