You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/06/22 01:49:36 UTC

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1062: dep cache support version filter

tianxiaoliang commented on a change in pull request #1062:
URL: https://github.com/apache/servicecomb-service-center/pull/1062#discussion_r655817178



##########
File path: datasource/mongo/sd/depcache_test.go
##########
@@ -81,13 +81,14 @@ func TestDepCacheBasicFunc(t *testing.T) {
 		assert.Nil(t, depCache.cache.Get("id_not_exist"))
 		assert.Equal(t, depRule1.ServiceKey.ServiceName, depCache.cache.Get("id1").(model.DependencyRule).ServiceKey.ServiceName)
 		assert.Len(t, depCache.cache.GetValue("p/appid1/svc1/1.0"), 1)
+		assert.Equal(t, depRule1.ServiceKey.ServiceName, depCache.cache.GetValue("p/appid1/svc1/1.0")[0].(model.DependencyRule).ServiceKey.ServiceName)

Review comment:
       这个ut看上去很复杂了，最好能分离case，否则就加注释吧




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org