You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/05 09:45:33 UTC

[GitHub] [tvm-vta] liangfu commented on a change in pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset

liangfu commented on a change in pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#discussion_r536612380



##########
File path: hardware/xilinx/scripts/vivado.tcl
##########
@@ -80,6 +82,11 @@ set store_ip "${ip_path}/vta_store/soln/impl/ip/xilinx_com_hls_store_1_0.zip"
 # Create custom project
 create_project -force $proj_name $proj_path -part $device
 
+# Apply board preset if exists
+if {$board != "None" && $board_rev != "None"} {
+  set_property BOARD_PART $board:$board_rev [current_project]

Review comment:
       Just curious, why is BOARD_PART required here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org