You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/12/16 06:14:15 UTC

[GitHub] [orc] pgaref commented on pull request #972: ORC-1059: Align findColumns behaviour between 1.6 and 1.7 release

pgaref commented on pull request #972:
URL: https://github.com/apache/orc/pull/972#issuecomment-995471135


   Thanks for the quick review @dongjoon-hyun ! 
   This will definitely help us bump to 1.7 quickly (e.g., next 1.7 release) but I was thinking that throwing an exception when a SArg column is not found is probably a better approach than just logging.
   
   I suggest we keep this in mind for 1.8 (and switch back to that behaviour) where we could align downstream consumers like Hive to only push SArgs for columns that are part of the schema.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org