You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/14 17:01:42 UTC

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new issue #592: proposal: Add IngressClass support for custom resources

tao12345666333 opened a new issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592


   Currently our custom resources are all namespace scoped.
   
   If you want to use multiple apisix-ingress-controllers in the namespace at the same time, this is not allowed.
   
   If we can add ingress class to custom resources, then we can let apisix-ingress-controller handle them separately.
   
   Although this is a very low frequency scene. It is currently being discussed #578 
   
   I think we may need to reach a consensus and add more complete information


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-890503599


   > > > First: Ingress Class has a default value ("apisix"). If you continue to use ingressClass, then only ApisixRoute containing "apisix" will be listened by default. And if you want to listen to all ApisixRoute CRD by default, it seems impossible to achieve? Or put IngressClass To an empty string?
   > > > Second: Does ApisixRoute CRD need to add the Spec.IngressClass field?
   > > 
   > > 
   > > A tricky way to support listen all ApisixRoute CRs is reserving a wildcard `*`, when the configured `ingressClass` is `*`, we listen all ApisixRoutes.
   > > I think add `spec.IngressClass` is a good way.
   > 
   > Consider this scenario: At present, some people have used ApisixRoute CRD, there is no ingressClass for isolation, so the default is to listen to all ApisixRoute CRDs. But when they upgraded to the new ingress-controller version, they found that by default Controller only listen to CRDs containing "apisix". Is this situation unreasonable? Or change the default value of ingressClass to "*"? But this will affect Ingress CRD.
   
   As we already have similar logic about `IngressClass` resource, we may respect it in other APISIX Ingress Controller CRDs, i.e. the default value of `spec.ingrssClass` will be decided by the default IngressClass resource.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
tao12345666333 edited a comment on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-889720138


   +1 for add `spec.IngressClass` field


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-889718058


   > First: Ingress Class has a default value ("apisix"). If you continue to use ingressClass, then only ApisixRoute containing "apisix" will be listened by default. And if you want to listen to all ApisixRoute CRD by default, it seems impossible to achieve? Or put IngressClass To an empty string?
   > Second: Does ApisixRoute CRD need to add the Spec.IngressClass field?
   
   A tricky way to support listen all ApisixRoute CRs is reserving a wildcard `*`, when the configured `ingressClass` is `*`, we listen all ApisixRoutes.
   
   I think add `spec.IngressClass` is a good way.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Donghui0 commented on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
Donghui0 commented on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-889724375


   > > First: Ingress Class has a default value ("apisix"). If you continue to use ingressClass, then only ApisixRoute containing "apisix" will be listened by default. And if you want to listen to all ApisixRoute CRD by default, it seems impossible to achieve? Or put IngressClass To an empty string?
   > > Second: Does ApisixRoute CRD need to add the Spec.IngressClass field?
   > 
   > A tricky way to support listen all ApisixRoute CRs is reserving a wildcard `*`, when the configured `ingressClass` is `*`, we listen all ApisixRoutes.
   > 
   > I think add `spec.IngressClass` is a good way.
   
   Consider this scenario: At present, some people have used ApisixRoute CRD, there is no ingressClass for isolation, so the default is to listen to all ApisixRoute CRDs. But when they upgraded to the new ingress-controller version, they found that by default Controller only listen to CRDs containing "apisix". Is this situation unreasonable? Or change the default value of ingressClass to "*"?  But this will affect Ingress CRD.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-880318435


   @tao12345666333 That would be a good way to support the soft isolation, but shall we still use the name `ingressClass`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-889720138


   I agree add `spec.IngressClass` field


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Donghui0 commented on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
Donghui0 commented on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-889707468


   First: Ingress Class has a default value ("apisix"). If you continue to use ingressClass, then only ApisixRoute containing "apisix" will be listened by default. And if you want to listen to all ApisixRoute CRD by default, it seems impossible to achieve? Or put IngressClass To an empty string?
   Second: Does ApisixRoute CRD need to add the Spec.IngressClass field?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-889718431


   >First: Ingress Class has a default value ("apisix"). If you continue to use ingressClass, then only ApisixRoute containing "apisix" will be listened by default. And if you want to listen to all ApisixRoute CRD by default, it seems impossible to achieve? Or put IngressClass To an empty string?
   
   The `IngressClass` can use `ingressclass.kubernetes.io/is-default-class` to set the default IngressClass.
   
   >Second: Does ApisixRoute CRD need to add the Spec.IngressClass field? 
   
   Yes, we need to add a field `spec.IngressClass`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #592: proposal: Add IngressClass support for custom resources

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #592:
URL: https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-880320436


   IngressClass is a general concept, I think it is more acceptable to take it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org