[GitHub] [ozone] lokeshj1703 commented on a change in pull request #2657: HDDS-5747. Reset default values in ContainerBalancerConfiguration

[GitBox <gi...@apache.org>]

lokeshj1703 commented on a change in pull request #2657:
URL: https://github.com/apache/ozone/pull/2657#discussion_r719228047



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerConfiguration.java
##########
@@ -61,25 +63,29 @@
       "ratio of maximum number of datanodes that should be involved in " +
       "balancing in one iteration to the total number of healthy, in service " +
       "nodes known to container balancer.")
-  private String maxDatanodesRatioToInvolvePerIteration = "0.5";
+  private String maxDatanodesRatioToInvolvePerIteration = "0.2";
 
   @Config(key = "size.moved.max.per.iteration", type = ConfigType.SIZE,
-      defaultValue = "10GB", tags = {ConfigTag.BALANCER},
+      defaultValue = "30GB", tags = {ConfigTag.BALANCER},
       description = "The maximum size of data in bytes that will be moved " +
           "by Container Balancer in one iteration.")
-  private long maxSizeToMovePerIteration = 10 * OzoneConsts.GB;
+  private long maxSizeToMovePerIteration = 30 * OzoneConsts.GB;
 
   @Config(key = "size.entering.target.max", type = ConfigType.SIZE,
-      defaultValue = "5GB", tags = {ConfigTag.BALANCER}, description = "The " +
-      "maximum size that can enter a target datanode while balancing. This is" +
-      " the sum of data from multiple sources.")
-  private long maxSizeEnteringTarget = 5 * OzoneConsts.GB;
+      defaultValue = "", tags = {ConfigTag.BALANCER}, description = "The " +
+      "maximum size in Gigabytes that can enter a target datanode in each " +

Review comment:
       NIT. Let's remove `in Gigabytes`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org