[GitHub] [ozone] swamirishi commented on a diff in pull request #3744: HDDS-7206. Change the placement policy interface to allow existing nodes to be specified for Rack Scatter Policy.

[GitBox <gi...@apache.org>]

swamirishi commented on code in PR #3744:
URL: https://github.com/apache/ozone/pull/3744#discussion_r971025496


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java:
##########
@@ -98,9 +99,11 @@ public SCMContainerPlacementRackAware(final NodeManager nodeManager,
    */
   @Override
   protected List<DatanodeDetails> chooseDatanodesInternal(
-      List<DatanodeDetails> excludedNodes, List<DatanodeDetails> favoredNodes,
-      int nodesRequired, long metadataSizeRequired, long dataSizeRequired)
-      throws SCMException {
+          List<DatanodeDetails> usedNodes,

Review Comment:
   Currently implementation has been done only for RackScatterPolicy. We have to change logic for other implementations as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org