[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5350: [SegmentGeneratorConfig Cleanup] Refactor CreateSegmentCommand and remove the clone constructor in SegmentGeneratorConfig (#5338)

[GitBox <gi...@apache.org>]

Jackie-Jiang opened a new pull request #5350:
URL: https://github.com/apache/incubator-pinot/pull/5350


   This is one step of cleaning up the SegmentGeneratorConfig. The end state we should always construct SegmentGeneratorConfig with table config and schema


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] npawar commented on pull request #5350: [SegmentGeneratorConfig Cleanup] Make PinotOutputFormat use table config and schema to create segments

[GitBox <gi...@apache.org>]

npawar commented on pull request #5350:
URL: https://github.com/apache/incubator-pinot/pull/5350#issuecomment-625979592


   This PR uses a SchemaBuilder.addTime method that I removed in https://github.com/apache/incubator-pinot/pull/5349 FYI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org