You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@myfaces.apache.org by ma...@apache.org on 2007/10/17 15:28:44 UTC

svn commit: r585488 - /myfaces/trinidad/branches/1.2.3-branch/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXIteratorTemplate.java

Author: matzew
Date: Wed Oct 17 06:28:43 2007
New Revision: 585488

URL: http://svn.apache.org/viewvc?rev=585488&view=rev
Log:
applying TRINIDAD-772 to 123-branch.

Modified:
    myfaces/trinidad/branches/1.2.3-branch/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXIteratorTemplate.java

Modified: myfaces/trinidad/branches/1.2.3-branch/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXIteratorTemplate.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/branches/1.2.3-branch/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXIteratorTemplate.java?rev=585488&r1=585487&r2=585488&view=diff
==============================================================================
--- myfaces/trinidad/branches/1.2.3-branch/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXIteratorTemplate.java (original)
+++ myfaces/trinidad/branches/1.2.3-branch/trinidad-api/src/main/java-templates/org/apache/myfaces/trinidad/component/UIXIteratorTemplate.java Wed Oct 17 06:28:43 2007
@@ -236,6 +236,15 @@
     // if we are starting from row zero then there is no problem:
     if (first == 0)
       return;
+
+    // Negative "first" makes no sense. Given the logic below,
+    // it forces iterator to scroll to the end unnecessarily.
+    if (first < 0)
+    {
+      setFirst(0);
+      return;
+    }
+
     CollectionModel model = getCollectionModel();
     int oldIndex = model.getRowIndex();
     try