You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by Alykoff <gi...@git.apache.org> on 2018/02/27 15:13:35 UTC

[GitHub] curator pull request #253: Change visible of constructor/fields

GitHub user Alykoff opened a pull request:

    https://github.com/apache/curator/pull/253

    Change visible of constructor/fields

    Change visible for `ServiceInstanceBuilder` constructor/fields. This is need for extensibility (for example in project `https://github.com/hazelcast/hazelcast-zookeeper`). I think that package visibility is bad for extensibility. Could you please also say your opinion about change package visibility in others classes?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Alykoff/curator patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #253
    
----
commit 7f76eb0160c86e537cb3ecd46c159d5b8c18779b
Author: Alykoff <ga...@...>
Date:   2018-02-27T15:13:18Z

    Change visible of constructor/fields
    
    Change visible for `ServiceInstanceBuilder` constructor/fields. This is need for extensibility (for example in project `https://github.com/hazelcast/hazelcast-zookeeper`). I think that package visibility is bad for extensibility. Could you please also say your opinion about change package visibility in others classes?

----


---

[GitHub] curator issue #253: Change visible of constructor/fields

Posted by Randgalt <gi...@git.apache.org>.

Github user Randgalt commented on the issue:

    https://github.com/apache/curator/pull/253
  
    Sure - I'm OK with this. But, please, open an issue in our Jira to match the PR. http://issues.apache.org/jira/browse/CURATOR


---

[GitHub] curator issue #253: Change visible of constructor/fields

Posted by Alykoff <gi...@git.apache.org>.

Github user Alykoff commented on the issue:

    https://github.com/apache/curator/pull/253
  
    I created another pull request with issue number https://github.com/apache/curator/pull/254.
    This pull request I closed.


---

[GitHub] curator pull request #253: Change visible of constructor/fields

Posted by Alykoff <gi...@git.apache.org>.

Github user Alykoff closed the pull request at:

    https://github.com/apache/curator/pull/253


---