You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by ma...@apache.org on 2015/12/30 16:43:57 UTC

svn commit: r1722362 - in /avro/branches/branch-1.8: CHANGES.txt lang/c/src/schema_equal.c

Author: martinkl
Date: Wed Dec 30 15:43:57 2015
New Revision: 1722362

URL: http://svn.apache.org/viewvc?rev=1722362&view=rev
Log:
AVRO-1617: C: Fix equality checking of record schemas. Contributed by Skye Wanderman-Milne.

Modified:
    avro/branches/branch-1.8/CHANGES.txt
    avro/branches/branch-1.8/lang/c/src/schema_equal.c

Modified: avro/branches/branch-1.8/CHANGES.txt
URL: http://svn.apache.org/viewvc/avro/branches/branch-1.8/CHANGES.txt?rev=1722362&r1=1722361&r2=1722362&view=diff
==============================================================================
--- avro/branches/branch-1.8/CHANGES.txt (original)
+++ avro/branches/branch-1.8/CHANGES.txt Wed Dec 30 15:43:57 2015
@@ -230,6 +230,9 @@ Avro 1.8.0 (15 December 2015)
     AVRO-1572: C: Fix EOF handling on data files that are multiples of
     4096 bytes. (Ben Walsh via martinkl)
 
+    AVRO-1617: C: Fix equality checking of record schemas. (Skye
+    Wanderman-Milne via martinkl)
+
 Avro 1.7.7 (23 July 2014)
 
   NEW FEATURES

Modified: avro/branches/branch-1.8/lang/c/src/schema_equal.c
URL: http://svn.apache.org/viewvc/avro/branches/branch-1.8/lang/c/src/schema_equal.c?rev=1722362&r1=1722361&r2=1722362&view=diff
==============================================================================
--- avro/branches/branch-1.8/lang/c/src/schema_equal.c (original)
+++ avro/branches/branch-1.8/lang/c/src/schema_equal.c Wed Dec 30 15:43:57 2015
@@ -33,6 +33,10 @@ schema_record_equal(struct avro_record_s
 	if (nullstrcmp(a->space, b->space)) {
 		return 0;
 	}
+	if (a->fields->num_entries != b->fields->num_entries) {
+		/* They have different numbers of fields */
+		return 0;
+	}
 	for (i = 0; i < a->fields->num_entries; i++) {
 		union {
 			st_data_t data;