[GitHub] [iceberg] nastra commented on a diff in pull request #6548: Core: Add timestamp handling to GenericRecord

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6548:
URL: https://github.com/apache/iceberg/pull/6548#discussion_r1066037304


##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java:
##########
@@ -909,7 +907,7 @@ private DataFile writeParquetFile(Table table, List<GenericRecord> records) thro
     }
 
     PartitionKey partitionKey = new PartitionKey(table.spec(), table.schema());
-    partitionKey.partition(new LocalDateTimeToLongMicros(records.get(0)));
+    partitionKey.partition(records.get(0));

Review Comment:
   so that means https://github.com/apache/iceberg/issues/6510 is not a bug but users have to do the conversion themselves?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org