You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@juneau.apache.org by ja...@apache.org on 2026/10/09 21:43:56 UTC
(juneau) branch juneau-release-manager updated: Document Shorts.nm and Shorts.any in the code conventions, and drop the removed or(boolean...) overload (J0649 follow-on).
This is an automated email from the ASF dual-hosted git repository.
jamesbognar pushed a commit to branch juneau-release-manager
in repository https://gitbox.apache.org/repos/asf/juneau.git
The following commit(s) were added to refs/heads/juneau-release-manager by this push:
new 8839709704 Document Shorts.nm and Shorts.any in the code conventions, and drop the removed or(boolean...) overload (J0649 follow-on).
8839709704 is described below
commit 8839709704d825605418c7a74d64a6a4f5c1fdf6
Author: James Bognar <ja...@apache.org>
AuthorDate: Fri Oct 9 17:43:51 2026 -0400
Document Shorts.nm and Shorts.any in the code conventions, and drop the removed or(boolean...) overload (J0649 follow-on).
Co-Authored-By: Claude Opus 5.5 (1M context) <no...@anthropic.com>
---
CODE-CONVENTIONS.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/CODE-CONVENTIONS.md b/CODE-CONVENTIONS.md
index def51cbce5..8185dc2af2 100644
--- a/CODE-CONVENTIONS.md
+++ b/CODE-CONVENTIONS.md
@@ -103,9 +103,9 @@ and re-swept 2026-09-13 (WORK-R0008 leftover pass):
- **First-non-null coalesce (`Shorts.or(...)`)** — **N/A (not a null-safe mapper).** Re-triaged
2026-09-13: ~12 `x == null ? null : f(x)` ternaries remain in `src/main` (`EmailService`,
`NexusStagingClient`, `MilestoneService`, `ReleaseRunRest`, `ReleaseEngine`, `DistPromoteStep`,
- `MavenSettingsCredentials`, `GithubReleaseSource`). Each is a null-safe mapper, and Shorts has no helper for that.
+ `MavenSettingsCredentials`, `GithubReleaseSource`). Each is a null-safe mapper; use `nm(x, X::f)` in new and touched code.
`or()` returns its first non-null argument, so `or(x, f(x))` returns `x`, not `f(x)`. It also
- evaluates `f(x)` when `x` is null. Leave the ternary.
+ evaluates `f(x)` when `x` is null.
- **Injectable wall-clock `Clock`** — **N/A (none found).** Reconfirmed 2026-09-13: no direct
`System.currentTimeMillis()` calls in `src/main`.
- **Size assertions (`assertSize`)** — **Applied** (leftover pass 2026-09-13). R0005 recorded N/A