[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5708: Support BYTES type for group-by expression

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5708:
URL: https://github.com/apache/incubator-pinot/pull/5708#discussion_r456713649



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/NoDictionarySingleColumnGroupKeyGenerator.java
##########
@@ -163,84 +164,201 @@ public int getCurrentGroupKeyUpperBound() {
 
   @Override
   public Iterator<GroupKey> getUniqueGroupKeys() {
-    return new GroupKeyIterator(_groupKeyMap);
+    switch (_dataType) {

Review comment:
       The main difference is from the entry-set and iterator implementation of the fastutil maps. For an example, `Int2IntMap.entrySet()` is marked deprecated and the class suggest using the type-specific method instead. Also, we are able to use the `fastIterator()` provided by the `FastEntrySet`, and also the unboxed values to reduce the garbage, and the unnecessary boxing/unboxing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org