You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Brian Byrne <bb...@confluent.io> on 2019/10/22 19:42:17 UTC
[DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality
Hello all,
I wrote a KIP about expanding the ConfigCommand's functionality when not
accessing ZooKeeper directly, i.e. when --bootstrap-servers is specified
instead of --zookeeper. This should bring the two into parity.
There's also a bit of bikeshedding about additional flags for shortening
entity specification on the command line. Please take a look:
https://cwiki.apache.org/confluence/x/ww-3Bw
Thanks,
Brian
Re: [DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality
Posted by Brian Byrne <bb...@confluent.io>.
Hi Stanislav,
That's fair, I wouldn't imagine it being necessary to add --describe for
all broker-loggers, but was intended mainly for consistency with the other
entity types. One might find it useful to grep for certain entries, or it's
possible that the output is improved to only show non-default values (like
the others), but I'm fine either way.
Thanks for the input.
Brian
On Sat, Oct 26, 2019 at 1:07 PM Stanislav Kozlovski <st...@confluent.io>
wrote:
> Hey Brian,
>
> Thank you for the KIP, any step towards KIP-500 is a great idea!
>
> I wanted to discuss the need for a --describe on all the broker-loggers
> resource at once. The output is very verbose - I count more than 150 lines.
> Although since I imagine more options to describe internal state wouldn't
> hurt, I don't feel strongly about this.
>
> Thanks,
> Stanislav
>
> On Wed, Oct 23, 2019 at 12:20 AM Brian Byrne <bb...@confluent.io> wrote:
>
> > Sure - updated.
> >
> > Thanks,
> > Brian
> >
> > On Tue, Oct 22, 2019 at 4:02 PM Colin McCabe <cm...@apache.org> wrote:
> >
> > > Hi Brian,
> > >
> > > Thanks for the KIP! This looks like a nice cleanup. It will be good
> to
> > > be able to perform these operations without direct ZK access.
> > >
> > > I guess this is a nitpick, but for the operations proposed for later,
> it
> > > might be nice to have a different color, like yellow, to indicate that
> > > we'll need a follow-on KIP to do them.
> > >
> > > best,
> > > Colin
> > >
> > >
> > > On Tue, Oct 22, 2019, at 12:42, Brian Byrne wrote:
> > > > Hello all,
> > > >
> > > > I wrote a KIP about expanding the ConfigCommand's functionality when
> > not
> > > > accessing ZooKeeper directly, i.e. when --bootstrap-servers is
> > specified
> > > > instead of --zookeeper. This should bring the two into parity.
> > > >
> > > > There's also a bit of bikeshedding about additional flags for
> > shortening
> > > > entity specification on the command line. Please take a look:
> > > > https://cwiki.apache.org/confluence/x/ww-3Bw
> > > >
> > > > Thanks,
> > > > Brian
> > > >
> > >
> >
>
>
> --
> Best,
> Stanislav
>
Re: [DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality
Posted by Stanislav Kozlovski <st...@confluent.io>.
Hey Brian,
Thank you for the KIP, any step towards KIP-500 is a great idea!
I wanted to discuss the need for a --describe on all the broker-loggers
resource at once. The output is very verbose - I count more than 150 lines.
Although since I imagine more options to describe internal state wouldn't
hurt, I don't feel strongly about this.
Thanks,
Stanislav
On Wed, Oct 23, 2019 at 12:20 AM Brian Byrne <bb...@confluent.io> wrote:
> Sure - updated.
>
> Thanks,
> Brian
>
> On Tue, Oct 22, 2019 at 4:02 PM Colin McCabe <cm...@apache.org> wrote:
>
> > Hi Brian,
> >
> > Thanks for the KIP! This looks like a nice cleanup. It will be good to
> > be able to perform these operations without direct ZK access.
> >
> > I guess this is a nitpick, but for the operations proposed for later, it
> > might be nice to have a different color, like yellow, to indicate that
> > we'll need a follow-on KIP to do them.
> >
> > best,
> > Colin
> >
> >
> > On Tue, Oct 22, 2019, at 12:42, Brian Byrne wrote:
> > > Hello all,
> > >
> > > I wrote a KIP about expanding the ConfigCommand's functionality when
> not
> > > accessing ZooKeeper directly, i.e. when --bootstrap-servers is
> specified
> > > instead of --zookeeper. This should bring the two into parity.
> > >
> > > There's also a bit of bikeshedding about additional flags for
> shortening
> > > entity specification on the command line. Please take a look:
> > > https://cwiki.apache.org/confluence/x/ww-3Bw
> > >
> > > Thanks,
> > > Brian
> > >
> >
>
--
Best,
Stanislav
Re: [DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality
Posted by Brian Byrne <bb...@confluent.io>.
Sure - updated.
Thanks,
Brian
On Tue, Oct 22, 2019 at 4:02 PM Colin McCabe <cm...@apache.org> wrote:
> Hi Brian,
>
> Thanks for the KIP! This looks like a nice cleanup. It will be good to
> be able to perform these operations without direct ZK access.
>
> I guess this is a nitpick, but for the operations proposed for later, it
> might be nice to have a different color, like yellow, to indicate that
> we'll need a follow-on KIP to do them.
>
> best,
> Colin
>
>
> On Tue, Oct 22, 2019, at 12:42, Brian Byrne wrote:
> > Hello all,
> >
> > I wrote a KIP about expanding the ConfigCommand's functionality when not
> > accessing ZooKeeper directly, i.e. when --bootstrap-servers is specified
> > instead of --zookeeper. This should bring the two into parity.
> >
> > There's also a bit of bikeshedding about additional flags for shortening
> > entity specification on the command line. Please take a look:
> > https://cwiki.apache.org/confluence/x/ww-3Bw
> >
> > Thanks,
> > Brian
> >
>
Re: [DISCUSS] KIP-543: Expand ConfigCommand's non-ZK functionality
Posted by Colin McCabe <cm...@apache.org>.
Hi Brian,
Thanks for the KIP! This looks like a nice cleanup. It will be good to be able to perform these operations without direct ZK access.
I guess this is a nitpick, but for the operations proposed for later, it might be nice to have a different color, like yellow, to indicate that we'll need a follow-on KIP to do them.
best,
Colin
On Tue, Oct 22, 2019, at 12:42, Brian Byrne wrote:
> Hello all,
>
> I wrote a KIP about expanding the ConfigCommand's functionality when not
> accessing ZooKeeper directly, i.e. when --bootstrap-servers is specified
> instead of --zookeeper. This should bring the two into parity.
>
> There's also a bit of bikeshedding about additional flags for shortening
> entity specification on the command line. Please take a look:
> https://cwiki.apache.org/confluence/x/ww-3Bw
>
> Thanks,
> Brian
>