You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2023/01/17 02:27:01 UTC

[GitHub] [bookkeeper] AnonHxy opened a new pull request, #3740: Fix entryId in ReadRequest when call readLac

AnonHxy opened a new pull request, #3740:
URL: https://github.com/apache/bookkeeper/pull/3740

   Descriptions of the changes in this PR:
   
   
   
   ### Motivation
   
   The `entryId` of `ReadRequest` should be -1 instead of 0 when call `PerChannelBookieClient#readLac`. 
   Luckly we will call `PerChannelBookieClient#readLac` only when `useV2WireProtocol` is false,  so it will not cause problem in production environment.  But it's a potential bug if we refactor the readLac in v2 protocol, so it's necessary to fix it I think
   
   
   
   ### Changes
   Changing `entryId` of `ReadRequest` in `PerChannelBookieClient#readLac` from 0 to `-1`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #3740: Fix v2 protocol ReadRequest in readLac

Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #3740:
URL: https://github.com/apache/bookkeeper/pull/3740#issuecomment-1535626144

   @StevenLuMT @eolivelli @hangc0276 PTAL, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 commented on pull request #3740: Cleanup v2 protocol ReadRequest in readLac

Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #3740:
URL: https://github.com/apache/bookkeeper/pull/3740#issuecomment-1534077851

   @AnonHxy Do you have any updates?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #3740: Cleanup v2 protocol ReadRequest in readLac

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #3740:
URL: https://github.com/apache/bookkeeper/pull/3740#issuecomment-1385024631

   > So this code is never executed.
   > 
   > We should drop it and not try to fix
   
   Thanks for your reply @eolivelli . I have modified this patch to cleanup it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #3740: Cleanup v2 protocol ReadRequest in readLac

Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #3740:
URL: https://github.com/apache/bookkeeper/pull/3740#issuecomment-1534146044

   > 
   
   OK. I will add a test to verfiy it later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org